GNU bug report logs - #10894
Mixed C-Vala projects distcheck is broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10894 in the body.
You can then email your comments to 10894 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Quentin Glidic <sardemff7+gnu <at> sardemff7.net>
To: bug-automake <at> gnu.org
Subject: Mixed C-Vala projects distcheck is broken
Date: Sun, 26 Feb 2012 22:12:50 +0100

[Message part 1 (text/plain, inline)]

Package: automake
Version: 1.11.3

Hello,

The distcheck of a project which mix C and Vala targets in the same 
Makefile.am leads to a pass of C targets to valac, which is completely 
wrong and fails if you put your headers in _SOURCES (valac ignores *.c 
files only).

Attached a patch that limits the vala stamps’ generation to targets with 
*.vala file.

-- 

Quentin "Sardem FF7" Glidic

[0001-vala-Fix-mixed-C-Vala-projects-distcheck.patch (text/x-patch, attachment)]

Message #8 received at 10894 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Quentin Glidic <sardemff7+gnu <at> sardemff7.net>
Cc: 10894 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#10894: Mixed C-Vala projects distcheck is broken
Date: Mon, 27 Feb 2012 22:33:05 +0100

[Message part 1 (text/plain, inline)]

Hi Quentin, thanks for the report.

On 02/26/2012 10:12 PM, Quentin Glidic wrote:
> Package: automake
> Version: 1.11.3
> 
> Hello,
> 
> The distcheck of a project which mix C and Vala targets in the same Makefile.am
> leads to a pass of C targets to valac, which is completely wrong and fails if
> you put your headers in _SOURCES (valac ignores *.c files only).
>
This is bad.  We had a test in the automake testsuite that tried to build a
project with mixed C/Vala sources, but it didn't use a C header as well :-(

I've thus added a new test case that exposes the bug (see the first attached
patch).

> Attached a patch that limits the vala stamps’ generation to targets with
> *.vala file.
>
Unfortunately, your patch doesn't seem to fix the issue.  I've attached a
second patch that seems to do the trick.  It will appear in the next automake
version (1.12) unless there are objections.

Thanks,
  Stefano

[0001-vala-expose-automake-bug-10894.patch (text/x-diff, attachment)]

[0002-vala-fix-valac-calls-for-projects-with-mixed-Vala-C.patch (text/x-diff, attachment)]

Message #11 received at 10894 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Quentin Glidic <sardemff7+gnu <at> sardemff7.net>
Cc: 10894 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#10894: Mixed C-Vala projects distcheck is broken
Date: Wed, 29 Feb 2012 19:53:46 +0100

tags 10894 patch
close 10894
thanks

On 02/27/2012 10:33 PM, Stefano Lattarini wrote:

> [PATCH 1/2] vala: expose automake bug#10894
>
> * tests/vala-mix2.test: New test.
> * tests/list-of-tests.mk: Add it.
> * tests/Makefile.am (XFAIL_TESTS): Likewise.
> * THANKS: Update.

> [PATCH 2/2] vala: fix 'valac' calls for projects with mixed Vala/C
>
> Fixes automake bug#10894.
>
> * automake.in (lang_vala_finish_target): Strip non-vala files
> from the dependencies of vala stamps, and from the invocation
> of valac compiler.  Related refactorings.
> * tests/Makefile.am (XFAIL_TESTS): Remove 'vala-mix2.test'.

I've pushed these patches to maint, and merged maint into master.
I'm thus closing this bug report.

Regards,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.