GNU bug report logs - #10781
EIEIO namespace use

Previous Next

Full log

View this message in rfc822 format

From: David Engster <deng <at> randomsample.de>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 10781 <at> debbugs.gnu.org, "Eric M. Ludlam" <eric <at> siege-engine.com>
Subject: bug#10781: EIEIO namespace use
Date: Sat, 28 Apr 2012 23:03:40 +0200

Stefan Monnier writes:
>> Yes, I think 'this' should indeed become 'eieio-this'. It will also be
>> the most work, since at least in CEDET you *very* often have
>
>> (defmethod foo ((this someclass) ...)
>>  ...)
>
>> so a 'this' in such a method is perfectly fine.
>
> An alternative approach is to keep the name `this' but get rid of the
> global definition.  I.e. Either completely remove the (defvar this nil),
> or replace it with (defvar this).

Eric, what would you prefer? I don't know enough about CLOS to say how
important a global 'eieio-this' actually is. Either way, I just tested
both solutions on CEDET trunk and each produced exactly this single
compile warning:

In ede-flush-directory-hash:
files.el:230:38:Warning: reference to free variable `this'

So actually, this appears to be a much smaller issue than I initially
thought. It seems pretty much every 'this' in CEDET is already bound in
the defmethod's argument list.

-David

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.