GNU bug report logs - #10760
24.0.93; [patch] Convert artist-mode to use define-minor-mode

Previous Next

Package: emacs;

Reported by: William Stevenson <yhvh2000 <at> gmail.com>

Date: Wed, 8 Feb 2012 07:15:02 UTC

Severity: minor

Tags: patch

Found in version 24.0.93

Fixed in version 24.2

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 10760 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: William Stevenson <yhvh2000 <at> gmail.com>
Cc: tab <at> lysator.liu.se, 10760 <at> debbugs.gnu.org
Subject: Re: bug#10760: 24.0.93;
	[patch] Convert artist-mode to use define-minor-mode
Date: Wed, 08 Feb 2012 14:25:20 -0500

Thank you.

> - (defvar artist-mode-map

The keymap does not have to be defined within the call to
define-minor-mode (actually I recommend you don't do that in general),
so you can leave the (defvar artist-mode-map ...) untouched.

> ! (defun artist-mode-init ()
[...]
> ! (defun artist-mode-exit ()

You can also keep these functions.  This will significantly reduce the
size of your patch and will make it much easier to figure out what is
really changed (and hence, whether or not the change is safe).

> !   :init-value nil   :group 'artist :lighter " Artist"

You should use artist-mode-name here.


        Stefan "who actually prefers `diff -u' format"
This bug report was last modified 13 years and 126 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.