GNU bug report logs - #10602
Visiting archives changes directory time

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10602 in the body.
You can then email your comments to 10602 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Visiting archives changes directory time
Date: Wed, 25 Jan 2012 22:03:52 +0200

Using archive-mode or tar-mode to visit archives touches
directory modification dates.  This is especially annoying
when archives are located in backup directories.  The problem
is in the function `insert' that temporarily modifies the
archive summary buffer causing lock-file to create a lock file
in the current directory that modifies the directory timestamp.

A similar bug#2295 was fixed by let-binding `buffer-file-truename'
to nil to prevent directory time modification in `lock_file'.

This is not a regression, so I propose to install in 24.2 something like

=== modified file 'lisp/arc-mode.el'
--- lisp/arc-mode.el	2012-01-19 07:21:25 +0000
+++ lisp/arc-mode.el	2012-01-25 19:54:01 +0000
@@ -783,7 +784,8 @@ (defun archive-summarize (&optional shut
 Optional argument SHUT-UP, if non-nil, means don't print messages
 when parsing the archive."
   (widen)
-  (let ((inhibit-read-only t))
+  (let ((buffer-file-truename nil) ; avoid changing dir mtime by lock_file
+	(inhibit-read-only t))
     (setq archive-proper-file-start (copy-marker (point-min) t))
     (set (make-local-variable 'change-major-mode-hook) 'archive-desummarize)
     (or shut-up

=== modified file 'lisp/tar-mode.el'
--- lisp/tar-mode.el	2012-01-19 07:21:25 +0000
+++ lisp/tar-mode.el	2012-01-25 19:54:01 +0000
@@ -520,12 +520,13 @@ (defun tar-summarize-buffer ()
         (progress-reporter-done progress-reporter)
       (message "Warning: premature EOF parsing tar file"))
     (goto-char (point-min))
-    (let ((inhibit-read-only t)
+    (let ((buffer-file-truename nil) ; avoid changing dir mtime by lock_file
+	  (inhibit-read-only t)
           (total-summaries
            (mapconcat 'tar-header-block-summarize tar-parse-info "\n")))
-      (insert total-summaries "\n"))
+      (insert total-summaries "\n")
     (goto-char (point-min))
-    (restore-buffer-modified-p modified)))
+      (restore-buffer-modified-p modified))))
 
 (defvar tar-mode-map
   (let ((map (make-keymap)))

Message #12 received at 10602 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juri Linkov <juri <at> jurta.org>
Cc: 10602 <at> debbugs.gnu.org
Subject: Re: bug#10602: Visiting archives changes directory time
Date: Mon, 16 Apr 2012 21:59:44 -0400

Juri Linkov wrote:

> This is not a regression, so I propose to install in 24.2 something like

You could install this now if you like...

Message #15 received at 10602 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 10602 <at> debbugs.gnu.org
Subject: Re: bug#10602: Visiting archives changes directory time
Date: Wed, 18 Apr 2012 08:27:18 +0300

>> This is not a regression, so I propose to install in 24.2 something like
>
> You could install this now if you like...

There are more patches I submitted for 24.2 and some of them are
not a complete solution.  Next week I'll start going through the list
of open issues and look if they could be improved before committing.

Message #18 received at 10602 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> jurta.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 10602 <at> debbugs.gnu.org
Subject: Re: bug#10602: Visiting archives changes directory time
Date: Tue, 09 Dec 2014 00:33:43 +0100

Juri Linkov <juri <at> jurta.org> writes:

>>> This is not a regression, so I propose to install in 24.2 something like
>>
>> You could install this now if you like...
>
> There are more patches I submitted for 24.2 and some of them are
> not a complete solution.  Next week I'll start going through the list
> of open issues and look if they could be improved before committing.

This is also marked as pending, but has not been applied in two years...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 10602 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 10602 <at> debbugs.gnu.org
Subject: Re: bug#10602: Visiting archives changes directory time
Date: Tue, 09 Dec 2014 02:34:30 +0200

forcemerge 2295 10602
thanks

> This is also marked as pending, but has not been applied in two years...

Sorry, I forgot to merge it with bug#2295 where I already installed
this patch two years ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.