GNU bug report logs - #10575
"compress" not found: causes many test failures

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10575 in the body.
You can then email your comments to 10575 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-automake <at> gnu.org
Subject: "compress" not found: causes many test failures
Date: Sat, 21 Jan 2012 22:17:20 +0100

[Message part 1 (text/plain, inline)]

On master a few days ago I noticed new test failures on a
Fedora 16 system, due to the unprotected use of compress.

In tests/dist-formats.tap, I read this:

    # Assume gzip(1) and compress(1) are available on every reasonable
    # portability target.

Of course, I could install it with a simple "yum install ncompress",
but the point is that compress is not installed by default.
That tool is becoming anachronistic.

    $ grep '^FAIL:' tests/test-suite.log
    FAIL: depmod
    FAIL: depmod.tap 50 - tru64 [long VPATH] make & remake
    FAIL: depmod.tap 84 - tru64 [absolute VPATH] make & remake
    FAIL: dist-formats
    FAIL: dist-formats.tap 9 - 'make dist-tarZ' work by default
    FAIL: dist-formats.tap 13 - 'make dist-xz' work by default
    FAIL: dist-formats.tap 15 - 'make dist-bzip2' work by default
    FAIL: dist-formats.tap 17 - 'make dist-zip' work by default
    FAIL: dist-formats.tap 19 - 'make dist-shar' work by default
    FAIL: dist-formats.tap 49 - ac=dist-tarZ,no-dist-gzip [distcheck]
    FAIL: dist-formats.tap 60 - gzip+bzip2+tarZ [make -j4 dist-all]
    FAIL: dist-formats.tap 63 - gzip+bzip2+tarZ [check .tar.Z tarball]
    FAIL: vala-mix
    FAIL: tap-bad-prog-w
    FAIL: tap-bad-prog-w.tap 2 - non-existent test is reported
    FAIL: tap-bad-prog-w.tap 3 - non-executable test is reported
    FAIL: tap-bad-prog-w.tap 4 - non-readable test is reported

Here's the complete test-suite.log file:

[test-suite.log.xz (application/octet-stream, attachment)]

Message #8 received at 10575 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 10575 <at> debbugs.gnu.org
Subject: Re: bug#10575: "compress" not found: causes many test failures
Date: Sun, 22 Jan 2012 10:10:49 +0100

[Message part 1 (text/plain, inline)]

Hi Jim, thanks for the report.

On 01/21/2012 10:17 PM, Jim Meyering wrote:
> On master a few days ago I noticed new test failures on a
> Fedora 16 system, due to the unprotected use of compress.
> 
> In tests/dist-formats.tap, I read this:
> 
>     # Assume gzip(1) and compress(1) are available on every reasonable
>     # portability target.
> 
> Of course, I could install it with a simple "yum install ncompress",
> but the point is that compress is not installed by default.
> That tool is becoming anachronistic.
> 
The attached patch should fix it.  I will push it by this evening if
there is no objection (and if you have time to give it a try, that would
be great).

Thanks,
  Stefano

[0001-dist-tests-missing-compress-program-was-causing-spur.patch (text/x-diff, attachment)]

Message #11 received at 10575 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 10575 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#10575: "compress" not found: causes many test failures
Date: Sun, 22 Jan 2012 10:24:19 +0100

[Message part 1 (text/plain, inline)]

On 01/21/2012 10:17 PM, Jim Meyering wrote:
>
>     FAIL: vala-mix
>
And the attached patch (applied to maint) should take care of this
failure.

Regards,
  Stefano

[0001-vala-tests-add-missing-valac-requirement-and-other-m.patch (text/x-diff, attachment)]

Message #14 received at 10575 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 10575 <at> debbugs.gnu.org
Subject: Re: bug#10575: "compress" not found: causes many test failures
Date: Sun, 22 Jan 2012 12:18:34 +0100

Stefano Lattarini wrote:
> Hi Jim, thanks for the report.
>
> On 01/21/2012 10:17 PM, Jim Meyering wrote:
>> On master a few days ago I noticed new test failures on a
>> Fedora 16 system, due to the unprotected use of compress.
>>
>> In tests/dist-formats.tap, I read this:
>>
>>     # Assume gzip(1) and compress(1) are available on every reasonable
>>     # portability target.
>>
>> Of course, I could install it with a simple "yum install ncompress",
>> but the point is that compress is not installed by default.
>> That tool is becoming anachronistic.
>>
> The attached patch should fix it.  I will push it by this evening if
> there is no objection (and if you have time to give it a try, that would
> be great).
...
> Subject: [PATCH] dist tests: missing "compress" program was causing spurious
>  failures
>
> Fixes automake bug#10575.
>
> The "compress" tool is becoming anachronistic, and thus is not
> installed by default on modern distros (e.g., Fedora 16).  We
> can't thus unconditionally assume it exists on every reasonable
> portability target.
>
> * tests/dist-formats.tap ($missing_compressors): When defining
> this, don't assume anymore that compress(1) is unconditionally
> available.
> (Parallel compression): Skip this sub-test if compress(1) is
> unavailable.
> Since we are at it, fix a couple of unrelated buglets: a typo
> in a test name (s/distcheck/ark-exists/), and some attempts to
> remove directories with "rm -f".

That patch looks fine.
I confirmed that avoids several of the failures.
Thanks for the quick work.

Message #17 received at 10575 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 10575 <at> debbugs.gnu.org
Subject: Re: bug#10575: "compress" not found: causes many test failures
Date: Sun, 22 Jan 2012 12:23:09 +0100

tags 10575 patch
severity 10575 minor
close 10575
thanks

On 01/22/2012 12:18 PM, Jim Meyering wrote:
>> Subject: [PATCH] dist tests: missing "compress" program was causing spurious
>>  failures
>>
>> Fixes automake bug#10575.
>>
>> The "compress" tool is becoming anachronistic, and thus is not
>> installed by default on modern distros (e.g., Fedora 16).  We
>> can't thus unconditionally assume it exists on every reasonable
>> portability target.
>>
>> * tests/dist-formats.tap ($missing_compressors): When defining
>> this, don't assume anymore that compress(1) is unconditionally
>> available.
>> (Parallel compression): Skip this sub-test if compress(1) is
>> unavailable.
>> Since we are at it, fix a couple of unrelated buglets: a typo
>> in a test name (s/distcheck/ark-exists/), and some attempts to
>> remove directories with "rm -f".
> 
> That patch looks fine.
> I confirmed that avoids several of the failures.
> Thanks for the quick work.
>
Thanks for the quick reply.  I've pushed the patch, and I'm closing
this bug.

Regards,
  Stefano

Message #26 received at 10575 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 10575 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#10575: "compress" not found: causes many test failures
Date: Sun, 22 Jan 2012 12:29:44 +0100

Stefano Lattarini wrote:
> On 01/21/2012 10:17 PM, Jim Meyering wrote:
>>
>>     FAIL: vala-mix
>>
> And the attached patch (applied to maint) should take care of this
> failure.

Thanks.
This reduces by one more my "FAIL" counter.

> Subject: [PATCH] vala tests: add missing 'valac' requirement, and other minor
>  fixlets
>
> See also automake bug#10575.
>
> * tests/vala-mix.test ($required): Add 'valac'; this will avoid
> spurious failures on systems lacking a Vala compiler.
> Add some explicative comments for a couple of non-obvious make

I think of "explicative" as a word not in common usage
and would use "explanatory" in its place.

> calls.
> Make grepping of "make -n" slightly stricter, to avoid potential
> false positives.
> ---
>  tests/vala-mix.test |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/vala-mix.test b/tests/vala-mix.test
> index f597a7f..73a07d9 100755
> --- a/tests/vala-mix.test
> +++ b/tests/vala-mix.test
> @@ -16,7 +16,7 @@
>
>  # Vala sources and C sources in the same program.  Functional test.
>
> -required='cc GNUmake'
> +required='valac cc GNUmake'
>  . ./defs || Exit 1
>
>  set -e
> @@ -96,8 +96,9 @@ have_generated_files ()
>  # C files.
>  have_generated_files
>
> +# Remake rules are not uselessly triggered.

That added comment didn't help me much, at first.
Then I realized you probably intended this:

  # Ensure that remake rules are not uselessly triggered.

>  $MAKE -q
> -$MAKE -n | grep stamp && Exit 1
> +$MAKE -n | $FGREP vala.stamp && Exit 1
>
>  # Check the distribution.
>  $MAKE distcheck

Message #29 received at 10575 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 10575 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#10575: "compress" not found: causes many test failures
Date: Sun, 22 Jan 2012 12:53:17 +0100

On 01/22/2012 12:29 PM, Jim Meyering wrote:
>
> Stefano Lattarini wrote:
>>
>> * tests/vala-mix.test ($required): Add 'valac'; this will avoid
>> spurious failures on systems lacking a Vala compiler.
>> Add some explicative comments for a couple of non-obvious make
> 
> I think of "explicative" as a word not in common usage
> and would use "explanatory" in its place.
>
Sorry, L1 interference.  I'll try to remember your advice in the
future.

>> diff --git a/tests/vala-mix.test b/tests/vala-mix.test
>> index f597a7f..73a07d9 100755
>> --- a/tests/vala-mix.test
>> +++ b/tests/vala-mix.test
>> @@ -16,7 +16,7 @@
>>
>>  # Vala sources and C sources in the same program.  Functional test.
>>
>> -required='cc GNUmake'
>> +required='valac cc GNUmake'
>>  . ./defs || Exit 1
>>
>>  set -e
>> @@ -96,8 +96,9 @@ have_generated_files ()
>>  # C files.
>>  have_generated_files
>>
>> +# Remake rules are not uselessly triggered.
> 
> That added comment didn't help me much, at first.
> Then I realized you probably intended this:
> 
>   # Ensure that remake rules are not uselessly triggered.
>
Yes, sorry for the sloppiness.  Unfortunately, I have already pushed,
so we can't squash in this improvement; but feel free to push it in a
"fixup" commit if you think that would be useful.

Thanks,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.