GNU bug report logs - #10489
24.0.92; dired-do-copy may create infinite directory hierarchy

Previous Next

Full log

Message #56 received at 10489 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 10489 <at> debbugs.gnu.org,
	Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#10489: 24.0.92;
	dired-do-copy may create infinite directory hierarchy
Date: Fri, 13 Jan 2012 08:27:46 -0500

IIUC the problem at hand can be solved by disregarding names and
comparing (file-attributes) instead, since we're checking whether two
names refer to the exact same (existing) directory.

>> As this seems like a common occurrence, how comes that we don't have
>> 
>> (defun file-name-compare (name1 name2 &optional dir)
>> "..."
>> (let ((n1 (file-truename (expand-file-name name1 dir)))
>> (n2 (file-truename (expand-file-name name2 dir))))
>> (when (memq system-type '(ms-dos windows-nt))
>> (setq n1 (downcase n1)
>> n2 (downcase n2)))
>> (string= n1 n2)))

file-name-equal-p would be nice, indeed, as discussed a few months
(years?) ago.

> I wouldn't check for `system-type', there might be other systems which
> do not care filename cases (VMS?). I would let-bind `case-fold-search',
> derived from `read-file-name-completion-ignore-case'.

read-file-name-completion-ignore-case is a user configuration which only
reflects the underlying system's sensitivity by default but the user is
free to modify it.  I used to set it to t under GNU/Linux, for instance.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.