GNU bug report logs - #10489
24.0.92; dired-do-copy may create infinite directory hierarchy

Previous Next

Package: emacs;

Reported by: michael_heerdegen <at> web.de

Date: Thu, 12 Jan 2012 19:36:01 UTC

Severity: important

Tags: patch

Merged with 11130

Found in version 24.0.92

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 10489 <at> debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy
Date: Fri, 13 Jan 2012 14:11:25 +0100

On Fri, Jan 13, 2012 at 14:01, Michael Albinus <michael.albinus <at> gmx.de> wrote:

> I wouldn't check for `system-type', there might be other systems which
> do not care filename cases (VMS?). I would let-bind `case-fold-search',
> derived from `read-file-name-completion-ignore-case'.

You're right that r-f-n-c-i-c should be used, but as for binding it,
that forces you to use a more expensive comparation. Perhaps this is
simpler:

 (defun file-name-compare (name1 name2 &optional dir)
   "..."
   (compare-strings (file-truename (expand-file-name name1 dir))
                    (file-truename (expand-file-name name2 dir))
                    nil nil
                    read-file-name-completion-ignore-case))

    Juanma
This bug report was last modified 13 years and 58 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.