GNU bug report logs - #10489
24.0.92; dired-do-copy may create infinite directory hierarchy

Previous Next

Package: emacs;

Reported by: michael_heerdegen <at> web.de

Date: Thu, 12 Jan 2012 19:36:01 UTC

Severity: important

Tags: patch

Merged with 11130

Found in version 24.0.92

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #441 received at 10489 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 10489 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#10489: 24.0.92;
	dired-do-copy may create infinite directory hierarchy
Date: Mon, 27 Feb 2012 12:10:57 +0100
Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:

>> I see why we might want to signal an error to the user when she does
>> (copy-directory "~/test" "~/test/test1"), but I don't see why that
>> implies that we need files-equal-p to handle non-existent files.
> Because if we don't do that, we have to create new directory Test1 and
> then test if Test1 is a subdir of Test.
> This just to avoid that.

This has to be handled in copy-directory. files-equal-p can (will!) be
used also somewhere else.

Best regards, Michael.




This bug report was last modified 13 years and 58 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.