GNU bug report logs - #10489
24.0.92; dired-do-copy may create infinite directory hierarchy

Previous Next

Full log

View this message in rfc822 format

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 10489 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy
Date: Mon, 27 Feb 2012 09:04:24 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> I have modified files-equal-p and file-subdir-of-p to work with
>> non--existing files,
>
> Calling files-equal-p on non-existing files makes no sense, so I don't
> think we should support it (at least not until we have concrete
> evidence that it is needed, at which point we can decide what we intend
> it to mean).
It is useful to handle e.g
(copy-directory "~/test" "~/test/test1")
where test1 is a non--existing directory.
Actually a check is done once test1 is build and stop the loop, 
so this would avoid creating an unuseful new directory.

We could give an optional arg noexist to files-equal-p.

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.