GNU bug report logs - #10489
24.0.92; dired-do-copy may create infinite directory hierarchy

Previous Next

Package: emacs;

Reported by: michael_heerdegen <at> web.de

Date: Thu, 12 Jan 2012 19:36:01 UTC

Severity: important

Tags: patch

Merged with 11130

Found in version 24.0.92

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #324 received at 10489 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Michael Albinus'" <michael.albinus <at> gmx.de>
Cc: 10489 <at> debbugs.gnu.org, 'Thierry Volpiatto' <thierry.volpiatto <at> gmail.com>
Subject: RE: bug#10489: 24.0.92;
	dired-do-copy may create infinite directory hierarchy
Date: Fri, 24 Feb 2012 08:42:52 -0800
> >> I don't understand why you use expand-file-name here:
> >> file-truename does it for you anyway.
> >
> > That's true, but only for Emacs 24+.  Is there any chance that this
> > code will be used (say by Tramp) with Emacs < 24, where
> > `file-truename' does not expand a relative file name?
> 
> "This code" belongs to a function introduced with Emacs 24. 
> Tramp cannot use it for older/other Emacsen, because it does
> not exist there :-)
> 
> If Tramp *emulates* this code, it is responsible to do it correctly.

I see.  I guess by the last part you mean that if the next Tramp version (which
will presumably take advantage of this) were to be used with an older Emacs
version, then it would test `(fboundp 'files-equal-p)' and if nil do something
else (e.g. emulate it) to test equality.  Is that what you meant?





This bug report was last modified 13 years and 58 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.