GNU bug report logs - #10489
24.0.92; dired-do-copy may create infinite directory hierarchy

Previous Next

Package: emacs;

Reported by: michael_heerdegen <at> web.de

Date: Thu, 12 Jan 2012 19:36:01 UTC

Severity: important

Tags: patch

Merged with 11130

Found in version 24.0.92

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#10489: 24.0.92;
	dired-do-copy may create infinite directory hierarchy
Date: Fri, 13 Jan 2012 10:38:45 +0100
[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:

> I don't think this will solves all the use cases.  File names are not
> strings, you cannot compare them as literal strings and hope to plumb
> all the leaks.
>
> Some situations which I think this patch will not handle correctly:
>
>  . file names with different letter-case on a case-insensitive file
>    system
>
>  . relative vs absolute file names
>
>  . file names that are hard links to the same directory (this includes
>    the infamous 8+3 short aliases on Windows)
>
> I didn't actually try the patch, so apologies if I missed something
> which makes these non-issues.
>
Here a version of the patch that use `equal' and handle also same error
on remotes files.
i.e (copy-directory "/sudo:host:/home/user/Test" "/home/user/Test")

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 
[Singlepatch-r118414ToTip.patch (text/x-diff, attachment)]

This bug report was last modified 13 years and 58 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.