GNU bug report logs - #10444
"make dist" fails if more than two compression formats are used

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10444 in the body.
You can then email your comments to 10444 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-automake <at> gnu.org
Subject: "make dist" fails if more than two compression formats are used
Date: Fri, 06 Jan 2012 20:18:42 +0100

Severity: grave

If I try to run "make dist" from an autoamke master checkout, I see this error:

  tardir=automake-1.11a && ${TAR-tar} chof - "$tardir" \
    | XZ_OPT=${XZ_OPT--e} xz -c >automake-1.11a.tar.xz
  ## The distdir gets removed ##
  ... rm -fr "automake-1.11a" ...
  ## And then make tries to tar it again ##
  tardir=automake-1.11a && ${TAR-tar} chof - "$tardir" \
    | GZIP=--best gzip -c >automake-1.11a.tar.gz
  ## Failure ensues
  tar: automake-1.11a: Cannot stat: No such file or directory
  tar: Exiting with failure status due to previous errors

This is pretty bad.  What is even worse is that the error is very likely to go
unnoticed (it has until now), since, due to implementation reasons, the `tar'
failure isn't reflected in the exit status of "make dist".

I will try to follow-up on this soonish.

Regards,
  Stefano

Message #10 received at 10444 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: automake-patches <at> gnu.org
Cc: 10444 <at> debbugs.gnu.org, 10448 <at> debbugs.gnu.org
Subject: [PATCHES] {master} dist: distdir not unconditionally removed anymore
	for xz and lzip
Date: Sun, 08 Jan 2012 10:19:08 +0100

[Message part 1 (text/plain, inline)]

References:
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10444>
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10448>

And here is a two-patch series fixing the bug.  The first patch enhances
the testsuite coverage for the various `dist-*' options and formats and
for the "make dist" usages (and in doing so exposes the bug), the second
patch fixes the problem (which, it turns out, was simply due to missing
edits after a merge).

Tested on Debian unstable (GNU make 3.81 and 3.80), Solaris 10 (with
GNU make 3.82, CCS make and Sun Distributed Make) and NetBSD 5.1 (with
system make and GNU make 3.82).

I will push the patches to master in a day or two if there is no objection.

Regards,
  Stefano

[0001-coverage-archive-and-compression-formats-used-by-mak.patch (text/x-diff, attachment)]

[0002-dist-distdir-not-unconditionally-removed-anymore-for.patch (text/x-diff, attachment)]

Message #17 received at 10444-done <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: automake-patches <at> gnu.org
Cc: 10444-done <at> debbugs.gnu.org, 10448-done <at> debbugs.gnu.org
Subject: Re: [PATCHES] {master}  dist: distdir not unconditionally removed
	anymore for xz and lzip
Date: Wed, 11 Jan 2012 18:59:17 +0100

On 01/08/2012 10:19 AM, Stefano Lattarini wrote:
> References:
>  <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10444>
>  <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10448>
> 
> I will push the patches to master in a day or two if there is no objection.
> 
Pushed now.

Thanks,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.