GNU bug report logs - #10164
24.0.91; Instant crash enabling linum-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#10164: closed (24.0.91; Instant crash enabling linum-mode)
Date: Wed, 30 Nov 2011 16:58:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 30 Nov 2011 18:56:31 +0200
with message-id <838vmx5z28.fsf <at> gnu.org>
and subject line Re: bug#10164: 24.0.91; Instant crash enabling linum-mode
has caused the debbugs.gnu.org bug report #10164,
regarding 24.0.91; Instant crash enabling linum-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
10164: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10164
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tim Crews <tim.crews <at> code-affinity.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.91; Instant crash enabling linum-mode
Date: Tue, 29 Nov 2011 19:05:20 -0700

[Message part 3 (text/html, inline)]

[Message part 4 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: lekktu <at> gmail.com, 10164-done <at> debbugs.gnu.org, tim.crews <at> code-affinity.com
Subject: Re: bug#10164: 24.0.91; Instant crash enabling linum-mode
Date: Wed, 30 Nov 2011 18:56:31 +0200

> From: Chong Yidong <cyd <at> gnu.org>
> Cc: Juanma Barranquero <lekktu <at> gmail.com>,  10164 <at> debbugs.gnu.org,  tim.crews <at> code-affinity.com
> Date: Thu, 01 Dec 2011 00:29:37 +0800
> 
> > Chong, please hold off the pretest while I debug this.
> 
> I bumped the version number in the trunk before seeing this latest
> message.  But, I haven't made the pretest tag yet---will wait.

Thanks.  The bug is fixed in revision 106561.

It was simply wrong to try to verify rows' hash values at that spot,
because the code immediately before that reallocates the glyph arrays,
so the contents of a glyph row could be complete garbage.  Therefore,
I removed the assertion.

I'm amazed that this assertion didn't trigger until now.  I guess too
few people compile with asserts.  Or maybe most calls to
adjust_glyph_matrix don't really reallocate, since display margins are
a relatively rarely used feature.

Sorry about this, it was a shameful thinko on my part to introduce
that assertion in the first place.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.