GNU bug report logs -
#10165
[PATCH] Allow setting corner in mouse avoidance mode.
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10165 in the body.
You can then email your comments to 10165 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Wed, 30 Nov 2011 06:00:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Thierry Volpiatto <thierry.volpiatto <at> gmail.com>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Wed, 30 Nov 2011 06:00:03 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
> Hi all,
> there was nothing except modifying function
> `mouse-avoidance-banish-destination' to set in which corner mouse is
> banish.
> This patch allow setting this through
> `mouse-avoidance-banish-destination' user variable like this:
> (left . top) or (right . bottom) etc...
Thanks. We're in feature freeze---please file this in the bug database
so it doesn't get forgotten.
[patch-r118037.patch (text/x-diff, inline)]
# HG changeset patch
# User Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
# Date 1322632617 -3600
# Node ID 885228e9f341f392fc6886bf2855a66c5bdba6c5
# Parent c511f9c3f7a2cab8b3684b2f1ea4782176988ac6
* lisp/avoid.el: Allow setting in which corner banish move the mouse.
(mouse-avoidance-banish-destination): New user variable, a cons pair to specify banish corner position.
(mouse-avoidance-banish-destination): Set destination according to mouse-avoidance-banish-destination value.
diff --git a/lisp/avoid.el b/lisp/avoid.el
--- a/lisp/avoid.el
+++ b/lisp/avoid.el
@@ -115,6 +115,11 @@
:type 'integer
:group 'avoid)
+(defcustom mouse-avoidance-banish-destination '(left . top)
+ "Set the position to which Mouse Avoidance mode `banish' moves the mouse."
+ :group 'avoid
+ :type 'list)
+
;; Internal variables
(defvar mouse-avoidance-state nil)
(defvar mouse-avoidance-pointer-shapes nil)
@@ -183,10 +188,18 @@
(defun mouse-avoidance-banish-destination ()
"The position to which Mouse Avoidance mode `banish' moves the mouse.
-You can redefine this if you want the mouse banished to a different corner."
- (let* ((pos (window-edges)))
- (cons (- (nth 2 pos) 2)
- (nth 1 pos))))
+If you want the mouse banished to a different corner set
+`mouse-avoidance-banish-destination' as you need."
+ (let* ((pos (loop for v in (window-edges)
+ for k in '(left top right bottom)
+ collect (cons k v)))
+ (side (car mouse-avoidance-banish-destination))
+ (up-down (cdr mouse-avoidance-banish-destination))
+ (fn (case side
+ (left '+)
+ (right '-))))
+ (cons (funcall fn (assoc-default side pos) 2)
+ (assoc-default up-down pos))))
(defun mouse-avoidance-banish-mouse ()
;; Put the mouse pointer in the upper-right corner of the current frame.
[Message part 3 (text/plain, inline)]
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Wed, 30 Nov 2011 06:06:02 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
As a reminder, I will have to put back the original behavior in
defcustom, that is to move the mouse by default in the
top right corner i.e
(defcustom mouse-avoidance-banish-destination '(right . top)
Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>> Hi all,
>> there was nothing except modifying function
>> `mouse-avoidance-banish-destination' to set in which corner mouse is
>> banish.
>> This patch allow setting this through
>> `mouse-avoidance-banish-destination' user variable like this:
>> (left . top) or (right . bottom) etc...
>
> Thanks. We're in feature freeze---please file this in the bug database
> so it doesn't get forgotten.
>
>
> # HG changeset patch
> # User Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
> # Date 1322632617 -3600
> # Node ID 885228e9f341f392fc6886bf2855a66c5bdba6c5
> # Parent c511f9c3f7a2cab8b3684b2f1ea4782176988ac6
> * lisp/avoid.el: Allow setting in which corner banish move the mouse.
> (mouse-avoidance-banish-destination): New user variable, a cons pair to specify banish corner position.
> (mouse-avoidance-banish-destination): Set destination according to mouse-avoidance-banish-destination value.
>
> diff --git a/lisp/avoid.el b/lisp/avoid.el
> --- a/lisp/avoid.el
> +++ b/lisp/avoid.el
> @@ -115,6 +115,11 @@
> :type 'integer
> :group 'avoid)
>
> +(defcustom mouse-avoidance-banish-destination '(left . top)
> + "Set the position to which Mouse Avoidance mode `banish' moves the mouse."
> + :group 'avoid
> + :type 'list)
> +
> ;; Internal variables
> (defvar mouse-avoidance-state nil)
> (defvar mouse-avoidance-pointer-shapes nil)
> @@ -183,10 +188,18 @@
>
> (defun mouse-avoidance-banish-destination ()
> "The position to which Mouse Avoidance mode `banish' moves the mouse.
> -You can redefine this if you want the mouse banished to a different corner."
> - (let* ((pos (window-edges)))
> - (cons (- (nth 2 pos) 2)
> - (nth 1 pos))))
> +If you want the mouse banished to a different corner set
> +`mouse-avoidance-banish-destination' as you need."
> + (let* ((pos (loop for v in (window-edges)
> + for k in '(left top right bottom)
> + collect (cons k v)))
> + (side (car mouse-avoidance-banish-destination))
> + (up-down (cdr mouse-avoidance-banish-destination))
> + (fn (case side
> + (left '+)
> + (right '-))))
> + (cons (funcall fn (assoc-default side pos) 2)
> + (assoc-default up-down pos))))
>
> (defun mouse-avoidance-banish-mouse ()
> ;; Put the mouse pointer in the upper-right corner of the current frame.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Wed, 30 Nov 2011 09:58:03 GMT)
Full text and
rfc822 format available.
Message #11 received at 10165 <at> debbugs.gnu.org (full text, mbox):
>> there was nothing except modifying function
>> `mouse-avoidance-banish-destination' to set in which corner mouse is
>> banish.
>> This patch allow setting this through
>> `mouse-avoidance-banish-destination' user variable like this:
>> (left . top) or (right . bottom) etc...
FWIW, I have in my .emacs:
;; Move the mouse to the screen corner on any keypress.
(when (and (display-mouse-p) (require 'avoid nil t))
;; Move the mouse to the lower-right corner instead of default upper-right
(defun mouse-avoidance-banish-destination ()
(cons (+ 3 (frame-width)) (- (frame-height) 1)))
(mouse-avoidance-mode 'banish))
It would be better to allow users to replace such code with customization.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Wed, 30 Nov 2011 10:32:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Juri Linkov <juri <at> jurta.org> writes:
>>> there was nothing except modifying function
>>> `mouse-avoidance-banish-destination' to set in which corner mouse is
>>> banish.
>>> This patch allow setting this through
>>> `mouse-avoidance-banish-destination' user variable like this:
>>> (left . top) or (right . bottom) etc...
>
> FWIW, I have in my .emacs:
>
> ;; Move the mouse to the screen corner on any keypress.
> (when (and (display-mouse-p) (require 'avoid nil t))
> ;; Move the mouse to the lower-right corner instead of default upper-right
> (defun mouse-avoidance-banish-destination ()
> (cons (+ 3 (frame-width)) (- (frame-height) 1)))
> (mouse-avoidance-mode 'banish))
>
> It would be better to allow users to replace such code with customization.
Yes, it is what my patch does:
Instead of your code you can just say:
(setq mouse-avoidance-banish-destination '(right . bottom))
or of course setting that through customize interface.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Wed, 30 Nov 2011 17:41:03 GMT)
Full text and
rfc822 format available.
Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):
Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
> Juri Linkov <juri <at> jurta.org> writes:
>
>>>> there was nothing except modifying function
>>>> `mouse-avoidance-banish-destination' to set in which corner mouse is
>>>> banish.
>>>> This patch allow setting this through
>>>> `mouse-avoidance-banish-destination' user variable like this:
>>>> (left . top) or (right . bottom) etc...
>>
>> FWIW, I have in my .emacs:
>>
>> ;; Move the mouse to the screen corner on any keypress.
>> (when (and (display-mouse-p) (require 'avoid nil t))
>> ;; Move the mouse to the lower-right corner instead of default upper-right
>> (defun mouse-avoidance-banish-destination ()
>> (cons (+ 3 (frame-width)) (- (frame-height) 1)))
>> (mouse-avoidance-mode 'banish))
>>
>> It would be better to allow users to replace such code with customization.
> Yes, it is what my patch does:
> Instead of your code you can just say:
> (setq mouse-avoidance-banish-destination '(right . bottom))
> or of course setting that through customize interface.
Also, I have added a new user variable to this patch that allow setting
the distance from window's edge:
(defcustom mouse-avoidance-banish-distance-from-edge 2
"Set the distance from edge of window in Mouse Avoidance mode `banish'."
:group 'avoid
:type 'integer)
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Thu, 01 Dec 2011 07:49:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 10165 <at> debbugs.gnu.org (full text, mbox):
>>> FWIW, I have in my .emacs:
>>>
>>> ;; Move the mouse to the screen corner on any keypress.
>>> (when (and (display-mouse-p) (require 'avoid nil t))
>>> ;; Move the mouse to the lower-right corner instead of default upper-right
>>> (defun mouse-avoidance-banish-destination ()
>>> (cons (+ 3 (frame-width)) (- (frame-height) 1)))
>>> (mouse-avoidance-mode 'banish))
>>>
>>> It would be better to allow users to replace such code with customization.
>> Yes, it is what my patch does:
>> Instead of your code you can just say:
>> (setq mouse-avoidance-banish-destination '(right . bottom))
>> or of course setting that through customize interface.
>
> Also, I have added a new user variable to this patch that allow setting
> the distance from window's edge:
>
> (defcustom mouse-avoidance-banish-distance-from-edge 2
> "Set the distance from edge of window in Mouse Avoidance mode `banish'."
> :group 'avoid
> :type 'integer)
Thanks, but in my settings the distance is relative to frame's edge
instead of window's edge. Is it possible to express this setting
with a user variable?
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Thu, 01 Dec 2011 08:46:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Juri Linkov <juri <at> jurta.org> writes:
>>>> FWIW, I have in my .emacs:
>>>>
>>>> ;; Move the mouse to the screen corner on any keypress.
>>>> (when (and (display-mouse-p) (require 'avoid nil t))
>>>> ;; Move the mouse to the lower-right corner instead of default upper-right
>>>> (defun mouse-avoidance-banish-destination ()
>>>> (cons (+ 3 (frame-width)) (- (frame-height) 1)))
>>>> (mouse-avoidance-mode 'banish))
>>>>
>>>> It would be better to allow users to replace such code with customization.
>>> Yes, it is what my patch does:
>>> Instead of your code you can just say:
>>> (setq mouse-avoidance-banish-destination '(right . bottom))
>>> or of course setting that through customize interface.
>>
>> Also, I have added a new user variable to this patch that allow setting
>> the distance from window's edge:
>>
>> (defcustom mouse-avoidance-banish-distance-from-edge 2
>> "Set the distance from edge of window in Mouse Avoidance mode `banish'."
>> :group 'avoid
>> :type 'integer)
>
> Thanks, but in my settings the distance is relative to frame's edge
> instead of window's edge. Is it possible to express this setting
> with a user variable?
Try this:
#+BEGIN_SRC lisp
(defun mouse-avoidance-banish-destination ()
"The position to which Mouse Avoidance mode `banish' moves the mouse.
If you want the mouse banished to a different corner set
`mouse-avoidance-banish-destination' as you need."
(let* ((fra-or-win (case (car mouse-avoidance-banish-distance-from-edge)
(frame (list 0 0 (frame-width) (frame-height)))
(window (window-edges))))
(pos (loop for v in fra-or-win
for k in '(left top right bottom)
collect (cons k v)))
(side (car mouse-avoidance-banish-destination))
(up-down (cdr mouse-avoidance-banish-destination))
(fn (case side
(left '+)
(right '-))))
(cons (funcall fn (assoc-default side pos)
(cdr mouse-avoidance-banish-distance-from-edge))
(assoc-default up-down pos))))
(defcustom mouse-avoidance-banish-destination '(right . top)
"Set the position to which Mouse Avoidance mode `banish' moves the mouse."
:group 'avoid
:type 'list)
(defcustom mouse-avoidance-banish-distance-from-edge '(window . 3)
"Set the distance from edge of window in Mouse Avoidance mode `banish'."
:group 'avoid
:type 'list)
#+END_SRC
And to fit your settings:
(setq mouse-avoidance-banish-destination '(right . bottom))
(setq mouse-avoidance-banish-distance-from-edge '(frame . 3))
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Fri, 02 Dec 2011 07:31:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 10165 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Juri Linkov <juri <at> jurta.org> writes:
>>>> FWIW, I have in my .emacs:
>>>>
>>>> ;; Move the mouse to the screen corner on any keypress.
>>>> (when (and (display-mouse-p) (require 'avoid nil t))
>>>> ;; Move the mouse to the lower-right corner instead of default upper-right
>>>> (defun mouse-avoidance-banish-destination ()
>>>> (cons (+ 3 (frame-width)) (- (frame-height) 1)))
>>>> (mouse-avoidance-mode 'banish))
>>>>
>>>> It would be better to allow users to replace such code with customization.
>>> Yes, it is what my patch does:
>>> Instead of your code you can just say:
>>> (setq mouse-avoidance-banish-destination '(right . bottom))
>>> or of course setting that through customize interface.
>>
>> Also, I have added a new user variable to this patch that allow setting
>> the distance from window's edge:
>>
>> (defcustom mouse-avoidance-banish-distance-from-edge 2
>> "Set the distance from edge of window in Mouse Avoidance mode `banish'."
>> :group 'avoid
>> :type 'integer)
>
> Thanks, but in my settings the distance is relative to frame's edge
> instead of window's edge. Is it possible to express this setting
> with a user variable?
Here the improved version of the patch:
[Singlepatch-r118037ToTip.patch (text/x-diff, inline)]
##Merge of all patches applied from revision 118094
## patch-r118037: * lisp/avoid.el: Allow setting in which corner banish move the mouse.
## patch-r118084: * lisp/avoid.el (mouse-avoidance-banish-distance-from-edge): Allow banishing mouse in frame or window corner.
##
diff --git a/lisp/avoid.el b/lisp/avoid.el
--- a/lisp/avoid.el
+++ b/lisp/avoid.el
@@ -115,6 +115,23 @@
:type 'integer
:group 'avoid)
+(defcustom mouse-avoidance-banish-destination '(right . top)
+ "Position to which Mouse Avoidance mode `banish' moves the mouse.
+
+Valid possible values can be:
+\'(right . top\), \'(left . top\), \'(right . bottom\) or \'(left . bottom\)."
+ :group 'avoid
+ :type 'list)
+
+(defcustom mouse-avoidance-banish-distance-from-edge '(window . 2)
+ "Distance from edge of window or frame in Mouse Avoidance mode `banish'.
+
+It is a cons cell where the car can be 'window or 'frame
+and the cdr and integer representing the distance
+from edge of window or frame."
+ :group 'avoid
+ :type 'list)
+
;; Internal variables
(defvar mouse-avoidance-state nil)
(defvar mouse-avoidance-pointer-shapes nil)
@@ -183,10 +200,24 @@
(defun mouse-avoidance-banish-destination ()
"The position to which Mouse Avoidance mode `banish' moves the mouse.
-You can redefine this if you want the mouse banished to a different corner."
- (let* ((pos (window-edges)))
- (cons (- (nth 2 pos) 2)
- (nth 1 pos))))
+
+If you want the mouse banished to a different corner set
+`mouse-avoidance-banish-destination' and
+`mouse-avoidance-banish-distance-from-edge' as you need."
+ (let* ((fra-or-win (case (car mouse-avoidance-banish-distance-from-edge)
+ (frame (list 0 0 (frame-width) (frame-height)))
+ (window (window-edges))))
+ (pos (loop for v in fra-or-win
+ for k in '(left top right bottom)
+ collect (cons k v)))
+ (side (car mouse-avoidance-banish-destination))
+ (up-down (cdr mouse-avoidance-banish-destination))
+ (fn (case side
+ (left '+)
+ (right '-))))
+ (cons (funcall fn (assoc-default side pos 'eq)
+ (cdr mouse-avoidance-banish-distance-from-edge))
+ (assoc-default up-down pos 'eq))))
(defun mouse-avoidance-banish-mouse ()
;; Put the mouse pointer in the upper-right corner of the current frame.
[Message part 3 (text/plain, inline)]
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Fri, 02 Dec 2011 07:37:01 GMT)
Full text and
rfc822 format available.
Message #29 received at submit <at> debbugs.gnu.org (full text, mbox):
Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
> +(defcustom mouse-avoidance-banish-distance-from-edge '(window . 2)
> + "Distance from edge of window or frame in Mouse Avoidance mode `banish'.
> +
> +It is a cons cell where the car can be 'window or 'frame
> +and the cdr and integer representing the distance
> +from edge of window or frame."
> + :group 'avoid
> + :type 'list)
I used same default value as it is actually, but i think using
'(frame . 2) as Juri does is much better.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Fri, 02 Dec 2011 10:56:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 10165 <at> debbugs.gnu.org (full text, mbox):
>> +(defcustom mouse-avoidance-banish-distance-from-edge '(window . 2)
>> + "Distance from edge of window or frame in Mouse Avoidance mode `banish'.
>> +
>> +It is a cons cell where the car can be 'window or 'frame
>> +and the cdr and integer representing the distance
>> +from edge of window or frame."
>> + :group 'avoid
>> + :type 'list)
>
> I used same default value as it is actually, but i think using
> '(frame . 2) as Juri does is much better.
Thanks. What do you think about using the same syntax as for the
geometry specification? Like (info "(emacs) Window Size X") describes:
{+-}XOFFSET{+-}YOFFSET
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Fri, 02 Dec 2011 11:25:01 GMT)
Full text and
rfc822 format available.
Message #35 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Juri Linkov <juri <at> jurta.org> writes:
>>> +(defcustom mouse-avoidance-banish-distance-from-edge '(window . 2)
>>> + "Distance from edge of window or frame in Mouse Avoidance mode `banish'.
>>> +
>>> +It is a cons cell where the car can be 'window or 'frame
>>> +and the cdr and integer representing the distance
>>> +from edge of window or frame."
>>> + :group 'avoid
>>> + :type 'list)
>>
>> I used same default value as it is actually, but i think using
>> '(frame . 2) as Juri does is much better.
>
> Thanks. What do you think about using the same syntax as for the
> geometry specification?
You mean using something like:
'(frame . "X+Y")
> Like (info "(emacs) Window Size X") describes:
>
> {+-}XOFFSET{+-}YOFFSET
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Fri, 02 Dec 2011 17:20:01 GMT)
Full text and
rfc822 format available.
Message #38 received at 10165 <at> debbugs.gnu.org (full text, mbox):
> You mean using something like:
> '(frame . "X+Y")
Yes, but we also need an edge specification too, like:
'(frame top +2 right -1)
'(window bottom -2 left +3)
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Fri, 02 Dec 2011 17:36:02 GMT)
Full text and
rfc822 format available.
Message #41 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Juri Linkov <juri <at> jurta.org> writes:
>> You mean using something like:
>> '(frame . "X+Y")
>
> Yes, but we also need an edge specification too, like:
>
> '(frame top +2 right -1)
>
> '(window bottom -2 left +3)
IIUC we would need only one defcustom, right?
We are seriously going out of the corner now. ;-)
Such settings maybe interesting for not popping up xfce toolbar at
bottom of screen when using Emacs in fullscreen for example.
I will try to rework my patch then.
Thanks.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Sat, 03 Dec 2011 08:59:02 GMT)
Full text and
rfc822 format available.
Message #44 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
> I will try to rework my patch then.
I use only one user variable now:
--8<---------------cut here---------------start------------->8---
(defcustom mouse-avoidance-banish-position '((frame-or-window . frame)
(side . right)
(side-pos . 3)
(top-or-bottom . top)
(top-or-bottom-pos . 0))
--8<---------------cut here---------------end--------------->8---
Which allow to set also the vertical position (top-or-bottom-pos).
See attached patch.
[Singlepatch-r118037ToTip.patch (text/x-diff, inline)]
##Merge of all patches applied from revision 118111
## patch-r118037: * lisp/avoid.el: Allow setting in which corner banish move the mouse.
## patch-r118084: * lisp/avoid.el (mouse-avoidance-banish-distance-from-edge): Allow banishing mouse in frame or window corner.
## patch-r118114: * lisp/avoid.el Allow specifying a vertical position when banishing mouse.
##
diff --git a/lisp/avoid.el b/lisp/avoid.el
--- a/lisp/avoid.el
+++ b/lisp/avoid.el
@@ -115,6 +115,23 @@
:type 'integer
:group 'avoid)
+(defcustom mouse-avoidance-banish-position '((frame-or-window . frame)
+ (side . right)
+ (side-pos . 3)
+ (top-or-bottom . top)
+ (top-or-bottom-pos . 0))
+ "Position to which Mouse Avoidance mode `banish' moves the mouse.
+An alist where keywords mean:
+FRAME-OR-WINDOW: banish the mouse to corner of frame or window.
+SIDE: banish the mouse on right or left corner of frame or window.
+SIDE-POS: Distance from right or left edge of frame or window.
+TOP-OR-BOTTOM: banish the mouse to top or bottom of frame or window.
+TOP-OR-BOTTOM-POS: Distance from top or bottom edge of frame or window."
+ :group 'avoid
+ :type '(alist :key-type sexp :value-type sexp)
+ :options '(frame-or-window side (side-pos integer)
+ top-or-bottom (top-or-bottom-pos integer)))
+
;; Internal variables
(defvar mouse-avoidance-state nil)
(defvar mouse-avoidance-pointer-shapes nil)
@@ -183,10 +200,40 @@
(defun mouse-avoidance-banish-destination ()
"The position to which Mouse Avoidance mode `banish' moves the mouse.
-You can redefine this if you want the mouse banished to a different corner."
- (let* ((pos (window-edges)))
- (cons (- (nth 2 pos) 2)
- (nth 1 pos))))
+
+If you want the mouse banished to a different corner set
+`mouse-avoidance-banish-position' as you need."
+ (let* ((fra-or-win (assoc-default
+ 'frame-or-window
+ mouse-avoidance-banish-position 'eq))
+ (list-values (case fra-or-win
+ (frame (list 0 0 (frame-width) (frame-height)))
+ (window (window-edges))))
+ (alist (loop for v in list-values
+ for k in '(left top right bottom)
+ collect (cons k v)))
+ (side (assoc-default
+ 'side
+ mouse-avoidance-banish-position 'eq))
+ (top-or-bottom (assoc-default
+ 'top-or-bottom
+ mouse-avoidance-banish-position 'eq))
+ (top-or-bottom-dist (assoc-default
+ 'top-or-bottom-pos
+ mouse-avoidance-banish-position 'eq))
+ (side-fn (case side
+ (left '+)
+ (right '-)))
+ (top-or-bottom-fn (case top-or-bottom
+ (top '+)
+ (bottom '-))))
+ (cons (funcall side-fn ; -/+
+ (assoc-default side alist 'eq) ; right or left
+ ;; distance from side
+ (cdr mouse-avoidance-banish-distance-from-edge))
+ (funcall top-or-bottom-fn ; -/+
+ (assoc-default top-or-bottom alist 'eq) ; top/bottom
+ top-or-bottom-dist)))) ; distance from top/bottom
(defun mouse-avoidance-banish-mouse ()
;; Put the mouse pointer in the upper-right corner of the current frame.
[Message part 3 (text/plain, inline)]
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Sat, 03 Dec 2011 09:27:01 GMT)
Full text and
rfc822 format available.
Message #47 received at submit <at> debbugs.gnu.org (full text, mbox):
Use this, as there is an error in precedent patch (still using value of
old variable), sorry.
--8<---------------cut here---------------start------------->8---
(defun mouse-avoidance-banish-destination ()
"The position to which Mouse Avoidance mode `banish' moves the mouse.
If you want the mouse banished to a different corner set
`mouse-avoidance-banish-position' as you need."
(let* ((fra-or-win (assoc-default
'frame-or-window
mouse-avoidance-banish-position 'eq))
(list-values (case fra-or-win
(frame (list 0 0 (frame-width) (frame-height)))
(window (window-edges))))
(alist (loop for v in list-values
for k in '(left top right bottom)
collect (cons k v)))
(side (assoc-default
'side
mouse-avoidance-banish-position 'eq))
(side-dist (assoc-default
'side-pos
mouse-avoidance-banish-position 'eq))
(top-or-bottom (assoc-default
'top-or-bottom
mouse-avoidance-banish-position 'eq))
(top-or-bottom-dist (assoc-default
'top-or-bottom-pos
mouse-avoidance-banish-position 'eq))
(side-fn (case side
(left '+)
(right '-)))
(top-or-bottom-fn (case top-or-bottom
(top '+)
(bottom '-))))
(cons (funcall side-fn ; -/+
(assoc-default side alist 'eq) ; right or left
side-dist) ; distance from side
(funcall top-or-bottom-fn ; -/+
(assoc-default top-or-bottom alist 'eq) ; top/bottom
top-or-bottom-dist)))) ; distance from top/bottom
--8<---------------cut here---------------end--------------->8---
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Mon, 05 Dec 2011 10:56:02 GMT)
Full text and
rfc822 format available.
Message #50 received at 10165 <at> debbugs.gnu.org (full text, mbox):
> Use this, as there is an error in precedent patch (still using value of
> old variable), sorry.
Thanks. I think names like `frame-or-window' and `top-or-bottom-pos'
are quite confusing. But fortunately we could avoid them.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Mon, 05 Dec 2011 18:08:01 GMT)
Full text and
rfc822 format available.
Message #53 received at 10165 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Juri Linkov <juri <at> jurta.org> writes:
>> Use this, as there is an error in precedent patch (still using value of
>> old variable), sorry.
>
> Thanks. I think names like `frame-or-window' and `top-or-bottom-pos'
> are quite confusing.
Yes, if you have better names tell me.
Also here on last version of patch I am using symbol instead of sexp
which is better.
> But fortunately we could avoid them.
Can you develop this?
Find here the last version of patch for review, (more or less what you
have actually) I will apply as soon Emacs is no more in feature freeze
if no objections.
[Singlepatch-r118037ToTip.patch (text/x-diff, inline)]
##Merge of all patches applied from revision 118117
## patch-r118037: * lisp/avoid.el: Allow setting in which corner banish move the mouse.
## patch-r118084: * lisp/avoid.el (mouse-avoidance-banish-distance-from-edge): Allow banishing mouse in frame or window corner.
## patch-r118114: * lisp/avoid.el Allow specifying a vertical position when banishing mouse.
##
diff --git a/lisp/avoid.el b/lisp/avoid.el
--- a/lisp/avoid.el
+++ b/lisp/avoid.el
@@ -115,6 +115,23 @@
:type 'integer
:group 'avoid)
+(defcustom mouse-avoidance-banish-position '((frame-or-window . frame)
+ (side . right)
+ (side-pos . 3)
+ (top-or-bottom . top)
+ (top-or-bottom-pos . 0))
+ "Position to which Mouse Avoidance mode `banish' moves the mouse.
+An alist where keywords mean:
+FRAME-OR-WINDOW: banish the mouse to corner of frame or window.
+SIDE: banish the mouse on right or left corner of frame or window.
+SIDE-POS: Distance from right or left edge of frame or window.
+TOP-OR-BOTTOM: banish the mouse to top or bottom of frame or window.
+TOP-OR-BOTTOM-POS: Distance from top or bottom edge of frame or window."
+ :group 'avoid
+ :type '(alist :key-type symbol :value-type symbol)
+ :options '(frame-or-window side (side-pos integer)
+ top-or-bottom (top-or-bottom-pos integer)))
+
;; Internal variables
(defvar mouse-avoidance-state nil)
(defvar mouse-avoidance-pointer-shapes nil)
@@ -183,13 +200,45 @@
(defun mouse-avoidance-banish-destination ()
"The position to which Mouse Avoidance mode `banish' moves the mouse.
-You can redefine this if you want the mouse banished to a different corner."
- (let* ((pos (window-edges)))
- (cons (- (nth 2 pos) 2)
- (nth 1 pos))))
+
+If you want the mouse banished to a different corner set
+`mouse-avoidance-banish-position' as you need."
+ (let* ((fra-or-win (assoc-default
+ 'frame-or-window
+ mouse-avoidance-banish-position 'eq))
+ (list-values (case fra-or-win
+ (frame (list 0 0 (frame-width) (frame-height)))
+ (window (window-edges))))
+ (alist (loop for v in list-values
+ for k in '(left top right bottom)
+ collect (cons k v)))
+ (side (assoc-default
+ 'side
+ mouse-avoidance-banish-position 'eq))
+ (side-dist (assoc-default
+ 'side-pos
+ mouse-avoidance-banish-position 'eq))
+ (top-or-bottom (assoc-default
+ 'top-or-bottom
+ mouse-avoidance-banish-position 'eq))
+ (top-or-bottom-dist (assoc-default
+ 'top-or-bottom-pos
+ mouse-avoidance-banish-position 'eq))
+ (side-fn (case side
+ (left '+)
+ (right '-)))
+ (top-or-bottom-fn (case top-or-bottom
+ (top '+)
+ (bottom '-))))
+ (cons (funcall side-fn ; -/+
+ (assoc-default side alist 'eq) ; right or left
+ side-dist) ; distance from side
+ (funcall top-or-bottom-fn ; -/+
+ (assoc-default top-or-bottom alist 'eq) ; top/bottom
+ top-or-bottom-dist)))) ; distance from top/bottom
(defun mouse-avoidance-banish-mouse ()
- ;; Put the mouse pointer in the upper-right corner of the current frame.
+ "Put the mouse pointer to `mouse-avoidance-banish-position'."
(mouse-avoidance-set-mouse-position (mouse-avoidance-banish-destination)))
(defsubst mouse-avoidance-delta (cur delta dist var min max)
[Message part 3 (text/plain, inline)]
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Wed, 07 Dec 2011 17:34:02 GMT)
Full text and
rfc822 format available.
Message #56 received at 10165 <at> debbugs.gnu.org (full text, mbox):
>> Thanks. I think names like `frame-or-window' and `top-or-bottom-pos'
>> are quite confusing.
>
> Yes, if you have better names tell me.
I think better names would be similar to geometry specification
like in (info "(emacs) Window Size X").
Then we could have such names (with possible values):
x-side `left' or `right'
y-side `top' or `bottom'
x-offset integer (positive, negative or zero)
y-offset integer (positive, negative or zero)
So for example it would be possible to customize
`mouse-avoidance-banish-position' to the following setting:
'((frame-or-window . frame)
(x-side . right)
(x-offset . 3)
(y-side . bottom)
(y-offset . -1))
Also `frame-or-window' is too long name, but currently I have no idea
what a shorter name would be better.
>> But fortunately we could avoid them.
>
> Can you develop this?
I think that instead of an alist it would be simpler to use a list
with the fixed meaning of each list element. I mean something like:
(defcustom mouse-avoidance-banish-position '(frame right 3 bottom -1)
:type '(list (choice (const frame :tag "Relative to frame coordinates")
(const window :tag "Relative to window coordinates"))
(choice (const left :tag "Relative to left edge")
(const right :tag "Relative to right edge"))
(integer :tag "Horizontal offset")
(choice (const top :tag "Relative to top edge")
(const bottom :tag "Relative to bottom edge"))
(integer :tag "Vertical offset")))
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Wed, 07 Dec 2011 18:06:01 GMT)
Full text and
rfc822 format available.
Message #59 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Juri Linkov <juri <at> jurta.org> writes:
>>> Thanks. I think names like `frame-or-window' and `top-or-bottom-pos'
>>> are quite confusing.
>>
>> Yes, if you have better names tell me.
>
> I think better names would be similar to geometry specification
> like in (info "(emacs) Window Size X").
>
> Then we could have such names (with possible values):
>
> x-side `left' or `right'
> y-side `top' or `bottom'
> x-offset integer (positive, negative or zero)
> y-offset integer (positive, negative or zero)
Note that the code I wrote don't require negative arguments.
You just set the distance from one edge with a positive argument,
doesn't matter if it is right, left top or bottom.
> So for example it would be possible to customize
> `mouse-avoidance-banish-position' to the following setting:
>
> '((frame-or-window . frame)
> (x-side . right)
> (x-offset . 3)
> (y-side . bottom)
> (y-offset . -1))
Ok for this, except for negative integers.
> Also `frame-or-window' is too long name, but currently I have no idea
> what a shorter name would be better.
>
>>> But fortunately we could avoid them.
>>
>> Can you develop this?
>
> I think that instead of an alist it would be simpler to use a list
> with the fixed meaning of each list element. I mean something like:
>
> (defcustom mouse-avoidance-banish-position '(frame right 3 bottom -1)
> :type '(list (choice (const frame :tag "Relative to frame coordinates")
> (const window :tag "Relative to window coordinates"))
> (choice (const left :tag "Relative to left edge")
> (const right :tag "Relative to right edge"))
> (integer :tag "Horizontal offset")
> (choice (const top :tag "Relative to top edge")
> (const bottom :tag "Relative to bottom edge"))
> (integer :tag "Vertical offset")))
I prefer an alist, it is easier to understand.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Wed, 07 Dec 2011 19:58:02 GMT)
Full text and
rfc822 format available.
Message #62 received at 10165 <at> debbugs.gnu.org (full text, mbox):
>> x-side `left' or `right'
>> y-side `top' or `bottom'
>> x-offset integer (positive, negative or zero)
>> y-offset integer (positive, negative or zero)
>
> Note that the code I wrote don't require negative arguments.
> You just set the distance from one edge with a positive argument,
> doesn't matter if it is right, left top or bottom.
Sorry, I don't understand. Could you please demonstrate how it would be
possible to represent the following setting:
(defun mouse-avoidance-banish-destination ()
(cons (+ 3 (frame-width)) (- (frame-height) 1)))
with only positive integer values in `mouse-avoidance-banish-position'?
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Thu, 08 Dec 2011 06:35:02 GMT)
Full text and
rfc822 format available.
Message #65 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Juri Linkov <juri <at> jurta.org> writes:
>>> x-side `left' or `right'
>>> y-side `top' or `bottom'
>>> x-offset integer (positive, negative or zero)
>>> y-offset integer (positive, negative or zero)
>>
>> Note that the code I wrote don't require negative arguments.
>> You just set the distance from one edge with a positive argument,
>> doesn't matter if it is right, left top or bottom.
>
> Sorry, I don't understand. Could you please demonstrate how it would be
> possible to represent the following setting:
>
> (defun mouse-avoidance-banish-destination ()
> (cons (+ 3 (frame-width)) (- (frame-height) 1)))
>
> with only positive integer values in `mouse-avoidance-banish-position'?
Yes you are right, sorry, need to use negative values for such setting.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Thu, 08 Dec 2011 20:22:01 GMT)
Full text and
rfc822 format available.
Message #68 received at 10165 <at> debbugs.gnu.org (full text, mbox):
> Yes you are right, sorry, need to use negative values for such setting.
I see no problem with that, by the way,
Stefan
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Thu, 12 Apr 2012 20:06:01 GMT)
Full text and
rfc822 format available.
Message #71 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
> Yes you are right, sorry, need to use negative values for such setting.
There were lots of different versions of the patch, but we're now in
Emacs 24.2 land, so installing this now would be OK.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Thu, 12 Apr 2012 21:14:02 GMT)
Full text and
rfc822 format available.
Message #74 received at 10165 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
>> Yes you are right, sorry, need to use negative values for such setting.
>
> There were lots of different versions of the patch, but we're now in
> Emacs 24.2 land, so installing this now would be OK.
Ok I will install it tomorrow.
[patch-r118474.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Fri, 13 Apr 2012 15:22:01 GMT)
Full text and
rfc822 format available.
Message #77 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
>> Yes you are right, sorry, need to use negative values for such setting.
>
> There were lots of different versions of the patch, but we're now in
> Emacs 24.2 land, so installing this now would be OK.
Please install the patch I am unable to use bzr, just give up.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Fri, 13 Apr 2012 21:16:02 GMT)
Full text and
rfc822 format available.
Message #80 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
> Please install the patch I am unable to use bzr, just give up.
Ok; applied.
But what's the problem? vc mode in Emacs means that you never have to
understand the underlying VC. :-)
--
(domestic pets only, the antidote for overdose, milk.)
http://lars.ingebrigtsen.no * Sent from my Rome
Added tag(s) fixed.
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Fri, 13 Apr 2012 21:16:02 GMT)
Full text and
rfc822 format available.
bug marked as fixed in version 24.2, send any further explanations to
10165 <at> debbugs.gnu.org and Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Fri, 13 Apr 2012 21:16:03 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10165; Package
emacs.
(Sat, 14 Apr 2012 05:17:01 GMT)
Full text and
rfc822 format available.
Message #87 received at 10165 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
>> Please install the patch I am unable to use bzr, just give up.
>
> Ok; applied.
Thanks.
> But what's the problem? vc mode in Emacs means that you never have to
> understand the underlying VC. :-)
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sat, 12 May 2012 11:24:03 GMT)
Full text and
rfc822 format available.
This bug report was last modified 13 years and 43 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.