GNU bug report logs - #10164
24.0.91; Instant crash enabling linum-mode

Previous Next

Package: emacs;

Reported by: Tim Crews <tim.crews <at> code-affinity.com>

Date: Wed, 30 Nov 2011 05:24:01 UTC

Severity: normal

Found in version 24.0.91

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 10164 <at> debbugs.gnu.org, Chong Yidong <cyd <at> gnu.org>, Tim Crews <tim.crews <at> code-affinity.com>
Subject: bug#10164: 24.0.91; Instant crash enabling linum-mode
Date: Wed, 30 Nov 2011 13:38:17 +0100

On Wed, Nov 30, 2011 at 13:29, Eli Zaretskii <eliz <at> gnu.org> wrote:

> Chong, I hope this is in time for the next pretest.  It would be a
> pity to release a pretest with such a glaring problem.

But verify_row_hash does nothing except checking and returning a flag,
so the new code will never cause an assertion failure...

    Juanma


=== modified file 'src/dispnew.c'
--- src/dispnew.c       2011-11-28 01:07:01 +0000
+++ src/dispnew.c       2011-11-30 12:25:09 +0000
@@ -608,9 +608,10 @@
                  row->glyphs[LAST_AREA]
                    = row->glyphs[LEFT_MARGIN_AREA] + dim.width;
                }
-             xassert (!row->enabled_p
-                      || row->mode_line_p
-                      || verify_row_hash (row));
+#if XASSERTS
+             if (row->enabled_p && !row->mode_line_p)
+               verify_row_hash (row));
+#endif
              ++row;
This bug report was last modified 13 years and 178 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.