GNU bug report logs - #9993
`vc-svn-checkin' needs "--non-interactive"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9993 in the body.
You can then email your comments to 9993 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: `vc-svn-checkin' needs "--non-interactive"
Date: Tue, 8 Nov 2011 13:57:01 +0000

When visiting a file in a Subversion working copy, if the repository
url is http and the server requires authentication for check-ins, when
you type "C-x v v" to check in (the file has local changes), Emacs
hangs (presumably svn thinks it has prompted for credentials and is
awaiting a response). To recover, it is necessary to kill the
"svn.exe" process and run "svn cleanup" on the (now locked) working
copy.

`vc-svn-checkin' should pass "--non-interactive" to the svn
executable. (Checking-in still won't work, but at least you get an
error promptly.)  As a workaround, set the variable
`vc-svn-checkin-switches' to "--non-interactive".

All svn invocations are probably potentially affected, depending on
how the server is set up. Indeed, I don't see why vc-mode shouldn't
pass "--non-interactive" to every svn invocation.

In GNU Emacs 24.0.91.1 (i386-mingw-nt5.1.2600)
 of 2011-10-31 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.6) --no-opt --cflags
-I"D:/devel/emacs/libs/libXpm-3.5.8/include"
-I"D:/devel/emacs/libs/libXpm-3.5.8/src"
-I"D:/devel/emacs/libs/libpng-dev_1.4.3-1/include"
-I"D:/devel/emacs/libs/zlib-dev_1.2.5-2/include"
-I"D:/devel/emacs/libs/giflib-4.1.4-1/include"
-I"D:/devel/emacs/libs/jpeg-6b-4/include"
-I"D:/devel/emacs/libs/tiff-3.8.2-1/include"
-I"D:/devel/emacs/libs/gnutls-2.10.1/include" --ldflags
-L"D:/devel/emacs/libs/gnutls-2.10.1/lib"'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENG
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Help

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Message #8 received at 9993 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Richard Copley <rcopley <at> gmail.com>
Cc: 9993 <at> debbugs.gnu.org
Subject: Re: bug#9993: `vc-svn-checkin' needs "--non-interactive"
Date: Tue, 08 Nov 2011 17:31:16 -0500

Richard Copley wrote:

> `vc-svn-checkin' should pass "--non-interactive" to the svn
> executable. (Checking-in still won't work, but at least you get an
> error promptly.)  As a workaround, set the variable
> `vc-svn-checkin-switches' to "--non-interactive".
>
> All svn invocations are probably potentially affected, depending on
> how the server is set up. Indeed, I don't see why vc-mode shouldn't
> pass "--non-interactive" to every svn invocation.

Cf bugs 4280 and 7152.

Perhaps we should just add --non-interactive to vc-svn-global-switches,
or make vc-svn-command unconditionally add it, and be done with this
once and for all (hopefully...).

Although like http://svn.haxx.se/dev/archive-2008-05/0762.shtml,
I wonder why svn cannot default to non-interactive when stdin is not a
tty.

Message #11 received at 9993 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Richard Copley <rcopley <at> gmail.com>, 9993 <at> debbugs.gnu.org
Subject: Re: bug#9993: `vc-svn-checkin' needs "--non-interactive"
Date: Tue, 08 Nov 2011 20:25:07 -0500

> Perhaps we should just add --non-interactive to vc-svn-global-switches,

That's a user var, so better leave it alone.

> or make vc-svn-command unconditionally add it, and be done with this
> once and for all (hopefully...).

That sounds right.

> Although like http://svn.haxx.se/dev/archive-2008-05/0762.shtml,
> I wonder why svn cannot default to non-interactive when stdin is not a
> tty.

We can add a comment in our code that --non-interactive is a workaround
and that svn should do it automatically since we're using a pipe.


        Stefan

Message #16 received at 9993-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 9993-done <at> debbugs.gnu.org
Subject: Re: bug#9993: `vc-svn-checkin' needs "--non-interactive"
Date: Wed, 09 Nov 2011 21:39:49 -0500

Version: 24.0.92

Stefan Monnier wrote:

>> or make vc-svn-command unconditionally add it
>
> That sounds right.

Done.

> We can add a comment in our code that --non-interactive is a workaround
> and that svn should do it automatically since we're using a pipe.

Gotta cater to the common use case of

  find . -name '*.pdf' | xargs svn update 

though. (http://svn.haxx.se/dev/archive-2009-04/0094.shtml)

Maybe newer svn DTRT though.

Message #19 received at 9993 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 9993 <at> debbugs.gnu.org
Cc: rgm <at> gnu.org
Subject: Re: bug#9993: `vc-svn-checkin' needs "--non-interactive"
Date: Thu, 10 Nov 2011 00:14:52 -0500

>>> or make vc-svn-command unconditionally add it
>> That sounds right.
> Done.
>> We can add a comment in our code that --non-interactive is a workaround
>> and that svn should do it automatically since we're using a pipe.
> Gotta cater to the common use case of
>   find . -name '*.pdf' | xargs svn update

Yes, I think the real test is not "is stdin a tty" but "are we connected
to a tty", which would work right in both cases (an Emacs subprocess
connected via a pipe does not have an associated tty whereas the above
svn command would if typed in bash).


        Stefan

Message #22 received at 9993 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 9993 <at> debbugs.gnu.org
Subject: Re: bug#9993: `vc-svn-checkin' needs "--non-interactive"
Date: Thu, 10 Nov 2011 10:25:10 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>>> or make vc-svn-command unconditionally add it
>>> That sounds right.
>> Done.
>>> We can add a comment in our code that --non-interactive is a workaround
>>> and that svn should do it automatically since we're using a pipe.
>> Gotta cater to the common use case of
>>   find . -name '*.pdf' | xargs svn update
>
> Yes, I think the real test is not "is stdin a tty"

The real test is "is the channel where we ask the question a tty".

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.