GNU bug report logs - #9983
valgrind warning in draw_glyphs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#9983: closed (valgrind warning in draw_glyphs)
Date: Mon, 07 Nov 2011 15:25:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 07 Nov 2011 10:21:18 -0500
with message-id <yxqd3d4yn4h.fsf <at> fencepost.gnu.org>
and subject line Re: bug#9983: valgrind warning in draw_glyphs
has caused the debbugs.gnu.org bug report #9983,
regarding valgrind warning in draw_glyphs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
9983: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9983
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: valgrind warning in draw_glyphs
Date: Sun, 06 Nov 2011 23:36:42 -0500

trunk with lucid toolkit
valgrind ./temacs -Q
gives this warning (not sure exactly when, just playing with the menus
and tooltips, the only "editing" action was to run a grep)





==2341== Conditional jump or move depends on uninitialised value(s)
==2341==    at 0x44CDDA: draw_glyphs (xdisp.c:22981)
==2341==    by 0x44D9FC: expose_area (xdisp.c:27401)
==2341==    by 0x44DDA8: expose_line (xdisp.c:27426)
==2341==    by 0x45B6AA: expose_window (xdisp.c:27653)
==2341==    by 0x45C0DA: expose_window_tree (xdisp.c:27725)
==2341==    by 0x45C0B0: expose_window_tree (xdisp.c:27723)
==2341==    by 0x45C16E: expose_frame (xdisp.c:27780)
==2341==    by 0x4C188D: handle_one_xevent (xterm.c:6219)
==2341==    by 0x4C2F56: XTread_socket (xterm.c:7148)
==2341==    by 0x4F2F26: read_avail_input (keyboard.c:6821)
==2341==    by 0x4F3049: handle_async_input (keyboard.c:7149)
==2341==    by 0x4F26A4: process_pending_signals (keyboard.c:7165)
==2341==  Uninitialised value was created by a stack allocation
==2341==    at 0x44AAD3: draw_glyphs (xdisp.c:22835)
==2341== 


The warning is for this:
        if (check_mouse_face
              && mouse_beg_col < start && mouse_end_col > i)

it looks like mouse_beg_col and mouse_end_col could be left uninitialized a few lines above.

[Message part 3 (message/rfc822, inline)]

From: Dan Nicolaescu <dann <at> gnu.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 9983-close <at> debbugs.gnu.org
Subject: Re: bug#9983: valgrind warning in draw_glyphs
Date: Mon, 07 Nov 2011 10:21:18 -0500

Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Dan Nicolaescu <dann <at> gnu.org> writes:
>
>> so it looks like check_mouse_face is tested after mouse_beg_col.
>
> That is perfectly ok under the as-if rule.  See also

Right.  Closing this bug then.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.