GNU bug report logs - #9934
24.0.91; `region-active-p' definition

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Tue, 1 Nov 2011 17:16:02 UTC

Severity: minor

Found in version 24.0.91

Done: Stefan Monnier <monnier <at> IRO.UMontreal.CA>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#9934: closed (24.0.91; `region-active-p' definition)
Date: Tue, 01 Nov 2011 20:12:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 01 Nov 2011 16:09:06 -0400
with message-id <jwv39e7fvwo.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#9934: 24.0.91; `region-active-p' definition
has caused the debbugs.gnu.org bug report #9934,
regarding 24.0.91; `region-active-p' definition
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
9934: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9934
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.91; `region-active-p' definition
Date: Tue, 1 Nov 2011 10:12:45 -0700
The definition:
 
(defun region-active-p ()  "..."
  (and transient-mark-mode mark-active))
 
Makes no sense, AFAICT.  The mark *cannot* be active unless
`transient-mark-mode' is non-nil.  The very definitions of "active" mark
and "active" region imply transient mark mode.  When transient mark mode
is off, the region and mark are *never* active - the notion of "active"
does not exist in that context.
 
And since the correct definition: (defun region-active-p () mark-active)
is so trivial, this function should just be removed.
 
When is there ever any reason to test (and transient-mark-mode
mark-active)?  When is that value ever different from just the value of
mark-active?
 

In GNU Emacs 24.0.91.1 (i386-mingw-nt5.1.2600) of 2011-10-30 on MARVIN
 Windowing system distributor `Microsoft Corp.', version 5.1.2600
 configured using `configure --with-gcc (4.6) --no-opt --cflags
 -I"D:/devel/emacs/libs/libXpm-3.5.8/include"
 -I"D:/devel/emacs/libs/libXpm-3.5.8/src"
 -I"D:/devel/emacs/libs/libpng-dev_1.4.3-1/include"
 -I"D:/devel/emacs/libs/zlib-dev_1.2.5-2/include"
 -I"D:/devel/emacs/libs/giflib-4.1.4-1/include"
 -I"D:/devel/emacs/libs/jpeg-6b-4/include"
 -I"D:/devel/emacs/libs/tiff-3.8.2-1/include"
 -I"D:/devel/emacs/libs/gnutls-2.10.1/include" --ldflags
 -L"D:/devel/emacs/libs/gnutls-2.10.1/lib"'
 



[Message part 3 (message/rfc822, inline)]
From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 9934-done <at> debbugs.gnu.org
Subject: Re: bug#9934: 24.0.91; `region-active-p' definition
Date: Tue, 01 Nov 2011 16:09:06 -0400
> When is there ever any reason to test (and transient-mark-mode
> mark-active)?  When is that value ever different from just the value of
> mark-active?
 
emacs -Q
M-x transient-mark-mode
M-: mark-active RET
C-SPC
M-: mark-active RET


        Stefan


This bug report was last modified 13 years and 204 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.