From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Resent-From: Svante Signell Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2011 22:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9926@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13201018229358 (code B ref -1); Mon, 31 Oct 2011 22:58:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 Oct 2011 22:57:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RL0mq-0002QZ-Gj for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:57:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RL0mm-0002QQ-3D for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:56:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL0ka-0006ca-W4 for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:54:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:53165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0ka-0006cO-RU for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:54:40 -0400 Received: from eggs.gnu.org ([140.186.70.92]:49267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0kZ-0001Sa-L1 for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:54:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL0kY-0006Zf-JW for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:54:39 -0400 Received: from smtp-2.sys.kth.se ([130.237.32.160]:48755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0kY-0006Yf-9z for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:54:38 -0400 Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-2.sys.kth.se (Postfix) with ESMTP id 78EB214DC89 for ; Mon, 31 Oct 2011 23:54:35 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-2.sys.kth.se ([130.237.32.160]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id PVBHNEabJFed; Mon, 31 Oct 2011 23:54:34 +0100 (CET) X-KTH-Auth: srs@kth.se [78.69.11.59] X-KTH-mail-from: srs@kth.se Received: from [192.168.0.6] (78-69-11-59-no42.tbcn.telia.com [78.69.11.59]) by smtp-2.sys.kth.se (Postfix) with ESMTP id AF0B014DC87; Mon, 31 Oct 2011 23:54:34 +0100 (CET) Message-ID: <1320101671.5171.11.camel@hp.my.own.domain> From: Svante Signell Date: Mon, 31 Oct 2011 23:54:31 +0100 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3-2 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Hello, Interesting to see that emacs-24.1 is on its way with many new features. When trying to compile the latest pre-release under GNU/Hurd, the build fails due to a missing definition in src/gnu.h. Inlined is a patch to add the proper definition of GC_MARK_STACK (as on many of the other architectures). Otherwise the global variable: static Lisp_Object Vdead; is undefined on line 6264: if (!EQ (obj, Vdead)) in function which_symbols(). Thanks! --- emacs-24.0.91/src/s/gnu.h~ 2011-10-14 02:40:36.000000000 +0200 +++ emacs-24.0.91/src/s/gnu.h 2011-10-31 23:28:48.000000000 +0100 @@ -44,3 +44,5 @@ #endif /* !_IO_STDIO_H */ #endif /* emacs */ +/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method for marking the stack. */ +#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2011 17:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Svante Signell Cc: 9926@debbugs.gnu.org Received: via spool by 9926-submit@debbugs.gnu.org id=B9926.132016951722894 (code B ref 9926); Tue, 01 Nov 2011 17:46:01 +0000 Received: (at 9926) by debbugs.gnu.org; 1 Nov 2011 17:45:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLIOj-0005xC-2T for submit@debbugs.gnu.org; Tue, 01 Nov 2011 13:45:17 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLIOg-0005x3-9s for 9926@debbugs.gnu.org; Tue, 01 Nov 2011 13:45:15 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pA1Hgs0o032522; Tue, 1 Nov 2011 13:42:54 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id A1807B465D; Tue, 1 Nov 2011 13:42:54 -0400 (EDT) From: Stefan Monnier Message-ID: References: <1320101671.5171.11.camel@hp.my.own.domain> Date: Tue, 01 Nov 2011 13:42:54 -0400 In-Reply-To: <1320101671.5171.11.camel@hp.my.own.domain> (Svante Signell's message of "Mon, 31 Oct 2011 23:54:31 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4028=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4028> : streams <697452> : uri <997010> X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) > Interesting to see that emacs-24.1 is on its way with many new features. > When trying to compile the latest pre-release under GNU/Hurd, the build > fails due to a missing definition in src/gnu.h. Inlined is a patch to > add the proper definition of GC_MARK_STACK (as on many of the other > architectures). Otherwise the global variable: static Lisp_Object Vdead; > is undefined on line 6264: if (!EQ (obj, Vdead)) in function > which_symbols(). Actually GC_MAKE_GCPROS_NOOPS should be made the default, and the build should succeed even if GC_MARK_STACK is not set to GC_MAKE_GCPROS_NOOPS. So the bug is in the which_symbols code. Stefan From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd References: <1320101671.5171.11.camel@hp.my.own.domain> In-Reply-To: <1320101671.5171.11.camel@hp.my.own.domain> Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2011 05:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9926@debbugs.gnu.org Received: via spool by 9926-submit@debbugs.gnu.org id=B9926.132064478512057 (code B ref 9926); Mon, 07 Nov 2011 05:47:01 +0000 Received: (at 9926) by debbugs.gnu.org; 7 Nov 2011 05:46:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNI2L-00038P-47 for submit@debbugs.gnu.org; Mon, 07 Nov 2011 00:46:25 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNI2H-00038G-GJ for 9926@debbugs.gnu.org; Mon, 07 Nov 2011 00:46:23 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id A376539E800D for <9926@debbugs.gnu.org>; Sun, 6 Nov 2011 21:43:30 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x8yYVeQ8rcAD for <9926@debbugs.gnu.org>; Sun, 6 Nov 2011 21:43:28 -0800 (PST) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 8BF1239E8007 for <9926@debbugs.gnu.org>; Sun, 6 Nov 2011 21:43:28 -0800 (PST) Message-ID: <4EB77003.9040006@cs.ucla.edu> Date: Sun, 06 Nov 2011 21:43:31 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) I installed the following patch in the trunk as bzr 106311 to fix the fails-to-compile bug. Making GC_MAKE_GCPROS_NOOPS the default sounds good, but as it doesn't fix a bug and we're in feature-freeze now I left that for later. === modified file 'src/ChangeLog' --- src/ChangeLog 2011-11-07 02:00:43 +0000 +++ src/ChangeLog 2011-11-07 05:37:49 +0000 @@ -1,3 +1,10 @@ +2011-11-07 Paul Eggert + + * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926). + This is also needed for porting to any host where GC_MARK_STACK is + not GC_MAKE_GCPROS_NOOPS. + (which_symbols): Use it. + 2011-11-07 Kenichi Handa * coding.c (coding_set_destination): Check coding->src_pos only === modified file 'src/alloc.c' --- src/alloc.c 2011-10-29 17:25:44 +0000 +++ src/alloc.c 2011-11-07 05:37:49 +0000 @@ -315,6 +315,7 @@ on free lists recognizable in O(1). */ static Lisp_Object Vdead; +#define DEADP(x) EQ (x, Vdead) #ifdef GC_MALLOC_CHECK @@ -411,6 +412,10 @@ #endif /* GC_MARK_STACK || GC_MALLOC_CHECK */ +#ifndef DEADP +# define DEADP(x) 0 +#endif + /* Recording what needs to be marked for gc. */ struct gcpro *gcprolist; @@ -6261,7 +6266,7 @@ int gc_count = inhibit_garbage_collection (); Lisp_Object found = Qnil; - if (!EQ (obj, Vdead)) + if (! DEADP (obj)) { for (sblk = symbol_block; sblk; sblk = sblk->next) { From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 12:17:19 2011 Received: (at control) by debbugs.gnu.org; 7 Nov 2011 17:17:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNSox-0002dr-6b for submit@debbugs.gnu.org; Mon, 07 Nov 2011 12:17:19 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNSou-0002dj-TB for control@debbugs.gnu.org; Mon, 07 Nov 2011 12:17:18 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RNSm7-0005N9-VY for control@debbugs.gnu.org; Mon, 07 Nov 2011 12:14:24 -0500 Date: Mon, 07 Nov 2011 12:14:23 -0500 Message-Id: Subject: control message for bug 9926 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) retitle 9926 make GC_MAKE_GCPROS_NOOPS the default severity 9926 wishlist submitter 9926 monnier@IRO.UMontreal.CA From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd References: <1320101671.5171.11.camel@hp.my.own.domain> Resent-From: Svante Signell Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2011 12:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9926@debbugs.gnu.org Cc: eggert@cs.ucla.edu X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: srs@kth.se Received: via spool by submit@debbugs.gnu.org id=B.132075509827650 (code B ref -1); Tue, 08 Nov 2011 12:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Nov 2011 12:24:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNkjZ-0007Bv-PL for submit@debbugs.gnu.org; Tue, 08 Nov 2011 07:24:58 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNkjX-0007Bn-6B for submit@debbugs.gnu.org; Tue, 08 Nov 2011 07:24:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNkge-0003TP-Ac for submit@debbugs.gnu.org; Tue, 08 Nov 2011 07:21:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:43315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNkge-0003TI-99 for submit@debbugs.gnu.org; Tue, 08 Nov 2011 07:21:56 -0500 Received: from eggs.gnu.org ([140.186.70.92]:45820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNkga-0006Eg-DH for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2011 07:21:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNkgZ-0003S8-AN for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2011 07:21:52 -0500 Received: from smtp-1.sys.kth.se ([130.237.32.175]:46925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNkgY-0003RJ-Vf for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2011 07:21:51 -0500 Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-1.sys.kth.se (Postfix) with ESMTP id 36A041563B3; Tue, 8 Nov 2011 13:21:47 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-1.sys.kth.se ([130.237.32.175]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id qCHw7OUaSuD5; Tue, 8 Nov 2011 13:21:45 +0100 (CET) X-KTH-Auth: srs [130.237.20.66] X-KTH-mail-from: srs@kth.se Received: from [130.237.20.66] (s1499.it.kth.se [130.237.20.66]) by smtp-1.sys.kth.se (Postfix) with ESMTP id D4DD61563A1; Tue, 8 Nov 2011 13:21:43 +0100 (CET) Message-ID: <1320754903.5597.30.camel@s1499.it.kth.se> From: Svante Signell Date: Tue, 08 Nov 2011 13:21:43 +0100 In-Reply-To: 4EB77003.9040006@cs.ucla.edu Organization: KTH Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3-2 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > I installed the following patch in the trunk as bzr 106311 > to fix the fails-to-compile bug. > > Making GC_MAKE_GCPROS_NOOPS the default sounds good, but as > it doesn't fix a bug and we're in feature-freeze now I left > that for later. > > === modified file 'src/ChangeLog' > --- src/ChangeLog 2011-11-07 02:00:43 +0000 > +++ src/ChangeLog 2011-11-07 05:37:49 +0000 > @@ -1,3 +1,10 @@ > +2011-11-07 Paul Eggert > + > + * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926). > + This is also needed for porting to any host where GC_MARK_STACK is > + not GC_MAKE_GCPROS_NOOPS. > + (which_symbols): Use it. Reading your patch shows that GC_MARK_STACK will still not be set for GNU/Hurd. However, the previous comment by Stefan Monnier says that GC_MAKE_GCPROS_NOOPS should be set as the default. So what is wrong with patching gnu.h?? Anyway, which are the differences/consequences of that part of the code in which_symbols being executed compared to not when GC_MARK_STACK is unset or set to GC_MAKE_GCPROS_NOOPS? From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2011 13:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: srs@kth.se Cc: eggert@cs.ucla.edu, 9926@debbugs.gnu.org Received: via spool by 9926-submit@debbugs.gnu.org id=B9926.13207592914002 (code B ref 9926); Tue, 08 Nov 2011 13:35:01 +0000 Received: (at 9926) by debbugs.gnu.org; 8 Nov 2011 13:34:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNlpD-00012U-86 for submit@debbugs.gnu.org; Tue, 08 Nov 2011 08:34:51 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNlpB-00012N-7B for 9926@debbugs.gnu.org; Tue, 08 Nov 2011 08:34:49 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AusGAJsuuU5MCoYy/2dsb2JhbABDmluPKYEGgXIBAQQBViMFCws0EhQYDYg5uCOJLQSIC5lahEg X-IronPort-AV: E=Sophos;i="4.69,477,1315195200"; d="scan'208";a="146854927" Received: from 76-10-134-50.dsl.teksavvy.com (HELO pastel.home) ([76.10.134.50]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 08 Nov 2011 08:31:49 -0500 Received: by pastel.home (Postfix, from userid 20848) id 1F4E2590B2; Tue, 8 Nov 2011 08:31:47 -0500 (EST) From: Stefan Monnier Message-ID: References: <1320101671.5171.11.camel@hp.my.own.domain> <1320754903.5597.30.camel@s1499.it.kth.se> Date: Tue, 08 Nov 2011 08:31:47 -0500 In-Reply-To: <1320754903.5597.30.camel@s1499.it.kth.se> (Svante Signell's message of "Tue, 08 Nov 2011 13:21:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > Anyway, which are the differences/consequences of that part of the code > in which_symbols being executed compared to not when GC_MARK_STACK is > unset or set to GC_MAKE_GCPROS_NOOPS? They don't matter: which_symbols is a function only for use from a C debugger: there is no call to this function within Emacs itself. Stefan From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2011 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: srs@kth.se Cc: 9926@debbugs.gnu.org Received: via spool by 9926-submit@debbugs.gnu.org id=B9926.132077085421592 (code B ref 9926); Tue, 08 Nov 2011 16:48:01 +0000 Received: (at 9926) by debbugs.gnu.org; 8 Nov 2011 16:47:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNopg-0005cC-Um for submit@debbugs.gnu.org; Tue, 08 Nov 2011 11:47:33 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNopb-0005c1-Nx for 9926@debbugs.gnu.org; Tue, 08 Nov 2011 11:47:31 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 6537F39E800D; Tue, 8 Nov 2011 08:44:28 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rGeh2ud831ZZ; Tue, 8 Nov 2011 08:44:27 -0800 (PST) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7B83D39E800C; Tue, 8 Nov 2011 08:44:27 -0800 (PST) Message-ID: <4EB95C65.2020404@cs.ucla.edu> Date: Tue, 08 Nov 2011 08:44:21 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 References: <1320754903.5597.30.camel@s1499.it.kth.se> In-Reply-To: <1320754903.5597.30.camel@s1499.it.kth.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.1 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) On 11/08/11 04:21, Svante Signell wrote: > the previous comment by Stefan Monnier says that > GC_MAKE_GCPROS_NOOPS should be set as the default. So what is wrong > with patching gnu.h?? I don't see anything wrong with changing Emacs to use GC_MAKE_GCPROS_NOOPS on GNU/Hurd. If there's no objection I would like to install the change suggested by Stefan, which should have the same effect as patching gnu.h but results in cleaner code internally. Please see the patch below. > Anyway, which are the differences/consequences of that part of the code > in which_symbols being executed compared to not when GC_MARK_STACK is > unset or set to GC_MAKE_GCPROS_NOOPS? As Stefan wrote, which_symbols is executed only if you run Emacs under a debugger and execute it yourself. And in that case, the new DEADP macro should do the right thing, regardless of what GC_MARK_STACK is set or unset to. === modified file 'src/ChangeLog' --- src/ChangeLog 2011-11-08 07:25:56 +0000 +++ src/ChangeLog 2011-11-08 16:36:16 +0000 @@ -1,3 +1,15 @@ +2011-11-08 Paul Eggert + + Set GC_MARK_STACK to GC_MAKE_GCPROS_NOOPS on GNU/Hurd (Bug#9926). + * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS. + * s/cygwin.h, s/darwin.h, s/freebsd.h, s/irix6-5.h, s/msdos.h: + * s/netbsd.h, s/sol2-6.h: + Remove definition of GC_MARK_STACK, since the default now works. + * s/aix4-2.h, s/hpux10-20.h, s/ms-w32.h, s/unixware.h: + Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's + no longer the default. + * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default. + 2011-11-08 Chong Yidong * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix. === modified file 'src/lisp.h' --- src/lisp.h 2011-11-07 17:04:01 +0000 +++ src/lisp.h 2011-11-08 16:29:11 +0000 @@ -2213,7 +2213,7 @@ #define GC_USE_GCPROS_CHECK_ZOMBIES 3 #ifndef GC_MARK_STACK -#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE +#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS #endif /* Whether we do the stack marking manually. */ === modified file 'src/s/aix4-2.h' --- src/s/aix4-2.h 2011-07-07 01:32:56 +0000 +++ src/s/aix4-2.h 2011-11-08 16:29:11 +0000 @@ -75,3 +75,7 @@ Emacs currently calls xrealloc on the results of get_current_dir name, to avoid a crash just use the Emacs implementation for that function. */ #define BROKEN_GET_CURRENT_DIR_NAME 1 + +/* Conservative garbage collection has not been tested, so for now + play it safe and stick with the old-fashioned way of marking. */ +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE === modified file 'src/s/cygwin.h' --- src/s/cygwin.h 2011-03-17 05:15:08 +0000 +++ src/s/cygwin.h 2011-11-08 16:29:11 +0000 @@ -85,12 +85,6 @@ change their controlling terminal */ #define vfork fork -/* This should work (at least when compiling with gcc). But I have no way - or intention to verify or even test it. If you encounter a problem with - it, feel free to change this setting, but please add a comment here about - why it needed to be changed. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS - /* Virtual addresses of pure and impure space can vary, as on Windows. */ #define VIRT_ADDR_VARIES === modified file 'src/s/darwin.h' --- src/s/darwin.h 2011-08-09 22:13:11 +0000 +++ src/s/darwin.h 2011-11-08 16:29:11 +0000 @@ -145,6 +145,3 @@ It is already a controlling terminal of subprocess, because we did ioctl TIOCSCTTY. */ #define DONT_REOPEN_PTY - -/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method for marking the stack. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/freebsd.h' --- src/s/freebsd.h 2011-02-16 01:35:20 +0000 +++ src/s/freebsd.h 2011-11-08 16:29:11 +0000 @@ -58,6 +58,3 @@ /* Tell that garbage collector that setjmp is known to save all registers relevant for conservative garbage collection in the jmp_buf. */ #define GC_SETJMP_WORKS 1 - -/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method for marking the stack. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/gnu-linux.h' --- src/s/gnu-linux.h 2011-09-09 01:06:52 +0000 +++ src/s/gnu-linux.h 2011-11-08 16:29:11 +0000 @@ -145,7 +145,6 @@ || defined __arm__ || defined __powerpc__ || defined __amd64__ \ || defined __ia64__ || defined __sh__ #define GC_SETJMP_WORKS 1 -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS #ifdef __mc68000__ #define GC_LISP_OBJECT_ALIGNMENT 2 #endif @@ -158,4 +157,6 @@ __builtin_ia64_bsp (), 0); \ } while (0) #endif +#else +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE #endif === modified file 'src/s/hpux10-20.h' --- src/s/hpux10-20.h 2011-02-16 01:35:20 +0000 +++ src/s/hpux10-20.h 2011-11-08 16:29:11 +0000 @@ -101,6 +101,10 @@ on HP-UX. (You get duplicate symbol errors on linking). */ #undef _FILE_OFFSET_BITS +/* Conservative garbage collection has not been tested, so for now + play it safe and stick with the old-fashioned way of marking. */ +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE + /* Define VIRT_ADDR_VARIES if the virtual addresses of pure and impure space as loaded can vary, and even their relative order cannot be relied on. === modified file 'src/s/irix6-5.h' --- src/s/irix6-5.h 2011-07-07 03:24:33 +0000 +++ src/s/irix6-5.h 2011-11-08 16:29:11 +0000 @@ -95,7 +95,6 @@ /* Tested on Irix 6.5. SCM worked on earlier versions. */ #define GC_SETJMP_WORKS 1 -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS /* DATA_SEG_BITS forces extra bits to be or'd in with any pointers which === modified file 'src/s/ms-w32.h' --- src/s/ms-w32.h 2011-11-05 16:30:13 +0000 +++ src/s/ms-w32.h 2011-11-08 16:29:11 +0000 @@ -402,5 +402,8 @@ #define DebPrint(stuff) #endif +/* Conservative garbage collection has not been tested, so for now + play it safe and stick with the old-fashioned way of marking. */ +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE /* ============================================================ */ === modified file 'src/s/msdos.h' --- src/s/msdos.h 2011-02-26 12:55:10 +0000 +++ src/s/msdos.h 2011-11-08 16:29:11 +0000 @@ -137,5 +137,3 @@ /* Tell the garbage collector that setjmp is known to save all registers relevant for conservative garbage collection in the jmp_buf. */ #define GC_SETJMP_WORKS 1 -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS - === modified file 'src/s/netbsd.h' --- src/s/netbsd.h 2011-02-16 01:35:20 +0000 +++ src/s/netbsd.h 2011-11-08 16:29:11 +0000 @@ -38,6 +38,3 @@ /* Tell that garbage collector that setjmp is known to save all registers relevant for conservative garbage collection in the jmp_buf. */ #define GC_SETJMP_WORKS 1 - -/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/sol2-6.h' --- src/s/sol2-6.h 2011-04-16 22:06:00 +0000 +++ src/s/sol2-6.h 2011-11-08 16:29:11 +0000 @@ -59,4 +59,3 @@ } #define GC_SETJMP_WORKS 1 -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/unixware.h' --- src/s/unixware.h 2011-04-16 22:06:00 +0000 +++ src/s/unixware.h 2011-11-08 16:29:11 +0000 @@ -50,3 +50,7 @@ } #define PENDING_OUTPUT_COUNT(FILE) ((FILE)->__ptr - (FILE)->__base) + +/* Conservative garbage collection has not been tested, so for now + play it safe and stick with the old-fashioned way of marking. */ +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2011 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 9926@debbugs.gnu.org, srs@kth.se Reply-To: Eli Zaretskii Received: via spool by 9926-submit@debbugs.gnu.org id=B9926.13207731601778 (code B ref 9926); Tue, 08 Nov 2011 17:26:02 +0000 Received: (at 9926) by debbugs.gnu.org; 8 Nov 2011 17:26:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNpQt-0000Sb-3i for submit@debbugs.gnu.org; Tue, 08 Nov 2011 12:26:00 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNpQo-0000SK-EK for 9926@debbugs.gnu.org; Tue, 08 Nov 2011 12:25:56 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LUC00800QZ4SY00@a-mtaout20.012.net.il> for 9926@debbugs.gnu.org; Tue, 08 Nov 2011 19:25:42 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.228.42.212]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LUC008P2R2TRM10@a-mtaout20.012.net.il>; Tue, 08 Nov 2011 19:25:42 +0200 (IST) Date: Tue, 08 Nov 2011 19:23:41 +0200 From: Eli Zaretskii In-reply-to: <4EB95C65.2020404@cs.ucla.edu> X-012-Sender: halo1@inter.net.il Message-id: <83ipmuil42.fsf@gnu.org> References: <1320754903.5597.30.camel@s1499.it.kth.se> <4EB95C65.2020404@cs.ucla.edu> X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Tue, 08 Nov 2011 08:44:21 -0800 > From: Paul Eggert > Cc: 9926@debbugs.gnu.org > > --- src/s/ms-w32.h 2011-11-05 16:30:13 +0000 > +++ src/s/ms-w32.h 2011-11-08 16:29:11 +0000 > @@ -402,5 +402,8 @@ > #define DebPrint(stuff) > #endif > > +/* Conservative garbage collection has not been tested, so for now > + play it safe and stick with the old-fashioned way of marking. */ > +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE Given that nt/config.nt defines this: /* Enable conservative stack marking for GC. */ #define GC_MARK_STACK 1 I wonder if the above change for ms-w32.h is TRT. From unknown Sun Jun 22 11:44:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: monnier@IRO.UMontreal.CA Subject: bug#9926: closed (Re: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd) Message-ID: References: <4EB98E7F.8040704@cs.ucla.edu> <1320101671.5171.11.camel@hp.my.own.domain> X-Gnu-PR-Message: they-closed 9926 X-Gnu-PR-Package: emacs Reply-To: 9926@debbugs.gnu.org Date: Tue, 08 Nov 2011 20:19:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1320783542-20509-1" This is a multi-part message in MIME format... ------------=_1320783542-20509-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #9926: make GC_MAKE_GCPROS_NOOPS the default which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 9926@debbugs.gnu.org. --=20 9926: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9926 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1320783542-20509-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 9926-done) by debbugs.gnu.org; 8 Nov 2011 20:18:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNs7d-0005Jr-Nb for submit@debbugs.gnu.org; Tue, 08 Nov 2011 15:18:18 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNs7a-0005Jd-TX for 9926-done@debbugs.gnu.org; Tue, 08 Nov 2011 15:18:16 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 20D3739E800D; Tue, 8 Nov 2011 12:18:08 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cT8y+brK3Dzi; Tue, 8 Nov 2011 12:18:07 -0800 (PST) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6EB3B39E8008; Tue, 8 Nov 2011 12:18:07 -0800 (PST) Message-ID: <4EB98E7F.8040704@cs.ucla.edu> Date: Tue, 08 Nov 2011 12:18:07 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd References: <1320754903.5597.30.camel@s1499.it.kth.se> <4EB95C65.2020404@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 9926-done Cc: 9926-done@debbugs.gnu.org, srs@kth.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) On 11/08/11 09:09, Stefan Monnier wrote: > So I'd rather use the OP's patch that only affects the Hurd. Sounds good. I did that as bzr 106331 and am marking this bug as done. ------------=_1320783542-20509-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 Oct 2011 22:57:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RL0mq-0002QZ-Gj for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:57:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RL0mm-0002QQ-3D for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:56:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL0ka-0006ca-W4 for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:54:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:53165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0ka-0006cO-RU for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:54:40 -0400 Received: from eggs.gnu.org ([140.186.70.92]:49267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0kZ-0001Sa-L1 for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:54:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL0kY-0006Zf-JW for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:54:39 -0400 Received: from smtp-2.sys.kth.se ([130.237.32.160]:48755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0kY-0006Yf-9z for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:54:38 -0400 Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-2.sys.kth.se (Postfix) with ESMTP id 78EB214DC89 for ; Mon, 31 Oct 2011 23:54:35 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-2.sys.kth.se ([130.237.32.160]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id PVBHNEabJFed; Mon, 31 Oct 2011 23:54:34 +0100 (CET) X-KTH-Auth: srs@kth.se [78.69.11.59] X-KTH-mail-from: srs@kth.se Received: from [192.168.0.6] (78-69-11-59-no42.tbcn.telia.com [78.69.11.59]) by smtp-2.sys.kth.se (Postfix) with ESMTP id AF0B014DC87; Mon, 31 Oct 2011 23:54:34 +0100 (CET) Message-ID: <1320101671.5171.11.camel@hp.my.own.domain> Subject: patch: emacs-24.0.91 FTBFS on GNU/Hurd From: Svante Signell To: bug-gnu-emacs@gnu.org Date: Mon, 31 Oct 2011 23:54:31 +0100 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3-2 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Hello, Interesting to see that emacs-24.1 is on its way with many new features. When trying to compile the latest pre-release under GNU/Hurd, the build fails due to a missing definition in src/gnu.h. Inlined is a patch to add the proper definition of GC_MARK_STACK (as on many of the other architectures). Otherwise the global variable: static Lisp_Object Vdead; is undefined on line 6264: if (!EQ (obj, Vdead)) in function which_symbols(). Thanks! --- emacs-24.0.91/src/s/gnu.h~ 2011-10-14 02:40:36.000000000 +0200 +++ emacs-24.0.91/src/s/gnu.h 2011-10-31 23:28:48.000000000 +0100 @@ -44,3 +44,5 @@ #endif /* !_IO_STDIO_H */ #endif /* emacs */ +/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method for marking the stack. */ +#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS ------------=_1320783542-20509-1-- From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2011 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 9926@debbugs.gnu.org Received: via spool by 9926-submit@debbugs.gnu.org id=B9926.132078460422104 (code B ref 9926); Tue, 08 Nov 2011 20:37:01 +0000 Received: (at 9926) by debbugs.gnu.org; 8 Nov 2011 20:36:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNsPT-0005kS-ON for submit@debbugs.gnu.org; Tue, 08 Nov 2011 15:36:44 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNsPQ-0005kG-FK for 9926@debbugs.gnu.org; Tue, 08 Nov 2011 15:36:42 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 12D86A60001; Tue, 8 Nov 2011 12:36:34 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BouqFB5UOf47; Tue, 8 Nov 2011 12:36:32 -0800 (PST) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 50EE839E8008; Tue, 8 Nov 2011 12:36:32 -0800 (PST) Message-ID: <4EB992CF.9000101@cs.ucla.edu> Date: Tue, 08 Nov 2011 12:36:31 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 References: <1320754903.5597.30.camel@s1499.it.kth.se> <4EB95C65.2020404@cs.ucla.edu> <83ipmuil42.fsf@gnu.org> In-Reply-To: <83ipmuil42.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.1 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) On 11/08/11 09:23, Eli Zaretskii wrote: > I wonder if the above change for ms-w32.h is TRT. Yes, Stefan wondered the same thing. I expect the answer is "no". Here's a revised patch (intended for 24.2). === modified file 'src/ChangeLog' --- src/ChangeLog 2011-11-08 20:15:17 +0000 +++ src/ChangeLog 2011-11-08 20:31:58 +0000 @@ -1,5 +1,17 @@ 2011-11-08 Paul Eggert + Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926). + * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS. + * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h: + * s/netbsd.h, s/sol2-6.h: + Remove definition of GC_MARK_STACK, since the default now works. + * s/aix4-2.h, s/hpux10-20.h, s/unixware.h: + Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's + no longer the default. + * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default. + +2011-11-08 Paul Eggert + * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926). 2011-11-08 Paul Eggert === modified file 'src/lisp.h' --- src/lisp.h 2011-11-07 17:04:01 +0000 +++ src/lisp.h 2011-11-08 20:31:58 +0000 @@ -2213,7 +2213,7 @@ #define GC_USE_GCPROS_CHECK_ZOMBIES 3 #ifndef GC_MARK_STACK -#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE +#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS #endif /* Whether we do the stack marking manually. */ === modified file 'src/s/aix4-2.h' --- src/s/aix4-2.h 2011-07-07 01:32:56 +0000 +++ src/s/aix4-2.h 2011-11-08 20:31:58 +0000 @@ -75,3 +75,7 @@ Emacs currently calls xrealloc on the results of get_current_dir name, to avoid a crash just use the Emacs implementation for that function. */ #define BROKEN_GET_CURRENT_DIR_NAME 1 + +/* Conservative garbage collection has not been tested, so for now + play it safe and stick with the old-fashioned way of marking. */ +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE === modified file 'src/s/cygwin.h' --- src/s/cygwin.h 2011-03-17 05:15:08 +0000 +++ src/s/cygwin.h 2011-11-08 20:31:58 +0000 @@ -85,12 +85,6 @@ change their controlling terminal */ #define vfork fork -/* This should work (at least when compiling with gcc). But I have no way - or intention to verify or even test it. If you encounter a problem with - it, feel free to change this setting, but please add a comment here about - why it needed to be changed. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS - /* Virtual addresses of pure and impure space can vary, as on Windows. */ #define VIRT_ADDR_VARIES === modified file 'src/s/darwin.h' --- src/s/darwin.h 2011-08-09 22:13:11 +0000 +++ src/s/darwin.h 2011-11-08 20:31:58 +0000 @@ -145,6 +145,3 @@ It is already a controlling terminal of subprocess, because we did ioctl TIOCSCTTY. */ #define DONT_REOPEN_PTY - -/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method for marking the stack. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/freebsd.h' --- src/s/freebsd.h 2011-02-16 01:35:20 +0000 +++ src/s/freebsd.h 2011-11-08 20:31:58 +0000 @@ -58,6 +58,3 @@ /* Tell that garbage collector that setjmp is known to save all registers relevant for conservative garbage collection in the jmp_buf. */ #define GC_SETJMP_WORKS 1 - -/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method for marking the stack. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/gnu-linux.h' --- src/s/gnu-linux.h 2011-09-09 01:06:52 +0000 +++ src/s/gnu-linux.h 2011-11-08 20:31:58 +0000 @@ -145,7 +145,6 @@ || defined __arm__ || defined __powerpc__ || defined __amd64__ \ || defined __ia64__ || defined __sh__ #define GC_SETJMP_WORKS 1 -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS #ifdef __mc68000__ #define GC_LISP_OBJECT_ALIGNMENT 2 #endif @@ -158,4 +157,6 @@ __builtin_ia64_bsp (), 0); \ } while (0) #endif +#else +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE #endif === modified file 'src/s/gnu.h' --- src/s/gnu.h 2011-11-08 20:15:17 +0000 +++ src/s/gnu.h 2011-11-08 20:31:58 +0000 @@ -43,6 +43,3 @@ ((FILE)->_IO_write_ptr - (FILE)->_IO_write_base) #endif /* !_IO_STDIO_H */ #endif /* emacs */ - -/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method for marking the stack. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/hpux10-20.h' --- src/s/hpux10-20.h 2011-02-16 01:35:20 +0000 +++ src/s/hpux10-20.h 2011-11-08 20:31:58 +0000 @@ -101,6 +101,10 @@ on HP-UX. (You get duplicate symbol errors on linking). */ #undef _FILE_OFFSET_BITS +/* Conservative garbage collection has not been tested, so for now + play it safe and stick with the old-fashioned way of marking. */ +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE + /* Define VIRT_ADDR_VARIES if the virtual addresses of pure and impure space as loaded can vary, and even their relative order cannot be relied on. === modified file 'src/s/irix6-5.h' --- src/s/irix6-5.h 2011-07-07 03:24:33 +0000 +++ src/s/irix6-5.h 2011-11-08 20:31:58 +0000 @@ -95,7 +95,6 @@ /* Tested on Irix 6.5. SCM worked on earlier versions. */ #define GC_SETJMP_WORKS 1 -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS /* DATA_SEG_BITS forces extra bits to be or'd in with any pointers which === modified file 'src/s/msdos.h' --- src/s/msdos.h 2011-02-26 12:55:10 +0000 +++ src/s/msdos.h 2011-11-08 20:31:58 +0000 @@ -137,5 +137,3 @@ /* Tell the garbage collector that setjmp is known to save all registers relevant for conservative garbage collection in the jmp_buf. */ #define GC_SETJMP_WORKS 1 -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS - === modified file 'src/s/netbsd.h' --- src/s/netbsd.h 2011-02-16 01:35:20 +0000 +++ src/s/netbsd.h 2011-11-08 20:31:58 +0000 @@ -38,6 +38,3 @@ /* Tell that garbage collector that setjmp is known to save all registers relevant for conservative garbage collection in the jmp_buf. */ #define GC_SETJMP_WORKS 1 - -/* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method. */ -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/sol2-6.h' --- src/s/sol2-6.h 2011-04-16 22:06:00 +0000 +++ src/s/sol2-6.h 2011-11-08 20:31:58 +0000 @@ -59,4 +59,3 @@ } #define GC_SETJMP_WORKS 1 -#define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS === modified file 'src/s/unixware.h' --- src/s/unixware.h 2011-04-16 22:06:00 +0000 +++ src/s/unixware.h 2011-11-08 20:31:58 +0000 @@ -50,3 +50,7 @@ } #define PENDING_OUTPUT_COUNT(FILE) ((FILE)->__ptr - (FILE)->__base) + +/* Conservative garbage collection has not been tested, so for now + play it safe and stick with the old-fashioned way of marking. */ +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE From unknown Sun Jun 22 11:44:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2011 20:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 9926@debbugs.gnu.org, srs@kth.se Received: via spool by 9926-submit@debbugs.gnu.org id=B9926.132078593624046 (code B ref 9926); Tue, 08 Nov 2011 20:59:01 +0000 Received: (at 9926) by debbugs.gnu.org; 8 Nov 2011 20:58:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNskx-0006Fl-JX for submit@debbugs.gnu.org; Tue, 08 Nov 2011 15:58:56 -0500 Received: from harpie.cc.umontreal.ca ([132.204.2.134]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNskv-0006FV-9E for 9926@debbugs.gnu.org; Tue, 08 Nov 2011 15:58:54 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pA8H95Ag013128; Tue, 8 Nov 2011 12:09:05 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id A05F9130090; Tue, 8 Nov 2011 12:09:04 -0500 (EST) From: Stefan Monnier Message-ID: References: <1320754903.5597.30.camel@s1499.it.kth.se> <4EB95C65.2020404@cs.ucla.edu> Date: Tue, 08 Nov 2011 12:09:04 -0500 In-Reply-To: <4EB95C65.2020404@cs.ucla.edu> (Paul Eggert's message of "Tue, 08 Nov 2011 08:44:21 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4035=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4035> : streams <699570> : uri <1002563> X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) > I don't see anything wrong with changing Emacs to use GC_MAKE_GCPROS_NOOPS > on GNU/Hurd. If there's no objection I would like to install the change > suggested by Stefan, which should have the same effect as patching gnu.h > but results in cleaner code internally. Please see the patch below. I'd rather keep the old default for now and change it in 24.2, only. So I'd rather use the OP's patch that only affects the Hurd. > === modified file 'src/s/ms-w32.h' > --- src/s/ms-w32.h 2011-11-05 16:30:13 +0000 > +++ src/s/ms-w32.h 2011-11-08 16:29:11 +0000 > @@ -402,5 +402,8 @@ > #define DebPrint(stuff) > #endif > +/* Conservative garbage collection has not been tested, so for now > + play it safe and stick with the old-fashioned way of marking. */ > +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE Really? This sounds wrong, Stefan