From unknown Sun Jun 15 10:54:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9918 <9918@debbugs.gnu.org> To: bug#9918 <9918@debbugs.gnu.org> Subject: Status: 24.0.90; lazy-highlighting in Info mode Reply-To: bug#9918 <9918@debbugs.gnu.org> Date: Sun, 15 Jun 2025 17:54:20 +0000 retitle 9918 24.0.90; lazy-highlighting in Info mode reassign 9918 emacs submitter 9918 Dani Moncayo severity 9918 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 10:49:16 2011 Received: (at submit) by debbugs.gnu.org; 31 Oct 2011 14:49:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKtAp-0005vV-HG for submit@debbugs.gnu.org; Mon, 31 Oct 2011 10:49:16 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKtAi-0005vJ-Eb for submit@debbugs.gnu.org; Mon, 31 Oct 2011 10:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKt8W-0006Ye-Dj for submit@debbugs.gnu.org; Mon, 31 Oct 2011 10:46:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:38604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKt8W-0006YZ-63 for submit@debbugs.gnu.org; Mon, 31 Oct 2011 10:46:52 -0400 Received: from eggs.gnu.org ([140.186.70.92]:33051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKt8V-0007hK-6s for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 10:46:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKt8R-0006Xh-5s for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 10:46:51 -0400 Received: from mail-yw0-f41.google.com ([209.85.213.41]:42514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKt8Q-0006Xc-U1 for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 10:46:47 -0400 Received: by ywa17 with SMTP id 17so6978560ywa.0 for ; Mon, 31 Oct 2011 07:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=9D/gh1WZvAzHspwJ5Vu+DDHw1w5MJeXB/Cu4uDs5k44=; b=a/WH5YZukWO6rwAoWR92IhA4rqC9jJ0679KQnI3mHwfIvF2W9k5xRJOy0sgxsTkpDh vDW5+Jor0MYtzKy8LRoUayd3K+uuKKOIpL2Pl9nc3y+sxy4ZMNab7I6o2A/EvRyEx1lz HzVqGv49hu/iD4E3RPIoS6u2WuSjaDaLRcAxA= MIME-Version: 1.0 Received: by 10.236.78.129 with SMTP id g1mr17266594yhe.52.1320072406255; Mon, 31 Oct 2011 07:46:46 -0700 (PDT) Received: by 10.236.36.40 with HTTP; Mon, 31 Oct 2011 07:46:46 -0700 (PDT) Date: Mon, 31 Oct 2011 15:46:46 +0100 Message-ID: Subject: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) >From "emacs -Q": 1. Open Info node "(emacs)Top" (C-h r). 2. Move point to the end of the first paragraph. 3. Type "C-s extensible". The word "extensible" (in the first line of the paragraph) should be lazy-highlighted, as happens if you repeat the experiment after doing "M-x text-mode". In GNU Emacs 24.0.90.1 (i386-mingw-nt6.1.7601) of 2011-10-27 on DANI-PC Windowing system distributor `Microsoft Corp.', version 6.1.7601 configured using `configure --with-gcc (4.5)' -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 16:46:45 2011 Received: (at 9918) by debbugs.gnu.org; 31 Oct 2011 20:46:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKykm-0007rD-PP for submit@debbugs.gnu.org; Mon, 31 Oct 2011 16:46:44 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKyki-0007r2-Sc for 9918@debbugs.gnu.org; Mon, 31 Oct 2011 16:46:42 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LTY00J006VZJP00@a-mtaout21.012.net.il> for 9918@debbugs.gnu.org; Mon, 31 Oct 2011 22:43:53 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.128.216]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LTY00JE66X4J220@a-mtaout21.012.net.il>; Mon, 31 Oct 2011 22:43:53 +0200 (IST) Date: Mon, 31 Oct 2011 22:43:54 +0200 From: Eli Zaretskii Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode In-reply-to: X-012-Sender: halo1@inter.net.il To: Dani Moncayo Message-id: <83sjm8nb79.fsf@gnu.org> References: X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > Date: Mon, 31 Oct 2011 15:46:46 +0100 > From: Dani Moncayo > > >From "emacs -Q": > 1. Open Info node "(emacs)Top" (C-h r). > 2. Move point to the end of the first paragraph. > 3. Type "C-s extensible". > > The word "extensible" (in the first line of the paragraph) should be > lazy-highlighted, as happens if you repeat the experiment after doing > "M-x text-mode". This is a feature. info.el sets isearch-search-fun-function to Info-isearch-search, which by default searches in a special way (you should see the "Failing I-search" message in the echo are). If you don't want this behavior, try customizing Info-isearch-search to nil. I think this bug report can be closed. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 17:02:26 2011 Received: (at 9918) by debbugs.gnu.org; 31 Oct 2011 21:02:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKyzw-0008Dj-CU for submit@debbugs.gnu.org; Mon, 31 Oct 2011 17:02:25 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKyzt-0008Da-26 for 9918@debbugs.gnu.org; Mon, 31 Oct 2011 17:02:22 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9VL05UM030518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 31 Oct 2011 21:00:06 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9VL04Pe027611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Oct 2011 21:00:05 GMT Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9VKxxL6024482; Mon, 31 Oct 2011 15:59:59 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Oct 2011 13:59:59 -0700 From: "Drew Adams" To: "'Eli Zaretskii'" , "'Dani Moncayo'" References: <83sjm8nb79.fsf@gnu.org> Subject: RE: bug#9918: 24.0.90; lazy-highlighting in Info mode Date: Mon, 31 Oct 2011 14:00:03 -0700 Message-ID: <436BB482340F4A548F73F626446F9DA6@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83sjm8nb79.fsf@gnu.org> Thread-Index: AcyYDfY7rw8qRP1SRTal0x39hciKHQAAHhxg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4EAF0C57.001D,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > > >From "emacs -Q": > > 1. Open Info node "(emacs)Top" (C-h r). > > 2. Move point to the end of the first paragraph. > > 3. Type "C-s extensible". > > > > The word "extensible" (in the first line of the paragraph) should be > > lazy-highlighted, as happens if you repeat the experiment > > after doing "M-x text-mode". > > This is a feature. info.el sets isearch-search-fun-function to > Info-isearch-search, which by default searches in a special way (you > should see the "Failing I-search" message in the echo are). If you > don't want this behavior, try customizing Info-isearch-search to nil. > > I think this bug report can be closed. Hm. Obviously this is _not_ TRT from a user point of view. This happens _only_ when there is only one match of the search pattern and that match is before point. And AFAICT it happens _only_ in Info. Yes, Isearch forward means Isearch _forward_. But as Dani points out, in other buffers even a singleton occurrence that precedes point gets highlighted. This is a bug, IMHO. It should not be closed. Whether it is a high priority for being fixed is another matter, but it should not be closed just because Isearch is a bit special in Info. That's just a cop-out. Feature, indeed! What we should say is "Good catch, Dani - thanks." From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 17:10:33 2011 Received: (at 9918) by debbugs.gnu.org; 31 Oct 2011 21:10:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKz7p-0008Op-9P for submit@debbugs.gnu.org; Mon, 31 Oct 2011 17:10:33 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKz7n-0008Oi-4S for 9918@debbugs.gnu.org; Mon, 31 Oct 2011 17:10:31 -0400 Received: by gyh20 with SMTP id 20so6193243gyh.3 for <9918@debbugs.gnu.org>; Mon, 31 Oct 2011 14:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=h6PdlPyDZvq3vcM/383J5InFni4Ky4phJmulocfZn5s=; b=qQU+ixGOodDRptrWwYe8vjpu9qOn96jUDMr3kXTHdruX4xNufMvGUw+G26MZ5a2O0/ tk3F4i2nZUiBoOMOhGyVnIzC57ENXdGRXgbrCh20sUQs29sMWrztidnPcYy8NTCnWV2D /BI2D5Ijs9j8NOnO4WvycRDY19XwmEqUxqmuQ= MIME-Version: 1.0 Received: by 10.236.78.129 with SMTP id g1mr19464029yhe.52.1320095297146; Mon, 31 Oct 2011 14:08:17 -0700 (PDT) Received: by 10.236.36.40 with HTTP; Mon, 31 Oct 2011 14:08:17 -0700 (PDT) In-Reply-To: <83sjm8nb79.fsf@gnu.org> References: <83sjm8nb79.fsf@gnu.org> Date: Mon, 31 Oct 2011 22:08:17 +0100 Message-ID: Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) >> >From "emacs -Q": >> 1. Open Info node "(emacs)Top" (C-h r). >> 2. Move point to the end of the first paragraph. >> 3. Type "C-s extensible". >> >> The word "extensible" (in the first line of the paragraph) should be >> lazy-highlighted, as happens if you repeat the experiment after doing >> "M-x text-mode". > > This is a feature. =A0info.el sets isearch-search-fun-function to > Info-isearch-search, which by default searches in a special way IMO, it would be better if that special way of searching was consistent with the standard Isearch wrt the lazy highlighting. In step #3 above, the lazy highlighting is performed well until the search begins to fail, point at which the lazy highlighting is deactivated. As I said, this behavior is (a) inconsistent with the standard Isearch (try to do the same in text mode) and (b) less informative for the user (there is indeed a match of "extensible" that should be advised to the user). --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 17:15:56 2011 Received: (at 9918) by debbugs.gnu.org; 31 Oct 2011 21:15:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKzD2-0008WK-5F for submit@debbugs.gnu.org; Mon, 31 Oct 2011 17:15:56 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKzD1-0008WD-0F for 9918@debbugs.gnu.org; Mon, 31 Oct 2011 17:15:55 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9VLDdh0013648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 31 Oct 2011 21:13:40 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9VLDc4e024505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Oct 2011 21:13:39 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9VLDWdj024336; Mon, 31 Oct 2011 16:13:32 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Oct 2011 14:13:32 -0700 From: "Drew Adams" To: "'Dani Moncayo'" , "'Eli Zaretskii'" References: <83sjm8nb79.fsf@gnu.org> Subject: RE: bug#9918: 24.0.90; lazy-highlighting in Info mode Date: Mon, 31 Oct 2011 14:13:37 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcyYEVG788RrjC33S6KyO9kBdHAXwwAADwqQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090201.4EAF0F84.00D7,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > In step #3 above, the lazy highlighting is performed well until the > search begins to fail, point at which the lazy highlighting is > deactivated. As I said, this behavior is (a) inconsistent with the > standard Isearch (try to do the same in text mode) and (b) less > informative for the user (there is indeed a match of "extensible" that > should be advised to the user). Note that the problem arises only when there is only one match for the search pattern, and that match occurs before point. E.g.: `g Intro', put point in the 3rd paragraph, then search for `extensible'. There is no problem highlighting occurrences that are before point. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 17:32:28 2011 Received: (at 9918) by debbugs.gnu.org; 31 Oct 2011 21:32:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKzT1-0000SI-Mc for submit@debbugs.gnu.org; Mon, 31 Oct 2011 17:32:28 -0400 Received: from mail-yw0-f44.google.com ([209.85.213.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKzSv-0000S8-Ow for 9918@debbugs.gnu.org; Mon, 31 Oct 2011 17:32:23 -0400 Received: by ywt2 with SMTP id 2so6179984ywt.3 for <9918@debbugs.gnu.org>; Mon, 31 Oct 2011 14:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lzT8xffAQ1v2Ub20PlUh4J7A1BnfA08Om7egdlAfWA4=; b=LgnHe72gRGgPaBi9Vo20OibkuS4kGfOoY8TAwwCORoABG9sO01JMZbgmN9LnlinWnK cOkhfg8ff+qWDjmEY6+fAyYUPbjKv5AJ08Wtwf6vRir2paq0skpM6Jlk+LVdBAq6DuiJ LtogOIMomrME6aJSt8nX/tpuV/spXa8/J19kI= MIME-Version: 1.0 Received: by 10.236.157.35 with SMTP id n23mr12533131yhk.103.1320096607646; Mon, 31 Oct 2011 14:30:07 -0700 (PDT) Received: by 10.236.36.40 with HTTP; Mon, 31 Oct 2011 14:30:07 -0700 (PDT) In-Reply-To: References: <83sjm8nb79.fsf@gnu.org> Date: Mon, 31 Oct 2011 22:30:07 +0100 Message-ID: Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: Drew Adams Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 9918 Cc: Eli Zaretskii , 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) > Note that the problem arises only when there is only one match for the search > pattern, and that match occurs before point. > > E.g.: `g Intro', put point in the 3rd paragraph, then search for `extensible'. > There is no problem highlighting occurrences that are before point. In that case there is no problem, but I think that the reason is that the search is succeeding (there is a match in the last paragraph). Try to do the same starting from the middle of the last paragraph, and you will see the problem again. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 17:41:37 2011 Received: (at 9918) by debbugs.gnu.org; 31 Oct 2011 21:41:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKzbs-0000f1-TQ for submit@debbugs.gnu.org; Mon, 31 Oct 2011 17:41:37 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKzbr-0000et-Fg for 9918@debbugs.gnu.org; Mon, 31 Oct 2011 17:41:36 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9VLdGJ0008933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 31 Oct 2011 21:39:18 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9VLdFcN026514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Oct 2011 21:39:16 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9VLdA2c008177; Mon, 31 Oct 2011 16:39:10 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Oct 2011 14:39:09 -0700 From: "Drew Adams" To: "'Dani Moncayo'" References: <83sjm8nb79.fsf@gnu.org> Subject: RE: bug#9918: 24.0.90; lazy-highlighting in Info mode Date: Mon, 31 Oct 2011 14:39:14 -0700 Message-ID: <149530B01E1F480EB95B0A56368A2DEB@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcyYFEa11ItwuI2pSfWihcLgBi2wcAAAJKFw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090207.4EAF1587.0030,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 9918 Cc: 'Eli Zaretskii' , 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > > Note that the problem arises only when there is only one > > match for the search pattern, and that match occurs before point. > > > > E.g.: `g Intro', put point in the 3rd paragraph, then > > search for `extensible'. There is no problem highlighting > > occurrences that are before point. > > In that case there is no problem, but I think that the reason is that > the search is succeeding (there is a match in the last paragraph). > Try to do the same starting from the middle of the last paragraph, and > you will see the problem again. Yes. But hit C-s again and it then correctly highlights all of the occurrences (just as it should have done initially, and which happens in other modes). It is when there is only a single match that it immediately moves on to the next node that has a match, instead of highlighting the match in the current node. At least when there is more than one match a second C-s will highlight them all. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 19:20:48 2011 Received: (at 9918) by debbugs.gnu.org; 31 Oct 2011 23:20:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RL19r-0002z2-U4 for submit@debbugs.gnu.org; Mon, 31 Oct 2011 19:20:48 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RL19p-0002yt-TI for 9918@debbugs.gnu.org; Mon, 31 Oct 2011 19:20:47 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id C1C636E8079; Mon, 31 Oct 2011 16:18:30 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7A156451C2E1; Mon, 31 Oct 2011 16:18:29 -0700 (PDT) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode Organization: JURTA References: Date: Tue, 01 Nov 2011 01:15:54 +0200 In-Reply-To: (Dani Moncayo's message of "Mon, 31 Oct 2011 15:46:46 +0100") Message-ID: <87vcr4pxau.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > From "emacs -Q": > 1. Open Info node "(emacs)Top" (C-h r). > 2. Move point to the end of the first paragraph. > 3. Type "C-s extensible". > > The word "extensible" (in the first line of the paragraph) should be > lazy-highlighted, as happens if you repeat the experiment after doing > "M-x text-mode". The difference between this recipe in a normal buffer and an Info buffer is in the line (when (not isearch-error) in `isearch-lazy-highlight-new-loop'. A normal Isearch starts a new lazy highlighting loop even if there is no success (`isearch-success' is nil) and no errors (`isearch-error' is nil). But Info Isearch sets `isearch-error' to "initial node", so `isearch-lazy-highlight-new-loop' doesn't start lazy-highlighting. It seems with the error "initial node", it's still possible to lazy-highlight other matches. So it's not a normal error, and we can make an exception for this type of "error". This will work with the following patch: === modified file 'lisp/isearch.el' --- lisp/isearch.el 2011-10-30 14:41:20 +0000 +++ lisp/isearch.el 2011-10-31 23:12:01 +0000 @@ -2721,7 +2721,7 @@ (defun isearch-lazy-highlight-new-loop ( ;; something important did indeed change (lazy-highlight-cleanup t) ;kill old loop & remove overlays (setq isearch-lazy-highlight-error isearch-error) - (when (not isearch-error) + (when (or (not isearch-error) (equal isearch-error "initial node")) (setq isearch-lazy-highlight-start-limit beg isearch-lazy-highlight-end-limit end) (setq isearch-lazy-highlight-window (selected-window) But it's not good to hardcode it, so perhaps we should introduce a special property for errors that are not quite an error, and set it just for "initial node". From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 05:41:55 2011 Received: (at 9918) by debbugs.gnu.org; 1 Nov 2011 09:41:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLAqw-0000GI-Vl for submit@debbugs.gnu.org; Tue, 01 Nov 2011 05:41:55 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLAqv-0000G3-4v for 9918@debbugs.gnu.org; Tue, 01 Nov 2011 05:41:53 -0400 Received: by gyh20 with SMTP id 20so6720692gyh.3 for <9918@debbugs.gnu.org>; Tue, 01 Nov 2011 02:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=XXuwRoG1QsKnSsqxwtPdgkvjukupXSdW6j1QwgmvmSE=; b=FEfBWUh26w1V0EoqXX823g5VPhg6Up7tBMtY0hSMHflAkqHZ6eCHkxNbLgjOv/V1r4 MBBBlEX8ry5hHDTcuClXC4OcYo8D/j9GOLyEIU1Zl9xI77WwkuKar8k40oZtjIak7ZR6 BGzT08dSEtjNDLEFZkzDG8HKXIk+KP8wuGP6w= MIME-Version: 1.0 Received: by 10.236.126.52 with SMTP id a40mr20850163yhi.125.1320140376252; Tue, 01 Nov 2011 02:39:36 -0700 (PDT) Received: by 10.236.36.40 with HTTP; Tue, 1 Nov 2011 02:39:36 -0700 (PDT) In-Reply-To: <87vcr4pxau.fsf@mail.jurta.org> References: <87vcr4pxau.fsf@mail.jurta.org> Date: Tue, 1 Nov 2011 10:39:36 +0100 Message-ID: Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) > But Info Isearch sets `isearch-error' to "initial node", so > `isearch-lazy-highlight-new-loop' doesn't start lazy-highlighting. > It seems with the error "initial node", it's still possible to > lazy-highlight other matches. =A0So it's not a normal error, > and we can make an exception for this type of "error". > This will work with the following patch: > > [...] > > But it's not good to hardcode it, so perhaps we should introduce > a special property for errors that are not quite an error, > and set it just for "initial node". Indeed. IIUC, "initial node" just inform the user that the current search is failing inside this node (where the search started), but this should not be considered an error (like "incomplete input" or "No previous search string"), because "initial node", unlike "incomplete input", does not deactivate the current Isearch. So, I think that maybe TRT would be to move the "inital node" message to the Isearch prompt, so that such prompt would be "Failing I-search (initial node): ". BTW: while looking for sentences that set the value of `isearch-error' inside lisp/isearch.el, I've noticed that some errors begins with an uppercase letter ("No previous search string") and others don't ("incomplete input"). This should be fixed to make it consistent for all error messages. --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 06:23:53 2011 Received: (at 9918) by debbugs.gnu.org; 1 Nov 2011 10:23:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLBVZ-0001C9-3D for submit@debbugs.gnu.org; Tue, 01 Nov 2011 06:23:53 -0400 Received: from mail-yw0-f44.google.com ([209.85.213.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLBVW-0001C2-Hl for 9918@debbugs.gnu.org; Tue, 01 Nov 2011 06:23:51 -0400 Received: by ywt2 with SMTP id 2so6713468ywt.3 for <9918@debbugs.gnu.org>; Tue, 01 Nov 2011 03:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MFbguOTo9d+iglcX8ykxGfSOMAfimy4XoqZyQARWJgo=; b=uRDBDeHFvrsWiNz8OYcnF04guRT5jJ2j4sYozxb4LvC4s6mpLMSB2t3sDKEcM3Li+O SAJRB+ffNKbsx78uUjyi0Uop818NXNwUqzb8YpkNq8opbhbHyO8FYqze+YCPMb+Qyx1e LYnh2UpozeivfkEEEBXCQz/ZOHFQx0lKyrpeY= MIME-Version: 1.0 Received: by 10.236.195.36 with SMTP id o24mr21200623yhn.57.1320142893336; Tue, 01 Nov 2011 03:21:33 -0700 (PDT) Received: by 10.236.36.40 with HTTP; Tue, 1 Nov 2011 03:21:33 -0700 (PDT) In-Reply-To: References: <87vcr4pxau.fsf@mail.jurta.org> Date: Tue, 1 Nov 2011 11:21:33 +0100 Message-ID: Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) BTW, whatever the patch be, there is a second issue (discovered by Drew) that should be addressed: The first time Isearch is fails inside an Info node, you get the "initial node" message, and then, typing another "C-s" have the effect of continuing the Isearch across subsequent info nodes. But this behavior sometimes fails. For example: 1. Go to Info node "(emacs)Intro". 2. Type "C-s extensible C-s C-s". --> Here you've got the "initial node" message. OK. 3. Type "C-s". --> (Observed) The "initial node" message is removed, and everything remains the same. You have to type "C-s" again to continue the search in subsequent nodes. --> (Expected) The Isearch is continued across subsequent nodes, without the need of an extra "C-s". -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 19:21:30 2011 Received: (at 9918) by debbugs.gnu.org; 1 Nov 2011 23:21:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLNe6-0005Ot-Bf for submit@debbugs.gnu.org; Tue, 01 Nov 2011 19:21:30 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLNe3-0005Ok-O7 for 9918@debbugs.gnu.org; Tue, 01 Nov 2011 19:21:28 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 7E23B6E8085; Tue, 1 Nov 2011 16:19:07 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A520A451C2D8; Tue, 1 Nov 2011 16:19:06 -0700 (PDT) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode Organization: JURTA References: <87vcr4pxau.fsf@mail.jurta.org> Date: Wed, 02 Nov 2011 01:07:11 +0200 In-Reply-To: (Dani Moncayo's message of "Tue, 1 Nov 2011 10:39:36 +0100") Message-ID: <87aa8fo2ko.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > IIUC, "initial node" just inform the user that the current search is > failing inside this node (where the search started), but this should > not be considered an error (like "incomplete input" or "No previous > search string"), because "initial node", unlike "incomplete input", > does not deactivate the current Isearch. If it's not possible to code this situation with the combination of existing variables `isearch-success' and `isearch-error', then perhaps we should introduce a new variable `isearch-warning'. > BTW: while looking for sentences that set the value of `isearch-error' > inside lisp/isearch.el, I've noticed that some errors begins with an > uppercase letter ("No previous search string") and others don't > ("incomplete input"). This should be fixed to make it consistent for > all error messages. This is intentional because when you see "No previous search string" the search string is empty, so the message should look like the beginning of a new sentence, not like the continuation of a non-empty search string. > BTW, whatever the patch be, there is a second issue (discovered by > Drew) that should be addressed: > > The first time Isearch is fails inside an Info node, you get the > "initial node" message, and then, typing another "C-s" have the effect > of continuing the Isearch across subsequent info nodes. But this > behavior sometimes fails. For example: > > 1. Go to Info node "(emacs)Intro". > 2. Type "C-s extensible C-s C-s". > --> Here you've got the "initial node" message. OK. > 3. Type "C-s". > --> (Observed) The "initial node" message is removed, and everything > remains the same. You have to type "C-s" again to continue the search > in subsequent nodes. > --> (Expected) The Isearch is continued across subsequent nodes, > without the need of an extra "C-s". The current behavior is correct. When you see the message about failing Isearch without the "initial node" suffix, that means that it reached the end of the whole manual and failed completely. The subsequent `C-s' starts searching from the beginning of the manual. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 02 03:56:39 2011 Received: (at 9918) by debbugs.gnu.org; 2 Nov 2011 07:56:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLVgc-0008UI-F2 for submit@debbugs.gnu.org; Wed, 02 Nov 2011 03:56:39 -0400 Received: from mail-yw0-f44.google.com ([209.85.213.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLVgZ-0008UB-F3 for 9918@debbugs.gnu.org; Wed, 02 Nov 2011 03:56:36 -0400 Received: by ywt2 with SMTP id 2so7741111ywt.3 for <9918@debbugs.gnu.org>; Wed, 02 Nov 2011 00:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=vA/C2oPHT78Ylh6WZ4eKcYPBNsEUu1qDCR9JyNh6a/Y=; b=sSyxcv6CBbtsyC42osteqZ2BsKe72rItB3ycgqCQMjYiZXDl/74G0E+yzN5XDCDZ/8 9MZKiJj8bL8wCWn6NMaBbU7qk/YHoeP/mRoaDjpwTaaU899JdT9BlTX69veBSEynx931 cQsslLzkDl82GNZXmTkfOob13y1wlVNixzlNo= MIME-Version: 1.0 Received: by 10.236.139.197 with SMTP id c45mr5291595yhj.64.1320220453310; Wed, 02 Nov 2011 00:54:13 -0700 (PDT) Received: by 10.236.41.9 with HTTP; Wed, 2 Nov 2011 00:54:12 -0700 (PDT) In-Reply-To: <87aa8fo2ko.fsf@mail.jurta.org> References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> Date: Wed, 2 Nov 2011 08:54:12 +0100 Message-ID: Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) >> 1. Go to Info node "(emacs)Intro". >> 2. Type "C-s extensible C-s C-s". >> --> Here you've got the "initial node" message. OK. >> 3. Type "C-s". >> --> (Observed) The "initial node" message is removed, and everything >> remains the same. =A0You have to type "C-s" again to continue the search >> in subsequent nodes. >> --> (Expected) The Isearch is continued across subsequent nodes, >> without the need of an extra "C-s". > > The current behavior is correct. =A0When you see the message about failin= g > Isearch without the "initial node" suffix, that means that it reached > the end of the whole manual and failed completely. =A0The subsequent `C-s= ' > starts searching from the beginning of the manual. Ah Ok. Then, I think that, in this case, a message like "end of the manual" (analogous to "initial node") would be good, for the user to know what's going on. --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 05:14:41 2011 Received: (at 9918) by debbugs.gnu.org; 3 Nov 2011 09:14:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLtNg-00025M-E8 for submit@debbugs.gnu.org; Thu, 03 Nov 2011 05:14:41 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLtNe-00025D-GU for 9918@debbugs.gnu.org; Thu, 03 Nov 2011 05:14:39 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 763106E8054; Thu, 3 Nov 2011 02:12:10 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9A8F9451C2D8; Thu, 3 Nov 2011 02:12:09 -0700 (PDT) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode Organization: JURTA References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> Date: Thu, 03 Nov 2011 11:07:25 +0200 In-Reply-To: (Dani Moncayo's message of "Wed, 2 Nov 2011 08:54:12 +0100") Message-ID: <87ipn1r2uq.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > Then, I think that, in this case, a message like "end of the manual" > (analogous to "initial node") would be good, for the user to know > what's going on. This is possible to do with a small patch: === modified file 'lisp/info.el' --- lisp/info.el 2011-11-02 10:46:18 +0000 +++ lisp/info.el 2011-11-03 09:06:57 +0000 @@ -1844,7 +1844,7 @@ (defun Info-search (regexp &optional bou (setq list nil))) (if found (message "") - (signal 'search-failed (list regexp)))) + (signal 'search-failed (list regexp "end of the manual")))) (if (not found) (progn (Info-read-subfile osubfile) (goto-char opoint) From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 05:47:24 2011 Received: (at 9918) by debbugs.gnu.org; 3 Nov 2011 09:47:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLttM-0002pt-5d for submit@debbugs.gnu.org; Thu, 03 Nov 2011 05:47:24 -0400 Received: from mail-yw0-f44.google.com ([209.85.213.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLttJ-0002pm-Oc for 9918@debbugs.gnu.org; Thu, 03 Nov 2011 05:47:22 -0400 Received: by ywt2 with SMTP id 2so1101448ywt.3 for <9918@debbugs.gnu.org>; Thu, 03 Nov 2011 02:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Z25bVeXH38OSU5U9G4J/vQTC8N/fJbyproDa5bdFWg4=; b=QwtEusNT4LvsNdLXydt2au08n9KnjGorT5uexo8domPUj9wxFvHvX5q/xmjIz5XGM+ HXgWPFXKJpZZ40HSaJtbtgaLpVAeL8ydslr7fg3LXZ7n/7YNP1WG6OdWufaHGZEJtddR us8q/aZau7Ttjkd/9VUvK2BCqh2VQdFcA/IRw= MIME-Version: 1.0 Received: by 10.236.176.69 with SMTP id a45mr11825785yhm.47.1320313493388; Thu, 03 Nov 2011 02:44:53 -0700 (PDT) Received: by 10.236.41.9 with HTTP; Thu, 3 Nov 2011 02:44:52 -0700 (PDT) In-Reply-To: <87ipn1r2uq.fsf@mail.jurta.org> References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> <87ipn1r2uq.fsf@mail.jurta.org> Date: Thu, 3 Nov 2011 10:44:52 +0100 Message-ID: Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) >> Then, I think that, in this case, a message like "end of the manual" >> (analogous to "initial node") would be good, for the user to know >> what's going on. > > This is possible to do with a small patch: Looks good! Thanks! So, the remaining issue is to handle "initial node" and "end of the manual", not as errors (they *don't* deactivate the Isearch), but as informative messages. As I pointed out in a previous post, I think that it would be unsuitable to show these informative messages the same way as error messages (with "[...]" suffix), because they have a different nature (ones deactivate Isearch, the others don't). I think that these two informative messages ("initial node", "end of the manual") fall into the same category as the messages that are added to the Isearch prompt ("Failing", "Wrapped", "Overwrapped", "Failing overwrapped", ...). So I propose to present all these "Isearch flags" to the user using a common pattern. For example: * "Isearch:" * "Isearch [failing]:" * "Isearch [wrapped]:" * "Isearch [overwrapped]:" * "Isearch [failing, overwrapped]:" * "Isearch [failing, initial node]:" * "Isearch [failing, end of manual]:" It would add consistency to the Isearch visual feedback. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 15:33:51 2011 Received: (at 9918) by debbugs.gnu.org; 3 Nov 2011 19:33:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM32s-0001Gc-O8 for submit@debbugs.gnu.org; Thu, 03 Nov 2011 15:33:50 -0400 Received: from mail-qy0-f172.google.com ([209.85.216.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM32q-0001GV-2T for 9918@debbugs.gnu.org; Thu, 03 Nov 2011 15:33:48 -0400 Received: by qyl16 with SMTP id 16so100714qyl.3 for <9918@debbugs.gnu.org>; Thu, 03 Nov 2011 12:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=L+8ckGcV+EmDpEi5NtiWE2uVZ0bS43qKmEfBPib271I=; b=BP1ouyy5JN68N+mdXi4hWcJSC4HvKs4hA2V2re82poPBxE7iCCxFOWTYIMf0YcqSvG ZoYdjKXdw6qUqGnB+fV+OgCD+ZRr8cHOcroTQnWh5bZrYjXTZQtCKxM6bPL9/WTKinIn bJ3RMH7efxZDuW+EOkdKo7SmXhSIWNQeV08zQ= MIME-Version: 1.0 Received: by 10.236.155.2 with SMTP id i2mr14881415yhk.115.1320348253909; Thu, 03 Nov 2011 12:24:13 -0700 (PDT) Received: by 10.236.41.9 with HTTP; Thu, 3 Nov 2011 12:24:13 -0700 (PDT) In-Reply-To: References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> <87ipn1r2uq.fsf@mail.jurta.org> Date: Thu, 3 Nov 2011 20:24:13 +0100 Message-ID: Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) > I think that these two informative messages ("initial node", "end of > the manual") fall into the same category as the messages that are > added to the Isearch prompt ("Failing", "Wrapped", "Overwrapped", > "Failing overwrapped", ...). =A0So I propose to present all these > "Isearch flags" to the user using a common pattern. For example: > * "Isearch:" > * "Isearch [failing]:" > * "Isearch [overwrapped]:" > * "Isearch [failing, overwrapped]:" > * "Isearch [failing, initial node]:" > > It would add consistency to the Isearch visual feedback. ... however a downside of this approach is that the position of the search string varies each time a flag is added to or removed from the prompt. I really dislike that, and btw, this effect occurs currently ("I-search: foo" -> "Failing I-search: foo" ...). So, I rather would write the flags at the right side of the search string, like the error messages are showed right now: * "Isearch: foo" * "Isearch: foo [failing]" * "Isearch: foo [failing, overwrapped]" * "Isearch: foo [failing, initial node]" ... This approach raises a question: how to show the _error_ flags to make them distinguishable from the _informative_ flags? One possibility is to show all the flags the same way. After all, the fact that the errors deactivate the Isearch should be enough for the user to know what's going on, I think. --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 16:00:41 2011 Received: (at 9918) by debbugs.gnu.org; 3 Nov 2011 20:00:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM3Sr-0001se-I3 for submit@debbugs.gnu.org; Thu, 03 Nov 2011 16:00:41 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM3So-0001sW-CE for 9918@debbugs.gnu.org; Thu, 03 Nov 2011 16:00:39 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 443E66E809B; Thu, 3 Nov 2011 12:58:07 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7598A451C58B; Thu, 3 Nov 2011 12:58:06 -0700 (PDT) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode Organization: JURTA References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> <87ipn1r2uq.fsf@mail.jurta.org> Date: Thu, 03 Nov 2011 21:56:20 +0200 In-Reply-To: (Dani Moncayo's message of "Thu, 3 Nov 2011 20:24:13 +0100") Message-ID: <87sjm5f09n.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > * "Isearch: foo" > * "Isearch: foo [failing]" > * "Isearch: foo [failing, overwrapped]" > * "Isearch: foo [failing, initial node]" Yes, moving all prefixes into suffixes and always displaying the search string at the fixed position in the message avoids this problem where prefixes shift the search string to the right in the message, so its position jumps left and right during Isearch depending on the length of the composite prefix that makes more difficult to concentrate on the search string displayed in the message. > This approach raises a question: how to show the _error_ flags to make > them distinguishable from the _informative_ flags? > > One possibility is to show all the flags the same way. After all, the > fact that the errors deactivate the Isearch should be enough for the > user to know what's going on, I think. I think to show all the flags the same way is better. Of course, this should be postponed for 24.2. But now I'd like to fix the original problem you reported. I think we should remove `(not isearch-error)' from `isearch-lazy-highlight-new-loop'. This is over-optimization. It can't know for sure beforehand whether lazy-highlighting will be able to highlight matches even when isearch-error is non-nil. === modified file 'lisp/isearch.el' --- lisp/isearch.el 2011-10-30 01:56:03 +0000 +++ lisp/isearch.el 2011-11-03 19:55:07 +0000 @@ -2674,7 +2721,6 @@ (defun isearch-lazy-highlight-new-loop ( ;; something important did indeed change (lazy-highlight-cleanup t) ;kill old loop & remove overlays (setq isearch-lazy-highlight-error isearch-error) - (when (not isearch-error) (setq isearch-lazy-highlight-start-limit beg isearch-lazy-highlight-end-limit end) (setq isearch-lazy-highlight-window (selected-window) @@ -2692,7 +2738,7 @@ (defun isearch-lazy-highlight-new-loop ( (unless (equal isearch-string "") (setq isearch-lazy-highlight-timer (run-with-idle-timer lazy-highlight-initial-delay nil - 'isearch-lazy-highlight-update)))))) + 'isearch-lazy-highlight-update))))) (defun isearch-lazy-highlight-search () "Search ahead for the next or previous match, for lazy highlighting. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 16:55:20 2011 Received: (at 9918) by debbugs.gnu.org; 3 Nov 2011 20:55:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM4Jj-00039n-O8 for submit@debbugs.gnu.org; Thu, 03 Nov 2011 16:55:20 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM4Ji-00039g-14 for 9918@debbugs.gnu.org; Thu, 03 Nov 2011 16:55:18 -0400 Received: by gye5 with SMTP id 5so1697272gye.3 for <9918@debbugs.gnu.org>; Thu, 03 Nov 2011 13:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=GQ8JLX4HpyWwnxOcKiNE3F9+2PMUDHBSDXUeMOs5OaM=; b=KyYh3gbWidzB9ZppbMiy6kL/kRsSLLViD1NR4oU76x0OdHY8yKk8sLPcswijrv3Whb aHkEeYyoLAtTsejdk1P2WpzUDeG3sOyI6/GBah7G+NObELHzne2d+mYNmSJrorfHefd7 PKAMV2et4tj2xMP56vvkEDGOWXVFi9K/1/VEM= MIME-Version: 1.0 Received: by 10.236.77.232 with SMTP id d68mr14758672yhe.98.1320352986285; Thu, 03 Nov 2011 13:43:06 -0700 (PDT) Received: by 10.236.41.9 with HTTP; Thu, 3 Nov 2011 13:43:06 -0700 (PDT) In-Reply-To: <87sjm5f09n.fsf@mail.jurta.org> References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> <87ipn1r2uq.fsf@mail.jurta.org> <87sjm5f09n.fsf@mail.jurta.org> Date: Thu, 3 Nov 2011 21:43:06 +0100 Message-ID: Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode From: Dani Moncayo To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) > I'd like to fix > the original problem you reported. =A0I think we should remove > `(not isearch-error)' from `isearch-lazy-highlight-new-loop'. > This is over-optimization. =A0It can't know for sure beforehand > whether lazy-highlighting will be able to highlight matches > even when isearch-error is non-nil. Ok, the original problem is fixed by your patch. Install it when you want. And let's keep this bug report open, until the other proposed change be made (in 24.2). Thanks a lot. --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 17:16:52 2011 Received: (at 9918) by debbugs.gnu.org; 3 Nov 2011 21:16:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM4ea-0003fU-91 for submit@debbugs.gnu.org; Thu, 03 Nov 2011 17:16:52 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM4eY-0003fN-Fq for 9918@debbugs.gnu.org; Thu, 03 Nov 2011 17:16:51 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id D28AF6E808A; Thu, 3 Nov 2011 14:14:18 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 02A44451C58B; Thu, 3 Nov 2011 14:14:17 -0700 (PDT) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode Organization: JURTA References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> <87ipn1r2uq.fsf@mail.jurta.org> <87sjm5f09n.fsf@mail.jurta.org> Date: Thu, 03 Nov 2011 23:11:17 +0200 In-Reply-To: (Dani Moncayo's message of "Thu, 3 Nov 2011 21:43:06 +0100") Message-ID: <8739e4gbd7.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > And let's keep this bug report open, until the other proposed change > be made (in 24.2). I propose also to fix the clarity and unambiguousness of final messages now before the next release: === modified file 'lisp/info.el' --- lisp/info.el 2011-10-24 05:47:05 +0000 +++ lisp/info.el 2011-11-03 21:09:57 +0000 @@ -1846,7 +1844,7 @@ (defun Info-search (regexp &optional bou (setq list nil))) (if found (message "") - (signal 'search-failed (list regexp)))) + (signal 'search-failed (list regexp "end of the manual")))) (if (not found) (progn (Info-read-subfile osubfile) (goto-char opoint) === modified file 'lisp/misearch.el' --- lisp/misearch.el 2011-04-19 13:44:55 +0000 +++ lisp/misearch.el 2011-11-03 21:08:09 +0000 @@ -173,8 +173,8 @@ (defun multi-isearch-search-fun () found) ;; Return nil when multi-isearch-next-buffer-current-function fails ;; (`with-current-buffer' raises an error for nil returned from it). - (error nil)) - (signal 'search-failed (list string "Repeat for next buffer")))))))) + (error (signal 'search-failed (list string "end of multi")))) + (signal 'search-failed (list string "repeat for next buffer")))))))) (defun multi-isearch-wrap () "Wrap the multiple buffers search when search is failed. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 19 16:07:08 2011 Received: (at 9918-done) by debbugs.gnu.org; 19 Nov 2011 21:07:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRs7v-0002nG-La for submit@debbugs.gnu.org; Sat, 19 Nov 2011 16:07:08 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRs7t-0002n8-PH for 9918-done@debbugs.gnu.org; Sat, 19 Nov 2011 16:07:06 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id AA85A6E804B; Sat, 19 Nov 2011 13:06:00 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 2D5F7451C5FA; Sat, 19 Nov 2011 13:05:57 -0800 (PST) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode Organization: JURTA References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> <87ipn1r2uq.fsf@mail.jurta.org> <87sjm5f09n.fsf@mail.jurta.org> Date: Sat, 19 Nov 2011 23:04:03 +0200 In-Reply-To: <87sjm5f09n.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 03 Nov 2011 21:56:20 +0200") Message-ID: <87pqgnq0xo.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9918-done Cc: 9918-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > But now I'd like to fix the original problem you reported. > I think we should remove `(not isearch-error)' from > `isearch-lazy-highlight-new-loop'. This is over-optimization. > It can't know for sure beforehand whether lazy-highlighting will be > able to highlight matches even when isearch-error is non-nil. I installed this fix. > I propose also to fix the clarity and unambiguousness of final messages And this one as well. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 02:46:48 2011 Received: (at 9918) by debbugs.gnu.org; 1 Dec 2011 07:46:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RW1M0-0000Nv-HP for submit@debbugs.gnu.org; Thu, 01 Dec 2011 02:46:48 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RW1Lz-0000Np-2x for 9918@debbugs.gnu.org; Thu, 01 Dec 2011 02:46:47 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id E5BE768407C; Wed, 30 Nov 2011 23:46:38 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id CCE7C451C5C7; Wed, 30 Nov 2011 23:46:25 -0800 (PST) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#9918: 24.0.90; lazy-highlighting in Info mode Organization: JURTA References: <87vcr4pxau.fsf@mail.jurta.org> <87aa8fo2ko.fsf@mail.jurta.org> <87ipn1r2uq.fsf@mail.jurta.org> <87sjm5f09n.fsf@mail.jurta.org> <8739e4gbd7.fsf@mail.jurta.org> Date: Thu, 01 Dec 2011 09:45:33 +0200 In-Reply-To: <8739e4gbd7.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 03 Nov 2011 23:11:17 +0200") Message-ID: <87k46gspk2.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9918 Cc: 9918@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > I propose also to fix the clarity and unambiguousness of final messages I noticed that "end of manual" is displayed only in multi-file Info manuals. To display it in a single-file Info manual, the following patch is necessary as well: === modified file 'lisp/info.el' --- lisp/info.el 2011-11-23 07:03:56 +0000 +++ lisp/info.el 2011-12-01 07:45:18 +0000 @@ -1769,12 +1774,14 @@ (defun Info-search (regexp &optional bou ;; If no subfiles, give error now. (if give-up (if (null Info-current-subfile) - (let ((search-spaces-regexp - (if (or (not isearch-mode) isearch-regexp) - Info-search-whitespace-regexp))) - (if backward - (re-search-backward regexp) - (re-search-forward regexp))) + (if isearch-mode + (signal 'search-failed (list regexp "end of manual")) + (let ((search-spaces-regexp + (if (or (not isearch-mode) isearch-regexp) + Info-search-whitespace-regexp))) + (if backward + (re-search-backward regexp) + (re-search-forward regexp)))) (setq found nil))) (if (and bound (not found)) From unknown Sun Jun 15 10:54:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Dec 2011 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator