From unknown Sun Jun 15 08:33:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9915: 24.0.91; Info-hide-node-references does not take effect immediately Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2011 11:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9915@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: Eli Zaretskii Received: via spool by submit@debbugs.gnu.org id=B.13200617806722 (code B ref -1); Mon, 31 Oct 2011 11:50:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Oct 2011 11:49:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKqN1-0001kN-QN for submit@debbugs.gnu.org; Mon, 31 Oct 2011 07:49:40 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKqMz-0001kG-Fm for submit@debbugs.gnu.org; Mon, 31 Oct 2011 07:49:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKqKr-0004hX-9d for submit@debbugs.gnu.org; Mon, 31 Oct 2011 07:47:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:45340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKqKr-0004hS-8A for submit@debbugs.gnu.org; Mon, 31 Oct 2011 07:47:25 -0400 Received: from eggs.gnu.org ([140.186.70.92]:55756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKqKq-00054f-2s for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 07:47:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKqKo-0004gz-HK for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 07:47:24 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:42940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKqKo-0004gu-FZ for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 07:47:22 -0400 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RKqKo-0006XE-8S for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 07:47:22 -0400 Date: Mon, 31 Oct 2011 07:47:22 -0400 Message-Id: From: Eli Zaretskii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) emacs -Q C-h i m Emacs RET Observe this line near the middle of the window: For information on extending Emacs, see Emacs Lisp(elisp). Use "M-x customize-variable" to customize the variable Info-hide-node-references to a nil value. Then return to the *info* buffer. Expected result: the above line shows the full reference, as in For information on extending Emacs, see *note Emacs Lisp: (elisp)Top. Actual result: the display does not change, until you leave this node and return to it, or manually invoke revert-buffer. This is confusing. The option should take effect immediately after it is customized. Bonus points for making its effect immediate when the variable's value is changed through "M-x set-variable RET". In GNU Emacs 24.0.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) of 2011-10-31 on fencepost.gnu.org configured using `configure '--enable-asserts' '--enable-checking' '--with-gif=no' '--with-tiff=no' 'CFLAGS=-ggdb -g3 -O0 -DGLYPH_DEBUG=1'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default enable-multibyte-characters: t Major mode: RMAIL Minor modes in effect: shell-dirtrack-mode: t display-time-mode: t show-paren-mode: t savehist-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent input: 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 6 ~ ESC [ 6 ~ ESC O A ESC O A ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O A ESC O A C-x C-x C-w C-x C-s C-x k RET C-u g ESC O A RET d d d d d d SPC d SPC d SPC d d d d C-x C-s ESC ! ESC O A RET ESC x ESC O A RET ESC O A RET C-s 1 2 : 3 4 : 0 5 C-s ESC O B ESC [ 6 ~ ESC [ 6 ~ ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B C-x C-x C-w C-x C-s C-x k RET C-u g ESC O A RET d d ESC x r e p o r t - e m TAB RET Recent messages: Wrote /home/e/eliz/mail.n2 Getting mail from /srv/data/home/e/eliz/mail.n2... Counting new messages...done (2) Saving file /home/e/eliz/INBOX... Wrote /home/e/eliz/INBOX [2 times] Computing summary lines...done 2 new messages read Showing message 916 Showing message 916...done No following nondeleted message Load-path shadows: None found. Features: (shadow emacsbug help-mode view newcomment multi-isearch shell pcomplete comint ring flyspell ispell qp rmailsum rmailmm message sendmail regexp-opt format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse rfc2231 rmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time paren cus-start cus-load time-date savehist saveplace tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dynamic-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From unknown Sun Jun 15 08:33:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9915: 24.0.91; Info-hide-node-references does not take effect immediately Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2011 09:38:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 9915@debbugs.gnu.org Received: via spool by 9915-submit@debbugs.gnu.org id=B9915.1320140279629 (code B ref 9915); Tue, 01 Nov 2011 09:38:03 +0000 Received: (at 9915) by debbugs.gnu.org; 1 Nov 2011 09:37:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLAn9-0000A2-3h for submit@debbugs.gnu.org; Tue, 01 Nov 2011 05:37:59 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLAn6-00009m-Dr for 9915@debbugs.gnu.org; Tue, 01 Nov 2011 05:37:57 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id CD9156E806B; Tue, 1 Nov 2011 02:35:39 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id F0A9E451C5B8; Tue, 1 Nov 2011 02:35:38 -0700 (PDT) From: Juri Linkov Organization: JURTA References: Date: Tue, 01 Nov 2011 11:32:35 +0200 In-Reply-To: (Eli Zaretskii's message of "Mon, 31 Oct 2011 07:47:22 -0400") Message-ID: <877h3k1ahg.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > Use "M-x customize-variable" to customize the variable > Info-hide-node-references to a nil value. Then return to the *info* > buffer. > > Expected result: the above line shows the full reference, as in > > For information on extending Emacs, see *note Emacs Lisp: (elisp)Top. > > Actual result: the display does not change, until you leave this node > and return to it, or manually invoke revert-buffer. Is this what you want? === modified file 'lisp/info.el' --- lisp/info.el 2011-10-30 14:37:48 +0000 +++ lisp/info.el 2011-11-01 09:30:42 +0000 @@ -231,6 +231,12 @@ (defcustom Info-hide-note-references t (const :tag "Replace tag and hide reference" t) (const :tag "Hide tag and reference" hide) (other :tag "Only replace tag" tag)) + :set (lambda (sym val) + (set sym val) + (dolist (buffer (buffer-list)) + (with-current-buffer buffer + (when (eq major-mode 'Info-mode) + (revert-buffer t t))))) :group 'info) (defcustom Info-refill-paragraphs nil From unknown Sun Jun 15 08:33:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9915: 24.0.91; Info-hide-node-references does not take effect immediately Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2011 11:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 9915@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 9915-submit@debbugs.gnu.org id=B9915.132014645012640 (code B ref 9915); Tue, 01 Nov 2011 11:21:01 +0000 Received: (at 9915) by debbugs.gnu.org; 1 Nov 2011 11:20:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLCOf-0003Ho-Gf for submit@debbugs.gnu.org; Tue, 01 Nov 2011 07:20:50 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLCOc-0003Hh-Vw for 9915@debbugs.gnu.org; Tue, 01 Nov 2011 07:20:48 -0400 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RLCMP-0005ZJ-OW; Tue, 01 Nov 2011 07:18:29 -0400 Date: Tue, 01 Nov 2011 07:18:29 -0400 Message-Id: From: Eli Zaretskii In-reply-to: <877h3k1ahg.fsf@mail.jurta.org> (message from Juri Linkov on Tue, 01 Nov 2011 11:32:35 +0200) References: <877h3k1ahg.fsf@mail.jurta.org> X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > From: Juri Linkov > Cc: 9915@debbugs.gnu.org > Date: Tue, 01 Nov 2011 11:32:35 +0200 > > > Use "M-x customize-variable" to customize the variable > > Info-hide-node-references to a nil value. Then return to the *info* > > buffer. > > > > Expected result: the above line shows the full reference, as in > > > > For information on extending Emacs, see *note Emacs Lisp: (elisp)Top. > > > > Actual result: the display does not change, until you leave this node > > and return to it, or manually invoke revert-buffer. > > Is this what you want? This works for me, thanks. But there seems to be a left-over problem with this change, at least on a TTY: when I finish customizing the value and hit RET on the "Set for current session" button, Emacs signals an error: custom-variable-set: Selecting deleted buffer The customization does take effect, this error notwithstanding. From unknown Sun Jun 15 08:33:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9915: 24.0.91; Info-hide-node-references does not take effect immediately Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2011 23:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 9915@debbugs.gnu.org Received: via spool by 9915-submit@debbugs.gnu.org id=B9915.132018838818650 (code B ref 9915); Tue, 01 Nov 2011 23:00:04 +0000 Received: (at 9915) by debbugs.gnu.org; 1 Nov 2011 22:59:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLNJ6-0004qj-FE for submit@debbugs.gnu.org; Tue, 01 Nov 2011 18:59:48 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLNJ4-0004qc-9A for 9915@debbugs.gnu.org; Tue, 01 Nov 2011 18:59:47 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 936626E8055; Tue, 1 Nov 2011 15:57:25 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id B913C451C2D8; Tue, 1 Nov 2011 15:57:24 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <877h3k1ahg.fsf@mail.jurta.org> Date: Tue, 01 Nov 2011 23:59:02 +0200 In-Reply-To: (Eli Zaretskii's message of "Tue, 01 Nov 2011 07:18:29 -0400") Message-ID: <87vcr3v7g5.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > This works for me, thanks. But there seems to be a left-over problem > with this change, at least on a TTY: when I finish customizing the > value and hit RET on the "Set for current session" button, Emacs > signals an error: > > custom-variable-set: Selecting deleted buffer This is due to the peculiarity of the implementation of `Info-revert-find-node' that kills the *Info* buffer to revert it. Its comment says: ;; It's perhaps a bit nasty to kill the *info* buffer to force a re-read, ;; but at least it keeps this routine (which is for makeinfo-buffer and ;; Info-revert-buffer-function) out of the way of normal operations. It has other nasty effects when used in defcustom, e.g. when *Info* buffers are displayed in different windows, it will mess up the window configuration. I think `Info-revert-find-node' should be rewritten to not kill the *Info* buffer, but I'm not sure whether this is need for 24.1. From unknown Sun Jun 15 08:33:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9915: 24.0.91; Info-hide-node-references does not take effect immediately Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2011 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 9915@debbugs.gnu.org Received: via spool by 9915-submit@debbugs.gnu.org id=B9915.132022776810303 (code B ref 9915); Wed, 02 Nov 2011 09:57:02 +0000 Received: (at 9915) by debbugs.gnu.org; 2 Nov 2011 09:56:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLXYG-0002g8-Ad for submit@debbugs.gnu.org; Wed, 02 Nov 2011 05:56:08 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLXYD-0002ft-JP for 9915@debbugs.gnu.org; Wed, 02 Nov 2011 05:56:06 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 2897E6E804D; Wed, 2 Nov 2011 02:53:43 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id D2256451C577; Wed, 2 Nov 2011 02:53:41 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <877h3k1ahg.fsf@mail.jurta.org> <87vcr3v7g5.fsf@mail.jurta.org> Date: Wed, 02 Nov 2011 11:45:51 +0200 In-Reply-To: <87vcr3v7g5.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 01 Nov 2011 23:59:02 +0200") Message-ID: <87k47iyi0g.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > This is due to the peculiarity of the implementation of > `Info-revert-find-node' that kills the *Info* buffer to revert it. > Its comment says: > > ;; It's perhaps a bit nasty to kill the *info* buffer to force a re-read, > ;; but at least it keeps this routine (which is for makeinfo-buffer and > ;; Info-revert-buffer-function) out of the way of normal operations. > > It has other nasty effects when used in defcustom, e.g. when > *Info* buffers are displayed in different windows, it will mess up > the window configuration. I think `Info-revert-find-node' should > be rewritten to not kill the *Info* buffer, but I'm not sure > whether this is need for 24.1. This should be fixed with the following patch that doesn't kill the *Info* buffer. I tested it with `M-x makeinfo-buffer RET', with `M-x revert-buffer RET' and with customizing `Info-hide-node-references'. === modified file 'lisp/info.el' --- lisp/info.el 2011-10-24 05:47:05 +0000 +++ lisp/info.el 2011-11-02 09:43:59 +0000 @@ -231,6 +231,12 @@ (defcustom Info-hide-note-references t (const :tag "Replace tag and hide reference" t) (const :tag "Hide tag and reference" hide) (other :tag "Only replace tag" tag)) + :set (lambda (sym val) + (set sym val) + (dolist (buffer (buffer-list)) + (with-current-buffer buffer + (when (eq major-mode 'Info-mode) + (revert-buffer t t))))) :group 'info) (defcustom Info-refill-paragraphs nil @@ -811,10 +822,6 @@ (defun Info-on-current-buffer (&optional (concat default-directory (buffer-name)))) (Info-find-node-2 nil nodename)) -;; It's perhaps a bit nasty to kill the *info* buffer to force a re-read, -;; but at least it keeps this routine (which is for makeinfo-buffer and -;; Info-revert-buffer-function) out of the way of normal operations. -;; (defun Info-revert-find-node (filename nodename) "Go to an Info node FILENAME and NODENAME, re-reading disk contents. When *info* is already displaying FILENAME and NODENAME, the window position @@ -822,33 +829,24 @@ (defun Info-revert-find-node (filename n (or (eq major-mode 'Info-mode) (switch-to-buffer "*info*")) (let ((old-filename Info-current-file) (old-nodename Info-current-node) - (old-buffer-name (buffer-name)) + (window-selected (eq (selected-window) (get-buffer-window))) (pcolumn (current-column)) (pline (count-lines (point-min) (line-beginning-position))) - (wline (count-lines (point-min) (window-start))) - (old-history-forward Info-history-forward) - (old-history Info-history) - (new-history (and Info-current-file - (list Info-current-file Info-current-node (point))))) - (kill-buffer (current-buffer)) - (switch-to-buffer (or old-buffer-name "*info*")) - (Info-mode) - (Info-find-node filename nodename) - (setq Info-history-forward old-history-forward) - (setq Info-history old-history) + (wline (count-lines (point-min) (window-start)))) + ;; When `Info-current-file' is nil, `Info-find-node-2' rereads the file. + (setq Info-current-file nil) + (Info-find-node filename nodename t) (if (and (equal old-filename Info-current-file) (equal old-nodename Info-current-node)) (progn ;; note goto-line is no good, we want to measure from point-min - (goto-char (point-min)) - (forward-line wline) - (set-window-start (selected-window) (point)) + (when window-selected + (goto-char (point-min)) + (forward-line wline) + (set-window-start (selected-window) (point))) (goto-char (point-min)) (forward-line pline) - (move-to-column pcolumn)) - ;; only add to the history when coming from a different file+node - (if new-history - (setq Info-history (cons new-history Info-history)))))) + (move-to-column pcolumn))))) (defun Info-revert-buffer-function (_ignore-auto noconfirm) (when (or noconfirm (y-or-n-p "Revert info buffer? ")) From unknown Sun Jun 15 08:33:08 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eli Zaretskii Subject: bug#9915: closed (Re: bug#9915: 24.0.91; Info-hide-node-references does not take effect immediately) Message-ID: References: <87d3cnpz0y.fsf@mail.jurta.org> X-Gnu-PR-Message: they-closed 9915 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 9915@debbugs.gnu.org Date: Sat, 19 Nov 2011 21:48:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1321739282-14730-1" This is a multi-part message in MIME format... ------------=_1321739282-14730-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #9915: 24.0.91; Info-hide-node-references does not take effect immediately which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 9915@debbugs.gnu.org. --=20 9915: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9915 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1321739282-14730-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 9915-done) by debbugs.gnu.org; 19 Nov 2011 21:47:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRskn-0003oh-L1 for submit@debbugs.gnu.org; Sat, 19 Nov 2011 16:47:18 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRski-0003oW-0r for 9915-done@debbugs.gnu.org; Sat, 19 Nov 2011 16:47:15 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id C8FE76E805D; Sat, 19 Nov 2011 13:46:06 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 4257D451C5FA; Sat, 19 Nov 2011 13:46:04 -0800 (PST) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#9915: 24.0.91; Info-hide-node-references does not take effect immediately Organization: JURTA References: <877h3k1ahg.fsf@mail.jurta.org> <87vcr3v7g5.fsf@mail.jurta.org> <87k47iyi0g.fsf@mail.jurta.org> Date: Sat, 19 Nov 2011 23:45:17 +0200 In-Reply-To: <87k47iyi0g.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 02 Nov 2011 11:45:51 +0200") Message-ID: <87d3cnpz0y.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9915-done Cc: 9915-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > This should be fixed with the following patch that doesn't kill the > *Info* buffer. I tested it with `M-x makeinfo-buffer RET', with `M-x > revert-buffer RET' and with customizing `Info-hide-node-references'. Patch installed. ------------=_1321739282-14730-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 Oct 2011 11:49:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKqN1-0001kN-QN for submit@debbugs.gnu.org; Mon, 31 Oct 2011 07:49:40 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKqMz-0001kG-Fm for submit@debbugs.gnu.org; Mon, 31 Oct 2011 07:49:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKqKr-0004hX-9d for submit@debbugs.gnu.org; Mon, 31 Oct 2011 07:47:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:45340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKqKr-0004hS-8A for submit@debbugs.gnu.org; Mon, 31 Oct 2011 07:47:25 -0400 Received: from eggs.gnu.org ([140.186.70.92]:55756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKqKq-00054f-2s for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 07:47:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKqKo-0004gz-HK for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 07:47:24 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:42940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKqKo-0004gu-FZ for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 07:47:22 -0400 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RKqKo-0006XE-8S for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 07:47:22 -0400 Date: Mon, 31 Oct 2011 07:47:22 -0400 Message-Id: From: Eli Zaretskii To: bug-gnu-emacs@gnu.org Subject: 24.0.91; Info-hide-node-references does not take effect immediately X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) emacs -Q C-h i m Emacs RET Observe this line near the middle of the window: For information on extending Emacs, see Emacs Lisp(elisp). Use "M-x customize-variable" to customize the variable Info-hide-node-references to a nil value. Then return to the *info* buffer. Expected result: the above line shows the full reference, as in For information on extending Emacs, see *note Emacs Lisp: (elisp)Top. Actual result: the display does not change, until you leave this node and return to it, or manually invoke revert-buffer. This is confusing. The option should take effect immediately after it is customized. Bonus points for making its effect immediate when the variable's value is changed through "M-x set-variable RET". In GNU Emacs 24.0.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) of 2011-10-31 on fencepost.gnu.org configured using `configure '--enable-asserts' '--enable-checking' '--with-gif=no' '--with-tiff=no' 'CFLAGS=-ggdb -g3 -O0 -DGLYPH_DEBUG=1'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default enable-multibyte-characters: t Major mode: RMAIL Minor modes in effect: shell-dirtrack-mode: t display-time-mode: t show-paren-mode: t savehist-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent input: 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 6 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 5 ~ ESC [ 6 ~ ESC [ 6 ~ ESC O A ESC O A ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O A ESC O A C-x C-x C-w C-x C-s C-x k RET C-u g ESC O A RET d d d d d d SPC d SPC d SPC d d d d C-x C-s ESC ! ESC O A RET ESC x ESC O A RET ESC O A RET C-s 1 2 : 3 4 : 0 5 C-s ESC O B ESC [ 6 ~ ESC [ 6 ~ ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B C-x C-x C-w C-x C-s C-x k RET C-u g ESC O A RET d d ESC x r e p o r t - e m TAB RET Recent messages: Wrote /home/e/eliz/mail.n2 Getting mail from /srv/data/home/e/eliz/mail.n2... Counting new messages...done (2) Saving file /home/e/eliz/INBOX... Wrote /home/e/eliz/INBOX [2 times] Computing summary lines...done 2 new messages read Showing message 916 Showing message 916...done No following nondeleted message Load-path shadows: None found. Features: (shadow emacsbug help-mode view newcomment multi-isearch shell pcomplete comint ring flyspell ispell qp rmailsum rmailmm message sendmail regexp-opt format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse rfc2231 rmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time paren cus-start cus-load time-date savehist saveplace tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dynamic-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) ------------=_1321739282-14730-1--