GNU bug report logs - #9914
24.0.91; htmlfontify.el: Add support for code block fontification on ODT export

Previous Next

Full log

Message #38 received at 9914 <at> debbugs.gnu.org (full text, mbox):

From: Vivek Dasmohapatra <vivek <at> etla.org>
To: Jambunathan K <kjambunathan <at> gmail.com>
Cc: Chong Yidong <cyd <at> gnu.org>, 9914 <at> debbugs.gnu.org
Subject: Re: bug#9914: 24.0.91; htmlfontify.el: Add support for code block
	fontification on ODT export
Date: Tue, 13 Mar 2012 03:35:35 +0000 (GMT)

This looks reasonable to me, I have only one point to make from an initial
review:

The patches seem to introduce tabs into the code - I believe I only
ever used spaces, and I'd prefer to keep it that way (this is a minor
point: if the project wishes to change the indent style, this should 
be done separately to a feature patchset, just to keep the history sane).

Oh... just noticed - in the fontify-string defun:

    (with-temp-buffer
      (insert string)
      (htmlfontify-buffer)
      (prog1 (buffer-string)
	(setq buffer-modified-p nil)
	(kill-buffer)))))

susect this would be neater as:

    (with-temp-buffer
      (insert string)
      (htmlfontify-buffer)
      (set-buffer-modified-p nil)
      (buffer-string))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.