GNU bug report logs - #9911
valgrind warning in process.c:send_process

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9911 in the body.
You can then email your comments to 9911 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: valgrind warning in process.c:send_process
Date: Sun, 30 Oct 2011 17:38:51 -0400

valgrind ./temacs 

produces this warning

 

==30382== Conditional jump or move depends on uninitialised value(s)
==30382==    at 0x6302A9: send_process (process.c:5398)
==30382==    by 0x630DC8: Fprocess_send_string (process.c:5648)
==30382==    by 0x5D6D61: Ffuncall (eval.c:2977)
==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
==30382==    by 0x5D77BA: funcall_lambda (eval.c:3205)
==30382==    by 0x5D6F4C: Ffuncall (eval.c:3023)
==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
==30382==    by 0x5D77BA: funcall_lambda (eval.c:3205)
==30382==    by 0x5D6F4C: Ffuncall (eval.c:3023)
==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
==30382==    by 0x5D77BA: funcall_lambda (eval.c:3205)
==30382==    by 0x5D6F4C: Ffuncall (eval.c:3023)

Looks like struct coding_system.src_multibyte needs to be
initialized.

Message #8 received at 9911 <at> debbugs.gnu.org (full text, mbox):

From: Kenichi Handa <handa <at> m17n.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 9911 <at> debbugs.gnu.org
Subject: Re: bug#9911: valgrind warning in process.c:send_process
Date: Mon, 07 Nov 2011 11:39:06 +0900

In article <yxqzkgif9ck.fsf <at> fencepost.gnu.org>, Dan Nicolaescu <dann <at> gnu.org> writes:

> valgrind ./temacs 

> produces this warning

> ==30382== Conditional jump or move depends on uninitialised value(s)
> ==30382==    at 0x6302A9: send_process (process.c:5398)
> ==30382==    by 0x630DC8: Fprocess_send_string (process.c:5648)
> ==30382==    by 0x5D6D61: Ffuncall (eval.c:2977)
> ==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
> ==30382==    by 0x5D77BA: funcall_lambda (eval.c:3205)
> ==30382==    by 0x5D6F4C: Ffuncall (eval.c:3023)
> ==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
> ==30382==    by 0x5D77BA: funcall_lambda (eval.c:3205)
> ==30382==    by 0x5D6F4C: Ffuncall (eval.c:3023)
> ==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
> ==30382==    by 0x5D77BA: funcall_lambda (eval.c:3205)
> ==30382==    by 0x5D6F4C: Ffuncall (eval.c:3023)

> Looks like struct coding_system.src_multibyte needs to be
> initialized.

I fixed it.  But as "valgrind ./temacs" segfaults in my
environment, I can't confirm the fix.  Please check if the
fix is correct or not.

---
Kenichi Handa
handa <at> m17n.org

Message #13 received at 9911-done <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Kenichi Handa <handa <at> m17n.org>
Cc: 9910-done <at> debbugs.gnu.org, 9912-done <at> debbugs.gnu.org,
	9911-done <at> debbugs.gnu.org
Subject: Re: bug#9910: valgrind warning in coding.c:coding_set_destination
Date: Sun, 06 Nov 2011 23:28:38 -0500

Kenichi Handa <handa <at> m17n.org> writes:

> In article <yxq1utugnxb.fsf <at> fencepost.gnu.org>, Dan Nicolaescu <dann <at> gnu.org> writes:
>
>> valgrind ./temacs 
>
>> produces this warning:
>
>> ==30382== Conditional jump or move depends on uninitialised value(s)
>> ==30382==    at 0x499251: coding_set_destination (coding.c:1046)
>> ==30382==    by 0x4B477A: decode_coding (coding.c:7022)
>> ==30382==    by 0x4B7317: decode_coding_object (coding.c:7671)
>> ==30382==    by 0x63610F: Fcall_process (callproc.c:813)
>> ==30382==    by 0x5D6C07: Ffuncall (eval.c:2956)
>> ==30382==    by 0x5D5ECA: Fapply (eval.c:2479)
>> ==30382==    by 0x5D6C07: Ffuncall (eval.c:2956)
>> ==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
>> ==30382==    by 0x5D77BA: funcall_lambda (eval.c:3205)
>> ==30382==    by 0x5D6F4C: Ffuncall (eval.c:3023)
>> ==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
>> ==30382==    by 0x5D77BA: funcall_lambda (eval.c:3205)
>  
>>  This looks like setup_coding_system (or whatever else initializes struct
>>  coding_system) does not initialize the src_pos field.
>
> I fixed it.  But as "valgrind ./temacs" segfaults in my
> environment, I can't confirm the fix.  Please check if the
> fix is correct or not.

Thank you very much!
The fix looks good, the warning does not appear anymore.

valgrind ./temacs also segfaults for me in 32 bit mode (i686), it works
in 64 bit mode (x86_64).

Message #16 received at 9911 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Kenichi Handa <handa <at> m17n.org>
Cc: Dan Nicolaescu <dann <at> gnu.org>, 9911 <at> debbugs.gnu.org
Subject: Re: bug#9911: valgrind warning in process.c:send_process
Date: Mon, 07 Nov 2011 09:39:23 +0100

Kenichi Handa <handa <at> m17n.org> writes:

> But as "valgrind ./temacs" segfaults in my environment,

Try defining VIRT_ADDR_VARIES.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #19 received at 9911 <at> debbugs.gnu.org (full text, mbox):

From: Kenichi Handa <handa <at> m17n.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: dann <at> gnu.org, 9911 <at> debbugs.gnu.org
Subject: Re: bug#9911: valgrind warning in process.c:send_process
Date: Fri, 11 Nov 2011 15:35:16 +0900

In article <m38vnsmimc.fsf <at> hase.home>, Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Kenichi Handa <handa <at> m17n.org> writes:
> > But as "valgrind ./temacs" segfaults in my environment,

> Try defining VIRT_ADDR_VARIES.

Thank you.  When I re-built Emacs with that defined,
I can use valgrind on temacs.

---
Kenichi Handa
handa <at> m17n.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.