From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 28 22:01:04 2011 Received: (at submit) by debbugs.gnu.org; 29 Oct 2011 02:01:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RJyEK-00010w-BC for submit@debbugs.gnu.org; Fri, 28 Oct 2011 22:01:04 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RJyEI-00010p-DS for submit@debbugs.gnu.org; Fri, 28 Oct 2011 22:01:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJyCO-00060B-Bp for submit@debbugs.gnu.org; Fri, 28 Oct 2011 21:59:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:53928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJyCO-000606-AN for submit@debbugs.gnu.org; Fri, 28 Oct 2011 21:59:04 -0400 Received: from eggs.gnu.org ([140.186.70.92]:57858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJyCN-0005hn-Kz for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 21:59:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJyCM-0005zj-Ca for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 21:59:03 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:44365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJyCM-0005zf-BB for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 21:59:02 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RJyCM-0007Yh-7H for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 21:59:02 -0400 To: bug-gnu-emacs@gnu.org Subject: xg_win_to_widget uninitialized access From: Dan Nicolaescu Date: Fri, 28 Oct 2011 21:59:02 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) valgrind gives a warning for an uninitialized access in xg_win_to_widget for the gtk_get_event_widget call. if (gdkwin) { GdkEvent event; event.any.window = gdkwin; gwdesc = gtk_get_event_widget (&event); } gtk_get_event_widget is (in gtk3): GtkWidget* gtk_get_event_widget (GdkEvent *event) { GtkWidget *widget; gpointer widget_ptr; widget = NULL; if (event && event->any.window && (event->type == GDK_DESTROY || !gdk_window_is_destroyed (event->any.window))) { gdk_window_get_user_data (event->any.window, &widget_ptr); widget = widget_ptr; } return widget; } so indeed event->type is uninitialized. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 30 13:34:25 2011 Received: (at 9901-done) by debbugs.gnu.org; 30 Oct 2011 17:34:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKZH6-0000zI-VF for submit@debbugs.gnu.org; Sun, 30 Oct 2011 13:34:25 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKZH5-0000z7-64 for 9901-done@debbugs.gnu.org; Sun, 30 Oct 2011 13:34:23 -0400 Received: from iph3.telenor.se (iph3.telenor.se [195.54.127.134]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id 4B6DCDD8D for <9901-done@debbugs.gnu.org>; Sun, 30 Oct 2011 18:32:15 +0100 (CET) X-SENDER-IP: [85.225.45.201] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmNLAGKJrU5V4S3JPGdsb2JhbABDiT6gARkBAQEBHhkNJYFyAQEEAScTHCMFCwtGLQwKFAaIFQKxZoghYQSZO4M+iHU X-IronPort-AV: E=Sophos;i="4.69,427,1315173600"; d="scan'208";a="140146908" Received: from c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.201]) by iph3.telenor.se with ESMTP; 30 Oct 2011 18:32:14 +0100 Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 6B3307FA058; Sun, 30 Oct 2011 18:32:14 +0100 (CET) Subject: Re: bug#9901: xg_win_to_widget uninitialized access Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=us-ascii From: =?iso-8859-1?Q?Jan_Dj=E4rv?= In-Reply-To: Date: Sun, 30 Oct 2011 18:32:16 +0100 Content-Transfer-Encoding: 7bit Message-Id: <1FE344F8-B368-410D-A5B5-14BECB35345E@swipnet.se> References: To: Dan Nicolaescu X-Mailer: Apple Mail (2.1251.1) X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 9901-done Cc: 9901-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.2 (--) Fixed. Jan D. 29 okt 2011 kl. 03:59 skrev Dan Nicolaescu: > valgrind gives a warning for an uninitialized access in > xg_win_to_widget for the gtk_get_event_widget call. > > > if (gdkwin) > { > GdkEvent event; > event.any.window = gdkwin; > gwdesc = gtk_get_event_widget (&event); > } > > gtk_get_event_widget is (in gtk3): > > GtkWidget* > gtk_get_event_widget (GdkEvent *event) > { > GtkWidget *widget; > gpointer widget_ptr; > > widget = NULL; > if (event && event->any.window && > (event->type == GDK_DESTROY || !gdk_window_is_destroyed > (event->any.window))) > { > gdk_window_get_user_data (event->any.window, &widget_ptr); > widget = widget_ptr; > } > > return widget; > } > > so indeed event->type is uninitialized. > > > From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 30 13:34:27 2011 Received: (at 9901-done) by debbugs.gnu.org; 30 Oct 2011 17:34:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKZH9-0000zQ-Ds for submit@debbugs.gnu.org; Sun, 30 Oct 2011 13:34:27 -0400 Received: from smtprelay-b11.telenor.se ([62.127.194.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKZH5-0000z8-6A for 9901-done@debbugs.gnu.org; Sun, 30 Oct 2011 13:34:24 -0400 Received: from iph4.telenor.se (iph4.telenor.se [195.54.127.135]) by smtprelay-b11.telenor.se (Postfix) with ESMTP id 7FA0614035 for <9901-done@debbugs.gnu.org>; Sun, 30 Oct 2011 18:32:15 +0100 (CET) X-SENDER-IP: [85.225.45.201] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmNLAIeJrU5V4S3JPGdsb2JhbABDiT6gARkBAQEBHhkNJYFyAQEEAScTHCMFCwtGLQwKFAaIFQKxZ4ghYQSZO4M+iHU X-IronPort-AV: E=Sophos;i="4.69,427,1315173600"; d="scan'208";a="1997435498" Received: from c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.201]) by iph4.telenor.se with ESMTP; 30 Oct 2011 18:32:14 +0100 Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 7CB797FA059; Sun, 30 Oct 2011 18:32:14 +0100 (CET) Subject: Re: bug#9901: xg_win_to_widget uninitialized access Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=us-ascii From: =?iso-8859-1?Q?Jan_Dj=E4rv?= In-Reply-To: Date: Sun, 30 Oct 2011 18:31:21 +0100 Content-Transfer-Encoding: 7bit Message-Id: References: To: Dan Nicolaescu X-Mailer: Apple Mail (2.1251.1) X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 9901-done Cc: 9901-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.2 (--) Fixed. Jan D. 29 okt 2011 kl. 03:59 skrev Dan Nicolaescu: > valgrind gives a warning for an uninitialized access in > xg_win_to_widget for the gtk_get_event_widget call. > > > if (gdkwin) > { > GdkEvent event; > event.any.window = gdkwin; > gwdesc = gtk_get_event_widget (&event); > } > > gtk_get_event_widget is (in gtk3): > > GtkWidget* > gtk_get_event_widget (GdkEvent *event) > { > GtkWidget *widget; > gpointer widget_ptr; > > widget = NULL; > if (event && event->any.window && > (event->type == GDK_DESTROY || !gdk_window_is_destroyed > (event->any.window))) > { > gdk_window_get_user_data (event->any.window, &widget_ptr); > widget = widget_ptr; > } > > return widget; > } > > so indeed event->type is uninitialized. > > > From unknown Wed Jun 18 00:24:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 28 Nov 2011 12:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator