GNU bug report logs - #9890
cosmetic bug in AM_MAINTAINER_MODE

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zack Weinberg <zackw <at> panix.com>
To: bug-automake <at> gnu.org
Subject: cosmetic bug in AM_MAINTAINER_MODE
Date: Thu, 27 Oct 2011 10:37:34 -0700

[Message part 1 (text/plain, inline)]

If you use AM_MAINTAINER_MODE([enable]), configure will print

> checking whether to disable maintainer-specific portions of Makefiles ... yes

when --disable-maintainer-mode was *not* given on the command line, and

> checking whether to disable maintainer-specific portions of Makefiles ... no

when it *was* given.  This states the opposite of what has actually happened.

The easiest way to fix this cosmetic bug is to not use
am_maintainer_other in the first argument to AC_MSG_CHECKING.  The
result code ($USE_MAINTAINER_MODE) is "yes" if maintainer mode is
enabled and "no" if it isn't, regardless of what the default was, so
it will always be correct to say "checking whether to enable ...".
Patch attached.

(Bug found in automake/aclocal 1.11, but maintainer.m4 doesn't seem to
have been modified in a long time.)

zw

[mm4.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.