From unknown Sat Aug 16 22:00:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9890 <9890@debbugs.gnu.org> To: bug#9890 <9890@debbugs.gnu.org> Subject: Status: cosmetic bug in AM_MAINTAINER_MODE Reply-To: bug#9890 <9890@debbugs.gnu.org> Date: Sun, 17 Aug 2025 05:00:40 +0000 retitle 9890 cosmetic bug in AM_MAINTAINER_MODE reassign 9890 automake submitter 9890 Zack Weinberg severity 9890 normal tag 9890 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 14:47:02 2011 Received: (at submit) by debbugs.gnu.org; 27 Oct 2011 18:47:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RJUyj-0006z6-3Y for submit@debbugs.gnu.org; Thu, 27 Oct 2011 14:47:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RJTvT-0005RK-52 for submit@debbugs.gnu.org; Thu, 27 Oct 2011 13:39:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJTtb-0007KC-DD for submit@debbugs.gnu.org; Thu, 27 Oct 2011 13:37:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:40742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJTtb-0007K6-BP for submit@debbugs.gnu.org; Thu, 27 Oct 2011 13:37:39 -0400 Received: from eggs.gnu.org ([140.186.70.92]:41889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJTta-0005WL-8U for bug-automake@gnu.org; Thu, 27 Oct 2011 13:37:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJTtY-0007Je-Rv for bug-automake@gnu.org; Thu, 27 Oct 2011 13:37:38 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:61661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJTtY-0007JI-Lo for bug-automake@gnu.org; Thu, 27 Oct 2011 13:37:36 -0400 Received: by bkbzu5 with SMTP id zu5so1774223bkb.0 for ; Thu, 27 Oct 2011 10:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=0i8vCcfZyMoih8iWZQ1xXTLhBmH9qcv6MiFk9T4HA8s=; b=P1j4avqKA2optyJSx6XDLclIwVwcA8UPedxnF0pyTZFEyoYFfe2UO+yjdEekpRjewo LJ4+mSe+8QxqXqrCGMjA75qmwtbZwBTsSOF//0fFoZQN1n5Y+74EgPrnsXMYv6OS6b3p EJxpYXDXKfnQXCJoM4ecJYIOqygtCjYJ4A1Mo= MIME-Version: 1.0 Received: by 10.182.50.8 with SMTP id y8mr6099566obn.79.1319737054965; Thu, 27 Oct 2011 10:37:34 -0700 (PDT) Received: by 10.182.88.103 with HTTP; Thu, 27 Oct 2011 10:37:34 -0700 (PDT) Date: Thu, 27 Oct 2011 10:37:34 -0700 X-Google-Sender-Auth: z0rmmTR8GfH0Dz22MYRVMB5DLyo Message-ID: Subject: cosmetic bug in AM_MAINTAINER_MODE From: Zack Weinberg To: bug-automake@gnu.org Content-Type: multipart/mixed; boundary=f46d0444741d5bae8604b04b3ac7 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 27 Oct 2011 14:46:59 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --f46d0444741d5bae8604b04b3ac7 Content-Type: text/plain; charset=UTF-8 If you use AM_MAINTAINER_MODE([enable]), configure will print > checking whether to disable maintainer-specific portions of Makefiles ... yes when --disable-maintainer-mode was *not* given on the command line, and > checking whether to disable maintainer-specific portions of Makefiles ... no when it *was* given. This states the opposite of what has actually happened. The easiest way to fix this cosmetic bug is to not use am_maintainer_other in the first argument to AC_MSG_CHECKING. The result code ($USE_MAINTAINER_MODE) is "yes" if maintainer mode is enabled and "no" if it isn't, regardless of what the default was, so it will always be correct to say "checking whether to enable ...". Patch attached. (Bug found in automake/aclocal 1.11, but maintainer.m4 doesn't seem to have been modified in a long time.) zw --f46d0444741d5bae8604b04b3ac7 Content-Type: text/x-patch; charset=US-ASCII; name="mm4.diff" Content-Disposition: attachment; filename="mm4.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gua11j530 LS0tIG1haW50YWluZXIubTQJMjAxMC0wMi0wMSAxNjo1OToxNS4wMDAwMDAwMDAgLTA4MDAKKysr IG1haW50YWluZXIubTQJMjAxMS0xMC0yNyAxMDowNTo1NS44NzY5MTEwNzQgLTA3MDAKQEAgLTEs NyArMSw3IEBACiAjIEFkZCAtLWVuYWJsZS1tYWludGFpbmVyLW1vZGUgb3B0aW9uIHRvIGNvbmZp Z3VyZS4gICAgICAgICAtKi0gQXV0b2NvbmYgLSotCiAjIEZyb20gSmltIE1leWVyaW5nCiAKLSMg Q29weXJpZ2h0IChDKSAxOTk2LCAxOTk4LCAyMDAwLCAyMDAxLCAyMDAyLCAyMDAzLCAyMDA0LCAy MDA1LCAyMDA4CisjIENvcHlyaWdodCAoQykgMTk5NiwgMTk5OCwgMjAwMCwgMjAwMSwgMjAwMiwg MjAwMywgMjAwNCwgMjAwNSwgMjAwOCwgMjAxMQogIyBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24s IEluYy4KICMKICMgVGhpcyBmaWxlIGlzIGZyZWUgc29mdHdhcmU7IHRoZSBGcmVlIFNvZnR3YXJl IEZvdW5kYXRpb24KQEAgLTIyLDcgKzIyLDcgQEAKICAgICAgICBbZGlzYWJsZV0sIFttNF9kZWZp bmUoW2FtX21haW50YWluZXJfb3RoZXJdLCBbZW5hYmxlXSldLAogICAgICAgIFttNF9kZWZpbmUo W2FtX21haW50YWluZXJfb3RoZXJdLCBbZW5hYmxlXSkKICAgICAgICAgbTRfd2Fybihbc3ludGF4 XSwgW3VuZXhwZWN0ZWQgYXJndW1lbnQgdG8gQU1AJnRAX01BSU5UQUlORVJfTU9ERTogJDFdKV0p Ci1BQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gYW1fbWFpbnRhaW5lcl9vdGhlciBtYWludGFp bmVyLXNwZWNpZmljIHBvcnRpb25zIG9mIE1ha2VmaWxlc10pCitBQ19NU0dfQ0hFQ0tJTkcoW3do ZXRoZXIgdG8gZW5hYmxlIG1haW50YWluZXItc3BlY2lmaWMgcG9ydGlvbnMgb2YgTWFrZWZpbGVz XSkKICAgZG5sIG1haW50YWluZXItbW9kZSdzIGRlZmF1bHQgaXMgJ2Rpc2FibGUnIHVubGVzcyAn ZW5hYmxlJyBpcyBwYXNzZWQKICAgQUNfQVJHX0VOQUJMRShbbWFpbnRhaW5lci1tb2RlXSwKIFsg IC0tXVthbV9tYWludGFpbmVyX290aGVyXVstbWFpbnRhaW5lci1tb2RlICBhbV9tYWludGFpbmVy X290aGVyIG1ha2UgcnVsZXMgYW5kIGRlcGVuZGVuY2llcyBub3QgdXNlZnVsCg== --f46d0444741d5bae8604b04b3ac7-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 06:20:37 2011 Received: (at submit) by debbugs.gnu.org; 29 Oct 2011 10:20:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RK61k-0008RA-Ry for submit@debbugs.gnu.org; Sat, 29 Oct 2011 06:20:37 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RK61i-0008R3-Rb for submit@debbugs.gnu.org; Sat, 29 Oct 2011 06:20:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RK5zl-0002gC-DV for submit@debbugs.gnu.org; Sat, 29 Oct 2011 06:18:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:37409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RK5zl-0002g8-Br for submit@debbugs.gnu.org; Sat, 29 Oct 2011 06:18:33 -0400 Received: from eggs.gnu.org ([140.186.70.92]:53656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RK5zj-0007gY-Jk for bug-automake@gnu.org; Sat, 29 Oct 2011 06:18:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RK5zh-0002fJ-K0 for bug-automake@gnu.org; Sat, 29 Oct 2011 06:18:31 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:56805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RK5zh-0002f8-AK for bug-automake@gnu.org; Sat, 29 Oct 2011 06:18:29 -0400 Received: by wyg34 with SMTP id 34so5613872wyg.0 for ; Sat, 29 Oct 2011 03:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; bh=ha8TLsw6bx4uzHyLfI3xH0fzdbjv+CG3cnQhUDs4CKw=; b=iwHkZGWAds3vo/MCpfhcUImoYaZ5izVw8nCAA71rhQEXzgrLLsJwplwBzgLfiJwOae p1PdkekKTwyqu43zB9yUvxtk4MVsFCiH4abRCfNv6HlUfC0gFpMbx+BKfG+z1fqub7Ql UhsPUWg7dt99PdtaMWtF01NrjRxw2MeOl2Z3E= Received: by 10.227.206.147 with SMTP id fu19mr8333376wbb.22.1319883507759; Sat, 29 Oct 2011 03:18:27 -0700 (PDT) Received: from bigio.localnet (host250-103-dynamic.0-87-r.retail.telecomitalia.it. [87.0.103.250]) by mx.google.com with ESMTPS id ff6sm20425128wbb.10.2011.10.29.03.18.25 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 29 Oct 2011 03:18:27 -0700 (PDT) From: Stefano Lattarini To: bug-automake@gnu.org Subject: Re: bug#9890: cosmetic bug in AM_MAINTAINER_MODE Date: Sat, 29 Oct 2011 12:18:15 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_oL9qO/auPwn3ehp" Message-Id: <201110291218.16167.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Zack Weinberg , 9890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --Boundary-00=_oL9qO/auPwn3ehp Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit tags 9890 patch thanks On Thursday 27 October 2011, Zack Weinberg wrote: > If you use AM_MAINTAINER_MODE([enable]), configure will print > > > checking whether to disable maintainer-specific portions of Makefiles ... yes > > when --disable-maintainer-mode was *not* given on the command line, and > > > checking whether to disable maintainer-specific portions of Makefiles ... no > > when it *was* given. This states the opposite of what has actually happened. > > The easiest way to fix this cosmetic bug is to not use > am_maintainer_other in the first argument to AC_MSG_CHECKING. The > result code ($USE_MAINTAINER_MODE) is "yes" if maintainer mode is > enabled and "no" if it isn't, regardless of what the default was, so > it will always be correct to say "checking whether to enable ...". > Patch attached. > > (Bug found in automake/aclocal 1.11, but maintainer.m4 doesn't seem to > have been modified in a long time.) > Thanks for the analysis and solution. I've applied your diff, and added a testcase. Attached is the patch I intend to push shortly (I'll give a couple of days for reviews and objections). Also, I have a minor question: Zack, are you the same "Zack Weinberg" already listed in the THANKS file with the address "zack@codesourcery.com"? If yes, should I update that address? Regards, Stefano --Boundary-00=_oL9qO/auPwn3ehp Content-Type: text/x-patch; charset="utf-8"; name="0001-maint-mode-fix-botched-configure-messages.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0001-maint-mode-fix-botched-configure-messages.patch" =46rom 58c1537ce9a5ff3fa4a7afbf5e85464f715ba523 Mon Sep 17 00:00:00 2001 Message-Id: <58c1537ce9a5ff3fa4a7afbf5e85464f715ba523.1319883380.git.stefan= o.lattarini@gmail.com> =46rom: Stefano Lattarini Date: Sat, 29 Oct 2011 12:15:59 +0200 Subject: [PATCH] maint-mode: fix botched configure messages This change fixes automake bug#9890. * m4/maintainer.m4 (AM_MAINTAINER_MODE): Fix the "checking ..." configure message related to the enabling/disabling of maintainer mode. * tests/help-maintainer.test: Renamed ... * tests/maintmode-configure-msg.test: ... to this, and extended to cover the fixed bug. Also, since we are at it, make grepping of configure help screens stricter, and throw in some few other changes to reduce code duplication and enhance readability. * tests/Makefile.am (TESTS): Update. Report and initial patch by Zack Weinberg, test cases added by Stefano Lattarini. =2D-- ChangeLog | 17 ++++++++ m4/maintainer.m4 | 6 +- tests/Makefile.am | 2 +- tests/Makefile.in | 2 +- tests/help-maintainer.test | 61 --------------------------- tests/maintmode-configure-msg.test | 79 ++++++++++++++++++++++++++++++++= ++++ 6 files changed, 101 insertions(+), 66 deletions(-) delete mode 100755 tests/help-maintainer.test create mode 100755 tests/maintmode-configure-msg.test diff --git a/ChangeLog b/ChangeLog index 39c661c..972d52a 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,20 @@ +2011-10-29 Zack Weinberg (tiny change) + Stefano Lattarini + + maint-mode: fix botched configure messages + This change fixes automake bug#9890. + * m4/maintainer.m4 (AM_MAINTAINER_MODE): Fix the "checking ..." + configure message related to the enabling/disabling of maintainer + mode. + * tests/help-maintainer.test: Renamed ... + * tests/maintmode-configure-msg.test: ... to this, and extended + to cover the fixed bug. Also, since we are at it, make grepping + of configure help screens stricter, and throw in some few other + changes to reduce code duplication and enhance readability. + * tests/Makefile.am (TESTS): Update. + Report and initial patch by Zack Weinberg, test cases added by + Stefano Lattarini. + 2011-10-20 Stefano Lattarini =20 deps: partially revert commit `v1.11-512-geeee551' diff --git a/m4/maintainer.m4 b/m4/maintainer.m4 index 0b54e67..085e96c 100644 =2D-- a/m4/maintainer.m4 +++ b/m4/maintainer.m4 @@ -1,8 +1,8 @@ # Add --enable-maintainer-mode option to configure. -*- Autoconf -= *- # From Jim Meyering =20 =2D# Copyright (C) 1996, 1998, 2000, 2001, 2002, 2003, 2004, 2005, 2008 =2D# Free Software Foundation, Inc. +# Copyright (C) 1996, 1998, 2000, 2001, 2002, 2003, 2004, 2005, 2008, +# 2011 Free Software Foundation, Inc. # # This file is free software; the Free Software Foundation # gives unlimited permission to copy and/or distribute it, @@ -22,7 +22,7 @@ AC_DEFUN([AM_MAINTAINER_MODE], [disable], [m4_define([am_maintainer_other], [enable])], [m4_define([am_maintainer_other], [enable]) m4_warn([syntax], [unexpected argument to AM@&t@_MAINTAINER_MODE: = $1])]) =2DAC_MSG_CHECKING([whether to am_maintainer_other maintainer-specific port= ions of Makefiles]) +AC_MSG_CHECKING([whether to enable maintainer-specific portions of Makefil= es]) dnl maintainer-mode's default is 'disable' unless 'enable' is passed AC_ARG_ENABLE([maintainer-mode], [ --][am_maintainer_other][-maintainer-mode am_maintainer_other make rul= es and dependencies not useful diff --git a/tests/Makefile.am b/tests/Makefile.am index c16eb9f..dfa9781 100644 =2D-- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -422,7 +422,6 @@ help-depend2.test \ help-dmalloc.test \ help-init.test \ help-lispdir.test \ =2Dhelp-maintainer.test \ help-multilib.test \ help-python.test \ help-regex.test \ @@ -548,6 +547,7 @@ lzma.test \ m4-inclusion.test \ maintclean.test \ maintclean-vpath.test \ +maintmode-configure-msg.test \ make.test \ makej.test \ makej2.test \ diff --git a/tests/Makefile.in b/tests/Makefile.in index 65e8d7f..248b6ba 100644 =2D-- a/tests/Makefile.in +++ b/tests/Makefile.in @@ -706,7 +706,6 @@ help-depend2.test \ help-dmalloc.test \ help-init.test \ help-lispdir.test \ =2Dhelp-maintainer.test \ help-multilib.test \ help-python.test \ help-regex.test \ @@ -832,6 +831,7 @@ lzma.test \ m4-inclusion.test \ maintclean.test \ maintclean-vpath.test \ +maintmode-configure-msg.test \ make.test \ makej.test \ makej2.test \ diff --git a/tests/help-maintainer.test b/tests/help-maintainer.test deleted file mode 100755 index 6933d0c..0000000 =2D-- a/tests/help-maintainer.test +++ /dev/null @@ -1,61 +0,0 @@ =2D#! /bin/sh =2D# Copyright (C) 2010 Free Software Foundation, Inc. =2D# =2D# This program is free software; you can redistribute it and/or modify =2D# it under the terms of the GNU General Public License as published by =2D# the Free Software Foundation; either version 2, or (at your option) =2D# any later version. =2D# =2D# This program is distributed in the hope that it will be useful, =2D# but WITHOUT ANY WARRANTY; without even the implied warranty of =2D# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the =2D# GNU General Public License for more details. =2D# =2D# You should have received a copy of the GNU General Public License =2D# along with this program. If not, see . =2D =2D# Make sure that our macro `AM_MAINTAINER_MODE' adds proper text to =2D# the configure help screen. =2D =2D. ./defs || Exit 1 =2D =2Dset -e =2D =2Dcat > configure.in <stdout || { cat stdout; Exit 1; } =2Dcat stdout =2D$EGREP '^ *--enable-maintainer-mode( |$)' stdout =2D$FGREP ' enable make rules' stdout =2D =2Drm -rf autom4te*.cache # just to be sure =2Dsed 's/\(AM_MAINTAINER_MODE\).*/\1([disable])/' configure.in >t =2Dmv -f t configure.in =2D =2Dcat configure.in =2D$ACLOCAL =2D$AUTOCONF --force =2D./configure --help >stdout || { cat stdout; Exit 1; } =2Dcat stdout =2D$EGREP '^ *--enable-maintainer-mode( |$)' stdout =2D$FGREP ' enable make rules' stdout =2D =2Drm -rf autom4te*.cache # just to be sure =2Dsed 's/\(AM_MAINTAINER_MODE\).*/\1([enable])/' configure.in >t =2Dmv -f t configure.in =2D =2Dcat configure.in =2D$ACLOCAL =2D$AUTOCONF --force =2D./configure --help >stdout || { cat stdout; Exit 1; } =2Dcat stdout =2D$EGREP '^ *--disable-maintainer-mode( |$)' stdout =2D$FGREP ' disable make rules' stdout =2D =2D: diff --git a/tests/maintmode-configure-msg.test b/tests/maintmode-configure= =2Dmsg.test new file mode 100755 index 0000000..5771392 =2D-- /dev/null +++ b/tests/maintmode-configure-msg.test @@ -0,0 +1,79 @@ +#! /bin/sh +# Copyright (C) 2010, 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Make sure that our macro `AM_MAINTAINER_MODE' adds proper text to +# the configure help screen. Also make sure the "checking ..." messages +# related to the enabling/disabling of maintainer mode are correct (see +# automake bug#9890). + +. ./defs || Exit 1 + +set -e + +set_maintmode () +{ + rm -rf autom4te*.cache # Just to be sure not to use a stale cache. + echo "AC_INIT([$me], [1.0])" > configure.in + case $1 in + DEFAULT) echo AM_MAINTAINER_MODE;; + *) echo "AM_MAINTAINER_MODE([$*])";; + esac >> configure.in +} + +check_configure_message_with () +{ + answer=3D$1; shift + ./configure ${1+"$@"} >stdout || { cat stdout; Exit 1; } + cat stdout + grep "^checking whether to enable maintainer-specific.*\\.\\.\\. $answer= $" stdout + test `grep -c 'checking.*maint' stdout` -eq 1 + : +} + +set_maintmode "DEFAULT" + +$ACLOCAL + +$AUTOCONF --force + +./configure --help >stdout || { cat stdout; Exit 1; } +cat stdout +grep '^ *--enable-maintainer-mode.* enable make rules' stdout + +check_configure_message_with "no" +check_configure_message_with "yes" --enable-maintainer-mode + +set_maintmode "disable" + +$AUTOCONF --force +./configure --help >stdout || { cat stdout; Exit 1; } +cat stdout +grep '^ *--enable-maintainer-mode.* enable make rules' stdout + +check_configure_message_with "no" +check_configure_message_with "yes" --enable-maintainer-mode + +set_maintmode "enable" + +$AUTOCONF --force +./configure --help >stdout || { cat stdout; Exit 1; } +cat stdout +grep '^ *--disable-maintainer-mode.* disable make rules' stdout + +check_configure_message_with "yes" +check_configure_message_with "no" --disable-maintainer-mode + +: =2D-=20 1.7.2.3 --Boundary-00=_oL9qO/auPwn3ehp-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 11:42:58 2011 Received: (at 9890) by debbugs.gnu.org; 29 Oct 2011 15:42:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKB3h-0002Qo-St for submit@debbugs.gnu.org; Sat, 29 Oct 2011 11:42:58 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKB3f-0002Qh-L1 for 9890@debbugs.gnu.org; Sat, 29 Oct 2011 11:42:56 -0400 Received: by gyh20 with SMTP id 20so4478563gyh.3 for <9890@debbugs.gnu.org>; Sat, 29 Oct 2011 08:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1yEp8u53lql3ggoQj0z0xc+999yKZGpAE1E4xix1xZ4=; b=m7TERLc/Ui3CSJn61lNQr6DvWWZ3fkTqZXudSTRZWhGn+vQbqECMGoKsxlq2i/unQX qI8zdurmqHYN4eBTAN3hxmTlcpegYjt4+6eqgI4x0WjNGLfZkaYtorEysPheYpJ/k6wM Kcv0nSAbAG/cp8h6vKtkgtGHqKb/Ai1PwKiNY= Received: by 10.68.28.103 with SMTP id a7mr11360492pbh.63.1319902854201; Sat, 29 Oct 2011 08:40:54 -0700 (PDT) Received: from ardsley.local (99-113-32-219.lightspeed.sntcca.sbcglobal.net. [99.113.32.219]) by mx.google.com with ESMTPS id jm5sm33659102pbc.1.2011.10.29.08.40.52 (version=SSLv3 cipher=OTHER); Sat, 29 Oct 2011 08:40:53 -0700 (PDT) Message-ID: <4EAC1E85.3040704@panix.com> Date: Sat, 29 Oct 2011 08:40:53 -0700 From: Zack Weinberg User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Stefano Lattarini Subject: Re: bug#9890: cosmetic bug in AM_MAINTAINER_MODE References: <201110291218.16167.stefano.lattarini@gmail.com> In-Reply-To: <201110291218.16167.stefano.lattarini@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 9890 Cc: bug-automake@gnu.org, 9890@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On 2011-10-29 3:18 AM, Stefano Lattarini wrote: > Thanks for the analysis and solution. I've applied your diff, and added > a testcase. Attached is the patch I intend to push shortly (I'll give a > couple of days for reviews and objections). Thank you for the quick turnaround. > Also, I have a minor question: > Zack, are you the same "Zack Weinberg" already listed in the THANKS file > with the address "zack@codesourcery.com"? If yes, should I update that > address? Yes I am, and yes you should update that address. I left CodeSourcery in 2005, but I mean zackw@panix.com to remain valid indefinitely. zw From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 06:34:41 2011 Received: (at submit) by debbugs.gnu.org; 3 Nov 2011 10:34:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLud6-0003ws-3Z for submit@debbugs.gnu.org; Thu, 03 Nov 2011 06:34:41 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RLud3-0003wk-J3 for submit@debbugs.gnu.org; Thu, 03 Nov 2011 06:34:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLuab-00076k-Hu for submit@debbugs.gnu.org; Thu, 03 Nov 2011 06:32:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:45481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLuab-00076g-Fp for submit@debbugs.gnu.org; Thu, 03 Nov 2011 06:32:05 -0400 Received: from eggs.gnu.org ([140.186.70.92]:50156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLuaa-0007wz-Dc for bug-automake@gnu.org; Thu, 03 Nov 2011 06:32:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLuaU-00076F-NP for bug-automake@gnu.org; Thu, 03 Nov 2011 06:32:04 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:63890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLuaU-000764-Iv for bug-automake@gnu.org; Thu, 03 Nov 2011 06:31:58 -0400 Received: by wyg24 with SMTP id 24so1307450wyg.0 for ; Thu, 03 Nov 2011 03:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=4EBtvT4MPpnUhsbW7kJqSlP/FMvy8NOgqEiF8U9RD8w=; b=lMnsfZyuoguzsObJsUkBQ5P23GnBXhuZ6TIP7qmyLWUn6GgXmRaCqsmV96RfVHyaUk JzJPIi2dznaLjZefgf1l0WhRaQkRd8OsfYlCiHQM6L4crX+/b+t6nvi4gQwfoZ/T11Th 7RgrdMLcjGR100FT1EojECg9eZtjBTeBTe/Mk= Received: by 10.227.203.198 with SMTP id fj6mr11061547wbb.24.1320316316789; Thu, 03 Nov 2011 03:31:56 -0700 (PDT) Received: from bigio.localnet (host129-94-dynamic.4-87-r.retail.telecomitalia.it. [87.4.94.129]) by mx.google.com with ESMTPS id eu16sm9344365wbb.7.2011.11.03.03.31.54 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Nov 2011 03:31:55 -0700 (PDT) From: Stefano Lattarini To: Zack Weinberg Subject: Re: bug#9890: cosmetic bug in AM_MAINTAINER_MODE Date: Thu, 3 Nov 2011 11:31:46 +0100 User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) References: <201110291218.16167.stefano.lattarini@gmail.com> <4EAC1E85.3040704@panix.com> In-Reply-To: <4EAC1E85.3040704@panix.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201111031131.47479.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit Cc: 9890-done@debbugs.gnu.org, bug-automake@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) On Saturday 29 October 2011, Zack Weinberg wrote: > On 2011-10-29 3:18 AM, Stefano Lattarini wrote: > > Zack, are you the same "Zack Weinberg" already listed in the THANKS file > > with the address "zack@codesourcery.com"? If yes, should I update that > > address? > > Yes I am, and yes you should update that address. I left CodeSourcery > in 2005, but I mean zackw@panix.com to remain valid indefinitely. > I've amended the THANKS file, and pushed the patch. I'm thus closing this bug report. Regards, Stefano From unknown Sat Aug 16 22:00:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 01 Dec 2011 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator