GNU bug report logs - #9873
24.0.90; dired - window changes size when trying to delete more than one file

Previous Next

Full log

Message #56 received at 9873 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Christoph Scholtes <cschol2112 <at> googlemail.com>,
	Juanma Barranquero <lekktu <at> gmail.com>, 9873 <at> debbugs.gnu.org
Subject: Re: bug#9873: 24.0.90;
	dired - window changes size when trying to delete more than one file
Date: Thu, 03 Nov 2011 21:42:41 +0200

>> +	pop-up-frames)
>
> There should be no need to bind this to nil.

I agree it's unnecessary.  Below is a new patch without `pop-up-frames':

=== modified file 'lisp/window.el'
--- lisp/window.el	2011-11-02 09:39:18 +0000
+++ lisp/window.el	2011-11-03 19:34:58 +0000
@@ -4853,6 +4853,23 @@ (defun display-buffer-pop-up-window (buf
       (set-window-prev-buffers window nil)
       window)))
 
+(defun display-buffer-pop-up-window-below (buffer alist)
+  "Display BUFFER by popping up a new window below the selected window."
+  (let (
+	;; Stay within the confines of the initial window.
+	;; Don't resize other windows.  (Bug#1806 Bug#9873)
+	(window-nest t)
+	(split-window-preferred-function
+	 (lambda (window)
+	   (or (and (let ((split-height-threshold 0))
+		      (window-splittable-p (selected-window)))
+		    ;; Try to split the selected window vertically if
+		    ;; that's possible.  (Bug#1806)
+		    (split-window-below))
+	       ;; Otherwise, try to split WINDOW sensibly.
+	       (split-window-sensibly window)))))
+    (display-buffer-pop-up-window buffer alist)))
+
 (defun display-buffer--maybe-pop-up-frame-or-window (buffer alist)
   "Try displaying BUFFER based on `pop-up-frames' or `pop-up-windows'.
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.