GNU bug report logs - #9867
24.0.90; quit-window should provide quit-window-hook

Previous Next

Full log

Message #42 received at 9867 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Christoph Scholtes <cschol2112 <at> googlemail.com>, 9867 <at> debbugs.gnu.org
Subject: Re: bug#9867: 24.0.90; quit-window should provide quit-window-hook
Date: Sun, 25 Aug 2019 07:24:39 +0200

martin rudalics <rudalics <at> gmx.at> writes:

>> That's true, but is there a use case for the hook function having to
>> know what window it's quitting?
>
> I don't know.  But you could replace 'with-current-buffer' with
> 'with-selected-window' to avoid worrying about that (and better check
> if WINDOW is not already selected before doing that internal state
> saving rigmarole).

I wasn't aware of `with-selected-window' -- it sounds a bit dramatic.
Does it have any side effects?

> Or, as I suggested earlier, run the hook only when
> quitting the selected window.

That's possible, but the semantics become perhaps a bit complicated?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.