GNU bug report logs - #9867
24.0.90; quit-window should provide quit-window-hook

Previous Next

Full log

Message #21 received at 9867 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Christoph Scholtes <cschol2112 <at> googlemail.com>, 9867 <at> debbugs.gnu.org
Subject: Re: bug#9867: 24.0.90; quit-window should provide quit-window-hook
Date: Wed, 21 Aug 2019 13:18:59 -0700

martin rudalics <rudalics <at> gmx.at> writes:

> If people really need such a hook at all, please
>
> - Make it either an abnormal hook run with the window quit as argument
>   or run it from 'quit-window' but then only if it quits the selected
>   window.

I was going back and forth on whether to call the hook from
`quit-window' or `quit-restore-window', so I ended up with invalid vode
in the latter.  Thinking about it a bit more, I think it makes more
sense to just run it from the former command -- other callers that call
`quit-restore-window' should perhaps call that hook manually (or not) at
all.

I'll move the hook over.

> - Fix the reference to the non-existent function 'quit-buffer'.

OK; done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.