From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Christoph Scholtes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Oct 2011 04:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9867@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.131951557425407 (code B ref -1); Tue, 25 Oct 2011 04:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Oct 2011 04:06:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RIYHE-0006bi-JJ for submit@debbugs.gnu.org; Tue, 25 Oct 2011 00:06:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RIYHA-0006bU-Ea for submit@debbugs.gnu.org; Tue, 25 Oct 2011 00:06:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIYFX-0008M6-Hk for submit@debbugs.gnu.org; Tue, 25 Oct 2011 00:04:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:44831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIYFX-0008M2-GF for submit@debbugs.gnu.org; Tue, 25 Oct 2011 00:04:27 -0400 Received: from eggs.gnu.org ([140.186.70.92]:56153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIYFW-0005OC-Mj for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2011 00:04:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIYFV-0008Lc-PY for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2011 00:04:26 -0400 Received: from mail-vw0-f41.google.com ([209.85.212.41]:37852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIYFV-0008LX-Gw for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2011 00:04:25 -0400 Received: by vws16 with SMTP id 16so79216vws.0 for ; Mon, 24 Oct 2011 21:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=from:to:subject:user-agent:date:message-id:mime-version :content-type; bh=AYv0LjFNq9g15qHp0czYqf803tIaxvM+iklh4BtytAE=; b=UBywLloJeMNHMJOFc8FaUThvEZv2r0/lrW70gFMYk2RPWsvZOwfSlnOSC/xVjnRd2d Rcdxm9qmKEoneT9R+g6EiOPVE1aiDMl4iHJxBZ4lqSgwpmwKWyWClnapNiUj6VwZ44fi HrU/fmTs/AFjECQOUtBVNiLvcWQ5ftjr52Gng= Received: by 10.52.33.69 with SMTP id p5mr25306316vdi.78.1319515464933; Mon, 24 Oct 2011 21:04:24 -0700 (PDT) Received: from MARVIN (71-208-77-210.hlrn.qwest.net. [71.208.77.210]) by mx.google.com with ESMTPS id gw4sm9090118vdb.10.2011.10.24.21.04.23 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Oct 2011 21:04:24 -0700 (PDT) From: Christoph Scholtes User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (windows-nt) Date: Mon, 24 Oct 2011 22:04:17 -0600 Message-ID: <861uu1ogxq.fsf@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.1 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) A `quit-window-hook' should be provided for the `quit-window' function. See discussion here: http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg00919.html From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 02:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Christoph Scholtes Cc: 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156626773114996 (code B ref 9867); Tue, 20 Aug 2019 02:23:02 +0000 Received: (at 9867) by debbugs.gnu.org; 20 Aug 2019 02:22:11 +0000 Received: from localhost ([127.0.0.1]:60680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hztmk-0003to-KZ for submit@debbugs.gnu.org; Mon, 19 Aug 2019 22:22:10 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hztmh-0003td-Ht for 9867@debbugs.gnu.org; Mon, 19 Aug 2019 22:22:08 -0400 Received: from [12.144.191.101] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hztmc-0001bz-Pj; Tue, 20 Aug 2019 04:22:05 +0200 From: Lars Ingebrigtsen References: <861uu1ogxq.fsf@googlemail.com> Date: Mon, 19 Aug 2019 19:22:00 -0700 In-Reply-To: <861uu1ogxq.fsf@googlemail.com> (Christoph Scholtes's message of "Mon, 24 Oct 2011 22:04:17 -0600") Message-ID: <87d0h01sqf.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Christoph Scholtes writes: > A `quit-window-hook' should be provided for the `quit-window' function. > > See discussion here: > http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg00919.html Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Christoph Scholtes writes: > A `quit-window-hook' should be provided for the `quit-window' function. > > See discussion here: > http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg00919.html (I'm going through old bug reports that have unfortunately gotten no attention yet.) It seems like Chong OK'd this hook at the time, but it was never added to Emacs. I've now added it to Emacs 27, because it seems like a useful addition to have -- now modes that need to do some clean-up thing before doing whatever `quit-window' does can just add that to the hook (buffer-locally). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 19 22:22:18 2019 Received: (at control) by debbugs.gnu.org; 20 Aug 2019 02:22:18 +0000 Received: from localhost ([127.0.0.1]:60683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hztmr-0003u8-Ua for submit@debbugs.gnu.org; Mon, 19 Aug 2019 22:22:18 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hztmq-0003u0-Qk for control@debbugs.gnu.org; Mon, 19 Aug 2019 22:22:17 -0400 Received: from [12.144.191.101] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hztmm-0001cC-Aa for control@debbugs.gnu.org; Tue, 20 Aug 2019 04:22:16 +0200 Date: Mon, 19 Aug 2019 19:22:09 -0700 Message-Id: <87blwk1sq6.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #9867 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 9867 fixed close 9867 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 9867 fixed close 9867 27.1 quit From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 08:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen , Christoph Scholtes Cc: 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156628918723987 (code B ref 9867); Tue, 20 Aug 2019 08:20:02 +0000 Received: (at 9867) by debbugs.gnu.org; 20 Aug 2019 08:19:47 +0000 Received: from localhost ([127.0.0.1]:60860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzzMp-0006Eo-Dv for submit@debbugs.gnu.org; Tue, 20 Aug 2019 04:19:47 -0400 Received: from mout.gmx.net ([212.227.17.21]:36377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzzMm-0006Eb-LI for 9867@debbugs.gnu.org; Tue, 20 Aug 2019 04:19:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566289172; bh=ZWz9EU5iUi+ZevDkW5czZ532+F05MLIimb5YDPvbzEA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Ca0uA8Xq2ev7CfM4h4X5E9NCfRR69AcOmiFixacPIFzIdBqYHdupjSuJ4+W/q+iOY zgoX+Bgfn/OFppXRDUGJXFydYBAC+TbCeYhyK8Bs6g9YX5nU6cqE9r/jW7lY0+FpQp 9sPqxj1mOczi2NRWnsz49C8SI8EvkozCScPC3HmU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.135]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MAwXh-1i6Gle398j-00BINb; Tue, 20 Aug 2019 10:19:31 +0200 References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> From: martin rudalics Message-ID: <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> Date: Tue, 20 Aug 2019 10:19:29 +0200 MIME-Version: 1.0 In-Reply-To: <87d0h01sqf.fsf@mouse.gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:TkpDYn7osu/tqhQOrlNPB6yN6/rU1EY5MvXBpP4lUN9jyWBBQZS 38VVvHta+D4CmvRmxw9K3PTz7cVLJVoFS0jiSP7HofzK6kkvo/a4NGM4QJsGUSIcvqdLowr aZJwGP6ZsXcW52CWsQof3MyebtfhdIEYP/B6q4YFYl6BN1eG+5Iw7SqGrrj7I2i1sjaPAnS LN2jAF2mX1tXR18nJX2IA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:CAo8+IwIlH4=:hzl7+p2lBYPq/fwVqe/3La ASpS8WDyD65BfS4oz2wLmH58qFFdGLmGsPkmmEBFspe3XH2aF0fYS0dxR/2LlHc4pvInAT613 I0o8O6KYGzDqqXa2LYYafL6BAA/m/Su7GY0yNoqr4tX5TB/KDO98Ct6BDysVKSKjYU9q9Y7qT 0ieNcWavwcaPpTJfoDOIvrH/VGTK1fP0rDFlXfXsBSm/KAoIazPP0FtpZo6EuqRo1APCMoabO 3mzb4lmhYxkx/H+6cf+N7B+sgOFQBd39oEbdslh513lxHv+Kq9E7udZ3Lze1w1aud6p5LpEk6 EwUjfcyOdZOuEQcbQN4GxKQvfSEvCFGBlSWRD8ztq9SKZ1xzW6kApO3scAP6zZkG+Bs6+r55G StAcqiaMQ0CXe+8mn5Slo/5JTBd6SO66KTapxCuqq5EpKvyhhzoWlPmcMFazL0mihSanhwWhB gNcUxidaoOzeT6BBqT5QTB0OshvOoxlfd/2vpgIySCINj/oID2QnvRfQpBUbZlVFp8GXYwYBo rTHXH0WRmfeY1sB3WEd7NIMjr3gk4b7E61GBcOz40H1y8cHChZb/7sYQb3vavfGXbAw+sUBCI ORyjdFBPL1RyKI+rPpBjUFWxp5+Qs43g/qq2QBgvnO0wdzWhHt7/GCJ1Ql9yYDEjCgcOX5NrI szltmYXFhfI2aKrvgVhmzToE8SgrKjAxeVpOSuGrpEvD7BKe8nNSs8H3w3R7TqGqj92csg+OC QhXCbzxX9VXbjSMRlo9+we5IoM2AvghXiQ9hEJvn6uSvq2ebKktmTaKSeyeN1lXXMNZxwDYCU JApDz3tClNVMt+2JC/yU78GHjXz1u3VC1GJVy5xEFhF2ApZ19zoBozkiAEfU+cjdmkrk5wTFC 2jzgJh/sgQYs0lvWwBXY7Fhz6w/zDa2JWfzc90jqkLBzskWYc4qIUPUeFfCHLVD3ZlmTbel4A +TObP+KmlaMJ47s+Bkd+lZiNcX8Fq2ofC1lJxBD1sUwtiyS+vY/J0DoGU5WcB2jB6MEt8uDse zmTe2Y8SUMbXEhrLY+L4OR2A2gYYTnUF/2dSajMW8sw8lYDc+w75i2kNLvnkP0obF/itljjn3 ffR6O0Zc0WFP0YY+pRzTnys8hOIYiGg6q1SJ4V/py7yKnP+M1wmNNkbeV3xhIcn+d5vvV0POD 8Ueys= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > It seems like Chong OK'd this hook at the time, but it was never added > to Emacs. I've now added it to Emacs 27, because it seems like a useful > addition to have -- now modes that need to do some clean-up thing before > doing whatever `quit-window' does can just add that to the hook > (buffer-locally). 'quit-restore-window' can quit _any_ window not just the selected one. This means that if a user puts something on a normal hook run by that function, that something can only guess at which window is really quit by that function. Also, running a buffer-local value of that hook is meaningless given the current implementation. See the tribulations run_window_configuration_change_hook runs into when trying to overcome a similar problem (and note the unwind-protection overhead it incurs). If people really need such a hook at all, please - Make it either an abnormal hook run with the window quit as argument or run it from 'quit-window' but then only if it quits the selected window. - Make sure to call any buffer-local value of that hook for the buffer of the window that is quit. - Prefix it with 'quit-restore-' if you intend to run it from 'quit-restore-window' (that function may be called by other functions as well). - Fix the reference to the non-existent function 'quit-buffer'. Thanks, martin From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: martin rudalics Cc: cschol2112@googlemail.com, larsi@gnus.org, 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156631113426333 (code B ref 9867); Tue, 20 Aug 2019 14:26:01 +0000 Received: (at 9867) by debbugs.gnu.org; 20 Aug 2019 14:25:34 +0000 Received: from localhost ([127.0.0.1]:33521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i054n-0006qf-TC for submit@debbugs.gnu.org; Tue, 20 Aug 2019 10:25:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i054m-0006qR-C0 for 9867@debbugs.gnu.org; Tue, 20 Aug 2019 10:25:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i054d-0007xk-4m; Tue, 20 Aug 2019 10:25:25 -0400 Received: from [176.228.60.248] (port=4690 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i054V-0005rJ-MS; Tue, 20 Aug 2019 10:25:17 -0400 Date: Tue, 20 Aug 2019 17:25:20 +0300 Message-Id: <83ef1flxrj.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> (message from martin rudalics on Tue, 20 Aug 2019 10:19:29 +0200) References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: martin rudalics > Date: Tue, 20 Aug 2019 10:19:29 +0200 > Cc: 9867@debbugs.gnu.org > > If people really need such a hook at all, please > > - Make it either an abnormal hook run with the window quit as argument > or run it from 'quit-window' but then only if it quits the selected > window. > > - Make sure to call any buffer-local value of that hook for the buffer > of the window that is quit. > > - Prefix it with 'quit-restore-' if you intend to run it from > 'quit-restore-window' (that function may be called by other > functions as well). > > - Fix the reference to the non-existent function 'quit-buffer'. And also: - Add the new hook to the list in the node "Standard Hooks" in the ELisp manual. Thanks. From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2019 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: martin rudalics Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156641874931170 (code B ref 9867); Wed, 21 Aug 2019 20:20:02 +0000 Received: (at 9867) by debbugs.gnu.org; 21 Aug 2019 20:19:09 +0000 Received: from localhost ([127.0.0.1]:36512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0X4X-00086f-BI for submit@debbugs.gnu.org; Wed, 21 Aug 2019 16:19:09 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0X4V-00086X-RD for 9867@debbugs.gnu.org; Wed, 21 Aug 2019 16:19:08 -0400 Received: from 77.16.217.167.tmi.telenormobil.no ([77.16.217.167] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0X4Q-00069g-7x; Wed, 21 Aug 2019 22:19:05 +0200 From: Lars Ingebrigtsen References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> Date: Wed, 21 Aug 2019 13:18:59 -0700 In-Reply-To: <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> (martin rudalics's message of "Tue, 20 Aug 2019 10:19:29 +0200") Message-ID: <87mug2xoek.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: martin rudalics writes: > If people really need such a hook at all, please > > - Make it either an abnormal hook run with the window quit as argument > or run it from 'quit-window' but then only if it quits the selected > wi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: > If people really need such a hook at all, please > > - Make it either an abnormal hook run with the window quit as argument > or run it from 'quit-window' but then only if it quits the selected > window. I was going back and forth on whether to call the hook from `quit-window' or `quit-restore-window', so I ended up with invalid vode in the latter. Thinking about it a bit more, I think it makes more sense to just run it from the former command -- other callers that call `quit-restore-window' should perhaps call that hook manually (or not) at all. I'll move the hook over. > - Fix the reference to the non-existent function 'quit-buffer'. OK; done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2019 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Eli Zaretskii Cc: cschol2112@googlemail.com, martin rudalics , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156641899931594 (code B ref 9867); Wed, 21 Aug 2019 20:24:02 +0000 Received: (at 9867) by debbugs.gnu.org; 21 Aug 2019 20:23:19 +0000 Received: from localhost ([127.0.0.1]:36516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0X8Y-0008DV-UD for submit@debbugs.gnu.org; Wed, 21 Aug 2019 16:23:19 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0X8X-0008DN-9j for 9867@debbugs.gnu.org; Wed, 21 Aug 2019 16:23:17 -0400 Received: from 77.16.217.167.tmi.telenormobil.no ([77.16.217.167] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0X8T-0006CV-1M; Wed, 21 Aug 2019 22:23:15 +0200 From: Lars Ingebrigtsen References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <83ef1flxrj.fsf@gnu.org> Date: Wed, 21 Aug 2019 13:23:09 -0700 In-Reply-To: <83ef1flxrj.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Aug 2019 17:25:20 +0300") Message-ID: <87imqqxo7m.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > And also: > > - Add the new hook to the list in the node "Standard Hooks" in the > ELisp manual. OK; done. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > And also: > > - Add the new hook to the list in the node "Standard Hooks" in the > ELisp manual. OK; done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Aug 2019 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.15664613115416 (code B ref 9867); Thu, 22 Aug 2019 08:09:02 +0000 Received: (at 9867) by debbugs.gnu.org; 22 Aug 2019 08:08:31 +0000 Received: from localhost ([127.0.0.1]:36970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0i90-0001PI-L4 for submit@debbugs.gnu.org; Thu, 22 Aug 2019 04:08:30 -0400 Received: from mout.gmx.net ([212.227.17.20]:57705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0i8y-0001P5-Af for 9867@debbugs.gnu.org; Thu, 22 Aug 2019 04:08:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566461302; bh=nsE2b7NLYoCcjnR/+jnlb09WF5wuA00AqlrFs/xTHNk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Tg63j125NqWWhMNz7OBYHRnCBN5l2oKxdamQoCA4iEULc2AK1/osmWMYB3EVj87gU HTG1UFltL/PtE/eqWI/kaCnNsVoqi4xoVfRtv2jjqFVliH1hCX98SUhyN2zc76EzJV 9PkfPA5Lcnu9Aut55pjSs4zOsqqJ8awodZGopFY8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.249.58]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lq9Ma-1iVfEs0LTs-00dqmR; Thu, 22 Aug 2019 10:08:22 +0200 References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> From: martin rudalics Message-ID: <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> Date: Thu, 22 Aug 2019 10:08:23 +0200 MIME-Version: 1.0 In-Reply-To: <87mug2xoek.fsf@mouse.gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:0mtiwtlAEx60eELv0tFIvHlfx9ok7ycoo+R+Clo6iKyqULBKwuG DRUpzfKmPQcFfEAmiWwr3QhwladXz7707X2Kj4U7mn8zTC2MQmOyW//ZaB4VBPOg6iTfJg4 Hc8NnGx3BHgnkL4e8p9G2Ucfcvk9PR0Sp97GswgyEyV0lzxnM/9cMY810SzfskjrzAC7ZzP JBZ+EWWWE/KKCFz65Kx+w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/5zCTbLaAis=:zE/GPsBH3TJOHq4kcdSmPg b6ouyczMYsURD/iVunqSvMV0PYYEW0z+yTAP3KA8SB6sUR+kVmcRBcjVL0qdEiYZXpZLnvxq3 6ySJ3urn5DU4IotpZVZbDEtfCFfql6oFWP4gf4CEBkaWR/PBjqZ65RgZ3dSvxLKpwMnxZCsYy MFPdbqmgc+1BnDaUb1nSZyd+fmKbV/lubObyd4Mt267+LbLLYC3n6sH77ndsDmDW2EnuMzJ+w xsPssjaOc++8D0eI9aEU+YwO/iNsUDDGRORCsQBcjzB4ry5njGXk5u0is1x1pY4i2TrEgO6lA Cw4OYKguW/M2/harjlVM4GZNIVnSrY/I9NmThVZlUSA6PXKP4zjTrFeOpP1yYerc0Uz8N1BnD GTCQfmlcCB2+jG6nO8ieSFroNXd4bMkkmMZnompMa5YMniJThgqfKol2KC8DeyR7L16IpcL8w nXiLyqHuHy8FD7ITMwrhotFfqsIxj8VK3I3u3FLpty5KdEI+7oAMOxLvSqxtUkSuWb3t8Rekg JQP6hnSUTxYkFpqeKJCAj/eGribMzrfQwnj6yrVm+AUtCFcxnhgdRSZV1Wke2pY7c2di0b4h3 Zy48nyR0U2IICYwBnjeQlltlms70uffiTJ4PP5JDgqiijH5tg+ovc1dQP9O+AYvwqxF93X+8v E4R/84pKBJzljMoP2QncwhRHAtiNFfPrHoISswZpnVGI6nDyIDtpbuFMnJMGctckk5DuVWadf ycWWAXZNg+PtrXDYsW5IhH7uQv31dz+U4qYIuj0ZI3ytoLXbWvd+0/ra7WpDD8+3A6/uflj84 4dDfC0xn2X7Z+JPa/H3tJUqhj/3oQrLUK87wKarq++DxUfJArmg3dONgk3O/xXOjPhQ/PI2Fc muNBMDPWLXNxIdvS90fLISl14Mw1OUS660I3k8w/Zjltp229t13WDRoMfRtJ6UPiYNbXJofLp agRlCd9FgKuuKe0Y906X48sliR3La7phPo1qTHxTFJVjwEU6hOInI2OkeUHMZFXaCpvldjWeO HBI0ukJ9n3XjjwrEadRq3FvDCdd+eHtWueO418cYSo0W9PCCExtblT8R8NEEbQWv/JbYEu5dn 90Xj35Da3lmYhiXoGOZX3YGjsbpqRSPi8pXSlxr07NXaUtAxWrc8hSixCwcpHezfqazx3krHD +BzSsSMTiz8IyD6ryAKClboDbsLVb2Xw9bRcdT1eLsPOncfQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> - Make it either an abnormal hook run with the window quit as argument >> or run it from 'quit-window' but then only if it quits the selected >> window. > > I was going back and forth on whether to call the hook from > `quit-window' or `quit-restore-window', so I ended up with invalid vode > in the latter. Thinking about it a bit more, I think it makes more > sense to just run it from the former command -- other callers that call > `quit-restore-window' should perhaps call that hook manually (or not) at > all. > > I'll move the hook over. But it's still misconfigured when WINDOW is not the selected window: The function run by the hook would not know which window is quit and which is its buffer. >> - Fix the reference to the non-existent function 'quit-buffer'. > > OK; done. Thanks. martin From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 00:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: martin rudalics Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156651890629339 (code B ref 9867); Fri, 23 Aug 2019 00:09:01 +0000 Received: (at 9867) by debbugs.gnu.org; 23 Aug 2019 00:08:26 +0000 Received: from localhost ([127.0.0.1]:38525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0x7x-0007d9-Vs for submit@debbugs.gnu.org; Thu, 22 Aug 2019 20:08:26 -0400 Received: from quimby.gnus.org ([80.91.231.51]:35836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0x7w-0007cw-4V for 9867@debbugs.gnu.org; Thu, 22 Aug 2019 20:08:24 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0x7q-0001je-59; Fri, 23 Aug 2019 02:08:20 +0200 From: Lars Ingebrigtsen References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> Date: Fri, 23 Aug 2019 02:08:17 +0200 In-Reply-To: <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> (martin rudalics's message of "Thu, 22 Aug 2019 10:08:23 +0200") Message-ID: <8736hsd9qm.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: martin rudalics writes: > But it's still misconfigured when WINDOW is not the selected window: > The function run by the hook would not know which window is quit and > which is its buffer. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: > But it's still misconfigured when WINDOW is not the selected window: > The function run by the hook would not know which window is quit and > which is its buffer. Yup; should be fixed now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 07:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156654641628146 (code B ref 9867); Fri, 23 Aug 2019 07:47:02 +0000 Received: (at 9867) by debbugs.gnu.org; 23 Aug 2019 07:46:56 +0000 Received: from localhost ([127.0.0.1]:39054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i14Hf-0007Ju-Tl for submit@debbugs.gnu.org; Fri, 23 Aug 2019 03:46:56 -0400 Received: from mout.gmx.net ([212.227.15.15]:33721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i14He-0007Je-2G for 9867@debbugs.gnu.org; Fri, 23 Aug 2019 03:46:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566546407; bh=E9V/WLXaXK3Cj1NkB7Ar1ENJ1CaxFHLyXyj0Cw+EaWQ=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=dZ3zeoQbikDbeP0AOXGPvOh6Fi8Y1LrLxYr7K/aTNYPC+4dIzaluGVvrXNOuJkqcT B7XEdde1Bbb9KdsAJCd2Sy6/bgP0BA6c5TSDgLXBvcB6HuoaB9n/+ueZioIhNVMLgK HBvTgjridgQ81UyH4opP7RK0226c8x3zMwveAcl4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.162.73.81]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MePcd-1hazcW2Q07-00QApM; Fri, 23 Aug 2019 09:46:47 +0200 References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> <8736hsd9qm.fsf@mouse.gnus.org> From: martin rudalics Message-ID: <70aa4943-eb2d-ffa2-b6ee-4638181d1920@gmx.at> Date: Fri, 23 Aug 2019 09:46:48 +0200 MIME-Version: 1.0 In-Reply-To: <8736hsd9qm.fsf@mouse.gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:XZk+UY+MF5Ght+G+JaxlLTMXtQ4h6rS4B1BVeMI/sZduW23LG3K ECLTiUOUgyupIps1tzftSE9h57iH1yYgR9wRZ2pzdGkPymnUXUTELzBMN4sdbLa8HNlHawp 5Au5nNNZv58wfCkj9JOBsTQcj16t3+gsgEAyjfz4s3+ZB9kQ4stqZQj46pxQKGM0DCcXnrB G3rmqomEAX0JV3Eti+sKA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:kXBzkGFPq7k=:OZ4cL3G4N/nXpGAJ4IDVqk zhOMQ9JsVspi2ttJn9GmseazEsLavCcISHUGgU+6yCSqkcdyLMdS/GAmPeVtaYx64LVo5sO3o 93ZWvZabLdctggztaHxo0cVYfFZ9Yq76nzhq0TZPv+ALl5mUQpFUQa6zEdvq9FAZRIrYeAW6s SP+jokJDf0BiAt+gDAYa9DqEt6Pc3EBIS9YeWBgo6UXeAMpWU4drVKYFKmWO+p89Kq5A+QTIh TmnnTwIyQHBRGezpGLTt+jz1NM7ydA3glKP5bRiahQHsPEt75ub6S1ywAWHPcOVz33CSEkhTX yOIznuDHOcqdV/iRpuwmqmKXQ6nQpLhX9Jp4aUNQ+4iviPylkxYyEXpPXEIluN/dxbCbxGgnD 5YxVX9RAbG5qVq/TMnnKBri+U4LcL1iebgzddZrUqwfGaRXKflYkX06NoWQzHGMOmAbRSmg3J +3HqvFcPL354WSG086RKNRlQG4A8VX0BnWBy2qjwjJJmUYaWXgmm/Sc1TLULWeWh0Jd/jtWNo sRLbBFhgvG+CjgHtiDrR+Is4rJdnQb3YKwUWDtxGcnYfDGTS4YwOR/TC6v+0LRl0ri5ZkC7Mj II5DZNUITXDsiwovuaxJ0Opp5iDwkprSyOBCmF3MoPNah11i+PE3NZxiQ/3yAmbr9390iA8ho TjWYNoVct6ZSAU7+/BXlvFi4pznJ8D/h8TBJCbIGK6yuZNeN1YgcQICzemb7e0cCe+mMIZExM j0J6CwuHpFcRYmzgqr2R56Cz39K91uPi+97OtWzOxSB3QzkNfEl45LJkc28+bZr/aMPFmRC4K mMc7Rqt4ad0b+3vSBOGFnb51AoHuctAKKOxXwl9irdqoQSytb4ejGNOdn3iemcWIBHpyNfeIn LzAflnorpjiWhAmpw3Y+pq0tb8CbD4VjFKy06sIQD9VSFM5bXpMH3R8FDRTpk0U24LQ6UgRAR vUt2Hyma56GlBfNh9qASr1ZI7yR6rzAE1PFtEacoq+PwHVeUvhyMp2owq29TKrHaSkUeyZYpV fW2guC+HpH0XSeJHeNV/Bz6p+uDetVM3Mem13jyBwnKAYu14zBeZVTkhSk/auJzwQBoVv3XmG QpsLg5sEbsX6dQJ4UGvKmNgmXdFJCDx45UTQlCrE47MCZOt8hgyXOr1RMyGAnYcyc/EZpq0DS bk+WU= X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> But it's still misconfigured when WINDOW is not the selected window: >> The function run by the hook would not know which window is quit and >> which is its buffer. > > Yup; should be fixed now. The function on the hook still wouldn't reliably know which window was quit, for example, when its buffer is displayed in two windows at the same time. Consider: (let ((window (split-window))) (quit-window nil window)) martin From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 08:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: martin rudalics Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156654754330039 (code B ref 9867); Fri, 23 Aug 2019 08:06:02 +0000 Received: (at 9867) by debbugs.gnu.org; 23 Aug 2019 08:05:43 +0000 Received: from localhost ([127.0.0.1]:39085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i14Zr-0007oR-Im for submit@debbugs.gnu.org; Fri, 23 Aug 2019 04:05:43 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i14Zp-0007oJ-U8 for 9867@debbugs.gnu.org; Fri, 23 Aug 2019 04:05:42 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i14Zl-0005DK-Uq; Fri, 23 Aug 2019 10:05:40 +0200 From: Lars Ingebrigtsen References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> <8736hsd9qm.fsf@mouse.gnus.org> <70aa4943-eb2d-ffa2-b6ee-4638181d1920@gmx.at> Date: Fri, 23 Aug 2019 10:05:37 +0200 In-Reply-To: <70aa4943-eb2d-ffa2-b6ee-4638181d1920@gmx.at> (martin rudalics's message of "Fri, 23 Aug 2019 09:46:48 +0200") Message-ID: <87a7c0cnn2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: martin rudalics writes: > The function on the hook still wouldn't reliably know which window was > quit, for example, when its buffer is displayed in two windows at the > same time. Consider: > > (let ((window (split-window) [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: > The function on the hook still wouldn't reliably know which window was > quit, for example, when its buffer is displayed in two windows at the > same time. Consider: > > (let ((window (split-window))) > (quit-window nil window)) That's true, but is there a use case for the hook function having to know what window it's quitting? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 08:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.15665497649343 (code B ref 9867); Fri, 23 Aug 2019 08:43:02 +0000 Received: (at 9867) by debbugs.gnu.org; 23 Aug 2019 08:42:44 +0000 Received: from localhost ([127.0.0.1]:39126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i159f-0002Qd-Od for submit@debbugs.gnu.org; Fri, 23 Aug 2019 04:42:43 -0400 Received: from mout.gmx.net ([212.227.15.18]:48321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i159d-0002QN-25 for 9867@debbugs.gnu.org; Fri, 23 Aug 2019 04:42:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566549752; bh=w/Snbc+uj9RAt/ROeCmnezr8taFlwJ5Bg8gh+7vz5Ec=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=X23QAOBkDZMZ1qNe+ysEeIdTz+idkkdirTMxfXpkox++elvl/uxwIeAteYUu/3MHP NC8vOLArbETUc8ECrXJyuJKUJEx5SJFsEi6uckclfqQgEsEdYv7vvLpQMiIC/7xBYy cP2tk1vcblMEizHsofXDhwDKeCytZ/HfpBipMcZg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.162.73.81]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKsnP-1hfyxp1sIX-00LEFt; Fri, 23 Aug 2019 10:42:32 +0200 References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> <8736hsd9qm.fsf@mouse.gnus.org> <70aa4943-eb2d-ffa2-b6ee-4638181d1920@gmx.at> <87a7c0cnn2.fsf@gnus.org> From: martin rudalics Message-ID: Date: Fri, 23 Aug 2019 10:42:32 +0200 MIME-Version: 1.0 In-Reply-To: <87a7c0cnn2.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:s4yYD+Z55jPslVqm9W8VaeQoaHYdZl6RTJ3ff8+CJ/xruNxvJOo 1/fvqEeCjq2ZKHCBEUVJeQDuBnPz3NVDTduRJGOFI+M9OgqhK2/Aqtphh7JcinUj3xFmgO8 uhhjp1NJck8C8GIgL6/EumRZBYXyBjYYh8AXKWWXDGu+QbPVLLg57ICpT467SFy1hk/DUsB SObWuVNW34l4/MOgfjIsw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TUsiFeWi1Ik=:KTD5P77qosuLc8RZnvD6Of rtbKYH1QINKSUcuzv82HPQtQ366FRYN00e7qIucp0tIiQDClcb/RA1AOD2NHk7FcjnHZXdB+v 51WdhFnA5ba4cQ0LzjojxmJ33fnRuEOR1WiizkMxi14rBcHCt6KY3JdHbLV6iXtnRU5ju0WBb bQo0IfTUOhAM0cXT0uELxljV8gak3J6iQBCjKN3SZiWBjsvSeyA+2OqMVHTJpzhIxCQoPNX3H cqrJDsy0eD7zvt+qgPJW5xA8UAJFWoP2UpNDwLKpF1z1oyLfOijy8A5nps1Q+6h/53XgNEjnL FdCOuunlXCbj4Ve102ql1qPrZd075/ysjrSv7yEJOPoawOMb4stWxZAn73QSHnvlbCnP0Upa2 SuPKfYHkONIo79nIyhpN1NDd69f8gHjCHkS06tL1kHb3kJZC5u2ok3A4b98PbjNHS7TNT70Qu ZQSCvNsA/WQ6G7NwT6bM69iJEkXtOTTzwB3Cy16iYYuo+YoNJA/N2cSAn+EPnN830b6DdFuu/ yJ2ApMxNQAtWLkd0HYBgbVnpaOrHusAJ8q40Sz6+t1omXdF7f/flBvH4Ehh2VCB4q6dNO7F5A vAtaqX9M0NHpag1xLdJyIODXbJEIkSfh4wQ4nYkir2zuc7nHpiQTsVEfs9XzGZ1cqfnDKF5gD j6BHHf6MRs8Kvlyb6pWsDlF4bS3sdQ1/UH5XnHhHexubsu7Cazk//FEApK/H1kMlOObJ9TXCv ay6YFy0KKEr77777Qk1UrFcxf4syD8vQRg26w4gFPI+gjQ3bZESf1yZiN40UPzqxQXHTbW0jB hIbPjLbfo/QXWsPJzIwRb96Kt0IVJNXqZLf+c3R/PZ55JU7kzlOXLHSNMpKEoaf/Hw3Dz1rsH e0Bc6wIAjz2Re5jKAd3rJkCnvXCZA5pNT1wpD3ZAAKQKilYVXO5TsYGShD4PPhUxa4v8oEW9v J0ofRO6VExWhlQI5UWvrK4CJ9W1lHyn7NZI6YN91EsIp+Xggw0IEEy8kTIxH5SZHY0Xslzt/9 IuvTAHB1RYvzdC3RYmYNXeUEfsnJTD1LuYcvZFr33+qqOjpHDbbeSMZG+KmC0PAoyXg1EMGm5 IpDULE8vCXLpzayPkPv3a0xPqeuygVvP6JQDO1lj9vhO9YZYLH6sxleUSaa8D9buOk2k38u80 KYzojqjogCLCRD2+GEs7P4YcQ5Vw8ov9CPJ8jV0jv2NLPbiw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > That's true, but is there a use case for the hook function having to > know what window it's quitting? I don't know. But you could replace 'with-current-buffer' with 'with-selected-window' to avoid worrying about that (and better check if WINDOW is not already selected before doing that internal state saving rigmarole). Or, as I suggested earlier, run the hook only when quitting the selected window. martin From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 05:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: martin rudalics Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156671068821671 (code B ref 9867); Sun, 25 Aug 2019 05:25:01 +0000 Received: (at 9867) by debbugs.gnu.org; 25 Aug 2019 05:24:48 +0000 Received: from localhost ([127.0.0.1]:43444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1l1E-0005dR-Fl for submit@debbugs.gnu.org; Sun, 25 Aug 2019 01:24:48 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1l1C-0005dI-G8 for 9867@debbugs.gnu.org; Sun, 25 Aug 2019 01:24:47 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1l16-0001Nj-25; Sun, 25 Aug 2019 07:24:42 +0200 From: Lars Ingebrigtsen References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> <8736hsd9qm.fsf@mouse.gnus.org> <70aa4943-eb2d-ffa2-b6ee-4638181d1920@gmx.at> <87a7c0cnn2.fsf@gnus.org> Date: Sun, 25 Aug 2019 07:24:39 +0200 In-Reply-To: (martin rudalics's message of "Fri, 23 Aug 2019 10:42:32 +0200") Message-ID: <87zhjxakbs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: martin rudalics writes: >> That's true, but is there a use case for the hook function having to >> know what window it's quitting? > > I don't know. But you could replace 'with-current-buffer' with > 'with-selected-window' t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: >> That's true, but is there a use case for the hook function having to >> know what window it's quitting? > > I don't know. But you could replace 'with-current-buffer' with > 'with-selected-window' to avoid worrying about that (and better check > if WINDOW is not already selected before doing that internal state > saving rigmarole). I wasn't aware of `with-selected-window' -- it sounds a bit dramatic. Does it have any side effects? > Or, as I suggested earlier, run the hook only when > quitting the selected window. That's possible, but the semantics become perhaps a bit complicated? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 08:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156672068921936 (code B ref 9867); Sun, 25 Aug 2019 08:12:02 +0000 Received: (at 9867) by debbugs.gnu.org; 25 Aug 2019 08:11:29 +0000 Received: from localhost ([127.0.0.1]:43548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1ncW-0005hj-Sv for submit@debbugs.gnu.org; Sun, 25 Aug 2019 04:11:29 -0400 Received: from mout.gmx.net ([212.227.17.22]:33951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1ncU-0005hV-J9 for 9867@debbugs.gnu.org; Sun, 25 Aug 2019 04:11:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566720677; bh=8h+tnwvrQiaYJ4ujNleTEHKiDAZpyTmFnTxMa/0DP8U=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=UIn9MT7/WrYqSXDsjXWVF1snqoMXlUbHEHjVMkNuVWjzGo4P4i8x+09mthIvjqSrL mIoE4I3Lx6zNUEStZ6pc+HVYxyO3ym+E1W65hXSut4DZESRzTTZMvkiqNfmTjtyMgx F/QnDdUMAStSAzrxZCdGidPF4oeDM0nu7T+hOkIA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.250.73]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M6730-1iPXXb3D34-00y91E; Sun, 25 Aug 2019 10:11:17 +0200 References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> <8736hsd9qm.fsf@mouse.gnus.org> <70aa4943-eb2d-ffa2-b6ee-4638181d1920@gmx.at> <87a7c0cnn2.fsf@gnus.org> <87zhjxakbs.fsf@gnus.org> From: martin rudalics Message-ID: <79f9288e-c518-3607-78a7-2e0e0939851d@gmx.at> Date: Sun, 25 Aug 2019 10:11:16 +0200 MIME-Version: 1.0 In-Reply-To: <87zhjxakbs.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:fxnJVdO5oXo3ktyfFZoWgcAs/Kbo2xYL9+ZWFY3jL5CLnocxjh1 wF0sMhiVZ9mAuNPPsSi84NiaANLvaphj0qHgkdMzShna4P1PlpiiqqRWRdQU2AoUrw/yylJ S89B5yJd6S27a+zujozJPxCEDs5dGqJiB1M4sXkaNqt9bueI03nwqNfhhpmlj+2Pf93T6Id 794XXZeaSAqVftDeSLmbw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6OuCTy78R4I=:NCYQ2U5kwedNp8rsCyok7F 5kweg12/n0JorA6DVA6zyGMiyi28qeJ8Pot+suPzO/Vy5jc5hHYh3rxmsJi+DcCi19dTrj49e ObhWUC4gnfxpKauWLmp8tEXoqBZ/ZFns2sNoAYyibXU55oWZ3UhvwfYDnEh1CR9zFH5nDj/Zy kuFDPLECKqNsWXpLIXDlFMXnR9icZjW1je3dAWuT7MohBWfLZDvOQwl73GjlwgfEmVo9gbHE1 WMO5dtPiVStAhxwyS8UZdSkJH0Ri4X9iyvIixnYL74lPsqoTjiwywZNg4LMW9741EBA8TwCnz DHJnfzg5ZSr8QIy8gEfJuBmpQQ0K1CMc0DdIlUpaNJ4laB0uJWciiguJVfaQ9EoEFiWkdAYkJ 7Nf9cTfnK6DzXp7U1LGSTEcLfK4JZyQmGEpiiAJzO8hbUMJsaSe8gGh9YkrMnOXHkeFDiOGp2 hWEtEZQDME0HqcH9AKPMTozPUmYLvuFDNKPhkq1ii+TewmwPiwAhl79XILcVRYPQpukgzyVZb zH73v718LXsknPuZTZhkvKCC7g36+82AraQQ6KCAPKMAzBodfwg/+eKzrfaPXhnHebeysmadz A7gAUIofQobCuaZKlFzxjgLGpTFubAX5QFUlm6ZoGfIv//mQY1EQoPHsiceGxvKUoY5qLzANR sfzRiy4AFblBCYI7KMVD3Xkf+jhj5BQ53BBbT6mIAtd6k2E7x+LklF3HUYZfu9JSWdopX7LFi 9q7T9DgA3DGeilxveBDl3Bm+wvQhCDq1RFD/2mJ/AaIl4oUoC2NpO2zqZwm0YAziWeN05FnWZ 1UcLmIMQcSd8YUs8U/77K9SpLNgqCxt/a6Flm6r5KLfIbJJhNzxJ5OTylFTbSb6NAbxgE4dk+ nfaDxPJFJDZgUd/9Sd/eGoeqtVkCZXMt0q6H6GYR8Dlp28r6rpwW3x9aH3ibofoQSzbfIs0D0 HcuzHZrE0nTkiXKc1XPa38S64g0pzc5WgfglpLvMX9Z2A40G7PE7WMumyrqAzG/zwyLKTXjpt 3pmfJnwkFP+fsOyfUbRxCYAcaS0Fh3TLOO7qwnjWgUa6SLorrKZzQR6++MmhLfLEufXWxcKev +5Sx/PP4lHNCPJ8Otu4rnaUFessXXU/E4MhiezvgCJocqZC5dA30FO95F+wgL7O0uar1uXzf3 +PELU= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I wasn't aware of `with-selected-window' -- it sounds a bit dramatic. > Does it have any side effects? Not normally. It's wrapped in an unwind protection form like 'with-current-buffer'. The following untested snippet should be (1) fairly optimal for the normal case where the selected window is quit and (2) guard against the case where the function run on the hook does soemthing unexpected with the window configuration: (let ((window (window-normalize-window window)) (buffer (window-buffer window))) (if (and (eq window (selected-window)) (eq buffer (current-buffer))) (run-hooks 'quit-window-hook) ;; Select WINDOW for `quit-window-hook'. (with-selected-window window (run-hooks 'quit-window-hook))) ;; Run 'quit-restore-window' only if 'quit-window-hook' has left ;; WINDOW alone. (when (and (window-live-p window) (eq (window-buffer window) buffer)) (quit-restore-window window (if kill 'kill 'bury)))) Something like (2) is needed, for example, when a function run by the hook kills WINDOW's buffer and 'kill-buffer' cleans up WINDOW by deleting it which in its turn would cause 'quit-restore-window' act on the window selected after 'replace-buffer-in-windows'. For an amusing example of why such a thing is necessary have a look at how often 'kill-buffer' checks whetheer the buffer it's supposed to kill is still alive. >> Or, as I suggested earlier, run the hook only when >> quitting the selected window. > > That's possible, but the semantics become perhaps a bit complicated? You would have to provide a somewhat disputable doc-string, indeed. martin From unknown Thu Aug 14 21:54:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Aug 2019 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: martin rudalics Cc: Christoph Scholtes , 9867@debbugs.gnu.org Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.15671580562513 (code B ref 9867); Fri, 30 Aug 2019 09:41:02 +0000 Received: (at 9867) by debbugs.gnu.org; 30 Aug 2019 09:40:56 +0000 Received: from localhost ([127.0.0.1]:53305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3dOp-0000eT-Sc for submit@debbugs.gnu.org; Fri, 30 Aug 2019 05:40:56 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3dOn-0000eH-2F for 9867@debbugs.gnu.org; Fri, 30 Aug 2019 05:40:54 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i3dOh-0000Lm-ID; Fri, 30 Aug 2019 11:40:50 +0200 From: Lars Ingebrigtsen References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> <8736hsd9qm.fsf@mouse.gnus.org> <70aa4943-eb2d-ffa2-b6ee-4638181d1920@gmx.at> <87a7c0cnn2.fsf@gnus.org> <87zhjxakbs.fsf@gnus.org> <79f9288e-c518-3607-78a7-2e0e0939851d@gmx.at> Date: Fri, 30 Aug 2019 11:40:46 +0200 In-Reply-To: <79f9288e-c518-3607-78a7-2e0e0939851d@gmx.at> (martin rudalics's message of "Sun, 25 Aug 2019 10:11:16 +0200") Message-ID: <87sgpjhty9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: martin rudalics writes: > Not normally. It's wrapped in an unwind protection form like > 'with-current-buffer'. The following untested snippet should be (1) > fairly optimal for the normal case where the selected window is q [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: > Not normally. It's wrapped in an unwind protection form like > 'with-current-buffer'. The following untested snippet should be (1) > fairly optimal for the normal case where the selected window is quit > and (2) guard against the case where the function run on the hook does > soemthing unexpected with the window configuration: > > (let ((window (window-normalize-window window)) > (buffer (window-buffer window))) > (if (and (eq window (selected-window)) > (eq buffer (current-buffer))) > (run-hooks 'quit-window-hook) > ;; Select WINDOW for `quit-window-hook'. > (with-selected-window window > (run-hooks 'quit-window-hook))) > ;; Run 'quit-restore-window' only if 'quit-window-hook' has left > ;; WINDOW alone. > (when (and (window-live-p window) > (eq (window-buffer window) buffer)) > (quit-restore-window window (if kill 'kill 'bury)))) I think the semantics of the command becomes rather muddled with this change. We currently provide no guarantees for what or how the hook function should do, or whether it basically disables the command if it changes the window and so on (which is what this change will do). If you think this should be what the semantics are, then I won't argue, so please feel free to go ahead and make whatever changes you want here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no