GNU bug report logs - #9853
24.0.90; gdb-version only set in non-stop mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9853 in the body.
You can then email your comments to 9853 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.90; gdb-version only set in non-stop mode
Date: Sun, 23 Oct 2011 18:33:50 -0400

The variable gdb-version is set in the function gdb-non-stop-handler, 
which is only called if gdb-non-stop is non-nil.  Given that 
gdb-non-stop-setting is customizable and may well be set to nil, 
wouldn't it make more sense to get the version some other way?  For 
instance, there's a GDB/MI command -gdb-version that could be used.

Also, the -enable-pretty-printing command is sent from 
gdb-non-stop-handler and so is only sent if gdb-non-stop is non-nil.  Is 
there a reason pretty-printing should only be enabled in non-stop mode.

Ken

Message #8 received at 9853 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: 9853 <at> debbugs.gnu.org
Subject: Re: bug#9853: 24.0.90; gdb-version only set in non-stop mode
Date: Wed, 26 Oct 2011 14:04:17 -0400

[Message part 1 (text/plain, inline)]

On 10/23/2011 6:33 PM, Ken Brown wrote:
> The variable gdb-version is set in the function gdb-non-stop-handler,
> which is only called if gdb-non-stop is non-nil. Given that
> gdb-non-stop-setting is customizable and may well be set to nil,
> wouldn't it make more sense to get the version some other way? For
> instance, there's a GDB/MI command -gdb-version that could be used.

After looking through gdb-mi.el more carefully, I see that emacs doesn't 
really need to know the GDB version.  So I withdraw my complaint.  But I 
think the variable gdb-version should probably be renamed to reflect its 
real purpose, perhaps to gdb-supports-non-stop.

> Also, the -enable-pretty-printing command is sent from
> gdb-non-stop-handler and so is only sent if gdb-non-stop is non-nil.

This still seems wrong, unless there's some reason that pretty-printing 
is only useful in non-stop mode.

The attached patch implements my suggestions (and also makes a couple of 
whitespace changes).

OK to apply?

Ken

[gdb-version.patch (text/plain, attachment)]

Message #13 received at 9853-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: 9853-done <at> debbugs.gnu.org
Subject: Re: bug#9853: 24.0.90; gdb-version only set in non-stop mode
Date: Tue, 29 Nov 2011 22:29:53 -0500

On 10/26/2011 2:04 PM, Ken Brown wrote:
> The attached patch implements my suggestions (and also makes a couple of
> whitespace changes).
>
> OK to apply?

Patch applied.  Closing bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.