GNU bug report logs - #9841
23.3; rmail-edit-current-message adds extra '>'s to Froms...

Previous Next

Package: emacs;

Reported by: mark.lillibridge <at> hp.com

Date: Sat, 22 Oct 2011 19:08:02 UTC

Severity: normal

Found in version 23.3

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#9841: closed (23.3; rmail-edit-current-message adds extra
 '>'s to Froms...)
Date: Fri, 07 Dec 2012 09:05:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 07 Dec 2012 04:03:58 -0500
with message-id <l58v9afd35.fsf <at> fencepost.gnu.org>
and subject line Re: bug#9841: 23.3; rmail-edit-current-message adds extra '>'s to Froms...
has caused the debbugs.gnu.org bug report #9841,
regarding 23.3; rmail-edit-current-message adds extra '>'s to Froms...
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
9841: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9841
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mark Lillibridge <mark.lillibridge <at> hp.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.3; rmail-edit-current-message adds extra '>'s to Froms...
Date: Sat, 22 Oct 2011 12:05:57 -0700
Start with a Rmail message (this one will do) not containing MIME that
contains lines like the following:

>From level 1
>>From level 2
>>>From level 3

Hit 'e' to edit the message.  Notice that nothing changes.  Now hit ^c^c
or ^c^] to stop editing (the later is supposed to abort, leaving the
message unchanged).  Notice that your message now has one more > in
front of each of the from lines:

>>From level 1
>>>From level 2
>>>>From level 3

You can repeat this as many times as you like, adding more and more >'s.


Towards a patch, I notice that rmail-cease-edit has the following code:

rmailedit.el:135:
  ;; Disguise any "From " lines so they don't start a new message.
  (goto-char (point-min))
  (or rmail-old-pruned (forward-line 1))
  (while (re-search-forward "^>*From " nil t)
    (beginning-of-line)
    (insert ">")
    (forward-line))

There is no corresponding code in the rmail-edit-current-message or the
viewing code that I can find.


    This probably needs more thought, but I think the decode code should
remove one >, and the incorporate new messages and done editting code
should add one > (as above).  Note this is related to bug #6574: Rmail
23 uses a broken mailbox format (mboxo) instead of a sane one like
mboxrd.

    I note that fetchmail to mbox loses information because it only adds
a > to From's without one already.  This is arguably not Rmail's fault,
however.

- Mark


[Message part 3 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 9841-done <at> debbugs.gnu.org
Subject: Re: bug#9841: 23.3;
	rmail-edit-current-message adds extra '>'s to Froms...
Date: Fri, 07 Dec 2012 04:03:58 -0500
Version: 24.4

Mark Lillibridge wrote:

> Start with a Rmail message (this one will do) not containing MIME that
> contains lines like the following:

Actually, I can only reproduce this with a message that _is_ MIME, ie
has a "MIME-version: 1.0" header (which almost everything does).
For non-MIME messages, rmail-show-message-1 _does_ add >, which is
why rmail-cease-edit tries to put them back. Anyway, I installed a
change to make it not do that for MIME messages, which have not been
unescaped during display.


This bug report was last modified 12 years and 198 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.