GNU bug report logs - #9824
Info fails to follow multi-line links to manuals with dots

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> jurta.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#9824: closed (Info fails to follow multi-line links to
 manuals with dots)
Date: Mon, 24 Oct 2011 05:53:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 24 Oct 2011 08:47:52 +0300
with message-id <87pqhnc54n.fsf <at> mail.jurta.org>
and subject line Re: bug#9824: Info fails to follow multi-line links to manuals with dots
has caused the debbugs.gnu.org bug report #9824,
regarding Info fails to follow multi-line links to manuals with dots
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
9824: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9824
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Info fails to follow multi-line links to manuals with dots
Date: Fri, 21 Oct 2011 17:10:27 +0300

For example, clicking on the following link fails to navigate to another
Info manual:

  languages, are documented in a separate manual.  *Note Introduction:
  (gccint-4.4)Top.

because a regexp for leading space in `Info-following-node-name-re'
doesn't take into account multi-line case.

Links to manuals without dots in the file name currently work
just by accident, e.g. clicking on:

  are performed by running the function.  *Note What Is a Function:
  (elisp)What Is a Function.

works because the regexp for unallowed chars in node names
doesn't contain parens (but contains dots) and matches everything
including file names (without dots).

This is wrong but I hesitate to make the regexp more restrictive
by disallowing parens in node names because Info currently using
regexp matching extensively is very brittle.

The following patch makes the regexp for leading space more permissive
by allowing newlines in leading space:

=== modified file 'lisp/info.el'
--- lisp/info.el	2011-09-24 19:18:43 +0000
+++ lisp/info.el	2011-10-21 14:10:04 +0000
@@ -2020,7 +2020,7 @@ (defun Info-following-node-name-re (&opt
 Submatch 2 if non-nil is the parenthesized file name part of the node name.
 Submatch 3 is the local part of the node name.
 End of submatch 0, 1, and 3 are the same, so you can safely concat."
-  (concat "[ \t]*"			;Skip leading space.
+  (concat "[ \t\n]*"			;Skip leading space.
 	  "\\(\\(([^)]+)\\)?"	;Node name can start with a file name.
 	  "\\([" (or allowedchars "^,\t\n") "]*" ;Any number of allowed chars.
 	  "[" (or allowedchars "^,\t\n") " ]" ;The last char can't be a space.

[Message part 3 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 9824-done <at> debbugs.gnu.org
Subject: Re: bug#9824: Info fails to follow multi-line links to manuals with
	dots
Date: Mon, 24 Oct 2011 08:47:52 +0300

>> The following patch makes the regexp for leading space more permissive
>> by allowing newlines in leading space:
>
> Looks acceptable,

Installed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.