From unknown Sat Sep 13 08:55:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9814 <9814@debbugs.gnu.org> To: bug#9814 <9814@debbugs.gnu.org> Subject: Status: 23.3; unguarded setq of default-directory in ido.el Reply-To: bug#9814 <9814@debbugs.gnu.org> Date: Sat, 13 Sep 2025 15:55:31 +0000 retitle 9814 23.3; unguarded setq of default-directory in ido.el reassign 9814 emacs submitter 9814 Dave Abrahams severity 9814 normal tag 9814 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 15:40:35 2011 Received: (at submit) by debbugs.gnu.org; 20 Oct 2011 19:40:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGyTi-0004jC-Gq for submit@debbugs.gnu.org; Thu, 20 Oct 2011 15:40:34 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGyTf-0004ip-NT for submit@debbugs.gnu.org; Thu, 20 Oct 2011 15:40:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGySR-0005HV-Ef for submit@debbugs.gnu.org; Thu, 20 Oct 2011 15:39:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:53568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGySR-0005HH-B0 for submit@debbugs.gnu.org; Thu, 20 Oct 2011 15:39:15 -0400 Received: from eggs.gnu.org ([140.186.70.92]:46099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGySP-0005LA-77 for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2011 15:39:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGySN-0005Fy-5Q for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2011 15:39:13 -0400 Received: from mail-qy0-f169.google.com ([209.85.216.169]:42670) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGySN-0005Fj-1c for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2011 15:39:11 -0400 Received: by qyk29 with SMTP id 29so5024123qyk.0 for ; Thu, 20 Oct 2011 12:39:10 -0700 (PDT) Received: by 10.229.42.208 with SMTP id t16mr2685843qce.135.1319139549901; Thu, 20 Oct 2011 12:39:09 -0700 (PDT) Received: from pluto.luannocracy.com (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com. [207.172.223.249]) by mx.google.com with ESMTPS id df3sm1254363qab.6.2011.10.20.12.39.08 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 20 Oct 2011 12:39:09 -0700 (PDT) Received: by pluto.luannocracy.com (Postfix, from userid 501) id 5C30C115E4E9; Thu, 20 Oct 2011 15:39:08 -0400 (EDT) From: Dave Abrahams To: bug-gnu-emacs@gnu.org Subject: 23.3; unguarded setq of default-directory in ido.el Date: Thu, 20 Oct 2011 14:53:48 -0400 User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) I'm sorry that I don't have a reproducer at the moment. I was having some failures during startup that would leave my Emacs unable to change buffers with `M-x switch-to-buffer', which was remapped to ido-switch-buffer, because it would attempt to make a Tramp connection to some nonexistent host. I could get around this by `M-: (setq default-directory "~")', so I went hunting in ido.el for mentions of default-directory and found 2 instances of (setq default-directory...) that were not apparently surrounded by a let. This seems like a likely cause of the problem. In GNU Emacs 23.3.1 (x86_64-apple-darwin10.8.0, Carbon Version 1.6.0 AppKit 1038.36) of 2011-09-12 on pluto.luannocracy.com Windowing system distributor `Apple Inc.', version 10.6.8 configured using `configure '--with-mac' '--enable-mac-app' '--prefix=/usr/local/stow/emacs-23.3' 'CC=gcc -arch x86_64'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: highlight-changes-visible-mode: t diff-auto-refine-mode: t recentf-mode: t pretty-control-l-mode: t Info-breadcrumbs-in-mode-line-mode: t workgroups-mode: t shell-dirtrack-mode: t me-minor-mode: t show-paren-mode: t ido-everywhere: t global-auto-revert-mode: t display-time-mode: t delete-selection-mode: t tooltip-mode: t mac-mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 01:45:48 2011 Received: (at 9814) by debbugs.gnu.org; 29 Oct 2011 05:45:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RK1jn-0008Lc-Op for submit@debbugs.gnu.org; Sat, 29 Oct 2011 01:45:48 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RK1jk-0008LU-Nn for 9814@debbugs.gnu.org; Sat, 29 Oct 2011 01:45:45 -0400 Received: from [155.69.18.173] (port=56658 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RK1hp-0003Wj-CD; Sat, 29 Oct 2011 01:43:46 -0400 From: Chong Yidong To: Dave Abrahams Subject: Re: bug#9814: 23.3; unguarded setq of default-directory in ido.el References: Date: Sat, 29 Oct 2011 13:43:39 +0800 In-Reply-To: (Dave Abrahams's message of "Thu, 20 Oct 2011 14:53:48 -0400") Message-ID: <8739ecuzck.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 9814 Cc: 9814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Dave Abrahams writes: > I'm sorry that I don't have a reproducer at the moment. I was having > some failures during startup that would leave my Emacs unable to change > buffers with `M-x switch-to-buffer', which was remapped to > ido-switch-buffer, because it would attempt to make a Tramp connection > to some nonexistent host. I could get around this by `M-: (setq > default-directory "~")', so I went hunting in ido.el for mentions of > default-directory and found 2 instances of (setq default-directory...) > that were not apparently surrounded by a let. This seems like a likely > cause of the problem. I'm not too familiar with ido, and do not know whether those setqs are intentional. Could you try let-binding default-directory in those locations and test it out for a while, and see if there is any effect? === modified file 'lisp/ido.el' *** lisp/ido.el 2011-10-26 08:42:22 +0000 --- lisp/ido.el 2011-10-29 05:42:48 +0000 *************** *** 2381,2389 **** ((eq method 'alt-file) (ido-record-work-file filename) ! (setq default-directory ido-current-directory) ! (ido-record-work-directory) ! (find-alternate-file filename)) ((memq method '(dired list-directory)) (if (equal filename ".") --- 2381,2389 ---- ((eq method 'alt-file) (ido-record-work-file filename) ! (let ((default-directory ido-current-directory)) ! (ido-record-work-directory) ! (find-alternate-file filename))) ((memq method '(dired list-directory)) (if (equal filename ".") *************** *** 2421,2432 **** ((eq method 'write) (ido-record-work-file filename) ! (setq default-directory ido-current-directory) ! (setq filename (concat ido-current-directory filename)) ! (ido-record-command 'write-file filename) ! (add-to-history 'file-name-history filename) ! (ido-record-work-directory) ! (write-file filename t)) ((eq method 'read-only) (ido-record-work-file filename) --- 2421,2432 ---- ((eq method 'write) (ido-record-work-file filename) ! (let ((default-directory ido-current-directory)) ! (setq filename (concat ido-current-directory filename)) ! (ido-record-command 'write-file filename) ! (add-to-history 'file-name-history filename) ! (ido-record-work-directory) ! (write-file filename t))) ((eq method 'read-only) (ido-record-work-file filename) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 15:37:04 2011 Received: (at 9814) by debbugs.gnu.org; 31 Oct 2011 19:37:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKxfM-0006Fa-5C for submit@debbugs.gnu.org; Mon, 31 Oct 2011 15:37:04 -0400 Received: from mail-vx0-f172.google.com ([209.85.220.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKxfJ-0006FA-At for 9814@debbugs.gnu.org; Mon, 31 Oct 2011 15:37:02 -0400 Received: by vcbfo1 with SMTP id fo1so5088988vcb.3 for <9814@debbugs.gnu.org>; Mon, 31 Oct 2011 12:34:47 -0700 (PDT) Received: by 10.220.108.141 with SMTP id f13mr2507502vcp.211.1320089687766; Mon, 31 Oct 2011 12:34:47 -0700 (PDT) Received: from pluto.local (129-134-58-66.gci.net. [66.58.134.129]) by mx.google.com with ESMTPS id j4sm11231336vdk.5.2011.10.31.12.34.46 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 31 Oct 2011 12:34:47 -0700 (PDT) Received: by pluto.local (Postfix, from userid 501) id DD77B1237416; Mon, 31 Oct 2011 11:24:18 -0800 (AKDT) From: Dave Abrahams To: Chong Yidong Subject: Re: bug#9814: 23.3; unguarded setq of default-directory in ido.el References: <8739ecuzck.fsf@gnu.org> Date: Mon, 31 Oct 2011 11:24:18 -0800 In-Reply-To: <8739ecuzck.fsf@gnu.org> (Chong Yidong's message of "Sat, 29 Oct 2011 13:43:39 +0800") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 9814 Cc: 9814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) on Fri Oct 28 2011, Chong Yidong wrote: > Dave Abrahams writes: > >> I'm sorry that I don't have a reproducer at the moment. I was having >> some failures during startup that would leave my Emacs unable to change >> buffers with `M-x switch-to-buffer', which was remapped to >> ido-switch-buffer, because it would attempt to make a Tramp connection >> to some nonexistent host. I could get around this by `M-: (setq >> default-directory "~")', so I went hunting in ido.el for mentions of >> default-directory and found 2 instances of (setq default-directory...) >> that were not apparently surrounded by a let. This seems like a likely >> cause of the problem. > > I'm not too familiar with ido, and do not know whether those setqs are > intentional. Could you try let-binding default-directory in those > locations and test it out for a while, and see if there is any effect? I've made the changes... I guess the best report you can expect, unless I get myself into trouble at startup again, is that it has no effect. Will you check back with me in a week? -- Dave Abrahams BoostPro Computing http://www.boostpro.com From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 00:46:57 2013 Received: (at 9814-done) by debbugs.gnu.org; 9 Jul 2013 04:46:57 +0000 Received: from localhost ([127.0.0.1]:40856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwPpI-00041P-9Q for submit@debbugs.gnu.org; Tue, 09 Jul 2013 00:46:56 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:32852) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwPpG-000415-5a for 9814-done@debbugs.gnu.org; Tue, 09 Jul 2013 00:46:54 -0400 Received: by mail-pd0-f178.google.com with SMTP id w11so4833860pde.37 for <9814-done@debbugs.gnu.org>; Mon, 08 Jul 2013 21:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=7mRThLgTEtvv5I4PN7I5rb052yG6BkNrZb73BGja374=; b=Bm4jQ65uDReqBokoDYi7dJTtffsRwPlPStxTUkJdQuY5iS9sFX8hiBw6lHiw4dzoWO ksj+nCfkRTKDXL8tjUM5VwsIiwXkESiRfWNWMArSCjXODQvhoSkbmxLeYDKfIIz5JLKG iw61NzvYUKfRb5UZQouf5jSJGv3RNSuyBZKIfsZbI539XJsN+h1pHhUEygojck++JkUx 9xLb9DDTH2hewGkrfH2xdi7pcY/3ChaB3wyyfuVI3nj6TU8VkdWcl4ia3NZErVt4Qjud N8H3/yF6BFRGppJVrkFItKBeDy5dvK7r4NOQ23bFMJtsSpq2mNi7TOpOXavB8WFjIp6C mMiA== X-Received: by 10.68.101.34 with SMTP id fd2mr24864699pbb.137.1373345208370; Mon, 08 Jul 2013 21:46:48 -0700 (PDT) Received: from Zeuss-MacBook.local ([182.48.101.29]) by mx.google.com with ESMTPSA id dj5sm25878490pbc.25.2013.07.08.21.46.46 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 08 Jul 2013 21:46:47 -0700 (PDT) From: Leo Liu To: Dave Abrahams Subject: Re: bug#9814: 23.3; unguarded setq of default-directory in ido.el References: <8739ecuzck.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Tue, 09 Jul 2013 12:46:26 +0800 In-Reply-To: (Dave Abrahams's message of "Mon, 31 Oct 2011 11:24:18 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.4) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 9814-done Cc: Chong Yidong , 9814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 2011-11-01 03:24 +0800, Dave Abrahams wrote: > I've made the changes... I guess the best report you can expect, unless > I get myself into trouble at startup again, is that it has no effect. > Will you check back with me in a week? I believe this bug might have been fixed already. It might have something to do with ido-may-cache-directory trying tramp hosts. Leo From unknown Sat Sep 13 08:55:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 06 Aug 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator