Subject: bug#9802: closed (Re: bug#9802: 23.3; missing key binding for rmail-summary-by-senders in Rmail [PATCH])

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 28 Oct 2011 02:53:02 +0000

Your bug report

#9802: 23.3; missing key binding for rmail-summary-by-senders in Rmail [PATCH]

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
9802: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9802
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#9802: 23.3; missing key binding for rmail-summary-by-senders in Rmail [PATCH]
From: Stefan Monnier <[email-masked]>
To: [email-masked]
Cc: [email-masked]
Date: Thu, 27 Oct 2011 22:50:43 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

> You'll notice that a binding for C-M-f to rmail-summary-by-senders
> (added recently) is missing from Rmail mode.
[...]
> A simple patch to fix this is:

Thanks, installed,

        Stefan

Subject: 23.3; missing key binding for rmail-summary-by-senders in Rmail [PATCH]
From: Mark Lillibridge <[email-masked]>
To: [email-masked]
Date: Wed, 19 Oct 2011 20:04:15 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

Compare the key bindings in Rmail summary mode:

C-M-f		rmail-summary-by-senders
C-M-h		rmail-summary
C-M-l		rmail-summary-by-labels
C-M-n		rmail-summary-next-labeled-message
C-M-p		rmail-summary-previous-labeled-message
C-M-r		rmail-summary-by-recipients
C-M-s		rmail-summary-by-regexp
C-M-t		rmail-summary-by-topic

to those of Rmail mode:

C-M-h		rmail-summary
C-M-l		rmail-summary-by-labels
C-M-n		rmail-next-labeled-message
C-M-p		rmail-previous-labeled-message
C-M-r		rmail-summary-by-recipients
C-M-s		rmail-summary-by-regexp
C-M-t		rmail-summary-by-topic

You'll notice that a binding for C-M-f to rmail-summary-by-senders
(added recently) is missing from Rmail mode.

(C-M-f is normally bound to forward-sexp, which is not very useful in
Rmail mode.)

A simple patch to fix this is:

ts-rhel5 [128]% ( setenv LC_ALL C ; setenv TZ UTC0 ; diff -Naur original-rmail.el rmail.el )
--- original-rmail.el   2011-02-23 23:23:08.000000000 +0000
+++ rmail.el    2011-10-20 02:51:29.845136000 +0000
@@ -1018,6 +1018,7 @@
     (define-key map "\e\C-l" 'rmail-summary-by-labels)
     (define-key map "\e\C-r" 'rmail-summary-by-recipients)
     (define-key map "\e\C-s" 'rmail-summary-by-regexp)
+    (define-key map "\e\C-f" 'rmail-summary-by-senders)
     (define-key map "\e\C-t" 'rmail-summary-by-topic)
     (define-key map "m"      'rmail-mail)
     (define-key map "\em"    'rmail-retry-failure)

- Mark
PS, rmail-summary-by-senders does not appear to be documented in the
documentation for rmail-summary-mode or rmail-mode; you may want to fix
that as well.