From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2011 06:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9781@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.131891990511190 (code B ref -1); Tue, 18 Oct 2011 06:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Oct 2011 06:38:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3Jg-0002uR-Ix for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:38:24 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3Jc-0002uB-NG for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG3IY-00048H-H9 for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:37:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:57963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IY-00048D-Fd for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:37:14 -0400 Received: from eggs.gnu.org ([140.186.70.92]:40279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IS-00066B-OX for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG3IL-00046W-TA for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:08 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]:33165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IL-00046D-Ix for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:01 -0400 Received: from iph3.telenor.se (iph3.telenor.se [195.54.127.134]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id CDAADEA111 for ; Tue, 18 Oct 2011 08:36:59 +0200 (CEST) X-SENDER-IP: [85.225.45.201] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AphiAHsdnU5V4S3JPGdsb2JhbABDiTyfHhkBAQEBNzKBbgFAHBMBBDteDApLh2OWOqAkgyuDfGEEmSaMLg X-IronPort-AV: E=Sophos;i="4.69,363,1315173600"; d="scan'208";a="132478265" Received: from c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.201]) by iph3.telenor.se with ESMTP; 18 Oct 2011 08:36:59 +0200 Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 0DB617FA058 for ; Tue, 18 Oct 2011 08:36:59 +0200 (CEST) From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Date: Tue, 18 Oct 2011 08:36:58 +0200 Message-Id: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> Mime-Version: 1.0 (Apple Message framework v1251.1) X-Mailer: Apple Mail (2.1251.1) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) This bug report will be sent to the Bug-GNU-Emacs mailing list and the GNU bug tracker at debbugs.gnu.org. Please check that the From: line contains a valid email address. After a delay of up to one day, you should receive an acknowledgement at that address. Please write in English if possible, as the Emacs maintainers usually do not have translators for other languages. Please describe exactly what actions triggered the bug, and the precise symptoms of the bug. If you can, give a recipe starting from `emacs -Q': I'm surprised nobody has seen this. In a bzr repository, do % bzr rm some-file and modify some other file. Then in Emacs, do vc-dir on the directory where the file was. Mark the file that is listed as removed. Also mark the edited file. Press v. Expected result: I can type in a log message and commit. Real result: A prompt in the minibuffer appears: some-file is edited but read-only; make it writable and continue? (y/n)=20= This is because in vc.el, vc-next-action there is this: (let ((ready-for-commit files)) ;; If files are edited but read-only, give user a chance to = correct (dolist (file files) (unless (file-writable-p file) ;; Make the file+buffer read-write. (unless (y-or-n-p (format "%s is edited but read-only; make = it writable and continue? " file)) (error "Aborted")) ;; Maybe we somehow lost permissions on the directory. (condition-case nil (set-file-modes file (logior (file-modes file) 128)) (error (error "Unable to make file writable"))) Files/directories that are removed are obviously not file-writable-p, so = the logic is wrong. Also, the choices in the question should be three: 1 Make writable and continue. 2 Don't make writable and continue 3 Abort As it is now, you either exit on the "Aborted" error or if you try to = continue on the "Unable to make file writable" error. Jan D. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /Users/jhd/Applications/Emacs.app/Contents/Resources/etc/DEBUG. In GNU Emacs 24.0.90.1 (x86_64-apple-darwin11.2.0, NS = apple-appkit-1138.23) of 2011-10-18 on zeplin Windowing system distributor `Apple', version 10.3.1138 configured using `configure '--verbose' '--enable-asserts' '--with-ns' = '--without-x-toolkit' 'CFLAGS=3D-g'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: C value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: sv_SE.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: desktop-save-mode: t delete-selection-mode: t icomplete-mode: t display-time-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: x r e p o r t - e m Recent messages: Loading /Users/jhd/lib/elisp/BAK-file.el (source)...done Loading /Users/jhd/lib/elisp/ccsetup.el (source)...done Loading icomplete...done Loading desktop...done No desktop file. For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug desktop cus-start cus-load msb delsel advice help-fns advice-preload icomplete cc-mode cc-fonts easymenu cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs regexp-opt time time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process ns multi-tty emacs) From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2011 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Cc: 9781@debbugs.gnu.org Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.131892120813138 (code B ref 9781); Tue, 18 Oct 2011 07:01:02 +0000 Received: (at 9781) by debbugs.gnu.org; 18 Oct 2011 07:00:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3eg-0003Pp-Hw for submit@debbugs.gnu.org; Tue, 18 Oct 2011 03:00:07 -0400 Received: from fencepost.gnu.org ([140.186.70.10] ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3ec-0003PP-Kx for 9781@debbugs.gnu.org; Tue, 18 Oct 2011 03:00:04 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RG3dh-0007j2-TK; Tue, 18 Oct 2011 02:59:05 -0400 From: Glenn Morris References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> X-Spook: TELINT Etacs Ceridian SCUD missile blackjack Afghanistan X-Ran: >p|n0iX(CZrX\T/9'b!C]n1Tj,S:/_Si$\}4.qyrVCb;M/rYDy7}2c9oUxq*.@1v0w~kh= X-Hue: red X-Attribution: GM Date: Tue, 18 Oct 2011 02:59:05 -0400 In-Reply-To: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> ("Jan =?UTF-8?Q?Dj=C3=A4rv?="'s message of "Tue, 18 Oct 2011 08:36:58 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Jan Dj=C3=A4rv wrote: > I'm surprised nobody has seen this. It is a long-known issue that vc-dir does not handle removed files totally correctly, though I haven't seen the particular symptoms you describe. http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D3214 From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Oct 2011 07:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: Jan =?UTF-8?Q?Dj=C3=A4rv?= , 9781@debbugs.gnu.org Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.131900772927171 (code B ref 9781); Wed, 19 Oct 2011 07:03:01 +0000 Received: (at 9781) by debbugs.gnu.org; 19 Oct 2011 07:02:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGQAB-00074A-Oi for submit@debbugs.gnu.org; Wed, 19 Oct 2011 03:02:09 -0400 Received: from fencepost.gnu.org ([140.186.70.10] ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGQA9-000742-35 for 9781@debbugs.gnu.org; Wed, 19 Oct 2011 03:02:06 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RGQ98-0000y6-G7; Wed, 19 Oct 2011 03:01:02 -0400 From: Dan Nicolaescu References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> Date: Wed, 19 Oct 2011 03:01:01 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 18 Oct 2011 02:59:05 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.5 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Glenn Morris writes: > Jan Dj=C3=A4rv wrote: > >> I'm surprised nobody has seen this. > > It is a long-known issue that vc-dir does not handle removed files > totally correctly, The problem is in the vc-bzr backend. vc-bzr-status should return nil when called for a file that has been removed. It does not. Also it looks like there's a disconnect between=20 bzr help status [snip] unknown Not versioned and not matching an ignore pattern. and the actual output: bzr status NON_EXISTENT_FILE nonexistent: NON_EXISTENT_FILE bzr: ERROR: Path(s) do not exist: NON_EXISTENT_FILE Exit 3 From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. In-Reply-To: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Oct 2011 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Cc: 9781@debbugs.gnu.org Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.131914479625977 (code B ref 9781); Thu, 20 Oct 2011 21:07:02 +0000 Received: (at 9781) by debbugs.gnu.org; 20 Oct 2011 21:06:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGzox-0006kw-Nb for submit@debbugs.gnu.org; Thu, 20 Oct 2011 17:06:35 -0400 Received: from fencepost.gnu.org ([140.186.70.10] ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGzow-0006kp-2u for 9781@debbugs.gnu.org; Thu, 20 Oct 2011 17:06:35 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RGznm-0001uD-2n; Thu, 20 Oct 2011 17:05:22 -0400 From: Glenn Morris References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> X-Spook: secure Fedayeen nitrate codes sniper pink noise morse UFO X-Ran: '?8-f"0niCZ!$Blrs%kNR[MYlf}`Kp(?uqX>Y!/UO7AOy''}i^1M X-Hue: red X-Attribution: GM Date: Thu, 20 Oct 2011 17:05:21 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Jan Dj=C3=A4rv wrote: > In a bzr repository, do > % bzr rm some-file > > and modify some other file. > > Then in Emacs, do vc-dir on the directory where the file was. > Mark the file that is listed as removed. Also mark the edited file. > Press v. > > Expected result: I can type in a log message and commit. > Real result: A prompt in the minibuffer appears: > some-file is edited but read-only; make it writable and continue? (y/n)=20 Fixed. Now you will be able to commit (and then get bug#3214). Actually the problem only happens with removed directories (because file-writable-p also returns non-nil if a file can be created). Recipe: mkdir /tmp/foo cd /tmp/foo bzr init mkdir subdir touch file subdir/subfile bzr add bzr commit -m "c1" bzr remove subdir echo 1 >> file emacs -Q M-x vc-dir RET M v > Also, the choices in the question should be three: > > 1 Make writable and continue. > 2 Don't make writable and continue > 3 Abort Isn't ctrl-g good enough for aborting, rather than introducing a 3-state question? From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Oct 2011 21:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Cc: 9781@debbugs.gnu.org Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.131914506726389 (code B ref 9781); Thu, 20 Oct 2011 21:12:02 +0000 Received: (at 9781) by debbugs.gnu.org; 20 Oct 2011 21:11:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGztL-0006ra-BA for submit@debbugs.gnu.org; Thu, 20 Oct 2011 17:11:07 -0400 Received: from fencepost.gnu.org ([140.186.70.10] ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGztJ-0006rT-Ft for 9781@debbugs.gnu.org; Thu, 20 Oct 2011 17:11:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RGzsA-00022G-NP; Thu, 20 Oct 2011 17:09:54 -0400 From: Glenn Morris References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> X-Spook: condor industrial intelligence Guantanamo bomb Dateline X-Ran: Bd!-.1~|k/w{AG (Glenn Morris's message of "Thu, 20 Oct 2011 17:05:21 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Glenn Morris wrote: >> 1 Make writable and continue. >> 2 Don't make writable and continue >> 3 Abort > > Isn't ctrl-g good enough for aborting, rather than introducing a 3-state > question? Ignore that, I misunderstood option 2. "Don't make writable, but continue committing anyway." (Will that cause an error with whatever VCS this issue is still relevant for?) From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Oct 2011 09:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: "9781@debbugs.gnu.org" <9781@debbugs.gnu.org> Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.131918852524852 (code B ref 9781); Fri, 21 Oct 2011 09:16:02 +0000 Received: (at 9781) by debbugs.gnu.org; 21 Oct 2011 09:15:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RHBCH-0006Sn-17 for submit@debbugs.gnu.org; Fri, 21 Oct 2011 05:15:25 -0400 Received: from smtprelay-h22.telenor.se ([195.54.99.197]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RHBCE-0006Sa-Qt for 9781@debbugs.gnu.org; Fri, 21 Oct 2011 05:15:23 -0400 Received: from iph3.telenor.se (iph3.telenor.se [195.54.127.134]) by smtprelay-h22.telenor.se (Postfix) with ESMTP id 3E833E9838 for <9781@debbugs.gnu.org>; Fri, 21 Oct 2011 11:14:03 +0200 (CEST) X-SENDER-IP: [85.225.45.201] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjhDAJM3oU5V4S3JPGdsb2JhbABDhHWER55pdhkBAQEBNzKBbgEBBAEjMyMQCwQBCTQCAi0MChQGE4gAAqJ2kW6HFTNhBJkqjC8 X-IronPort-AV: E=Sophos;i="4.69,384,1315173600"; d="scan'208,217";a="134391716" Received: from c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.201]) by iph3.telenor.se with ESMTP; 21 Oct 2011 11:14:03 +0200 Received: from [10.225.40.63] (unknown [193.45.43.33]) by coolsville.localdomain (Postfix) with ESMTPSA id 00C177FA058; Fri, 21 Oct 2011 11:14:02 +0200 (CEST) References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: 7bit Content-Type: multipart/alternative; boundary=Apple-Mail-D523C0A5-BD6E-4F22-895D-EBCD7E7DBD1E Message-Id: <68250520-33B2-43EE-893B-421ACCCCD9A9@swipnet.se> X-Mailer: iPhone Mail (9A334) From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Date: Fri, 21 Oct 2011 11:13:58 +0200 X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.4 (-) --Apple-Mail-D523C0A5-BD6E-4F22-895D-EBCD7E7DBD1E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hello. 20 okt 2011 kl. 23:05 skrev Glenn Morris : >=20 > Fixed. Now you will be able to commit (and then get bug#3214). >=20 > Actually the problem only happens with removed directories (because > file-writable-p also returns non-nil if a file can be created). I was indeed removing a directory. >=20 >=20 >> Also, the choices in the question should be three: >>=20 >> 1 Make writable and continue. >> 2 Don't make writable and continue >> 3 Abort >=20 > Isn't ctrl-g good enough for aborting, rather than introducing a 3-state > question? I wanted 2, that option was not available. Only 1 and 3 could be choosen. C= trl-g also does 3. Jan D. --Apple-Mail-D523C0A5-BD6E-4F22-895D-EBCD7E7DBD1E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Hello.


20 okt 2011 kl. 23:05 skrev Glenn Morris <rgm@gnu.org>:


Fixed. Now you will be able to commit (and then get bug#3214).
<= span>
Actually the problem only happens with removed directo= ries (because
file-writable-p also returns non-nil if a file= can be created).

I was indeed r= emoving a directory.



Also, the choices in the question shoul= d be three:
1 Make writable and continue.=
2 Don't make writabl= e and continue
3 Abor= t

Isn't ctrl-g good enough for= aborting, rather than introducing a 3-state
question?

I wanted 2, that option was not available. Only 1 and 3= could be choosen.  Ctrl-g also does 3.

 =  Jan D.

= --Apple-Mail-D523C0A5-BD6E-4F22-895D-EBCD7E7DBD1E-- From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Oct 2011 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: "9781@debbugs.gnu.org" <9781@debbugs.gnu.org> Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.131918864525054 (code B ref 9781); Fri, 21 Oct 2011 09:18:01 +0000 Received: (at 9781) by debbugs.gnu.org; 21 Oct 2011 09:17:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RHBEC-0006W2-OJ for submit@debbugs.gnu.org; Fri, 21 Oct 2011 05:17:25 -0400 Received: from smtprelay-b11.telenor.se ([62.127.194.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RHBE9-0006Vl-SQ for 9781@debbugs.gnu.org; Fri, 21 Oct 2011 05:17:22 -0400 Received: from iph2.telenor.se (iph2.telenor.se [195.54.127.133]) by smtprelay-b11.telenor.se (Postfix) with ESMTP id B549BEAA82 for <9781@debbugs.gnu.org>; Fri, 21 Oct 2011 11:16:02 +0200 (CEST) X-SENDER-IP: [85.225.45.201] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AixDACE3oU5V4S3JPGdsb2JhbABDiTyeaXYZAQEBATcygW4BAQQBOhwjBQsLDgouLQwKFAYTiAACtF6HSGEEmSqMLw X-IronPort-AV: E=Sophos;i="4.69,384,1315173600"; d="scan'208";a="498421448" Received: from c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.201]) by iph2.telenor.se with ESMTP; 21 Oct 2011 11:16:02 +0200 Received: from [10.225.40.63] (unknown [193.45.43.33]) by coolsville.localdomain (Postfix) with ESMTPSA id CEBE27FA058; Fri, 21 Oct 2011 11:16:01 +0200 (CEST) References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: <3D242727-985C-4926-9270-CBE926BDCECC@swipnet.se> X-Mailer: iPhone Mail (9A334) From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Date: Fri, 21 Oct 2011 11:15:58 +0200 X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.4 (-) Hi. 20 okt 2011 kl. 23:09 skrev Glenn Morris : > Glenn Morris wrote: >=20 >>> 1 Make writable and continue. >>> 2 Don't make writable and continue >>> 3 Abort >>=20 >> Isn't ctrl-g good enough for aborting, rather than introducing a 3-state >> question? >=20 > Ignore that, I misunderstood option 2. > "Don't make writable, but continue committing anyway." Too late :-) > (Will that cause an error with whatever VCS this issue is still relevant f= or?) I guess we have to check all backends individually.=20 Jan D. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 21 12:18:52 2011 Received: (at control) by debbugs.gnu.org; 21 Oct 2011 16:18:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RHHo4-0001j3-Ah for submit@debbugs.gnu.org; Fri, 21 Oct 2011 12:18:52 -0400 Received: from fencepost.gnu.org ([140.186.70.10] ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RHHo1-0001iv-MJ for control@debbugs.gnu.org; Fri, 21 Oct 2011 12:18:50 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RHHmo-0006BC-LH for control@debbugs.gnu.org; Fri, 21 Oct 2011 12:17:34 -0400 Date: Fri, 21 Oct 2011 12:17:34 -0400 Message-Id: Subject: control message for bug 9781 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) retitle 9781 read-only prompt in vc-next-action severity 9781 minor From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2011 18:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Cc: "9781@debbugs.gnu.org" <9781@debbugs.gnu.org> Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.131991326827167 (code B ref 9781); Sat, 29 Oct 2011 18:35:01 +0000 Received: (at 9781) by debbugs.gnu.org; 29 Oct 2011 18:34:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKDjg-000747-E0 for submit@debbugs.gnu.org; Sat, 29 Oct 2011 14:34:28 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKDjd-000740-Mx for 9781@debbugs.gnu.org; Sat, 29 Oct 2011 14:34:26 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RKDhf-0005VY-Oa; Sat, 29 Oct 2011 14:32:23 -0400 From: Glenn Morris References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> <3D242727-985C-4926-9270-CBE926BDCECC@swipnet.se> X-Spook: strategic DES Waco, Texas Janet Reno eavesdropping X-Ran: Hu?$8gPTV;4suCko9,C/ja8f%F<{N](N4xj2}o*&XFe(bN4-W~.v%C? ("Jan =?UTF-8?Q?Dj=C3=A4rv?="'s message of "Fri, 21 Oct 2011 11:15:58 +0200") Message-ID: <64zkgjlkco.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Jan Dj=C3=A4rv wrote: > I guess we have to check all backends individually.=20 I checked CVS, SVN and bzr; all have no problems committing read-only files. So this whole "is the file read-only" check should simply be skipped for those backends IMO. (I suspect only RCS is going to care about read-onlyness.) From unknown Sat Aug 16 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2011 19:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: Jan =?UTF-8?Q?Dj=C3=A4rv?= , "9781@debbugs.gnu.org" <9781@debbugs.gnu.org> Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.13199176991262 (code B ref 9781); Sat, 29 Oct 2011 19:49:01 +0000 Received: (at 9781) by debbugs.gnu.org; 29 Oct 2011 19:48:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKEt9-0000KJ-5I for submit@debbugs.gnu.org; Sat, 29 Oct 2011 15:48:19 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RKEt7-0000KC-8N for 9781@debbugs.gnu.org; Sat, 29 Oct 2011 15:48:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AroLAKJXrE5MCrTo/2dsb2JhbABClVKUFoEGgXIBAQQBViMFCwsOJhIUGA0kiBWybokCBKFEhEU X-IronPort-AV: E=Sophos;i="4.69,424,1315195200"; d="scan'208";a="145117402" Received: from 76-10-180-232.dsl.teksavvy.com (HELO pastel.home) ([76.10.180.232]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 29 Oct 2011 15:46:15 -0400 Received: by pastel.home (Postfix, from userid 20848) id D7B1258E17; Sat, 29 Oct 2011 15:46:14 -0400 (EDT) From: Stefan Monnier Message-ID: References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> <3D242727-985C-4926-9270-CBE926BDCECC@swipnet.se> <64zkgjlkco.fsf@fencepost.gnu.org> Date: Sat, 29 Oct 2011 15:46:14 -0400 In-Reply-To: <64zkgjlkco.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sat, 29 Oct 2011 14:32:23 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > skipped for those backends IMO. (I suspect only RCS is going to care > about read-onlyness.) Indeed. OR maybe SCCS as well, but everything else should pay little attention to read-only-ness (at most it will record it in the repository). Stefan From unknown Sat Aug 16 16:22:44 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Subject: bug#9781: closed (Re: bug#9781: 24.0.90; VC can't commit removed files/directories.) Message-ID: References: <86wqzgar03.fsf@fencepost.gnu.org> <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> X-Gnu-PR-Message: they-closed 9781 X-Gnu-PR-Package: emacs Reply-To: 9781@debbugs.gnu.org Date: Thu, 27 Sep 2012 07:02:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1348729322-27885-1" This is a multi-part message in MIME format... ------------=_1348729322-27885-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #9781: read-only prompt in vc-next-action which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 9781@debbugs.gnu.org. --=20 9781: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9781 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1348729322-27885-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 9781-done) by debbugs.gnu.org; 27 Sep 2012 07:01:38 +0000 Received: from localhost ([127.0.0.1]:57863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TH86M-0007FD-BL for submit@debbugs.gnu.org; Thu, 27 Sep 2012 03:01:38 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37031) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TH86K-0007F5-4G for 9781-done@debbugs.gnu.org; Thu, 27 Sep 2012 03:01:37 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TH86G-0001XE-Ml; Thu, 27 Sep 2012 03:01:32 -0400 From: Glenn Morris To: 9781-done@debbugs.gnu.org Subject: Re: bug#9781: 24.0.90; VC can't commit removed files/directories. References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> <3D242727-985C-4926-9270-CBE926BDCECC@swipnet.se> <64zkgjlkco.fsf@fencepost.gnu.org> X-Spook: MILSATCOM JPL USDOJ UNSCOM data haven UMTS emc Hugo Chavez X-Ran: PZ&_%$I?pa^|rsR;\Ude^|c]Cz`ZG=P{Mof{@N7XLZM_cmUB<6hH,-#{;Zl[8e4o;R9.og X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 27 Sep 2012 03:01:32 -0400 In-Reply-To: (Stefan Monnier's message of "Sat, 29 Oct 2011 15:46:14 -0400") Message-ID: <86wqzgar03.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -7.7 (-------) X-Debbugs-Envelope-To: 9781-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.7 (-------) Version: 24.3 I restricted the toggle-read-only business to RCS and SCCS (the latter might not even need it either). ------------=_1348729322-27885-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Oct 2011 06:38:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3Jg-0002uR-Ix for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:38:24 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3Jc-0002uB-NG for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG3IY-00048H-H9 for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:37:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:57963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IY-00048D-Fd for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:37:14 -0400 Received: from eggs.gnu.org ([140.186.70.92]:40279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IS-00066B-OX for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG3IL-00046W-TA for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:08 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]:33165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IL-00046D-Ix for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:01 -0400 Received: from iph3.telenor.se (iph3.telenor.se [195.54.127.134]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id CDAADEA111 for ; Tue, 18 Oct 2011 08:36:59 +0200 (CEST) X-SENDER-IP: [85.225.45.201] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AphiAHsdnU5V4S3JPGdsb2JhbABDiTyfHhkBAQEBNzKBbgFAHBMBBDteDApLh2OWOqAkgyuDfGEEmSaMLg X-IronPort-AV: E=Sophos;i="4.69,363,1315173600"; d="scan'208";a="132478265" Received: from c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.201]) by iph3.telenor.se with ESMTP; 18 Oct 2011 08:36:59 +0200 Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 0DB617FA058 for ; Tue, 18 Oct 2011 08:36:59 +0200 (CEST) From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: 24.0.90; VC can't commit removed files/directories. Date: Tue, 18 Oct 2011 08:36:58 +0200 Message-Id: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Apple Message framework v1251.1) X-Mailer: Apple Mail (2.1251.1) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) This bug report will be sent to the Bug-GNU-Emacs mailing list and the GNU bug tracker at debbugs.gnu.org. Please check that the From: line contains a valid email address. After a delay of up to one day, you should receive an acknowledgement at that address. Please write in English if possible, as the Emacs maintainers usually do not have translators for other languages. Please describe exactly what actions triggered the bug, and the precise symptoms of the bug. If you can, give a recipe starting from `emacs -Q': I'm surprised nobody has seen this. In a bzr repository, do % bzr rm some-file and modify some other file. Then in Emacs, do vc-dir on the directory where the file was. Mark the file that is listed as removed. Also mark the edited file. Press v. Expected result: I can type in a log message and commit. Real result: A prompt in the minibuffer appears: some-file is edited but read-only; make it writable and continue? (y/n)=20= This is because in vc.el, vc-next-action there is this: (let ((ready-for-commit files)) ;; If files are edited but read-only, give user a chance to = correct (dolist (file files) (unless (file-writable-p file) ;; Make the file+buffer read-write. (unless (y-or-n-p (format "%s is edited but read-only; make = it writable and continue? " file)) (error "Aborted")) ;; Maybe we somehow lost permissions on the directory. (condition-case nil (set-file-modes file (logior (file-modes file) 128)) (error (error "Unable to make file writable"))) Files/directories that are removed are obviously not file-writable-p, so = the logic is wrong. Also, the choices in the question should be three: 1 Make writable and continue. 2 Don't make writable and continue 3 Abort As it is now, you either exit on the "Aborted" error or if you try to = continue on the "Unable to make file writable" error. Jan D. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /Users/jhd/Applications/Emacs.app/Contents/Resources/etc/DEBUG. In GNU Emacs 24.0.90.1 (x86_64-apple-darwin11.2.0, NS = apple-appkit-1138.23) of 2011-10-18 on zeplin Windowing system distributor `Apple', version 10.3.1138 configured using `configure '--verbose' '--enable-asserts' '--with-ns' = '--without-x-toolkit' 'CFLAGS=3D-g'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: C value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: sv_SE.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: desktop-save-mode: t delete-selection-mode: t icomplete-mode: t display-time-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: x r e p o r t - e m Recent messages: Loading /Users/jhd/lib/elisp/BAK-file.el (source)...done Loading /Users/jhd/lib/elisp/ccsetup.el (source)...done Loading icomplete...done Loading desktop...done No desktop file. For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug desktop cus-start cus-load msb delsel advice help-fns advice-preload icomplete cc-mode cc-fonts easymenu cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs regexp-opt time time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process ns multi-tty emacs) ------------=_1348729322-27885-1--