Subject: Re: "make install-info" with DESTDIR writes unwanted usr/share/info/dir.gz

From: Jonathan Nieder <[email-masked]>
Date: Sun, 23 Oct 2011 10:12:00 -0500

Stefano Lattarini wrote:

> Here is my proposed patch (for maint).

Thanks!  Two nits:

[...]
> --- a/lib/am/texinfos.am
> +++ b/lib/am/texinfos.am
> @@ -208,18 +208,16 @@ install-info-am: $(INFO_DEPS)
>  	  echo " $(INSTALL_DATA) $$files '$(DESTDIR)$(infodir)'"; \
>  	  $(INSTALL_DATA) $$files "$(DESTDIR)$(infodir)" || exit $$?; done
>  	@$(POST_INSTALL)
[...]
> +## Only run this code if install-info actually exists, and if the user
> +## don't request it not to be run (through the `AM_UPDATE_INFO_DIR'
> +## environment variable).  See automake bug#9773 and Debian Bug#543992.

"don't request" -> "doesn't request"

[...]
> --- /dev/null
> +++ b/tests/install-info-dir.test
> @@ -0,0 +1,142 @@
[...]
> +# FIXME: this test is a good candidate for a conversion top TAP.
> +# FIXME: and could be merged with txinfo27.test

"top TAP" -> "to TAP"

The patch itself looks sensible, though I haven't tested it or
anything.