From unknown Sat Jun 21 17:34:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9754 <9754@debbugs.gnu.org> To: bug#9754 <9754@debbugs.gnu.org> Subject: Status: emacs -nv fails on glib 2.31 Reply-To: bug#9754 <9754@debbugs.gnu.org> Date: Sun, 22 Jun 2025 00:34:08 +0000 retitle 9754 emacs -nv fails on glib 2.31 reassign 9754 emacs submitter 9754 Ryan Lortie severity 9754 normal tag 9754 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 14 13:42:16 2011 Received: (at submit) by debbugs.gnu.org; 14 Oct 2011 17:42:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1REllw-0006mn-6j for submit@debbugs.gnu.org; Fri, 14 Oct 2011 13:42:16 -0400 Received: from manic.desrt.ca ([207.192.74.61] helo=mail.desrt.ca ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1REkTG-0004qp-Dm for submit@debbugs.gnu.org; Fri, 14 Oct 2011 12:18:58 -0400 Received: from [172.16.0.159] (173-230-190-244.cable.teksavvy.com [173.230.190.244]) by manic.desrt.ca (Postfix) with ESMTPSA id DB46F55BD9 for ; Fri, 14 Oct 2011 11:18:18 -0500 (EST) Message-ID: <1318609098.30586.7.camel@moonpix.lan> Subject: emacs -nv fails on glib 2.31 From: Ryan Lortie To: submit@debbugs.gnu.org Date: Fri, 14 Oct 2011 12:18:18 -0400 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.0 (3.2.0-1.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 14 Oct 2011 13:42:14 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Packages: emacs Version: 23.3 When running "emacs -nw" with the latest glib version, emacs gets stuck in this infinite loop: in xg_select at /usr/src/debug/emacs-23.3/src/xgselect.c:59 58 while (n_gfds > gfds_size) 59 gfds_size *= 2; This code is buggy in the case that gfds_size is zero (since clearly, no matter how many times you multiply by 2, you're not going to increase it). Further down in the same file, you see: 155 void 156 xgselect_initialize () 157 { 158 #if defined (USE_GTK) || defined (HAVE_GCONF) 159 gfds_size = 128; 160 gfds = xmalloc (sizeof (*gfds)*gfds_size); So it's clear that xgselect_initialize() is not being called in the "-nw" case. That makes sense -- why initialise GTK when not using it? The problem is that xg_select() is used even in the "-nw" case, without _initialize() having been called. This worked before because an unused GMainContext used to have 0 fds in it, so n_gfds would be zero and gfds_size would not need to be increased, causing the bug to be skipped over. Recent changes in glib have introduced one fd to every GMainContext to deal with the inherent race introduced by signal delivery (closing a longstanding glib bug). This means that the untouched GMainContext no longer has 0 fds -- but 1. This is what is triggering the problem in the buggy code above. The solution to this problem is one of: - ensure xgselect_initialize() is always called - don't use xg_select in -nw case - fix the code to deal with the array being zero-sized and nuke xgselect_initialize() From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 14 13:48:44 2011 Received: (at 9754) by debbugs.gnu.org; 14 Oct 2011 17:48:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RElsC-0006y5-86 for submit@debbugs.gnu.org; Fri, 14 Oct 2011 13:48:44 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RElsA-0006xv-Jv for 9754@debbugs.gnu.org; Fri, 14 Oct 2011 13:48:43 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RElra-0007L2-5l; Fri, 14 Oct 2011 13:48:06 -0400 From: Glenn Morris To: 9754@debbugs.gnu.org Subject: Re: bug#9754: emacs -nv fails on glib 2.31 References: <1318609098.30586.7.camel@moonpix.lan> X-Spook: AVIP broadside Echelon MD5 Albania NWO Albright covert X-Ran: cy;yA[kruesTG#@\dK`PwK&N/;X-V6)xHkj+HHrJ,&TbB"j8@ (Ryan Lortie's message of "Fri, 14 Oct 2011 12:18:18 -0400") Message-ID: <6zwrc7h3c9.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 9754 Cc: Ryan Lortie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) [ I am resending this report, which was assigned to the wrong package due to a "Packages:"/"Package:" typo, so that it appears on the bug-gnu-emacs list .] From: Ryan Lortie Packages: emacs Version: 23.3 When running "emacs -nw" with the latest glib version, emacs gets stuck in this infinite loop: in xg_select at /usr/src/debug/emacs-23.3/src/xgselect.c:59 58 while (n_gfds > gfds_size) 59 gfds_size *= 2; This code is buggy in the case that gfds_size is zero (since clearly, no matter how many times you multiply by 2, you're not going to increase it). Further down in the same file, you see: 155 void 156 xgselect_initialize () 157 { 158 #if defined (USE_GTK) || defined (HAVE_GCONF) 159 gfds_size = 128; 160 gfds = xmalloc (sizeof (*gfds)*gfds_size); So it's clear that xgselect_initialize() is not being called in the "-nw" case. That makes sense -- why initialise GTK when not using it? The problem is that xg_select() is used even in the "-nw" case, without _initialize() having been called. This worked before because an unused GMainContext used to have 0 fds in it, so n_gfds would be zero and gfds_size would not need to be increased, causing the bug to be skipped over. Recent changes in glib have introduced one fd to every GMainContext to deal with the inherent race introduced by signal delivery (closing a longstanding glib bug). This means that the untouched GMainContext no longer has 0 fds -- but 1. This is what is triggering the problem in the buggy code above. The solution to this problem is one of: - ensure xgselect_initialize() is always called - don't use xg_select in -nw case - fix the code to deal with the array being zero-sized and nuke xgselect_initialize() From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 16 01:16:19 2011 Received: (at 9754) by debbugs.gnu.org; 16 Oct 2011 05:16:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFJ58-0000rx-Nw for submit@debbugs.gnu.org; Sun, 16 Oct 2011 01:16:18 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFJ56-0000rl-Ts for 9754@debbugs.gnu.org; Sun, 16 Oct 2011 01:16:17 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id CF6F039E8008; Sat, 15 Oct 2011 22:15:27 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hAfnm+Yy9QTt; Sat, 15 Oct 2011 22:15:27 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 1AF1B39E8006; Sat, 15 Oct 2011 22:15:27 -0700 (PDT) Message-ID: <4E9A686E.8060207@cs.ucla.edu> Date: Sat, 15 Oct 2011 22:15:26 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15 MIME-Version: 1.0 To: Ryan Lortie Subject: Re: emacs -nv fails on glib 2.31 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) I don't think this bug can occur in the latest Emacs since it uses xpalloc which should do the right thing in this case. Could you please double-check by trying the latest Emacs pretest? Thanks. http://alpha.gnu.org/gnu/emacs/pretest/emacs-24.0.90.tar.gz From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 12:10:07 2011 Received: (at 9754) by debbugs.gnu.org; 11 Nov 2011 17:10:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ROucA-00082w-Ks for submit@debbugs.gnu.org; Fri, 11 Nov 2011 12:10:07 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ROqHX-0001YA-B0 for 9754@debbugs.gnu.org; Fri, 11 Nov 2011 07:32:32 -0500 Received: from euphor.blino.org (unknown [IPv6:2a01:e35:8a0b:8670:211:d8ff:fe95:6468]) by smtp1-g21.free.fr (Postfix) with ESMTP id 307E79401DE for <9754@debbugs.gnu.org>; Fri, 11 Nov 2011 13:32:09 +0100 (CET) From: Olivier Blin To: 9754@debbugs.gnu.org Subject: Re: emacs -nv fails on glib 2.31 Date: Fri, 11 Nov 2011 13:32:08 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 9754 X-Mailman-Approved-At: Fri, 11 Nov 2011 12:10:05 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.6 (/) --=-=-= Attached is the patch I added in Mageia to fix this bug. Something similar should be done in the emacs-23 branch. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=emacs-23.3-xgselect_init.patch Content-Description: fix infinite loop in text mode select() when built with gtk support (emacs #9754, mga #3259) diff -up emacs-23.3/src/xgselect.c.xgselect_init emacs-23.3/src/xgselect.c --- emacs-23.3/src/xgselect.c.xgselect_init 2011-01-08 18:45:14.000000000 +0100 +++ emacs-23.3/src/xgselect.c 2011-11-11 13:00:53.211765255 +0100 @@ -55,6 +55,9 @@ xg_select (max_fds, rfds, wfds, efds, ti do { if (n_gfds > gfds_size) { + if (gfds_size == 0) + xgselect_initialize (); + while (n_gfds > gfds_size) gfds_size *= 2; xfree (gfds); --=-=-= -- Olivier Blin - blino --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 12:16:27 2011 Received: (at 9754) by debbugs.gnu.org; 11 Nov 2011 17:16:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ROuiJ-0008Hp-3E for submit@debbugs.gnu.org; Fri, 11 Nov 2011 12:16:27 -0500 Received: from fencepost.gnu.org ([140.186.70.10] ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ROuiG-0008Hf-Ak for 9754@debbugs.gnu.org; Fri, 11 Nov 2011 12:16:25 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1ROuhx-00073a-OU; Fri, 11 Nov 2011 12:16:05 -0500 From: Glenn Morris To: Olivier Blin Subject: Re: bug#9754: emacs -nv fails on glib 2.31 References: <1318609098.30586.7.camel@moonpix.lan> X-Spook: NASA offensive information warfare benelux SWAT Blowpipe X-Ran: g9ym*o:=!z?XQUrfiww$f~Gt}"','=`T$04{({8vaSR?BS^NU]qdVIR$9z7Eu["8g@PTes X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 11 Nov 2011 12:16:05 -0500 In-Reply-To: (Olivier Blin's message of "Fri, 11 Nov 2011 13:32:08 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Olivier Blin wrote: > Attached is the patch I added in Mageia to fix this bug. > Something similar should be done in the emacs-23 branch. The Emacs 23 branch is no longer in use and won't be modified. Could someone please test the latest 24.0.9* pretest, as was requested? http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9754#11 I don't think this bug can occur in the latest Emacs since it uses xpalloc which should do the right thing in this case. Could you please double-check by trying the latest Emacs pretest? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 14:06:03 2012 Received: (at control) by debbugs.gnu.org; 28 Jan 2012 19:06:03 +0000 Received: from localhost ([127.0.0.1]:48522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrDb9-0002Id-CU for submit@debbugs.gnu.org; Sat, 28 Jan 2012 14:06:03 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:48870 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrDb4-0002Hs-5F for control@debbugs.gnu.org; Sat, 28 Jan 2012 14:06:01 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RrDaL-0006jj-CO for control@debbugs.gnu.org; Sat, 28 Jan 2012 14:05:13 -0500 Date: Sat, 28 Jan 2012 14:05:13 -0500 Message-Id: Subject: control message for bug 10631 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) merge 9754 10631 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 16:15:12 2012 Received: (at 9754) by debbugs.gnu.org; 28 Jan 2012 21:15:12 +0000 Received: from localhost ([127.0.0.1]:48603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrFc8-00063W-22 for submit@debbugs.gnu.org; Sat, 28 Jan 2012 16:15:12 -0500 Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:43398) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrFc6-00063M-7h for 9754@debbugs.gnu.org; Sat, 28 Jan 2012 16:15:11 -0500 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.4/8.13.4) with ESMTP id q0SLEIxi003525 for <9754@debbugs.gnu.org>; Sat, 28 Jan 2012 22:14:18 +0100 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.5/8.14.2) with ESMTP id q0SLEIap012982; Sat, 28 Jan 2012 22:14:18 +0100 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.5/8.14.5/Submit) id q0SLEHpY012981; Sat, 28 Jan 2012 22:14:17 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20260.25897.871504.852120@a1i15.kph.uni-mainz.de> Date: Sat, 28 Jan 2012 22:14:17 +0100 To: 9754@debbugs.gnu.org Subject: Re: emacs -nv fails on glib 2.31 X-Mailer: VM 8.2.0b under 23.4.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > The Emacs 23 branch is no longer in use and won't be modified. Nice. Today Emacs 23.4 has been released from that "unused branch" and is bound to fail with the next glib version. :-( From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 10 05:07:30 2012 Received: (at control) by debbugs.gnu.org; 10 Mar 2012 10:07:30 +0000 Received: from localhost ([127.0.0.1]:41963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6JCz-0000vV-D1 for submit@debbugs.gnu.org; Sat, 10 Mar 2012 05:07:30 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:48290) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6JCm-0000uo-UY for control@debbugs.gnu.org; Sat, 10 Mar 2012 05:07:27 -0500 Received: from bb116-14-103-36.singnet.com.sg ([116.14.103.36]:55787 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S6Ik5-0005oi-KB for control@debbugs.gnu.org; Sat, 10 Mar 2012 04:37:38 -0500 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 9754 Date: Sat, 10 Mar 2012 17:37:31 +0800 Message-ID: <87zkboztic.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 9754 thanks From unknown Sat Jun 21 17:34:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Apr 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 15:05:15 2012 Received: (at control) by debbugs.gnu.org; 15 May 2012 19:05:15 +0000 Received: from localhost ([127.0.0.1]:56471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUN3b-0002j4-09 for submit@debbugs.gnu.org; Tue, 15 May 2012 15:05:15 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:37281) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUN3a-0002iq-3v for control@debbugs.gnu.org; Tue, 15 May 2012 15:05:14 -0400 X-CornellRouted: This message has been Routed already. Received: from soapstone1.mail.cornell.edu (soapstone1.mail.cornell.edu [128.253.83.143]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4FJ51ns011805 for ; Tue, 15 May 2012 15:05:01 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by soapstone1.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4FJ54Sv027838 for ; Tue, 15 May 2012 15:05:05 -0400 (EDT) Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4FJ51tf003791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Tue, 15 May 2012 15:05:02 -0400 (EDT) Message-ID: <4FB2A8D5.1060706@cornell.edu> Date: Tue, 15 May 2012 15:04:53 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: control@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.15.184817 X-Original-Sender: kbrown@cornell.edu - Tue May 15 15:05:02 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.6 (/) unarchive 9754 From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 15:09:39 2012 Received: (at 9754) by debbugs.gnu.org; 15 May 2012 19:09:39 +0000 Received: from localhost ([127.0.0.1]:56495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUN7p-0002qa-Tr for submit@debbugs.gnu.org; Tue, 15 May 2012 15:09:38 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:40539) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUN7n-0002qH-Am for 9754@debbugs.gnu.org; Tue, 15 May 2012 15:09:36 -0400 X-CornellRouted: This message has been Routed already. Received: from alva01.serverfarm.cornell.edu (alva01.serverfarm.cornell.edu [128.84.106.36]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4FJ9FPm014144; Tue, 15 May 2012 15:09:15 -0400 (EDT) Received: from localhost.localdomain (pawpaw.mail.cornell.edu [128.253.83.170]) by alva01.serverfarm.cornell.edu (8.14.4/8.14.4) with ESMTP id q4FJ9GWW009193; Tue, 15 May 2012 15:09:16 -0400 Received: from pawpaw.mail.cornell.edu by pawpaw.mail.cornell.edu with queue id 204832997-6; Tue, 15 May 2012 19:09:04 GMT Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) by with SMTP id ; Tue, 15 May 2012 19:09:04 GMT (envelope-from kbrown@cornell.edu) Message-ID: <4FB2A9C7.3070604@cornell.edu> Date: Tue, 15 May 2012 15:08:55 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Paul Eggert Subject: Re: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> In-Reply-To: <4FAC34DA.7040606@cs.ucla.edu> Content-Type: multipart/mixed; boundary="------------020701030007020506060404" X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.15.190324 X-Original-Sender: kbrown@cornell.edu - Tue May 15 15:09:05 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-PMX-CORNELL: Alva01 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, "Douglas, William" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) This is a multi-part message in MIME format. --------------020701030007020506060404 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit I'm resending this because I got back a message saying I had to unarchive bug 9754 before I could add to it. On 5/10/2012 5:36 PM, Paul Eggert wrote: > On 05/10/2012 02:25 PM, Douglas, William wrote: >> Is there any chance of getting the fix for this applied or am I left >> distro patching and waiting for 24? > > The latter -- at least, that's the current plan. I think this bug still exists, in slightly different form, in emacs-24. The call of g_main_context_query in xgselect.c:62 still uses the variables gfds and gfds_size, which are not initialized by xgselect_initialize if we're running emacs -nw. But, more fundamentally, it doesn't make sense for emacs -nw to be interacting with GLib at all. I suggest the attached patch. Ken --------------020701030007020506060404 Content-Type: text/plain; charset=windows-1252; name="xgselect.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xgselect.patch" --- xgselect.c.orig 2012-05-15 13:53:13.000000000 -0400 +++ xgselect.c 2012-05-15 14:09:19.093750000 -0400 @@ -35,6 +35,9 @@ xg_select (int max_fds, SELECT_TYPE *rfds, SELECT_TYPE *wfds, SELECT_TYPE *efds, EMACS_TIME *timeout) { + if (inhibit_window_system || !display_arg) + return select (max_fds, rfds, wfds, efds, timeout); + SELECT_TYPE all_rfds, all_wfds; EMACS_TIME tmo, *tmop = timeout; --------------020701030007020506060404-- From unknown Sat Jun 21 17:34:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Tue, 15 May 2012 21:43:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 17:52:08 2012 Received: (at 9754) by debbugs.gnu.org; 15 May 2012 21:52:08 +0000 Received: from localhost ([127.0.0.1]:56750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUPf5-0008PU-4H for submit@debbugs.gnu.org; Tue, 15 May 2012 17:52:08 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:43607) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUPf3-0008Ox-7f for 9754@debbugs.gnu.org; Tue, 15 May 2012 17:52:06 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id E3F3939E800A; Tue, 15 May 2012 14:51:53 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OjGy5BgdXpOz; Tue, 15 May 2012 14:51:53 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 818A839E8006; Tue, 15 May 2012 14:51:53 -0700 (PDT) Message-ID: <4FB2CFF9.70309@cs.ucla.edu> Date: Tue, 15 May 2012 14:51:53 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Ken Brown Subject: Re: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> In-Reply-To: <4FB2A9C7.3070604@cornell.edu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, "Douglas, William" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 05/15/2012 12:08 PM, Ken Brown wrote: > I think this bug still exists, in slightly different form, in > emacs-24. The call of g_main_context_query in xgselect.c:62 still > uses the variables gfds and gfds_size, which are not initialized by > xgselect_initialize if we're running emacs -nw. They are initialized to NULL and zero, which should work for all their uses. > more fundamentally, it doesn't make sense for emacs -nw to be interacting > with GLib at all. I suggest the attached patch. That patch assumes C99's statements before declarations. I assume the following minor rewrite of it is OK too? === modified file 'src/xgselect.c' --- src/xgselect.c 2012-05-10 05:27:24 +0000 +++ src/xgselect.c 2012-05-15 21:30:36 +0000 @@ -38,17 +38,21 @@ xg_select (int max_fds, SELECT_TYPE *rfd SELECT_TYPE all_rfds, all_wfds; EMACS_TIME tmo, *tmop = timeout; - GMainContext *context = g_main_context_default (); + GMainContext *context; int have_wfds = wfds != NULL; int n_gfds = 0, our_tmo = 0, retval = 0, our_fds = 0; int i, nfds, fds_lim, tmo_in_millisec; + if (inhibit_window_system || !display_arg) + return select (max_fds, rfds, wfds, efds, timeout); + if (rfds) memcpy (&all_rfds, rfds, sizeof (all_rfds)); else FD_ZERO (&all_rfds); if (wfds) memcpy (&all_wfds, wfds, sizeof (all_rfds)); else FD_ZERO (&all_wfds); /* Update event sources in GLib. */ + context = g_main_context_default (); g_main_context_pending (context); do { From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 18:29:46 2012 Received: (at 9754) by debbugs.gnu.org; 15 May 2012 22:29:46 +0000 Received: from localhost ([127.0.0.1]:56773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUQFV-0000sb-5Z for submit@debbugs.gnu.org; Tue, 15 May 2012 18:29:45 -0400 Received: from limestone8.mail.cornell.edu ([128.253.83.168]:33335) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUQFA-0000s2-AP for 9754@debbugs.gnu.org; Tue, 15 May 2012 18:29:43 -0400 X-CornellRouted: This message has been Routed already. Received: from soapstone1.mail.cornell.edu (soapstone1.mail.cornell.edu [128.253.83.143]) by limestone8.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4FMTCU1013568 for <9754@debbugs.gnu.org>; Tue, 15 May 2012 18:29:12 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by soapstone1.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4FMTAOL015281; Tue, 15 May 2012 18:29:10 -0400 (EDT) Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4FMT6GL006892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 15 May 2012 18:29:07 -0400 (EDT) Message-ID: <4FB2D8AB.7030401@cornell.edu> Date: Tue, 15 May 2012 18:28:59 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Paul Eggert Subject: Re: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> In-Reply-To: <4FB2CFF9.70309@cs.ucla.edu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.15.222121 X-Original-Sender: kbrown@cornell.edu - Tue May 15 18:29:08 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Chong Yidong , "Douglas, William" , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/15/2012 5:51 PM, Paul Eggert wrote: > On 05/15/2012 12:08 PM, Ken Brown wrote: > >> I think this bug still exists, in slightly different form, in >> emacs-24. The call of g_main_context_query in xgselect.c:62 still >> uses the variables gfds and gfds_size, which are not initialized by >> xgselect_initialize if we're running emacs -nw. > > They are initialized to NULL and zero, which should work for > all their uses. I don't know if we can be sure of this without digging into the various GLib functions that get called in the xg_select code. I've been getting some crashes of emacs -nw on Cygwin after Cygwin's glib was updated to 2.32 a few days ago. That's what led me to start looking at xg_select. But the point is moot if we're going to apply the patch we're discussing (which gets rid of the crashes). >> more fundamentally, it doesn't make sense for emacs -nw to be interacting >> with GLib at all. I suggest the attached patch. > > That patch assumes C99's statements before declarations. > I assume the following minor rewrite of it is OK too? OK with me. Should I go ahead and apply it to the trunk? Or is it appropriate for the emacs-24 branch since it fixes a Cygwin crash? I guess that's up to Stefan and Chong, so I've added them to the CC. Ken From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 22:23:45 2012 Received: (at 9754) by debbugs.gnu.org; 16 May 2012 02:23:45 +0000 Received: from localhost ([127.0.0.1]:56838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUTtd-0006Lj-VO for submit@debbugs.gnu.org; Tue, 15 May 2012 22:23:44 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:33386) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUTtb-0006LT-P6 for 9754@debbugs.gnu.org; Tue, 15 May 2012 22:23:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApYIACxOgk9FpZcD/2dsb2JhbABDDrgVA4EMgQiCCQEBBAFWIwULCw4mEhQYDSSIHAW2MothhHkEpEWBXYIwUw X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="180454612" Received: from 69-165-151-3.dsl.teksavvy.com (HELO ceviche.home) ([69.165.151.3]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 15 May 2012 22:23:10 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 178D7660E0; Tue, 15 May 2012 22:23:09 -0400 (EDT) From: Stefan Monnier To: Ken Brown Subject: Re: Issue with Emacs 23.4 Message-ID: References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> Date: Tue, 15 May 2012 22:23:09 -0400 In-Reply-To: <4FB2D8AB.7030401@cornell.edu> (Ken Brown's message of "Tue, 15 May 2012 18:28:59 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Chong Yidong , Paul Eggert , "Douglas, William" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > OK with me. Should I go ahead and apply it to the trunk? Or is it > appropriate for the emacs-24 branch since it fixes a Cygwin crash? I guess > that's up to Stefan and Chong, so I've added them to the CC. I don't understand the potential consequences of this patch, so I can't really judge if it's appropriate for the emacs-24 branch. At least it doesn't seem "obviously correct" to me: what if the user opens up an X frame after starting "emacs -nw"? Are we sure we never need the Glib loop (IIRC nowadays Glib is used not just for Gtk but also for other things, like maybe D-Bus?). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 22:28:36 2012 Received: (at 9754) by debbugs.gnu.org; 16 May 2012 02:28:36 +0000 Received: from localhost ([127.0.0.1]:56842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUTyd-0006Sv-BM for submit@debbugs.gnu.org; Tue, 15 May 2012 22:28:35 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:49451) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUTyI-0006SM-7X for 9754@debbugs.gnu.org; Tue, 15 May 2012 22:28:33 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 4BEF0A60004; Tue, 15 May 2012 19:28:01 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eIC2NjHNBg8k; Tue, 15 May 2012 19:28:00 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id AA7C7A60002; Tue, 15 May 2012 19:28:00 -0700 (PDT) Message-ID: <4FB310B0.5010701@cs.ucla.edu> Date: Tue, 15 May 2012 19:28:00 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Ken Brown Subject: Re: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> In-Reply-To: <4FB2D8AB.7030401@cornell.edu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Chong Yidong , "Douglas, William" , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 05/15/2012 03:28 PM, Ken Brown wrote: > OK with me. Should I go ahead and apply it to the trunk? > Or is it appropriate for the emacs-24 branch since it fixes a Cygwin crash? As I understand it, the bug is present in Emacs 23 and so this is not a regression. So I applied the change to the trunk as bzr 108249. I don't understand the situation well enough to answer Stefan's questions, unfortunately -- which also suggests the patch isn't appropriate for the emacs-24 branch. From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 02:42:44 2012 Received: (at 9754) by debbugs.gnu.org; 16 May 2012 06:42:44 +0000 Received: from localhost ([127.0.0.1]:56949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUXwa-0004pB-4M for submit@debbugs.gnu.org; Wed, 16 May 2012 02:42:44 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:49351) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SUXwV-0004ov-6w for 9754@debbugs.gnu.org; Wed, 16 May 2012 02:42:40 -0400 Received: (qmail invoked by alias); 16 May 2012 06:42:23 -0000 Received: from p57BB95EF.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.149.239] by mail.gmx.net (mp040) with SMTP; 16 May 2012 08:42:23 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX19mLxFLuh9mb5PQlLyp3UchDq9DxH6CvYsEF90GZ9 Kj1Nfm6JtCeNeM From: Michael Albinus To: Stefan Monnier Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> Date: Wed, 16 May 2012 08:42:19 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 15 May 2012 22:23:09 -0400") Message-ID: <87pqa4ocdw.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Paul Eggert , "Douglas, William" , Ken Brown X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: > (IIRC nowadays Glib is used not just for Gtk but also for other > things, like maybe D-Bus?). Emacs' dbusbind.c uses plain libdbus. No DBus-GLib, no GDBus. > Stefan Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 13:40:05 2012 Received: (at submit) by debbugs.gnu.org; 16 May 2012 17:40:05 +0000 Received: from localhost ([127.0.0.1]:57968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUiCa-00060U-7y for submit@debbugs.gnu.org; Wed, 16 May 2012 13:40:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39444) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUiCW-000608-Jd for submit@debbugs.gnu.org; Wed, 16 May 2012 13:39:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUiCF-0007UE-51 for submit@debbugs.gnu.org; Wed, 16 May 2012 13:39:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUiCF-0007U3-1W for submit@debbugs.gnu.org; Wed, 16 May 2012 13:39:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUiCD-0000Lx-AK for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 13:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUiCB-0007TC-5c for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 13:39:32 -0400 Received: from plane.gmane.org ([80.91.229.3]:50888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUiCA-0007Su-VH for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 13:39:31 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SUiC6-0005Jw-Ro for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 19:39:26 +0200 Received: from pd9eb2977.dip.t-dialin.net ([217.235.41.119]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 16 May 2012 19:39:26 +0200 Received: from Stromeko by pd9eb2977.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 16 May 2012 19:39:26 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Achim Gratz Subject: Re: bug#9754: Issue with Emacs 23.4 Date: Wed, 16 May 2012 19:39:10 +0200 Lines: 17 Message-ID: <878vgsrpoh.fsf@Rainer.invalid> References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: pd9eb2977.dip.t-dialin.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) Cancel-Lock: sha1:TNyvOSf54S9KcBKipt9/l+h5k88= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier writes: > At least it doesn't seem "obviously correct" to me: what if the user > opens up an X frame after starting "emacs -nw"? The hang arises when emacs is started without an X server present or at least with DISPLAY not set. I don't see how a user would be able to open an X frame at a later point in time in that situation (or reasonable expect he might be able to). Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 21:20:04 2012 Received: (at 9754) by debbugs.gnu.org; 17 May 2012 01:20:04 +0000 Received: from localhost ([127.0.0.1]:58309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUpNr-00039D-VG for submit@debbugs.gnu.org; Wed, 16 May 2012 21:20:04 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:56801) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUpNr-00038i-2V for 9754@debbugs.gnu.org; Wed, 16 May 2012 21:20:03 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApYIACxOgk9FpZcD/2dsb2JhbABDuCMDgQyBCIIJAQEEAVYjEAsOJhIUGA0kiBwFtjKLYYR5BKRFgV2DAw X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="180643277" Received: from 69-165-151-3.dsl.teksavvy.com (HELO pastel.home) ([69.165.151.3]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 May 2012 21:19:45 -0400 Received: by pastel.home (Postfix, from userid 20848) id CF6F859577; Wed, 16 May 2012 21:19:44 -0400 (EDT) From: Stefan Monnier To: Achim Gratz Subject: Re: bug#9754: Issue with Emacs 23.4 Message-ID: References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> Date: Wed, 16 May 2012 21:19:44 -0400 In-Reply-To: <878vgsrpoh.fsf@Rainer.invalid> (Achim Gratz's message of "Wed, 16 May 2012 19:39:10 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> At least it doesn't seem "obviously correct" to me: what if the user >> opens up an X frame after starting "emacs -nw"? > The hang arises when emacs is started without an X server present or at > least with DISPLAY not set. I don't see how a user would be able to > open an X frame at a later point in time in that situation (or > reasonable expect he might be able to). Easy: M-x make-frame-on-display. Or start an emacs server and then connect to the server from an emacsclient with a DISPLAY set (which ends up calling make-frame-on-display as well, of course). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 02:25:40 2012 Received: (at submit) by debbugs.gnu.org; 17 May 2012 06:25:41 +0000 Received: from localhost ([127.0.0.1]:58512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUu9a-0003T4-T3 for submit@debbugs.gnu.org; Thu, 17 May 2012 02:25:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48925) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUu9D-0003SV-4D for submit@debbugs.gnu.org; Thu, 17 May 2012 02:25:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUu8t-0006f3-11 for submit@debbugs.gnu.org; Thu, 17 May 2012 02:24:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUu8s-0006ex-U6 for submit@debbugs.gnu.org; Thu, 17 May 2012 02:24:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUu8r-0001qO-As for bug-gnu-emacs@gnu.org; Thu, 17 May 2012 02:24:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUu8p-0006eK-Ai for bug-gnu-emacs@gnu.org; Thu, 17 May 2012 02:24:52 -0400 Received: from plane.gmane.org ([80.91.229.3]:52104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUu8p-0006e4-4Q for bug-gnu-emacs@gnu.org; Thu, 17 May 2012 02:24:51 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SUu8k-00078A-Kc for bug-gnu-emacs@gnu.org; Thu, 17 May 2012 08:24:46 +0200 Received: from pd9eb32fb.dip.t-dialin.net ([217.235.50.251]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 17 May 2012 08:24:46 +0200 Received: from Stromeko by pd9eb32fb.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 17 May 2012 08:24:46 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Achim Gratz Subject: Re: bug#9754: Issue with Emacs 23.4 Date: Thu, 17 May 2012 08:24:34 +0200 Lines: 18 Message-ID: <87bolne34t.fsf@Rainer.invalid> References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: pd9eb32fb.dip.t-dialin.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) Cancel-Lock: sha1:A0BWusU+EgnQ1qYzWhaNMuRuLcw= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier writes: > Easy: M-x make-frame-on-display. > Or start an emacs server and then connect to the server from an > emacsclient with a DISPLAY set (which ends up calling > make-frame-on-display as well, of course). Didn't know that... but it's been a while since I used a multi-display X setup. Thanks. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptations for KORG EX-800 and Poly-800MkII V0.9: http://Synth.Stromeko.net/Downloads.html#KorgSDada From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 07:05:15 2012 Received: (at 9754) by debbugs.gnu.org; 17 May 2012 11:05:15 +0000 Received: from localhost ([127.0.0.1]:58744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUyWA-0001SO-5W for submit@debbugs.gnu.org; Thu, 17 May 2012 07:05:15 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:49876) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUyVp-0001Rb-6u for 9754@debbugs.gnu.org; Thu, 17 May 2012 07:05:12 -0400 X-CornellRouted: This message has been Routed already. Received: from soapstone1.mail.cornell.edu (soapstone1.mail.cornell.edu [128.253.83.143]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4HB4SFb016956 for <9754@debbugs.gnu.org>; Thu, 17 May 2012 07:04:29 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by soapstone1.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4HB4Z4p001222 for <9754@debbugs.gnu.org>; Thu, 17 May 2012 07:04:35 -0400 (EDT) Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4HB4Lob015035 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 17 May 2012 07:04:23 -0400 (EDT) Message-ID: <4FB4DB2D.7040100@cornell.edu> Date: Thu, 17 May 2012 07:04:13 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.17.105740 X-Original-Sender: kbrown@cornell.edu - Thu May 17 07:04:24 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/16/2012 9:19 PM, Stefan Monnier wrote: >>> At least it doesn't seem "obviously correct" to me: what if the user >>> opens up an X frame after starting "emacs -nw"? >> The hang arises when emacs is started without an X server present or at >> least with DISPLAY not set. I don't see how a user would be able to >> open an X frame at a later point in time in that situation (or >> reasonable expect he might be able to). > > Easy: M-x make-frame-on-display. > Or start an emacs server and then connect to the server from an > emacsclient with a DISPLAY set (which ends up calling > make-frame-on-display as well, of course). So maybe the test if (inhibit_window_system || !display_arg) in my patch should be replaced by if (!x_in_use) Ken From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 08:44:25 2012 Received: (at 9754) by debbugs.gnu.org; 17 May 2012 12:44:26 +0000 Received: from localhost ([127.0.0.1]:58821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV047-0004V0-KI for submit@debbugs.gnu.org; Thu, 17 May 2012 08:44:25 -0400 Received: from limestone4.mail.cornell.edu ([128.253.83.164]:61764) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV043-0004TN-45 for 9754@debbugs.gnu.org; Thu, 17 May 2012 08:44:21 -0400 X-CornellRouted: This message has been Routed already. Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone4.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4HChst5020657 for <9754@debbugs.gnu.org>; Thu, 17 May 2012 08:43:54 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4HChtf5015577 for <9754@debbugs.gnu.org>; Thu, 17 May 2012 08:43:55 -0400 (EDT) Received: from [192.168.1.7] (rrcs-208-125-98-102.nys.biz.rr.com [208.125.98.102]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4HChlu9029111 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 17 May 2012 08:43:48 -0400 (EDT) Message-ID: <4FB4F27B.40508@cornell.edu> Date: Thu, 17 May 2012 08:43:39 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> In-Reply-To: <4FB4DB2D.7040100@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.17.100030 X-Original-Sender: kbrown@cornell.edu - Thu May 17 08:43:49 2012 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/17/2012 7:04 AM, Ken Brown wrote: > So maybe the test > > if (inhibit_window_system || !display_arg) > > in my patch should be replaced by > > if (!x_in_use) Here's the patch (against the trunk) that goes along with my suggestion: === modified file 'src/xfns.c' --- src/xfns.c 2012-05-02 10:20:35 +0000 +++ src/xfns.c 2012-05-17 12:29:53 +0000 @@ -136,7 +136,7 @@ /* Nonzero if using X. */ -static int x_in_use; +int x_in_use; static Lisp_Object Qnone; static Lisp_Object Qsuppress_icon; === modified file 'src/xgselect.c' --- src/xgselect.c 2012-05-16 02:22:53 +0000 +++ src/xgselect.c 2012-05-17 12:31:09 +0000 @@ -28,6 +28,8 @@ #include #include +extern int x_in_use; + static GPollFD *gfds; static ptrdiff_t gfds_size; @@ -43,7 +45,7 @@ int n_gfds = 0, our_tmo = 0, retval = 0, our_fds = 0; int i, nfds, fds_lim, tmo_in_millisec; - if (inhibit_window_system || !display_arg) + if (!x_in_use) return select (max_fds, rfds, wfds, efds, timeout); if (rfds) memcpy (&all_rfds, rfds, sizeof (all_rfds)); From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 08:49:57 2012 Received: (at 9754) by debbugs.gnu.org; 17 May 2012 12:49:57 +0000 Received: from localhost ([127.0.0.1]:58826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV09V-0004xe-2Q for submit@debbugs.gnu.org; Thu, 17 May 2012 08:49:57 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:34383) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV09A-0004xC-GP for 9754@debbugs.gnu.org; Thu, 17 May 2012 08:49:56 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3VtXQR47Ryz3hhWQ; Thu, 17 May 2012 14:49:18 +0200 (CEST) Received: from igel.home (ppp-88-217-121-3.dynamic.mnet-online.de [88.217.121.3]) by mail.mnet-online.de (Postfix) with ESMTPA id 3VtXQR0l1bz4KK7Q; Thu, 17 May 2012 14:49:19 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id A46D0CA2A4; Thu, 17 May 2012 14:49:18 +0200 (CEST) From: Andreas Schwab To: Ken Brown Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> X-Yow: Will this never-ending series of PLEASURABLE EVENTS never cease? Date: Thu, 17 May 2012 14:49:18 +0200 In-Reply-To: <4FB4F27B.40508@cornell.edu> (Ken Brown's message of "Thu, 17 May 2012 08:43:39 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Ken Brown writes: > +extern int x_in_use; That should be put in a header. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 09:21:25 2012 Received: (at 9754) by debbugs.gnu.org; 17 May 2012 13:21:25 +0000 Received: from localhost ([127.0.0.1]:58835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV0dw-0005fC-Bk for submit@debbugs.gnu.org; Thu, 17 May 2012 09:21:25 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:48006) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV0db-0005eK-Vl for 9754@debbugs.gnu.org; Thu, 17 May 2012 09:21:23 -0400 X-CornellRouted: This message has been Routed already. Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4HDKcEG020882; Thu, 17 May 2012 09:20:39 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4HDKdbm024249; Thu, 17 May 2012 09:20:40 -0400 (EDT) Received: from [192.168.1.7] (rrcs-208-125-98-102.nys.biz.rr.com [208.125.98.102]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4HDKcpM005168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 17 May 2012 09:20:39 -0400 (EDT) Message-ID: <4FB4FB1E.3010808@cornell.edu> Date: Thu, 17 May 2012 09:20:30 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Andreas Schwab Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.17.130925 X-Original-Sender: kbrown@cornell.edu - Thu May 17 09:20:40 2012 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/17/2012 8:49 AM, Andreas Schwab wrote: > Ken Brown writes: > >> +extern int x_in_use; > > That should be put in a header. Could you elaborate on that? Are you suggesting a header xfns.h with (essentially) just that one line in it? Thanks. Ken From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 10:01:59 2012 Received: (at 9754) by debbugs.gnu.org; 17 May 2012 14:01:59 +0000 Received: from localhost ([127.0.0.1]:59358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV1HC-0006g3-OY for submit@debbugs.gnu.org; Thu, 17 May 2012 10:01:58 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:59644) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV1H9-0006ft-K5 for 9754@debbugs.gnu.org; Thu, 17 May 2012 10:01:56 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3VtZ1t2SGBz3hhVq; Thu, 17 May 2012 16:01:37 +0200 (CEST) Received: from igel.home (ppp-88-217-121-3.dynamic.mnet-online.de [88.217.121.3]) by mail.mnet-online.de (Postfix) with ESMTPA id 3VtZ1s67Mpz4KK6h; Thu, 17 May 2012 16:01:37 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 74554CA2A4; Thu, 17 May 2012 16:01:37 +0200 (CEST) From: Andreas Schwab To: Ken Brown Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB4FB1E.3010808@cornell.edu> X-Yow: ANN JILLIAN'S HAIR makes LONI ANDERSON'S HAIR look like RICARDO MONTALBAN'S HAIR! Date: Thu, 17 May 2012 16:01:37 +0200 In-Reply-To: <4FB4FB1E.3010808@cornell.edu> (Ken Brown's message of "Thu, 17 May 2012 09:20:30 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Ken Brown writes: > On 5/17/2012 8:49 AM, Andreas Schwab wrote: >> Ken Brown writes: >> >>> +extern int x_in_use; >> >> That should be put in a header. > > Could you elaborate on that? Are you suggesting a header xfns.h with > (essentially) just that one line in it? There are already a lot to choose from. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 11:02:50 2012 Received: (at 9754) by debbugs.gnu.org; 17 May 2012 15:02:50 +0000 Received: from localhost ([127.0.0.1]:59446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV2E5-000860-Nk for submit@debbugs.gnu.org; Thu, 17 May 2012 11:02:50 -0400 Received: from relais.videotron.ca ([24.201.245.36]:64325) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV2Dl-00085Z-5K for 9754@debbugs.gnu.org; Thu, 17 May 2012 11:02:47 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from fmsmemgm.homelinux.net ([184.161.23.35]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0M4600K0U9RNWC80@VL-VM-MR006.ip.videotron.ca> for 9754@debbugs.gnu.org; Thu, 17 May 2012 11:02:11 -0400 (EDT) Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 763E1AE0E5; Thu, 17 May 2012 11:02:11 -0400 (EDT) From: Stefan Monnier To: Ken Brown Subject: Re: bug#9754: Issue with Emacs 23.4 Message-id: References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> Date: Thu, 17 May 2012 11:02:11 -0400 In-reply-to: <4FB4F27B.40508@cornell.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) >> So maybe the test >> if (inhibit_window_system || !display_arg) >> in my patch should be replaced by >> if (!x_in_use) Maybe. As I said, I'm not familiar enough with that code to really know what are the consequences, I just mentioned a few potential problems (without even knowing whether they're real). So unless someone more knowledgeable can confirm that the patch is "obviously safe" I don't want to see it in the emacs-24 branch. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 14:28:04 2012 Received: (at 9754) by debbugs.gnu.org; 17 May 2012 18:28:04 +0000 Received: from localhost ([127.0.0.1]:59630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV5Qi-00060u-9K for submit@debbugs.gnu.org; Thu, 17 May 2012 14:28:04 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:59977) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV5QN-000607-TQ for 9754@debbugs.gnu.org; Thu, 17 May 2012 14:28:02 -0400 X-CornellRouted: This message has been Routed already. Received: from alva02.serverfarm.cornell.edu (alva02.serverfarm.cornell.edu [128.84.106.39]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4HIRAd5025779; Thu, 17 May 2012 14:27:10 -0400 (EDT) Received: from localhost.localdomain (pawpaw.mail.cornell.edu [128.253.83.170]) by alva02.serverfarm.cornell.edu (8.14.4/8.14.4) with ESMTP id q4HIRDWL018757; Thu, 17 May 2012 14:27:13 -0400 Received: from pawpaw.mail.cornell.edu by pawpaw.mail.cornell.edu with queue id 205618147-6; Thu, 17 May 2012 18:26:52 GMT Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) by with SMTP id ; Thu, 17 May 2012 18:26:52 GMT (envelope-from kbrown@cornell.edu) Message-ID: <4FB542E2.7020304@cornell.edu> Date: Thu, 17 May 2012 14:26:42 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.17.181819 X-Original-Sender: kbrown@cornell.edu - Thu May 17 14:26:53 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-PMX-CORNELL: Alva02 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/17/2012 11:02 AM, Stefan Monnier wrote: >>> So maybe the test >>> if (inhibit_window_system || !display_arg) >>> in my patch should be replaced by >>> if (!x_in_use) > > Maybe. As I said, I'm not familiar enough with that code to really know > what are the consequences, I just mentioned a few potential problems > (without even knowing whether they're real). > > So unless someone more knowledgeable can confirm that the patch is > "obviously safe" I don't want to see it in the emacs-24 branch. I understand, and I'm no longer proposing the patch for the emacs-24 branch. My question is about what should be done in the trunk. It seems to me that it would be better to use x_in_use, and I'm wondering if knowledgeable people agree. Ken From debbugs-submit-bounces@debbugs.gnu.org Fri May 18 12:33:52 2012 Received: (at 9754) by debbugs.gnu.org; 18 May 2012 16:33:52 +0000 Received: from localhost ([127.0.0.1]:32983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVQ7j-0005wh-2S for submit@debbugs.gnu.org; Fri, 18 May 2012 12:33:51 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37256 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVQ7O-0005w8-IQ for 9754@debbugs.gnu.org; Fri, 18 May 2012 12:33:49 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SVQ6z-00066K-LX; Fri, 18 May 2012 12:33:05 -0400 From: Glenn Morris To: Ken Brown Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> X-Spook: assassination Armani top secret Watergate sniper MD4 X-Ran: n;B-!'us_UG5o^z^G$ra%'Lrg}3@9}C~WS4?}3@VO8gdW6@e8BOc(x|O%0@lWr9nr{rqWB X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 18 May 2012 12:33:05 -0400 In-Reply-To: <4FB542E2.7020304@cornell.edu> (Ken Brown's message of "Thu, 17 May 2012 14:26:42 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Ken Brown wrote: > I understand, and I'm no longer proposing the patch for the emacs-24 > branch. My question is about what should be done in the trunk. It > seems to me that it would be better to use x_in_use, and I'm wondering > if knowledgeable people agree. More knowledgeable people != me; but I just want to ask what the actual issue is. You said: The call of g_main_context_query in xgselect.c:62 still uses the variables gfds and gfds_size, which are not initialized by xgselect_initialize if we're running emacs -nw. But, more fundamentally, it doesn't make sense for emacs -nw to be interacting with GLib at all. This sort of makes it sound like the last sentence is a cosmetic issue, and it was the first bit (uninitialized variables; although they supposedly are initialized) that stopped your Cygwin crashes. Is the crash reproducible on any other platform besides Cygwin? From debbugs-submit-bounces@debbugs.gnu.org Fri May 18 13:10:28 2012 Received: (at 9754) by debbugs.gnu.org; 18 May 2012 17:10:28 +0000 Received: from localhost ([127.0.0.1]:33007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVQh7-0006q1-Gg for submit@debbugs.gnu.org; Fri, 18 May 2012 13:10:27 -0400 Received: from limestone5.mail.cornell.edu ([128.253.83.165]:65119) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVQh3-0006pn-Q9 for 9754@debbugs.gnu.org; Fri, 18 May 2012 13:10:23 -0400 X-CornellRouted: This message has been Routed already. Received: from soapstone1.mail.cornell.edu (soapstone1.mail.cornell.edu [128.253.83.143]) by limestone5.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4IH9pZU004044; Fri, 18 May 2012 13:09:52 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by soapstone1.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4IH9wpk023592; Fri, 18 May 2012 13:09:58 -0400 (EDT) Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4IH9hD9007248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 18 May 2012 13:09:44 -0400 (EDT) Message-ID: <4FB6824E.10804@cornell.edu> Date: Fri, 18 May 2012 13:09:34 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.18.165728 X-Original-Sender: kbrown@cornell.edu - Fri May 18 13:09:45 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/18/2012 12:33 PM, Glenn Morris wrote: > Ken Brown wrote: > >> I understand, and I'm no longer proposing the patch for the emacs-24 >> branch. My question is about what should be done in the trunk. It >> seems to me that it would be better to use x_in_use, and I'm wondering >> if knowledgeable people agree. > > More knowledgeable people != me; but I just want to ask what the actual > issue is. You said: > > The call of g_main_context_query in xgselect.c:62 still uses the > variables gfds and gfds_size, which are not initialized by > xgselect_initialize if we're running emacs -nw. But, more > fundamentally, it doesn't make sense for emacs -nw to be interacting > with GLib at all. > > This sort of makes it sound like the last sentence is a cosmetic issue, > and it was the first bit (uninitialized variables; although they > supposedly are initialized) that stopped your Cygwin crashes. No, I shouldn't have made the last sentence sound like a cosmetic issue. Paul correctly pointed out that the variables actually are initialized, so I don't understand what caused the crashes. They only started after a recent GLib upgrade, and I wasn't able to figure out why. But in the course of debugging, I began to wonder why emacs -nw was calling GLib functions in the first place. So I applied my patch and found that the crashes stopped. > Is the crash reproducible on any other platform besides Cygwin? I don't know. It would be useful for someone to try it on a GNU/Linux system with glib >= 2.32. Prior to the patch to xgselect.c, I was able to reliably reproduce the crash by simply starting emacs -nw and then doing C-x C-f C-g. But the problem seemed to only occur when Cygwin was running on Windows XP or Windows Vista, not on Windows 7. This makes it seem likely that the issue is Cygwin specific. Ken From debbugs-submit-bounces@debbugs.gnu.org Fri May 18 14:02:49 2012 Received: (at 9754) by debbugs.gnu.org; 18 May 2012 18:02:49 +0000 Received: from localhost ([127.0.0.1]:33083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVRVo-00082l-RS for submit@debbugs.gnu.org; Fri, 18 May 2012 14:02:49 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:13909) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVRVn-00082Z-5E for 9754@debbugs.gnu.org; Fri, 18 May 2012 14:02:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAOMAh09FpZld/2dsb2JhbAA3DqM0gQiBdQEBBAFWIwULCw4mEhQYDSSIE6IRi3Y0OgkBAgECgz4Dg3AEo2OEBVM X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="181020518" Received: from 69-165-153-93.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.93]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 18 May 2012 14:02:19 -0400 Received: by pastel.home (Postfix, from userid 20848) id 5669E59577; Fri, 18 May 2012 14:02:19 -0400 (EDT) From: Stefan Monnier To: Ken Brown Subject: Re: bug#9754: Issue with Emacs 23.4 Message-ID: References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> Date: Fri, 18 May 2012 14:02:19 -0400 In-Reply-To: <4FB542E2.7020304@cornell.edu> (Ken Brown's message of "Thu, 17 May 2012 14:26:42 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I understand, and I'm no longer proposing the patch for the emacs-24 branch. > My question is about what should be done in the trunk. It seems to me that > it would be better to use x_in_use, and I'm wondering if knowledgeable > people agree. I do think it's better, yes. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 18 14:39:24 2012 Received: (at 9754) by debbugs.gnu.org; 18 May 2012 18:39:24 +0000 Received: from localhost ([127.0.0.1]:33105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVS5C-0001HM-Ih for submit@debbugs.gnu.org; Fri, 18 May 2012 14:39:23 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:49986) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVS4p-0001GY-6K for 9754@debbugs.gnu.org; Fri, 18 May 2012 14:39:18 -0400 X-CornellRouted: This message has been Routed already. Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4IIcPV2016933 for <9754@debbugs.gnu.org>; Fri, 18 May 2012 14:38:25 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4IIcTKZ006631 for <9754@debbugs.gnu.org>; Fri, 18 May 2012 14:38:29 -0400 (EDT) Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4IIcRRM020694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 18 May 2012 14:38:27 -0400 (EDT) Message-ID: <4FB69719.4030201@cornell.edu> Date: Fri, 18 May 2012 14:38:17 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.18.182718 X-Original-Sender: kbrown@cornell.edu - Fri May 18 14:38:28 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/18/2012 2:02 PM, Stefan Monnier wrote: >> I understand, and I'm no longer proposing the patch for the emacs-24 branch. >> My question is about what should be done in the trunk. It seems to me that >> it would be better to use x_in_use, and I'm wondering if knowledgeable >> people agree. > > I do think it's better, yes. OK, thanks. Then I'll probably apply the following patch, after waiting a few days to see how a new bug in xg_select that I just reported is resolved. === modified file 'src/lisp.h' --- src/lisp.h 2012-05-09 17:51:30 +0000 +++ src/lisp.h 2012-05-18 13:38:36 +0000 @@ -3549,6 +3549,7 @@ #ifdef HAVE_X_WINDOWS /* Defined in xfns.c */ extern void syms_of_xfns (void); +extern int x_in_use; /* Defined in xsmfns.c */ extern void syms_of_xsmfns (void); === modified file 'src/xfns.c' --- src/xfns.c 2012-05-02 10:20:35 +0000 +++ src/xfns.c 2012-05-18 18:34:10 +0000 @@ -136,7 +136,7 @@ /* Nonzero if using X. */ -static int x_in_use; +int x_in_use; static Lisp_Object Qnone; static Lisp_Object Qsuppress_icon; === modified file 'src/xgselect.c' --- src/xgselect.c 2012-05-16 02:22:53 +0000 +++ src/xgselect.c 2012-05-18 18:33:23 +0000 @@ -43,7 +43,7 @@ int n_gfds = 0, our_tmo = 0, retval = 0, our_fds = 0; int i, nfds, fds_lim, tmo_in_millisec; - if (inhibit_window_system || !display_arg) + if (!x_in_use) return select (max_fds, rfds, wfds, efds, timeout); if (rfds) memcpy (&all_rfds, rfds, sizeof (all_rfds)); Ken From debbugs-submit-bounces@debbugs.gnu.org Fri May 18 15:13:03 2012 Received: (at 9754) by debbugs.gnu.org; 18 May 2012 19:13:03 +0000 Received: from localhost ([127.0.0.1]:33139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVSbn-00023X-3U for submit@debbugs.gnu.org; Fri, 18 May 2012 15:13:03 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:50571) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVSbk-000233-Gf for 9754@debbugs.gnu.org; Fri, 18 May 2012 15:13:01 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 722BCA60008; Fri, 18 May 2012 12:12:32 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 49aFTFfFWAf2; Fri, 18 May 2012 12:12:32 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id EEE1339E8006; Fri, 18 May 2012 12:12:31 -0700 (PDT) Message-ID: <4FB69F1F.9060801@cs.ucla.edu> Date: Fri, 18 May 2012 12:12:31 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Ken Brown Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> <4FB69719.4030201@cornell.edu> In-Reply-To: <4FB69719.4030201@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 05/18/2012 11:38 AM, Ken Brown wrote: > I'll probably apply the following patch Thanks, that looks good, except please put the "extern int x_in_use;" declaration in xterm.h not lisp.h, as x_in_use is related to the X protocol as opposed to Lisp per se. It's true that lisp.h declares syms_of_xfns but there is some defense for that as syms_of_xfns defines Lisp symbols; in contrast, x_in_use has nothing to do with Lisp. From debbugs-submit-bounces@debbugs.gnu.org Fri May 18 16:05:08 2012 Received: (at 9754) by debbugs.gnu.org; 18 May 2012 20:05:08 +0000 Received: from localhost ([127.0.0.1]:33185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVTQB-0003ES-M9 for submit@debbugs.gnu.org; Fri, 18 May 2012 16:05:08 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:49628) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVTPt-0003DT-Cl for 9754@debbugs.gnu.org; Fri, 18 May 2012 16:04:50 -0400 X-CornellRouted: This message has been Routed already. Received: from soapstone1.mail.cornell.edu (soapstone1.mail.cornell.edu [128.253.83.143]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4IK4Fe6029602 for <9754@debbugs.gnu.org>; Fri, 18 May 2012 16:04:16 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by soapstone1.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4IK4O63002387 for <9754@debbugs.gnu.org>; Fri, 18 May 2012 16:04:24 -0400 (EDT) Received: from [128.84.234.250] (dhcp250.math.cornell.edu [128.84.234.250]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4IK4Ict004669 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 18 May 2012 16:04:18 -0400 (EDT) Message-ID: <4FB6AB3F.2020703@cornell.edu> Date: Fri, 18 May 2012 16:04:15 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Paul Eggert Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> <4FB69719.4030201@cornell.edu> <4FB69F1F.9060801@cs.ucla.edu> In-Reply-To: <4FB69F1F.9060801@cs.ucla.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.18.195414 X-Original-Sender: kbrown@cornell.edu - Fri May 18 16:04:19 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/18/2012 3:12 PM, Paul Eggert wrote: > On 05/18/2012 11:38 AM, Ken Brown wrote: >> I'll probably apply the following patch > > Thanks, that looks good, except please put the "extern int x_in_use;" > declaration in xterm.h not lisp.h, as x_in_use is related to > the X protocol as opposed to Lisp per se. It's true that > lisp.h declares syms_of_xfns but there is some defense for > that as syms_of_xfns defines Lisp symbols; in contrast, > x_in_use has nothing to do with Lisp. OK. I was naively putting the declaration in the same place as that of inhibit_window_system and display_arg, but your suggestion makes much more sense. Ken From debbugs-submit-bounces@debbugs.gnu.org Sat May 19 02:30:41 2012 Received: (at 9754) by debbugs.gnu.org; 19 May 2012 06:30:42 +0000 Received: from localhost ([127.0.0.1]:33506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVdBZ-0000vA-GD for submit@debbugs.gnu.org; Sat, 19 May 2012 02:30:41 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:48326 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVdBW-0000v2-Go for 9754@debbugs.gnu.org; Sat, 19 May 2012 02:30:40 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SVdB3-0008Nf-KN; Sat, 19 May 2012 02:30:09 -0400 From: Glenn Morris To: Ken Brown Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> <4FB6824E.10804@cornell.edu> X-Spook: Indigo DRM Osama Blowpipe 9705 Samford Road George W. X-Ran: ~UR}m9\M`H*2Sj?R-Cw8uuh{w7zo;<>RKb7l}{i[JZ|?V X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 19 May 2012 02:30:09 -0400 In-Reply-To: <4FB6824E.10804@cornell.edu> (Ken Brown's message of "Fri, 18 May 2012 13:09:34 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Ken Brown wrote: > I don't know. It would be useful for someone to try it on a GNU/Linux > system with glib >= 2.32. > > Prior to the patch to xgselect.c, I was able to reliably reproduce the > crash by simply starting emacs -nw and then doing C-x C-f C-g. No such crash for me on Debian testing with glib 2.32 and a Gtk build of the emacs-24 branch. From debbugs-submit-bounces@debbugs.gnu.org Sat May 19 08:39:48 2012 Received: (at 9754) by debbugs.gnu.org; 19 May 2012 12:39:48 +0000 Received: from localhost ([127.0.0.1]:33786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SViwm-0001vw-CP for submit@debbugs.gnu.org; Sat, 19 May 2012 08:39:48 -0400 Received: from limestone3.mail.cornell.edu ([128.253.83.163]:45073) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SViwi-0001vg-Vw for 9754@debbugs.gnu.org; Sat, 19 May 2012 08:39:46 -0400 X-CornellRouted: This message has been Routed already. Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4JCd4KB016958; Sat, 19 May 2012 08:39:04 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4JCdBPS000821; Sat, 19 May 2012 08:39:12 -0400 (EDT) Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4JCd7Uf026266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 19 May 2012 08:39:08 -0400 (EDT) Message-ID: <4FB79461.9000602@cornell.edu> Date: Sat, 19 May 2012 08:38:57 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> <4FB6824E.10804@cornell.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.19.123030 X-Original-Sender: kbrown@cornell.edu - Sat May 19 08:39:09 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 Cc: 9754@debbugs.gnu.org, Achim Gratz , Stefan Monnier , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 5/19/2012 2:30 AM, Glenn Morris wrote: > Ken Brown wrote: > >> I don't know. It would be useful for someone to try it on a GNU/Linux >> system with glib>= 2.32. >> >> Prior to the patch to xgselect.c, I was able to reliably reproduce the >> crash by simply starting emacs -nw and then doing C-x C-f C-g. > > No such crash for me on Debian testing with glib 2.32 and a Gtk build of > the emacs-24 branch. Thanks for testing. Ken From debbugs-submit-bounces@debbugs.gnu.org Sat May 19 17:57:29 2012 Received: (at 9754-done) by debbugs.gnu.org; 19 May 2012 21:57:29 +0000 Received: from localhost ([127.0.0.1]:34758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVreT-0006Mt-4J for submit@debbugs.gnu.org; Sat, 19 May 2012 17:57:29 -0400 Received: from limestone8.mail.cornell.edu ([128.253.83.168]:62374) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVreR-0006Me-FO for 9754-done@debbugs.gnu.org; Sat, 19 May 2012 17:57:28 -0400 X-CornellRouted: This message has been Routed already. Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone8.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4JLuqxj008215 for <9754-done@debbugs.gnu.org>; Sat, 19 May 2012 17:56:52 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4JLuq8n014976 for <9754-done@debbugs.gnu.org>; Sat, 19 May 2012 17:56:52 -0400 (EDT) Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4JLuiur009627 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 19 May 2012 17:56:44 -0400 (EDT) Message-ID: <4FB81711.8060005@cornell.edu> Date: Sat, 19 May 2012 17:56:33 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Paul Eggert Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> <4FB69719.4030201@cornell.edu> <4FB69F1F.9060801@cs.ucla.edu> <4FB6AB3F.2020703@cornell.edu> In-Reply-To: <4FB6AB3F.2020703@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.19.214232 X-Original-Sender: kbrown@cornell.edu - Sat May 19 17:56:45 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754-done Cc: Achim Gratz , 9754-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Version: 24.2 I've committed the change as bzr revision 108316, and I'm closing the bug. Ken From debbugs-submit-bounces@debbugs.gnu.org Fri May 25 16:33:29 2012 Received: (at 9754) by debbugs.gnu.org; 25 May 2012 20:33:29 +0000 Received: from localhost ([127.0.0.1]:43596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SY1CS-0006qe-Rt for submit@debbugs.gnu.org; Fri, 25 May 2012 16:33:29 -0400 Received: from limestone5.mail.cornell.edu ([128.253.83.165]:54388) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SY1CQ-0006qQ-GT for 9754@debbugs.gnu.org; Fri, 25 May 2012 16:33:27 -0400 X-CornellRouted: This message has been Routed already. Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone5.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4PKWHZB029848 for <9754@debbugs.gnu.org>; Fri, 25 May 2012 16:32:17 -0400 (EDT) Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4PKWHDi014835 for <9754@debbugs.gnu.org>; Fri, 25 May 2012 16:32:17 -0400 (EDT) Received: from [128.84.234.242] (dhcp242.math.cornell.edu [128.84.234.242]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4PKWHCw009994 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for <9754@debbugs.gnu.org>; Fri, 25 May 2012 16:32:18 -0400 (EDT) Message-ID: <4FBFEC51.7010308@cornell.edu> Date: Fri, 25 May 2012 16:32:17 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: 9754@debbugs.gnu.org Subject: Re: bug#9754: Issue with Emacs 23.4 References: <4FAC34DA.7040606@cs.ucla.edu> <4FB2A9C7.3070604@cornell.edu> <4FB2CFF9.70309@cs.ucla.edu> <4FB2D8AB.7030401@cornell.edu> <878vgsrpoh.fsf@Rainer.invalid> <4FB4DB2D.7040100@cornell.edu> <4FB4F27B.40508@cornell.edu> <4FB542E2.7020304@cornell.edu> <4FB69719.4030201@cornell.edu> <4FB69F1F.9060801@cs.ucla.edu> <4FB6AB3F.2020703@cornell.edu> <4FB81711.8060005@cornell.edu> In-Reply-To: <4FB81711.8060005@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.25.202119 X-Original-Sender: kbrown@cornell.edu - Fri May 25 16:32:18 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9754 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Just to complete this discussion for the sake of the archives, the crashes I was getting resulted from a Cygwin bug, which has been fixed in the 2012-05-25 Cygwin snapshot. But I still think that the patch I applied makes sense, as long as it doesn't cause other problems down the road. Ken From unknown Sat Jun 21 17:34:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 23 Jun 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 06 12:19:01 2013 Received: (at control) by debbugs.gnu.org; 6 Feb 2013 17:19:01 +0000 Received: from localhost ([127.0.0.1]:39587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U38eC-0001Nd-Tc for submit@debbugs.gnu.org; Wed, 06 Feb 2013 12:19:01 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:45014) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U38eB-0001NX-Lo for control@debbugs.gnu.org; Wed, 06 Feb 2013 12:19:00 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U38cw-0005pG-CV for control@debbugs.gnu.org; Wed, 06 Feb 2013 12:17:42 -0500 Date: Wed, 06 Feb 2013 12:17:42 -0500 Message-Id: Subject: control message for bug 6975 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) unarchive 9754 forcemerge 9754 6975 From unknown Sat Jun 21 17:34:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Mar 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator