From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 18:50:48 2011 Received: (at submit) by debbugs.gnu.org; 10 Oct 2011 22:50:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDOgJ-0008Gn-W7 for submit@debbugs.gnu.org; Mon, 10 Oct 2011 18:50:48 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDOgI-0008Gb-4W for submit@debbugs.gnu.org; Mon, 10 Oct 2011 18:50:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDOfy-0007CA-Ke for submit@debbugs.gnu.org; Mon, 10 Oct 2011 18:50:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:59970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDOfy-0007C6-J9 for submit@debbugs.gnu.org; Mon, 10 Oct 2011 18:50:26 -0400 Received: from eggs.gnu.org ([140.186.70.92]:42447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDOfx-0002kz-OD for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2011 18:50:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDOfw-0007Bw-K8 for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2011 18:50:25 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:64816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDOfw-0007Bs-Hd for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2011 18:50:24 -0400 Received: by gya6 with SMTP id 6so7078107gya.0 for ; Mon, 10 Oct 2011 15:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=UFvXeQrN72Cz46ZHqcPvpEFcUD7Unp3x+aRjbSW7eTM=; b=xIDJlDJADktE9mCuMUkhj1twm4j8f816wNzJG3kjNlU8oF5jFtKXpJG/CClFh8h0GB RTmkZapu1TLdtRnEWbEYq+WqRCA5Ktm/r+S2EWHZaZuEg4cOx8Kdnw88NrwJPNC22GSe bTn2WoRU3rXTD0yfwB7OLgzfkcBlAoDlYqLgU= Received: by 10.68.34.226 with SMTP id c2mr39911891pbj.99.1318287023132; Mon, 10 Oct 2011 15:50:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.194.3 with HTTP; Mon, 10 Oct 2011 15:49:43 -0700 (PDT) From: Juanma Barranquero Date: Tue, 11 Oct 2011 00:49:43 +0200 Message-ID: Subject: list-colors-duplicates does not exclude enough colors on Windows To: Bug-Gnu-Emacs Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) Package: emacs Severity: minor On Windows, `list-colors-duplicates' matches the color name against the output of `w32-default-color-map', to avoid conflating colors which are RGB-equal, but semantically different, like SystemMenuText and SystemWindowText. Unfortunately, that makes colors not in that list different even if they are not, in particular all the grayNN/greyNN pairs. The following patch discards that check, and uses instead the heuristic that the only special colors on Windows are the ones starting with "System". That has always been the case anyway, and it's unlikely for the user to define a non-special System* color (and if he does, this patch will cause no harm anyway, it will just not be considered a duplicate of other colors). =C2=A0 =C2=A0 Juanma 2011-10-10 Juanma Barranquero * facemenu.el (list-colors-duplicates): On Windows, detect more duplicates by assuming that only colors matching "^System" are special "system colors". =3D=3D=3D modified file 'lisp/facemenu.el' --- lisp/facemenu.el 2011-09-11 01:55:09 +0000 +++ lisp/facemenu.el 2011-10-10 22:39:20 +0000 @@ -639,8 +639,8 @@ (l list)) (while (cdr l) (if (and (facemenu-color-equal (car (car l)) (car (car (cdr l)))) - (not (if (fboundp 'w32-default-color-map) - (not (assoc (car (car l)) (w32-default-color-map)))))) + (not (and (eq system-type 'windows-nt) + (string-match-p "^System" (car (car l)))))) (progn (setcdr (car l) (cons (car (car (cdr l))) (cdr (car l)))) (setcdr l (cdr (cdr l)))) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 02:01:52 2011 Received: (at 9722) by debbugs.gnu.org; 11 Oct 2011 06:01:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDVPT-0003Vu-04 for submit@debbugs.gnu.org; Tue, 11 Oct 2011 02:01:52 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDVPR-0003Vm-9H for 9722@debbugs.gnu.org; Tue, 11 Oct 2011 02:01:49 -0400 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RDVPB-0000HK-FA; Tue, 11 Oct 2011 02:01:33 -0400 Date: Tue, 11 Oct 2011 02:01:33 -0400 Message-Id: From: Eli Zaretskii To: Juanma Barranquero In-reply-to: (message from Juanma Barranquero on Tue, 11 Oct 2011 00:49:43 +0200) Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows References: X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > From: Juanma Barranquero > Date: Tue, 11 Oct 2011 00:49:43 +0200 > > On Windows, `list-colors-duplicates' matches the color name against > the output of `w32-default-color-map', to avoid conflating colors > which are RGB-equal, but semantically different, like SystemMenuText > and SystemWindowText. > > Unfortunately, that makes colors not in that list different even if > they are not, in particular all the grayNN/greyNN pairs. The duplicates annoyed me as well; thanks for taking care of it. However, there's something I'm missing here: why doesn't list-colors-duplicates recognize grayNN and greyNN as duplicates? We don't have them in the list that w32-default-color-map returns. As for duplicates such as "Dark Slate Gray" and "Dark Slate Grey", which are not filtered out because they _are_ in w32-default-color-map, would something break if we modify the list returned by that function to not include any duplicates in the first place? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 07:25:09 2011 Received: (at 9722) by debbugs.gnu.org; 11 Oct 2011 11:25:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDaSL-0002bu-AF for submit@debbugs.gnu.org; Tue, 11 Oct 2011 07:25:09 -0400 Received: from mail-qw0-f44.google.com ([209.85.216.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDaSI-0002bO-Im for 9722@debbugs.gnu.org; Tue, 11 Oct 2011 07:25:07 -0400 Received: by qadb12 with SMTP id b12so4905251qad.3 for <9722@debbugs.gnu.org>; Tue, 11 Oct 2011 04:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=Nr1I1nIsokPfj+33LSENzHAhzhoOi0s3o8hlp3DVbs0=; b=rYbF75tkzIwH+mC4pW9EtWORVpnDtip90/oyAkCfkFnKUkGJGVhv84oWDirJOLCCxW Bym4gK02iZnQuJAjUXfTY1RZ2pOi6KOV2IrKZr1zLD6beWXmgFlDdivXEIBWmk2pQi2H a/tEgkbXVCItfwxg3CUoEA5zHt24j7mz+qPwY= Received: by 10.68.13.35 with SMTP id e3mr44776385pbc.31.1318332284068; Tue, 11 Oct 2011 04:24:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.194.3 with HTTP; Tue, 11 Oct 2011 04:24:04 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 11 Oct 2011 13:24:04 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Tue, Oct 11, 2011 at 08:01, Eli Zaretskii wrote: > However, there's something I'm missing here: why doesn't > list-colors-duplicates recognize grayNN and greyNN as duplicates? > We don't have them in the list that w32-default-color-map returns. That's why. The System* colors aren't either. What the current code does on Windows is, basically, to detect duplicates when this (and (facemenu-color-equal COLOR1 COLOR2) (assoc COLOR1 (w32-default-color-map))) is true. I.e., COLOR1 is only checked if present in the default color list (which, I'm sure you remember, is the one hardcoded in w32fns.c, not the one from etc/rgb.txt). > As for duplicates such as "Dark Slate Gray" and "Dark Slate Grey", > which are not filtered out because they _are_ in > w32-default-color-map I'm not sure I understand. The dark*slate*gr?y colors are in the list, and so they are detected as duplicates. > would something break if we modify the list > returned by that function to not include any duplicates in the first > place? I don't think any code would break, but you would need to add the missing names at some other point, woudn't you? =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 15:40:32 2011 Received: (at 9722) by debbugs.gnu.org; 11 Oct 2011 19:40:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDiBj-0007MG-A1 for submit@debbugs.gnu.org; Tue, 11 Oct 2011 15:40:31 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDiBh-0007M4-A2 for 9722@debbugs.gnu.org; Tue, 11 Oct 2011 15:40:30 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LSX000002A6RH00@a-mtaout20.012.net.il> for 9722@debbugs.gnu.org; Tue, 11 Oct 2011 21:39:28 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.91.138]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LSX000H42LRKU20@a-mtaout20.012.net.il>; Tue, 11 Oct 2011 21:39:27 +0200 (IST) Date: Tue, 11 Oct 2011 21:39:29 +0200 From: Eli Zaretskii Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows In-reply-to: X-012-Sender: halo1@inter.net.il To: Juanma Barranquero Message-id: <834nzfxqq6.fsf@gnu.org> References: X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Juanma Barranquero > Date: Tue, 11 Oct 2011 13:24:04 +0200 > Cc: 9722@debbugs.gnu.org > > On Tue, Oct 11, 2011 at 08:01, Eli Zaretskii wrote: > > > However, there's something I'm missing here: why doesn't > > list-colors-duplicates recognize grayNN and greyNN as duplicates? > > We don't have them in the list that w32-default-color-map returns. > > That's why. The System* colors aren't either. What the current code > does on Windows is, basically, to detect duplicates when this > > (and (facemenu-color-equal COLOR1 COLOR2) > (assoc COLOR1 (w32-default-color-map))) > > is true. I.e., COLOR1 is only checked if present in the default color > list What is the purpose of checking w32-default-color-map? Is it solely for detecting the System* colors? That sounds an odd method of doing so. It is also fragile: it means any color not in w32-default-color-map will pass the duplicate test. > > As for duplicates such as "Dark Slate Gray" and "Dark Slate Grey", > > which are not filtered out because they _are_ in > > w32-default-color-map > > I'm not sure I understand. The dark*slate*gr?y colors are in the list, > and so they are detected as duplicates. No, they aren't. Don't you see the lines below? dark slate gray dark slate gray,dark slate grey,DarkSlateGray,DarkSlateGrey #2f4f4f dim gray dim gray,dim grey,DimGray,DimGrey #696969 slate gray slate gray,slate grey,SlateGray,SlateGrey #708090 light slate gray light slate gray,light slate grey,LightSlateGray,LightSlateGrey #778899 light gray light gray,light grey,LightGray,LightGrey #d3d3d3 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 16:55:30 2011 Received: (at 9722) by debbugs.gnu.org; 11 Oct 2011 20:55:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDjMH-0000dP-OV for submit@debbugs.gnu.org; Tue, 11 Oct 2011 16:55:30 -0400 Received: from mail-vx0-f172.google.com ([209.85.220.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDjMF-0000dC-7t for 9722@debbugs.gnu.org; Tue, 11 Oct 2011 16:55:27 -0400 Received: by vcbfo11 with SMTP id fo11so5405vcb.3 for <9722@debbugs.gnu.org>; Tue, 11 Oct 2011 13:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=aJgbHI+r3y2TSxoKSEYNYBGtI2nrKGbZznh6yzCGSyQ=; b=HDReP++KyNYIwRUL+S4ntab1rNVc9Y6ixM+8qttxSrCNwZ1i/NVoMd0WoQr924j2I/ Ll71q6swYnvUygFZU2xrgzhD4PUjvFmuGQIOtA6DA3QtzX8PDAaTrJiEazWi8yoECfPJ QZ3dx2Iusg8wYU9bnTxzVA4j0UP98ueKtIcnw= Received: by 10.68.56.72 with SMTP id y8mr2068874pbp.82.1318366502335; Tue, 11 Oct 2011 13:55:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.165.16 with HTTP; Tue, 11 Oct 2011 13:54:22 -0700 (PDT) In-Reply-To: <834nzfxqq6.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> From: Juanma Barranquero Date: Tue, 11 Oct 2011 22:54:22 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Tue, Oct 11, 2011 at 21:39, Eli Zaretskii wrote: > What is the purpose of checking w32-default-color-map? =C2=A0Is it solely > for detecting the System* colors? Well, I don't really know, but in that function that's the only thing it is used for. revno:59445, which introduced list-colors-duplicates and the use of w32-default-color-map, removed the following comment ;; Identify duplicate colors by the name rather than the color ;; value. For example, on MS-Windows, logical colors are added to ;; the list that might have the same value but have different ;; names and meanings. For example, `SystemMenuText' (the color ;; w32 uses for the text in menu entries) and `SystemWindowText' ;; (the default color w32 uses for the text in windows and ;; dialogs) may be the same display color and be adjacent in the ;; list. Detecting duplicates by name insures that both of these ;; colors remain despite identical color values. so it seems that was the only intention. BTW, if we remove the call to w32-d-c-m from list-colors-duplicates, its only use will be in w32fns.c:Fx_open_connection (to initialize Vw32_color_map) and then it is no longer necessary to have it as a lisp level function. > That sounds an odd method of doing so. Yes. > It is also fragile: it means any color not in > w32-default-color-map will pass the duplicate test. Not sure what you mean with "pass the duplicate test". It means that any color not in w32-default-color-map will never be considered duplicate of another color. > No, they aren't. =C2=A0Don't you see the lines below? > > =C2=A0dark slate gray =C2=A0 =C2=A0 =C2=A0 dark slate gray,dark slate gre= y,DarkSlateGray,DarkSlateGrey =C2=A0#2f4f4f > =C2=A0dim gray =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dim gray,d= im grey,DimGray,DimGrey =C2=A0#696969 > =C2=A0slate gray =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0slate gray,slat= e grey,SlateGray,SlateGrey =C2=A0#708090 > =C2=A0light slate gray =C2=A0 =C2=A0 =C2=A0light slate gray,light slate g= rey,LightSlateGray,LightSlateGrey =C2=A0#778899 > =C2=A0light gray =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0light gray,ligh= t grey,LightGray,LightGrey =C2=A0#d3d3d3 Yes, I see them. That means that list-colors-duplicates is correctly detecting them as duplicates: ELISP> (list-colors-duplicates '("black" "dark slate gray" "dark slate gray" "dark slate grey" "DarkSlateGray" "DarkSlateGrey")) (("black") ("dark slate gray" "DarkSlateGrey" "DarkSlateGray" "dark slate grey" "dark slate gray")) Or am I missing something? =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 08:02:33 2011 Received: (at 9722) by debbugs.gnu.org; 17 Oct 2011 12:02:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFlto-0005mu-Qa for submit@debbugs.gnu.org; Mon, 17 Oct 2011 08:02:33 -0400 Received: from mail-pz0-f50.google.com ([209.85.210.50]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFltm-0005mg-Rh for 9722@debbugs.gnu.org; Mon, 17 Oct 2011 08:02:31 -0400 Received: by pzk34 with SMTP id 34so6634453pzk.9 for <9722@debbugs.gnu.org>; Mon, 17 Oct 2011 05:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=O+ShrBOecZxs4VYXYXDZCp557wHtyGERQeqJuzX6dOo=; b=mle0LfScAFHN7pzUqod+5okLVkNrErr+0nWQ6FF6nsUonyiNEcEcFmGTVAhkQAv7SA JKFe5jMCfrfSRRaNNLEgV9aZ2Myg5MWJHIR7VhbrxGJDY+WppTiAvpl36+4dm6XG4KAQ rKEKc4oXO5H8Hi4WDSf/e7y89twbBQI01EdxA= Received: by 10.68.0.227 with SMTP id 3mr37891679pbh.48.1318852894066; Mon, 17 Oct 2011 05:01:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.165.16 with HTTP; Mon, 17 Oct 2011 05:00:54 -0700 (PDT) In-Reply-To: References: <834nzfxqq6.fsf@gnu.org> From: Juanma Barranquero Date: Mon, 17 Oct 2011 14:00:54 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Tue, Oct 11, 2011 at 22:54, Juanma Barranquero wrote: > Or am I missing something? Ping? =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 12:42:17 2011 Received: (at 9722) by debbugs.gnu.org; 17 Oct 2011 16:42:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqGW-0005UR-TV for submit@debbugs.gnu.org; Mon, 17 Oct 2011 12:42:17 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqGT-0005UD-KF for 9722@debbugs.gnu.org; Mon, 17 Oct 2011 12:42:14 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LT700800Y8YVE00@a-mtaout20.012.net.il> for 9722@debbugs.gnu.org; Mon, 17 Oct 2011 18:41:14 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.212.197]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LT7007V7YCPPIF0@a-mtaout20.012.net.il>; Mon, 17 Oct 2011 18:41:14 +0200 (IST) Date: Mon, 17 Oct 2011 18:41:14 +0200 From: Eli Zaretskii Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows In-reply-to: X-012-Sender: halo1@inter.net.il To: Juanma Barranquero Message-id: <83aa8zwoyd.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Juanma Barranquero > Date: Mon, 17 Oct 2011 14:00:54 +0200 > Cc: 9722@debbugs.gnu.org > > On Tue, Oct 11, 2011 at 22:54, Juanma Barranquero wrote: > > > Or am I missing something? > > Ping? Sorry. It doesn't sound TRT to me to use w32-default-color-map for the purpose of retaining some special colors in the list. I think it would be cleaner to have a separate (much shorter) list of colors that should not be removed even if their RGB values are identical to other colors already present in the list produced by defined-colors. If you agree, let's create such a list, put it on w32-fns.el, and use it in facemenu.el. OK? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 12:56:53 2011 Received: (at 9722) by debbugs.gnu.org; 17 Oct 2011 16:56:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqUY-0006XR-IW for submit@debbugs.gnu.org; Mon, 17 Oct 2011 12:56:52 -0400 Received: from mail-qy0-f179.google.com ([209.85.216.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqUU-0006XD-SN for 9722@debbugs.gnu.org; Mon, 17 Oct 2011 12:56:44 -0400 Received: by qyk31 with SMTP id 31so1329058qyk.3 for <9722@debbugs.gnu.org>; Mon, 17 Oct 2011 09:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=iPC8+09m9bhPrCYLysaBwokiKLv0z6YmeRRwbOZ9QIs=; b=w6hCT2Wz0gJrwpeRQJc6pAvcSqJ/nA/ukcYJ7QVYe7TE1C9fuMyAQIKQ9WaN1EMHgl I/Wd5oO18B/1ni++bfLjdiOCtwtdNgQQP1kNqP/eYIkbe2KJCQWhGwzbRcrXlUfXIMDv /23igm2iEJmCOen9UTXKs5r4Fpxat26oDt6AI= Received: by 10.68.0.227 with SMTP id 3mr39417340pbh.48.1318870545055; Mon, 17 Oct 2011 09:55:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.165.16 with HTTP; Mon, 17 Oct 2011 09:55:05 -0700 (PDT) In-Reply-To: <83aa8zwoyd.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> From: Juanma Barranquero Date: Mon, 17 Oct 2011 18:55:05 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Mon, Oct 17, 2011 at 18:41, Eli Zaretskii wrote: > It doesn't sound TRT to me to use w32-default-color-map for the > purpose of retaining some special colors in the list. I doesn't seem TRT to me either. My proposed patch removed that dependency. In fact, I believe that w32-default-color-map should be declared obsolete, to be turned into an internal-only function in some future release. There's no real point to have it exposed to elisp, other than using it in list-colors-duplicates. > =C2=A0I think it > would be cleaner to have a separate (much shorter) list of colors that > should not be removed even if their RGB values are identical to other > colors already present in the list produced by defined-colors. We can add that list, but currently, only colors named System.* are in that category. Checking for "^System" or populating that list are both very ad hoc fixes for a very specific Windows problem. > If you agree, let's create such a list, put it on w32-fns.el, and use > it in facemenu.el. > > OK? I'm not sure. Pros: - The new list could be expanded by the user (if exposed to elisp as a list and not a function) - It does not depend on the reserved colors all being called System.* Contras: - It does not remove the need for w32_color_map / Fw32_default_color_map, because these have another use (default color list in case etc/rgb.txt is not found). - It adds a new function or variable and a bit of complexity, for what is just filtering out a few colors. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 13:16:24 2011 Received: (at 9722) by debbugs.gnu.org; 17 Oct 2011 17:16:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqnX-0006zY-DB for submit@debbugs.gnu.org; Mon, 17 Oct 2011 13:16:23 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqnV-0006zK-Fu for 9722@debbugs.gnu.org; Mon, 17 Oct 2011 13:16:22 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LT700F00ZQ5JM00@a-mtaout23.012.net.il> for 9722@debbugs.gnu.org; Mon, 17 Oct 2011 19:15:23 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.212.197]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LT700FTUZXMD570@a-mtaout23.012.net.il>; Mon, 17 Oct 2011 19:15:23 +0200 (IST) Date: Mon, 17 Oct 2011 19:15:22 +0200 From: Eli Zaretskii Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows In-reply-to: To: Juanma Barranquero Message-id: <837h43wndh.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) > From: Juanma Barranquero > Date: Mon, 17 Oct 2011 18:55:05 +0200 > Cc: 9722@debbugs.gnu.org >=20 > I believe that w32-default-color-map should be declared obsolete, t= o > be turned into an internal-only function in some future > release. There's no real point to have it exposed to elisp, other > than using it in list-colors-duplicates. Perhaps so, but it's a separate issue. > > =C2=A0I think it > > would be cleaner to have a separate (much shorter) list of colors= that > > should not be removed even if their RGB values are identical to o= ther > > colors already present in the list produced by defined-colors. >=20 > We can add that list, but currently, only colors named System.* are= in > that category. Checking for "^System" or populating that list are b= oth > very ad hoc fixes for a very specific Windows problem. Yes, but checking for "^System.*" must be in facemenu.el, while the list could be on a w32-only file. Not a bug deal either way. > Pros: > - The new list could be expanded by the user (if exposed to elisp a= s a > list and not a function) > - It does not depend on the reserved colors all being called System= .* >=20 > Contras: > - It does not remove the need for w32_color_map / > Fw32_default_color_map, because these have another use (default col= or > list in case etc/rgb.txt is not found). > - It adds a new function or variable and a bit of complexity, for w= hat > is just filtering out a few colors. If you feel that the cons outweigh the pros, go ahead and commit your patch. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 10:51:54 2011 Received: (at 9722-done) by debbugs.gnu.org; 18 Oct 2011 14:51:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGB1F-0007SW-J0 for submit@debbugs.gnu.org; Tue, 18 Oct 2011 10:51:54 -0400 Received: from mail-pz0-f50.google.com ([209.85.210.50]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGB1D-0007SH-BD for 9722-done@debbugs.gnu.org; Tue, 18 Oct 2011 10:51:52 -0400 Received: by pzk34 with SMTP id 34so1807540pzk.9 for <9722-done@debbugs.gnu.org>; Tue, 18 Oct 2011 07:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=lqLboeJlxCm7xWX/DHT5CpiZcyhkr2Py0+uO042pZ50=; b=S0FntWM87nZy/CygIAMTHiAnvhKw/9V4LBrvhVlrIMYSfZJRMRDbYkvwYSJNvmTYo/ RxVwT215kmheLSOUu+7/8+/cGcFhBF+yJI+65F7XcaxVN4Vj5JcHXgihtugNnMZst9Lr 10PGrXzivv797043p3QsDghvonpwAjeapXiXU= Received: by 10.68.10.70 with SMTP id g6mr5343885pbb.65.1318949448092; Tue, 18 Oct 2011 07:50:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.165.16 with HTTP; Tue, 18 Oct 2011 07:50:08 -0700 (PDT) In-Reply-To: <837h43wndh.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> <837h43wndh.fsf@gnu.org> From: Juanma Barranquero Date: Tue, 18 Oct 2011 16:50:08 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722-done Cc: 9722-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Mon, Oct 17, 2011 at 19:15, Eli Zaretskii wrote: > Perhaps so, but it's a separate issue. Obviously, it does not affect this bug. Rather, it depends on this bug to be fixed. > Yes, but checking for "^System.*" must be in facemenu.el, while the > list could be on a w32-only file. =C2=A0Not a bug deal either way. You still would need a way to access the list from facemenu.el, conditional to some f?boundp or system-type check, so no net gain there. > If you feel that the cons outweigh the pros, go ahead and commit your > patch. Well, I'm not enthralled by the idea of hardcoding "^System", but I also dislike adding a w32-specific variable that isn't likely to change or be useful to the user. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 11:59:37 2011 Received: (at 9722-done) by debbugs.gnu.org; 18 Oct 2011 15:59:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGC4m-0000Yk-SL for submit@debbugs.gnu.org; Tue, 18 Oct 2011 11:59:37 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGC4l-0000YS-Dh for 9722-done@debbugs.gnu.org; Tue, 18 Oct 2011 11:59:36 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LT900K00R07TM00@a-mtaout23.012.net.il> for 9722-done@debbugs.gnu.org; Tue, 18 Oct 2011 17:58:07 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.212.197]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LT900KJUR0TLG60@a-mtaout23.012.net.il>; Tue, 18 Oct 2011 17:58:07 +0200 (IST) Date: Tue, 18 Oct 2011 17:58:07 +0200 From: Eli Zaretskii Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows In-reply-to: To: Juanma Barranquero Message-id: <83obxeuwa8.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> <837h43wndh.fsf@gnu.org> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 9722-done Cc: 9722-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) > From: Juanma Barranquero > Date: Tue, 18 Oct 2011 16:50:08 +0200 > Cc: 9722-done@debbugs.gnu.org >=20 > > Yes, but checking for "^System.*" must be in facemenu.el, while t= he > > list could be on a w32-only file. =C2=A0Not a bug deal either way= . >=20 > You still would need a way to access the list from facemenu.el, > conditional to some f?boundp or system-type check, so no net gain > there. >=20 > > If you feel that the cons outweigh the pros, go ahead and commit = your > > patch. >=20 > Well, I'm not enthralled by the idea of hardcoding "^System", but I > also dislike adding a w32-specific variable that isn't likely to > change or be useful to the user. We are in agreement. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 12:03:43 2011 Received: (at 9722-done) by debbugs.gnu.org; 18 Oct 2011 16:03:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGC8k-0000fz-2T for submit@debbugs.gnu.org; Tue, 18 Oct 2011 12:03:42 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGC8h-0000fn-GU for 9722-done@debbugs.gnu.org; Tue, 18 Oct 2011 12:03:40 -0400 Received: by gyh20 with SMTP id 20so708127gyh.3 for <9722-done@debbugs.gnu.org>; Tue, 18 Oct 2011 09:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=KXfO9Il3Ezj13UOtZrrfZ6L7wOBY/EZg6951pbJ9GkQ=; b=VEPEjsNwrajnUgiSY6vMdOf0114k4OAply+3xomY6MuZ31BMsMDpp9VF82pMsMdgvB QmPVn9wGFpWfh3sGIrsmoM1bumyRwOA7kqf2NhH8pAFPNDqHHX8kiR8IJH6xKk98+IHv a/QvHDf2ES9iAkb78YTYy6SWXvAOScDSjbsag= Received: by 10.68.13.35 with SMTP id e3mr5866724pbc.31.1318953756104; Tue, 18 Oct 2011 09:02:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.165.16 with HTTP; Tue, 18 Oct 2011 09:01:56 -0700 (PDT) In-Reply-To: <83obxeuwa8.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> <837h43wndh.fsf@gnu.org> <83obxeuwa8.fsf@gnu.org> From: Juanma Barranquero Date: Tue, 18 Oct 2011 18:01:56 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722-done Cc: 9722-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Tue, Oct 18, 2011 at 17:58, Eli Zaretskii wrote: > We are in agreement. BTW, I just realized that the "System" prefix is hardcoded in w32fns.c (SYSTEM_COLOR_PREFIX, which is called from add_system_logical_colors_to_map). =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 13:09:18 2011 Received: (at 9722-done) by debbugs.gnu.org; 18 Oct 2011 17:09:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGDAE-0002Ae-JB for submit@debbugs.gnu.org; Tue, 18 Oct 2011 13:09:18 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGDAB-0002AP-OK for 9722-done@debbugs.gnu.org; Tue, 18 Oct 2011 13:09:17 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LT900E00U2O4T00@a-mtaout22.012.net.il> for 9722-done@debbugs.gnu.org; Tue, 18 Oct 2011 19:07:50 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.212.197]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LT900EX1U913O20@a-mtaout22.012.net.il>; Tue, 18 Oct 2011 19:07:50 +0200 (IST) Date: Tue, 18 Oct 2011 19:07:50 +0200 From: Eli Zaretskii Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows In-reply-to: X-012-Sender: halo1@inter.net.il To: Juanma Barranquero Message-id: <83k482ut21.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> <837h43wndh.fsf@gnu.org> <83obxeuwa8.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 9722-done Cc: 9722-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Juanma Barranquero > Date: Tue, 18 Oct 2011 18:01:56 +0200 > Cc: 9722-done@debbugs.gnu.org > > BTW, I just realized that the "System" prefix is hardcoded in w32fns.c > (SYSTEM_COLOR_PREFIX, which is called from > add_system_logical_colors_to_map). Right. I wonder why we prepend the "System" part at all, why not use the color names as they are in the Registry? But I guess it's too late now to change that. Anyway, does this fact change the conclusions in any way? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 15:26:48 2011 Received: (at 9722) by debbugs.gnu.org; 18 Oct 2011 19:26:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGFJI-0005zS-I1 for submit@debbugs.gnu.org; Tue, 18 Oct 2011 15:26:48 -0400 Received: from mail-qy0-f172.google.com ([209.85.216.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGFJF-0005zF-U3 for 9722@debbugs.gnu.org; Tue, 18 Oct 2011 15:26:47 -0400 Received: by qyk34 with SMTP id 34so2469650qyk.3 for <9722@debbugs.gnu.org>; Tue, 18 Oct 2011 12:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=wzd1PpDcf6O6hb8l4ixGod7U9JVIseAc7VcUfsyXyyg=; b=rqHoGLJDc+qSw7fJLBRpCfZJvwNRZLeEL+HpNsnLzxf2q6tHMpviYBhTfoYzZu6S6d 7/kxPI0d9tT9dVG0y5s8rpRXL+hMxY32w42v3akdWsHpSpxaUo0JcQ1wl7oAZOEuFtbU lKqf13i77LVn82yKvQVJJdq3UBotXF4ei9ICo= Received: by 10.68.34.226 with SMTP id c2mr6734595pbj.99.1318965941061; Tue, 18 Oct 2011 12:25:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.165.16 with HTTP; Tue, 18 Oct 2011 12:25:01 -0700 (PDT) In-Reply-To: <83k482ut21.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> <837h43wndh.fsf@gnu.org> <83obxeuwa8.fsf@gnu.org> <83k482ut21.fsf@gnu.org> From: Juanma Barranquero Date: Tue, 18 Oct 2011 21:25:01 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Tue, Oct 18, 2011 at 19:07, Eli Zaretskii wrote: > Anyway, does this fact change the conclusions in any way? I don't think so. If anything, it makes checking for ^System a bit less ad hoc and a bit safer to use. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 17:02:17 2011 Received: (at 9722) by debbugs.gnu.org; 18 Oct 2011 21:02:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGGnh-0000RT-5E for submit@debbugs.gnu.org; Tue, 18 Oct 2011 17:02:17 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGGne-0000RF-7i for 9722@debbugs.gnu.org; Tue, 18 Oct 2011 17:02:15 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LTA00G004ZW9400@a-mtaout22.012.net.il> for 9722@debbugs.gnu.org; Tue, 18 Oct 2011 23:01:08 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.212.197]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LTA00GI451W2950@a-mtaout22.012.net.il>; Tue, 18 Oct 2011 23:01:08 +0200 (IST) Date: Tue, 18 Oct 2011 23:01:09 +0200 From: Eli Zaretskii Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows In-reply-to: X-012-Sender: halo1@inter.net.il To: Juanma Barranquero Message-id: <83hb36ui96.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> <837h43wndh.fsf@gnu.org> <83obxeuwa8.fsf@gnu.org> <83k482ut21.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Juanma Barranquero > Date: Tue, 18 Oct 2011 21:25:01 +0200 > Cc: 9722@debbugs.gnu.org > > On Tue, Oct 18, 2011 at 19:07, Eli Zaretskii wrote: > > > Anyway, does this fact change the conclusions in any way? > > I don't think so. If anything, it makes checking for ^System a bit > less ad hoc and a bit safer to use. Perhaps add a comment in facemenu.el that mentions where the System* prefix comes from. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 04:29:56 2011 Received: (at 9722) by debbugs.gnu.org; 19 Oct 2011 08:29:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGRX9-0000cT-Nv for submit@debbugs.gnu.org; Wed, 19 Oct 2011 04:29:56 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGRX8-0000cN-7K for 9722@debbugs.gnu.org; Wed, 19 Oct 2011 04:29:54 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 1DFD16E807D; Wed, 19 Oct 2011 01:28:52 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id C7B0A451C4B2; Wed, 19 Oct 2011 01:28:50 -0700 (PDT) From: Juri Linkov To: Juanma Barranquero Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows Organization: JURTA References: <834nzfxqq6.fsf@gnu.org> Date: Wed, 19 Oct 2011 11:20:14 +0300 In-Reply-To: (Juanma Barranquero's message of "Tue, 11 Oct 2011 22:54:22 +0200") Message-ID: <87wrc1ieot.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9722 Cc: Eli Zaretskii , 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Well, I don't really know, but in that function that's the only thing > it is used for. revno:59445, which introduced list-colors-duplicates > and the use of w32-default-color-map As you can see in revno:59445, `w32-default-color-map' used to be a variable that contained just "System" Windows colors. I don't know the subsequent fate of that variable. Hardcoding "^System" in facemenu.el is not bad as long as adding the prefix "System" is hardcoded as well in w32fns.c. Or we could add a new system-independent variable to hold system colors (and add GTK colors to it too). From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 04:37:20 2011 Received: (at 9722) by debbugs.gnu.org; 19 Oct 2011 08:37:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGReJ-0000nd-QZ for submit@debbugs.gnu.org; Wed, 19 Oct 2011 04:37:20 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGReH-0000nO-Dv for 9722@debbugs.gnu.org; Wed, 19 Oct 2011 04:37:18 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LTB00700153I700@a-mtaout20.012.net.il> for 9722@debbugs.gnu.org; Wed, 19 Oct 2011 10:36:03 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.212.197]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LTB006DA181GWD0@a-mtaout20.012.net.il>; Wed, 19 Oct 2011 10:36:02 +0200 (IST) Date: Wed, 19 Oct 2011 10:36:03 +0200 From: Eli Zaretskii Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows In-reply-to: <87wrc1ieot.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il To: Juri Linkov Message-id: <834nz5v0ng.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> <87wrc1ieot.fsf@mail.jurta.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 9722 Cc: lekktu@gmail.com, 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Juri Linkov > Cc: Eli Zaretskii , 9722@debbugs.gnu.org > Date: Wed, 19 Oct 2011 11:20:14 +0300 > > Or we could add a new system-independent variable to hold system colors > (and add GTK colors to it too). GTK is available on Windows as well, so someone someday could port the GTK Emacs to Windows. IOW, if we just add the GTK colors, they should be visible on all platforms. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 04:59:11 2011 Received: (at 9722) by debbugs.gnu.org; 19 Oct 2011 08:59:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGRzS-0001Kr-Dc for submit@debbugs.gnu.org; Wed, 19 Oct 2011 04:59:11 -0400 Received: from mail-gx0-f172.google.com ([209.85.161.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGRzP-0001Kd-OA for 9722@debbugs.gnu.org; Wed, 19 Oct 2011 04:59:08 -0400 Received: by ggnv1 with SMTP id v1so1420264ggn.3 for <9722@debbugs.gnu.org>; Wed, 19 Oct 2011 01:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=bhfq7+PTYM3P8XUKRg1QPVHqICsCRzoDvskJoNaJPYw=; b=VdTBGXitIvJqmrKlwyghezinZc0SQ3wLo8h33qYoD54REFdjovYOSe3Gp9aJVk45iY RjqgWCArzVXLcgOb+h0xFX/aA11qBzK14QISL6KoVKNPMzGbuOC0TeQxVFfFp68DnhCO 8003UTRkhIBl99YoQ5Qz3KXTNttSdsbn2uc9Q= Received: by 10.68.0.227 with SMTP id 3mr11177792pbh.48.1319014680061; Wed, 19 Oct 2011 01:58:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.165.16 with HTTP; Wed, 19 Oct 2011 01:57:20 -0700 (PDT) In-Reply-To: <87wrc1ieot.fsf@mail.jurta.org> References: <834nzfxqq6.fsf@gnu.org> <87wrc1ieot.fsf@mail.jurta.org> From: Juanma Barranquero Date: Wed, 19 Oct 2011 10:57:20 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Juri Linkov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722 Cc: Eli Zaretskii , 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Wed, Oct 19, 2011 at 10:20, Juri Linkov wrote: > Hardcoding "^System" in facemenu.el is not bad as long as adding the > prefix "System" is hardcoded as well in w32fns.c. Yes, that's my thinking too. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 24 15:32:10 2011 Received: (at 9722) by debbugs.gnu.org; 24 Oct 2011 19:32:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RIQFl-00012R-T0 for submit@debbugs.gnu.org; Mon, 24 Oct 2011 15:32:10 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RIQFj-00012C-OB for 9722@debbugs.gnu.org; Mon, 24 Oct 2011 15:32:08 -0400 Received: by gyh20 with SMTP id 20so5944584gyh.3 for <9722@debbugs.gnu.org>; Mon, 24 Oct 2011 12:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=lMDBLVaELLL2AIY5672dwKYpcOaMre2s6CXrf+PnTnE=; b=pFVn3UYAqctLwTnjqFeRDPU+oXsMN61+6a6XDKyIpyKVwuqdCWSmBJLZpe0TaNIi+Z poRGJRjItZ21aKBBYRe84Rw0KJRFlq43xV03BwnTD2+VZE5uSTuJHaBAyR1bVERYSojH QASdxdPSUeWRlEMTOXgDPzvrc2o2rX5sDqBdY= Received: by 10.68.34.226 with SMTP id c2mr49688532pbj.99.1319484628597; Mon, 24 Oct 2011 12:30:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.165.16 with HTTP; Mon, 24 Oct 2011 12:29:48 -0700 (PDT) In-Reply-To: <83hb36ui96.fsf@gnu.org> References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> <837h43wndh.fsf@gnu.org> <83obxeuwa8.fsf@gnu.org> <83k482ut21.fsf@gnu.org> <83hb36ui96.fsf@gnu.org> From: Juanma Barranquero Date: Mon, 24 Oct 2011 21:29:48 +0200 Message-ID: Subject: Re: bug#9722: list-colors-duplicates does not exclude enough colors on Windows To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 9722 Cc: 9722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Tue, Oct 18, 2011 at 23:01, Eli Zaretskii wrote: > Perhaps add a comment in facemenu.el that mentions where the System* > prefix comes from. Done. From unknown Sun Aug 17 22:04:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 22 Nov 2011 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator