GNU bug report logs - #9707
[PATCH] `gnus-thread-hide-subtree' interferes with `gnus-summary-refer-thread'

Previous Next

Package: gnus;

Reported by: Dave Abrahams <dave <at> boostpro.com>

Date: Sun, 9 Oct 2011 01:44:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 5.110018

Fixed in version 24.1

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9707 in the body.
You can then email your comments to 9707 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bugs <at> gnus.org:
bug#9707; Package gnus. (Sun, 09 Oct 2011 01:44:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dave Abrahams <dave <at> boostpro.com>:
New bug report received and forwarded. Copy sent to bugs <at> gnus.org. (Sun, 09 Oct 2011 01:44:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dave Abrahams <dave <at> boostpro.com>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: [PATCH] `gnus-thread-hide-subtree' interferes with
	`gnus-summary-refer-thread'
Date: Sat, 08 Oct 2011 21:43:37 -0400
[Message part 1 (text/plain, inline)]
For example, I have `gnus-thread-hide-subtree' set to `(not
gnus-article-unread-p)', so that when I enter a summary, only threads
with unread messages are expanded.  When I do `A T' so I can see a whole
thread, if the other articles in the thread are already read, I don't
see any change in my summary buffer, or my thread might collapse.  I
actually need to `T s' (`gnus-summary-show-thread') to see them.

The enclosed patch fixes the problem.

[gnus-sum.patch (text/x-patch, inline)]
diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el
index 207d963..2d2c3be 100644
--- a/lisp/gnus-sum.el
+++ b/lisp/gnus-sum.el
@@ -9032,7 +9032,8 @@ non-numeric or nil fetch the number specified by the
               'gnus-article-sort-by-number)))
       (setq gnus-newsgroup-articles
       	    (gnus-sorted-nunion gnus-newsgroup-articles (nreverse article-ids)))
-      (gnus-summary-limit-include-thread id))))
+      (gnus-summary-limit-include-thread id)))
+  (gnus-summary-show-thread))
 
 (defun gnus-summary-refer-article (message-id)
   "Fetch an article specified by MESSAGE-ID."
[Message part 3 (text/plain, inline)]



No Gnus v0.18
GNU Emacs 23.3.1 (x86_64-apple-darwin10.8.0, Carbon Version 1.6.0 AppKit 1038.36)
 of 2011-09-12 on pluto.luannocracy.com
200 Leafnode NNTP Daemon, version 1.11.8 running at localhost (my fqdn: pluto.boostpro.com)
500 Unknown command

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com


Information forwarded to bugs <at> gnus.org:
bug#9707; Package gnus. (Fri, 06 Jan 2012 20:27:02 GMT) Full text and rfc822 format available.

Message #8 received at 9707 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dave Abrahams <dave <at> boostpro.com>
Cc: 9707 <at> debbugs.gnu.org
Subject: Re: bug#9707: [PATCH] `gnus-thread-hide-subtree' interferes with
	`gnus-summary-refer-thread'
Date: Fri, 06 Jan 2012 21:22:59 +0100
Dave Abrahams <dave <at> boostpro.com> writes:

> For example, I have `gnus-thread-hide-subtree' set to `(not
> gnus-article-unread-p)', so that when I enter a summary, only threads
> with unread messages are expanded.  When I do `A T' so I can see a whole
> thread, if the other articles in the thread are already read, I don't
> see any change in my summary buffer, or my thread might collapse.  I
> actually need to `T s' (`gnus-summary-show-thread') to see them.
>
> The enclosed patch fixes the problem.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/




Added tag(s) fixed. Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 06 Jan 2012 20:27:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 24.1, send any further explanations to 9707 <at> debbugs.gnu.org and Dave Abrahams <dave <at> boostpro.com> Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 06 Jan 2012 20:27:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 04 Feb 2012 12:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 13 years and 197 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.