From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: When `gnus-registry-install' is 'ask, nnregistry is broken Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Fri, 07 Oct 2011 12:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: 9691@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Received: via spool by submit@debbugs.gnu.org id=B.131798924620247 (code B ref -1); Fri, 07 Oct 2011 12:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Oct 2011 12:07:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC9D3-0005GW-Ac for submit@debbugs.gnu.org; Fri, 07 Oct 2011 08:07:25 -0400 Received: from mail-vx0-f172.google.com ([209.85.220.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC9D1-0005GG-2F for submit@debbugs.gnu.org; Fri, 07 Oct 2011 08:07:24 -0400 Received: by vcbfo11 with SMTP id fo11so3090238vcb.3 for ; Fri, 07 Oct 2011 05:07:03 -0700 (PDT) Received: by 10.220.108.141 with SMTP id f13mr522172vcp.211.1317989222820; Fri, 07 Oct 2011 05:07:02 -0700 (PDT) Received: from pluto.luannocracy.com (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com. [207.172.223.249]) by mx.google.com with ESMTPS id gx2sm8570425vdb.5.2011.10.07.05.07.01 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Oct 2011 05:07:01 -0700 (PDT) Received: by pluto.luannocracy.com (Postfix, from userid 501) id 16A801093196; Fri, 7 Oct 2011 08:07:02 -0400 (EDT) From: Dave Abrahams Date: Fri, 07 Oct 2011 08:07:02 -0400 Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) nnregistry checks for (eq gnus-registry-install t) and nothing ever changes gnus-registry-install from ask to t. Given that gnus-registry-install is a customization option I think a separate variable is warranted, e.g. gnus-registry-installed. No Gnus v0.18 GNU Emacs 23.3.1 (x86_64-apple-darwin10.8.0, Carbon Version 1.6.0 AppKit 1038.36) of 2011-09-12 on pluto.luannocracy.com 200 Leafnode NNTP Daemon, version 1.11.8 running at localhost (my fqdn: pluto.boostpro.com) 500 Unknown command -- Dave Abrahams BoostPro Computing http://www.boostpro.com From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: Acknowledgement (When `gnus-registry-install' is 'ask, nnregistry is broken) Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Fri, 07 Oct 2011 12:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: 9691@debbugs.gnu.org Received: via spool by 9691-submit@debbugs.gnu.org id=B9691.131799016521639 (code B ref 9691); Fri, 07 Oct 2011 12:23:02 +0000 Received: (at 9691) by debbugs.gnu.org; 7 Oct 2011 12:22:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC9Rt-0005cy-Hw for submit@debbugs.gnu.org; Fri, 07 Oct 2011 08:22:45 -0400 Received: from mail-vx0-f172.google.com ([209.85.220.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC9Rq-0005ck-Q1 for 9691@debbugs.gnu.org; Fri, 07 Oct 2011 08:22:44 -0400 Received: by vcbfo11 with SMTP id fo11so3102272vcb.3 for <9691@debbugs.gnu.org>; Fri, 07 Oct 2011 05:22:23 -0700 (PDT) Received: by 10.220.107.195 with SMTP id c3mr535277vcp.253.1317990142978; Fri, 07 Oct 2011 05:22:22 -0700 (PDT) Received: from pluto.luannocracy.com (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com. [207.172.223.249]) by mx.google.com with ESMTPS id cu18sm8588242vdb.12.2011.10.07.05.22.20 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Oct 2011 05:22:20 -0700 (PDT) Received: by pluto.luannocracy.com (Postfix, from userid 501) id E008D1093481; Fri, 7 Oct 2011 08:22:20 -0400 (EDT) From: Dave Abrahams References: Date: Fri, 07 Oct 2011 08:22:20 -0400 In-Reply-To: (GNU bug Tracking System's message of "Fri, 07 Oct 2011 12:08:02 +0000") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) Hah! It's even more twisted... gnus-registry-install-shortcuts is the place where we call (gnus-registry-install-p), which is the one place we check (eq gnus-registry-install 'ask) to see whether to ask the user about installation. However, the only place where gnus-registry-install-shortcuts is called is gnus-registry-initialize: --8<---------------cut here---------------start------------->8--- ;;;###autoload (defun gnus-registry-initialize () "Initialize the Gnus registry." (interactive) (gnus-message 5 "Initializing the registry") (setq gnus-registry-install t) ; in case it was 'ask or nil (gnus-registry-install-hooks) (gnus-registry-install-shortcuts) (gnus-registry-read)) --8<---------------cut here---------------end--------------->8--- Notice how gnus-registry-initialize sets gnus-registry-install to t /before/ calling gnus-registry-install-shortcuts? That means nobody will ever get asked. Further on down the road, various parts of Gnus look directly at gnus-registry-install in various and sundry ways: --8<---------------cut here---------------start------------->8--- (defun nnmairix-determine-original-group-from-registry (mid) "Try to determinale original group for message-id MID from the registry." (when (and (boundp 'gnus-registry-install) gnus-registry-install) --8<---------------cut here---------------end--------------->8--- [essentially (bound-and-true-p gnus-registry-install)] --8<---------------cut here---------------start------------->8--- (defun nnir-mode () (when (eq (car (gnus-find-method-for-group gnus-newsgroup-name)) 'nnir) (setq gnus-summary-line-format (or nnir-summary-line-format gnus-summary-line-format)) (when (and (boundp 'gnus-registry-install) (eq gnus-registry-install t)) --8<---------------cut here---------------end--------------->8--- and finally: --8<---------------cut here---------------start------------->8--- (deffoo nnregistry-server-opened (server) (eq gnus-registry-install t)) (deffoo nnregistry-open-server (server &optional defs) (eq gnus-registry-install t)) --8<---------------cut here---------------end--------------->8--- It's a mess and I don't know what should be done. From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: Patch Enclosed (When `gnus-registry-install' is 'ask, nnregistry is broken) Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Sun, 09 Oct 2011 02:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: 9691@debbugs.gnu.org Cc: Ted Zlatanov Received: via spool by 9691-submit@debbugs.gnu.org id=B9691.13181289715385 (code B ref 9691); Sun, 09 Oct 2011 02:57:01 +0000 Received: (at 9691) by debbugs.gnu.org; 9 Oct 2011 02:56:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCjYg-0001On-Eg for submit@debbugs.gnu.org; Sat, 08 Oct 2011 22:56:11 -0400 Received: from mail-vx0-f172.google.com ([209.85.220.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCjYd-0001OL-9r for 9691@debbugs.gnu.org; Sat, 08 Oct 2011 22:56:08 -0400 Received: by vcbfo11 with SMTP id fo11so4004775vcb.3 for <9691@debbugs.gnu.org>; Sat, 08 Oct 2011 19:55:58 -0700 (PDT) Received: by 10.52.183.104 with SMTP id el8mr8383378vdc.77.1318128958427; Sat, 08 Oct 2011 19:55:58 -0700 (PDT) Received: from pluto.luannocracy.com (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com. [207.172.223.249]) by mx.google.com with ESMTPS id v8sm13930916vdg.22.2011.10.08.19.55.57 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 08 Oct 2011 19:55:57 -0700 (PDT) Received: by pluto.luannocracy.com (Postfix, from userid 501) id 9656B10AC515; Sat, 8 Oct 2011 22:55:56 -0400 (EDT) From: Dave Abrahams References: Date: Sat, 08 Oct 2011 22:55:56 -0400 In-Reply-To: (Dave Abrahams's message of "Fri, 07 Oct 2011 08:22:20 -0400") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) --=-=-= Content-Type: text/plain Here is my proposed fix for this problem: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Rationalize-the-use-of-gnus-registry-install.patch Content-Description: proposed fix >From dc140ae8315ef7ab9ca07123d94cd40c507c6763 Mon Sep 17 00:00:00 2001 From: Dave Abrahams Date: Sat, 8 Oct 2011 22:50:18 -0400 Subject: [PATCH] Rationalize the use of `gnus-registry-install' - don't programmatically change `gnus-registry-install' (at least not permanently), because it's a user option. - use a new variable, `gnus-registry-enabled', to indicate whether the registry is active. - replace checks of `gnus-registry-install' with checks of `gnus-registry-enabled' This also fixes the bug that with the default setting of `gnus-registry-install' (`ask'), the nnregistry server is stuck at `denied'. --- lisp/gnus-registry.el | 33 +++++++++++++++++++-------------- lisp/nnir.el | 6 ++---- lisp/nnmairix.el | 4 +--- lisp/nnregistry.el | 7 +++++-- 4 files changed, 27 insertions(+), 23 deletions(-) diff --git a/lisp/gnus-registry.el b/lisp/gnus-registry.el index f8ff52f..652e816 100644 --- a/lisp/gnus-registry.el +++ b/lisp/gnus-registry.el @@ -164,6 +164,8 @@ nnmairix groups are specifically excluded because they are ephemeral." (const :tag "Always Install" t) (const :tag "Ask Me" ask))) +(defvar gnus-registry-enabled) + (defvar gnus-summary-misc-menu) ;; Avoid byte compiler warning. (defvar gnus-registry-misc-menus nil) ; ugly way to keep the menus @@ -873,8 +875,9 @@ Uses `gnus-registry-marks' to find what shortcuts to install." ;; if this is called and the user doesn't want the ;; registry enabled, we'll ask anyhow - (when (eq gnus-registry-install nil) - (setq gnus-registry-install 'ask)) + (unless gnus-registry-install + (let ((gnus-registry-install 'ask)) + (gnus-registry-install-p))) ;; now the user is asked if gnus-registry-install is 'ask (when (gnus-registry-install-p) @@ -1151,7 +1154,6 @@ only the last one's marks are returned." "Initialize the Gnus registry." (interactive) (gnus-message 5 "Initializing the registry") - (setq gnus-registry-install t) ; in case it was 'ask or nil (gnus-registry-install-hooks) (gnus-registry-install-shortcuts) (gnus-registry-read)) @@ -1160,6 +1162,7 @@ only the last one's marks are returned." (defun gnus-registry-install-hooks () "Install the registry hooks." (interactive) + (setq gnus-registry-enabled t) (add-hook 'gnus-summary-article-move-hook 'gnus-registry-action) (add-hook 'gnus-summary-article-delete-hook 'gnus-registry-action) (add-hook 'gnus-summary-article-expire-hook 'gnus-registry-action) @@ -1181,23 +1184,25 @@ only the last one's marks are returned." (remove-hook 'gnus-save-newsrc-hook 'gnus-registry-save) (remove-hook 'gnus-read-newsrc-el-hook 'gnus-registry-read) - (remove-hook 'gnus-summary-prepare-hook 'gnus-registry-register-message-ids)) + (remove-hook 'gnus-summary-prepare-hook 'gnus-registry-register-message-ids) + (setq gnus-registry-enabled nil)) (add-hook 'gnus-registry-unload-hook 'gnus-registry-unload-hook) (defun gnus-registry-install-p () + "If the registry is not already enabled, and `gnus-registry-install' is t, +the registry is enabled. If `gnus-registry-install' is `ask', +the user is asked first. Returns non-nil iff the registry is enabled." (interactive) - (when (eq gnus-registry-install 'ask) - (setq gnus-registry-install - (gnus-y-or-n-p - (concat "Enable the Gnus registry? " - "See the variable `gnus-registry-install' " - "to get rid of this query permanently. "))) - (when gnus-registry-install - ;; we just set gnus-registry-install to t, so initialize the registry! + (unless gnus-registry-enabled + (when (if (eq gnus-registry-install 'ask) + (gnus-y-or-n-p + (concat "Enable the Gnus registry? " + "See the variable `gnus-registry-install' " + "to get rid of this query permanently. ")) + gnus-registry-install) (gnus-registry-initialize))) -;;; we could call it here: (customize-variable 'gnus-registry-install) - gnus-registry-install) + gnus-registry-enabled) ;; TODO: a few things diff --git a/lisp/nnir.el b/lisp/nnir.el index 0be6a17..cbd3f74 100644 --- a/lisp/nnir.el +++ b/lisp/nnir.el @@ -290,8 +290,7 @@ is `(valuefunc member)'." (autoload 'nnimap-command "nnimap") (autoload 'nnimap-possibly-change-group "nnimap") (autoload 'nnimap-make-thread-query "nnimap") - (autoload 'gnus-registry-action "gnus-registry") - (defvar gnus-registry-install)) + (autoload 'gnus-registry-action "gnus-registry")) (nnoo-declare nnir) @@ -1741,8 +1740,7 @@ environment unless `not-global' is non-nil." (when (eq (car (gnus-find-method-for-group gnus-newsgroup-name)) 'nnir) (setq gnus-summary-line-format (or nnir-summary-line-format gnus-summary-line-format)) - (when (and (boundp 'gnus-registry-install) - (eq gnus-registry-install t)) + (when (bound-and-true-p gnus-registry-enabled) (remove-hook 'gnus-summary-article-delete-hook 'gnus-registry-action t) (remove-hook 'gnus-summary-article-move-hook 'gnus-registry-action t) (remove-hook 'gnus-summary-article-expire-hook 'gnus-registry-action t) diff --git a/lisp/nnmairix.el b/lisp/nnmairix.el index 3d1ac02..f81aa03 100644 --- a/lisp/nnmairix.el +++ b/lisp/nnmairix.el @@ -603,7 +603,6 @@ Other back ends might or might not work.") nil)) ;; Silence byte-compiler. -(defvar gnus-registry-install) (autoload 'gnus-registry-get-id-key "gnus-registry") (deffoo nnmairix-request-set-mark (group actions &optional server) @@ -1636,8 +1635,7 @@ search in raw mode." (defun nnmairix-determine-original-group-from-registry (mid) "Try to determinale original group for message-id MID from the registry." - (when (and (boundp 'gnus-registry-install) - gnus-registry-install) + (when (bound-and-true-p gnus-registry-enabled) (unless (string-match "^<" mid) (set mid (concat "<" mid))) (unless (string-match ">$" mid) diff --git a/lisp/nnregistry.el b/lisp/nnregistry.el index 359050c..75a640a 100644 --- a/lisp/nnregistry.el +++ b/lisp/nnregistry.el @@ -36,8 +36,11 @@ (nnoo-declare nnregistry) +;; Suppress byte-compiler warning `reference to free variable' +(defvar gnus-registry-enabled) + (deffoo nnregistry-server-opened (server) - (eq gnus-registry-install t)) + gnus-registry-enabled) (deffoo nnregistry-close-server (server) t) @@ -46,7 +49,7 @@ nil) (deffoo nnregistry-open-server (server &optional defs) - (eq gnus-registry-install t)) + gnus-registry-enabled) (defvar nnregistry-within-nnregistry nil) -- 1.7.3.4 --=-=-= Content-Type: text/plain -- Dave Abrahams BoostPro Computing http://www.boostpro.com --=-=-=-- From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: Patch Enclosed (When `gnus-registry-install' is 'ask, nnregistry is broken) Resent-From: Ted Zlatanov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Fri, 14 Oct 2011 20:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: Dave Abrahams , Ted Zlatanov Cc: 9691@debbugs.gnu.org Received: via spool by 9691-submit@debbugs.gnu.org id=B9691.131862548112983 (code B ref 9691); Fri, 14 Oct 2011 20:52:02 +0000 Received: (at 9691) by debbugs.gnu.org; 14 Oct 2011 20:51:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1REoiu-0003NL-86 for submit@debbugs.gnu.org; Fri, 14 Oct 2011 16:51:21 -0400 Received: from cer-mailmxol2.jumptrading.com ([208.78.214.25]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1REoir-0003Mg-QW for 9691@debbugs.gnu.org; Fri, 14 Oct 2011 16:51:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap0EAN+amE7AqF0N/2dsb2JhbABDqWyBbgEBBXkQCw0EAwECCiUPAQQ7DgENBb9Mh3kEiAGRJxaMLA Received: from unknown (HELO chiexchange02.w2k.jumptrading.com) ([192.168.93.13]) by cer-mailmxol2.jumptrading.com with ESMTP; 14 Oct 2011 20:28:29 +0000 Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP Server id 8.2.176.0; Fri, 14 Oct 2011 15:28:29 -0500 Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 14 Oct 2011 15:28:29 -0500 From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Date: Fri, 14 Oct 2011 15:28:21 -0500 In-Reply-To: (Dave Abrahams's message of "Sat, 08 Oct 2011 22:55:56 -0400") Message-ID: <87sjmvmi6y.fsf@lifelogs.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-OriginalArrivalTime: 14 Oct 2011 20:28:29.0119 (UTC) FILETIME=[D5683CF0:01CC8AAF] X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sat, 08 Oct 2011 22:55:56 -0400 Dave Abrahams wrote: DA> Here is my proposed fix for this problem: DA> From dc140ae8315ef7ab9ca07123d94cd40c507c6763 Mon Sep 17 00:00:00 2001 DA> From: Dave Abrahams DA> Date: Sat, 8 Oct 2011 22:50:18 -0400 DA> Subject: [PATCH] Rationalize the use of `gnus-registry-install' DA> - don't programmatically change `gnus-registry-install' (at least not DA> permanently), because it's a user option. DA> - use a new variable, `gnus-registry-enabled', to indicate whether the DA> registry is active. DA> - replace checks of `gnus-registry-install' with checks of DA> `gnus-registry-enabled' DA> This also fixes the bug that with the default setting of DA> `gnus-registry-install' (`ask'), the nnregistry server is stuck at DA> `denied'. This is very nice, thank you. I'll commit it. We're in a feature freeze but I think it's more of a bug fix than a feature. Ted From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: Patch Enclosed (When `gnus-registry-install' is 'ask, nnregistry is broken) Resent-From: Ted Zlatanov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Mon, 17 Oct 2011 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: Dave Abrahams Cc: 9691@debbugs.gnu.org Received: via spool by 9691-submit@debbugs.gnu.org id=B9691.131887236827731 (code B ref 9691); Mon, 17 Oct 2011 17:27:01 +0000 Received: (at 9691) by debbugs.gnu.org; 17 Oct 2011 17:26:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqwy-0007DE-2H for submit@debbugs.gnu.org; Mon, 17 Oct 2011 13:26:08 -0400 Received: from z.lifelogs.com ([173.255.230.239]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqww-0007D7-4P for 9691@debbugs.gnu.org; Mon, 17 Oct 2011 13:26:06 -0400 Received: from heechee (c-76-28-40-19.hsd1.vt.comcast.net [76.28.40.19]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: tzz) by z.lifelogs.com (Postfix) with ESMTPSA id 0BD26620B7; Mon, 17 Oct 2011 17:25:12 +0000 (UTC) From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: <87sjmvmi6y.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Date: Mon, 17 Oct 2011 13:25:12 -0400 In-Reply-To: <87sjmvmi6y.fsf@lifelogs.com> (Ted Zlatanov's message of "Fri, 14 Oct 2011 15:28:21 -0500") Message-ID: <87ehybpm2v.fsf@lifelogs.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Fri, 14 Oct 2011 15:28:21 -0500 Ted Zlatanov wrote: TZ> On Sat, 08 Oct 2011 22:55:56 -0400 Dave Abrahams wrote: DA> Here is my proposed fix for this problem: DA> From dc140ae8315ef7ab9ca07123d94cd40c507c6763 Mon Sep 17 00:00:00 2001 DA> From: Dave Abrahams DA> Date: Sat, 8 Oct 2011 22:50:18 -0400 DA> Subject: [PATCH] Rationalize the use of `gnus-registry-install' DA> - don't programmatically change `gnus-registry-install' (at least not DA> permanently), because it's a user option. DA> - use a new variable, `gnus-registry-enabled', to indicate whether the DA> registry is active. DA> - replace checks of `gnus-registry-install' with checks of DA> `gnus-registry-enabled' DA> This also fixes the bug that with the default setting of DA> `gnus-registry-install' (`ask'), the nnregistry server is stuck at DA> `denied'. TZ> This is very nice, thank you. I'll commit it. We're in a feature TZ> freeze but I think it's more of a bug fix than a feature. This is committed, thanks again and sorry for the delay. Ted From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: Patch Enclosed (When `gnus-registry-install' is 'ask, nnregistry is broken) Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Mon, 17 Oct 2011 19:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: Ted Zlatanov Cc: Dave Abrahams , 9691@debbugs.gnu.org Received: via spool by 9691-submit@debbugs.gnu.org id=B9691.13188789567767 (code B ref 9691); Mon, 17 Oct 2011 19:16:01 +0000 Received: (at 9691) by debbugs.gnu.org; 17 Oct 2011 19:15:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFsfC-00021C-M2 for submit@debbugs.gnu.org; Mon, 17 Oct 2011 15:15:55 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFsfA-000213-5Q for 9691@debbugs.gnu.org; Mon, 17 Oct 2011 15:15:53 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1RFseC-0003Oy-4S; Mon, 17 Oct 2011 21:14:52 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: <87ehybpm2v.fsf@lifelogs.com> (Ted Zlatanov's message of "Mon, 17 Oct 2011 13:25:12 -0400") Date: Mon, 17 Oct 2011 21:14:46 +0200 Message-ID: References: <87sjmvmi6y.fsf@lifelogs.com> <87ehybpm2v.fsf@lifelogs.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUAAAAtAQcJAAEFAACO EScXAARPAxCaS1lMc1PiAAACQklEQVQ4jX2UzVfiMBDAo33oOWrLdTOxeMWOH2d52fa6KQauWy3h KvtK8+/vTCof4r6dkrbkN5+ZASGOJeGFCJCD+CqAQmCB+vEUkCBiAVB8BxFCHp+LH18j3WmMFmfh 4xCcYmOYD2B5AIj0uQ84gPD8MfhKAHUB+bKnjOnraDNSm19nm3G2XIflJrj1VgODyw/xHI5kHd7c Dgw7Vbz3IUhXR/Dnsl8fmwSZajoBcR7C77uwafotqQ8aGhmIp21MSReNlDXYZkxZTffljkSSSwKo UjXfg3OxCGIUtuw8n6j6E4R1VS778ils0kmfUVbvOoILDjcO/ZJij4e0auSWXVT9TWnLa+lV79xi MWkbiOmKbteFApBFzSFaiNWheUkEuhjAUefiySvNFodKcEr1ssUjcAy/8E8+o2vibSrnOMwCg9bc mNaYuEzpV9OzKwB4ZBC39iItg2ixlyreX1bAc3UCWtNVZnYKjAk/x6Fjq69g9tplt50JXeiAwIG8 r0yjTBUMnaOQWWv8J1CkMzNVVxFjUO7AA62rdshCWC891e3L1rwVrZlhPiiJ/ErK1DaeEOJtKVEN MQVcW5mqxjfZS4IPL6/F7StX04o0VTQc5M43rl6UmZyQXxLhnKsJWWnpLZepc1Y60uTezKmlwuU1 QE3Q2dRZm3KjdKKn4h5qQNoGZV1trWNQMBhFkLMnuhoGyXlCP8YUwDlZ52zEQk3OC2p2oXWCxOmF HqBP/wASGpLpdxDnigYhujo1YfpPQK7+D/4CKo/W9lPi/zwAAAAASUVORK5CYII= X-Now-Playing: Various's _Crammed Goes to the Movies_: "MC Jean Gab'1 & Tony Allen - Black" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1RFseC-0003Oy-4S X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1319483692.30347@gxS/fXydm7FjZQkGbnXNBg X-Spam-Status: No X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Ted Zlatanov writes: > This is committed, thanks again and sorry for the delay. Has the FSF gotten Dave's copyright paperwork yet? I haven't been notified of that... And the patch broke the XEmacs build. Please fix. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: Patch Enclosed (When `gnus-registry-install' is 'ask, nnregistry is broken) Resent-From: Ted Zlatanov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Mon, 17 Oct 2011 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: Lars Magne Ingebrigtsen Cc: Dave Abrahams , 9691@debbugs.gnu.org Received: via spool by 9691-submit@debbugs.gnu.org id=B9691.131888154511590 (code B ref 9691); Mon, 17 Oct 2011 20:00:02 +0000 Received: (at 9691) by debbugs.gnu.org; 17 Oct 2011 19:59:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFtKy-00030t-EB for submit@debbugs.gnu.org; Mon, 17 Oct 2011 15:59:05 -0400 Received: from cer-mailmxol2.jumptrading.com ([208.78.214.25]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFtKw-00030P-85 for 9691@debbugs.gnu.org; Mon, 17 Oct 2011 15:59:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEAMRpnE7AqF0N/2dsb2JhbABDqWKBbgEBBXkQCw0UJQ8BBEkOBb8qiAgEiAKRKRaMKw Received: from unknown (HELO chiexchange02.w2k.jumptrading.com) ([192.168.93.13]) by cer-mailmxol2.jumptrading.com with ESMTP; 17 Oct 2011 19:58:03 +0000 Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP Server id 8.2.176.0; Mon, 17 Oct 2011 14:58:03 -0500 Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 17 Oct 2011 14:58:03 -0500 From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: <87sjmvmi6y.fsf@lifelogs.com> <87ehybpm2v.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Date: Mon, 17 Oct 2011 14:57:55 -0500 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 17 Oct 2011 21:14:46 +0200") Message-ID: <87y5wjfl18.fsf@lifelogs.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-OriginalArrivalTime: 17 Oct 2011 19:58:03.0062 (UTC) FILETIME=[143B4D60:01CC8D07] X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Mon, 17 Oct 2011 21:14:46 +0200 Lars Magne Ingebrigtsen wrote: LMI> Ted Zlatanov writes: >> This is committed, thanks again and sorry for the delay. LMI> Has the FSF gotten Dave's copyright paperwork yet? I haven't been LMI> notified of that... I thought they did. Dave? Do you mind if I rewrite your patch so we don't require your papers, if they are not in yet? LMI> And the patch broke the XEmacs build. Please fix. I will, pending Dave's response. Ted From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: Patch Enclosed (When `gnus-registry-install' is 'ask, nnregistry is broken) Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Mon, 17 Oct 2011 22:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: Lars Magne Ingebrigtsen Cc: Ted Zlatanov , "9691@debbugs.gnu.org" <9691@debbugs.gnu.org> Received: via spool by 9691-submit@debbugs.gnu.org id=B9691.131889111028226 (code B ref 9691); Mon, 17 Oct 2011 22:39:02 +0000 Received: (at 9691) by debbugs.gnu.org; 17 Oct 2011 22:38:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFvpF-0007LD-Q0 for submit@debbugs.gnu.org; Mon, 17 Oct 2011 18:38:30 -0400 Received: from mail-vw0-f44.google.com ([209.85.212.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFvpD-0007L0-8r for 9691@debbugs.gnu.org; Mon, 17 Oct 2011 18:38:28 -0400 Received: by vws5 with SMTP id 5so3014733vws.3 for <9691@debbugs.gnu.org>; Mon, 17 Oct 2011 15:37:27 -0700 (PDT) Received: by 10.52.176.40 with SMTP id cf8mr21943456vdc.112.1318891046143; Mon, 17 Oct 2011 15:37:26 -0700 (PDT) Received: from [192.168.188.114] (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com. [207.172.223.249]) by mx.google.com with ESMTPS id r5sm6125543vdw.2.2011.10.17.15.37.24 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Oct 2011 15:37:25 -0700 (PDT) References: <87sjmvmi6y.fsf@lifelogs.com> <87ehybpm2v.fsf@lifelogs.com> In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Message-Id: X-Mailer: iPhone Mail (9A334) From: Dave Abrahams Date: Mon, 17 Oct 2011 18:37:20 -0400 X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) It went in the mail last week and I'm less than 2miles away... Fwiw BoostPro Computing * http://boostpro.com [Sent from coveted but awkward mobile device] -- On Oct 17, 2011, at 3:14 PM, Lars Magne Ingebrigtsen wrote: > Ted Zlatanov writes: > >> This is committed, thanks again and sorry for the delay. > > Has the FSF gotten Dave's copyright paperwork yet? I haven't been > notified of that... > > And the patch broke the XEmacs build. Please fix. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog http://lars.ingebrigtsen.no/ From unknown Sun Jun 22 11:42:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9691: Patch Enclosed (When `gnus-registry-install' is 'ask, nnregistry is broken) Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Tue, 18 Oct 2011 11:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9691 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: Ted Zlatanov Cc: Lars Magne Ingebrigtsen , 9691@debbugs.gnu.org Received: via spool by 9691-submit@debbugs.gnu.org id=B9691.131893771010710 (code B ref 9691); Tue, 18 Oct 2011 11:36:01 +0000 Received: (at 9691) by debbugs.gnu.org; 18 Oct 2011 11:35:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG7ws-0002mg-02 for submit@debbugs.gnu.org; Tue, 18 Oct 2011 07:35:10 -0400 Received: from mail-vw0-f44.google.com ([209.85.212.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG7wo-0002mG-OB for 9691@debbugs.gnu.org; Tue, 18 Oct 2011 07:35:08 -0400 Received: by vws5 with SMTP id 5so225350vws.3 for <9691@debbugs.gnu.org>; Tue, 18 Oct 2011 04:34:04 -0700 (PDT) Received: by 10.52.183.104 with SMTP id el8mr1863662vdc.77.1318937643723; Tue, 18 Oct 2011 04:34:03 -0700 (PDT) Received: from pluto.luannocracy.com (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com. [207.172.223.249]) by mx.google.com with ESMTPS id l4sm1696952vdv.4.2011.10.18.04.34.02 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 18 Oct 2011 04:34:02 -0700 (PDT) Received: by pluto.luannocracy.com (Postfix, from userid 501) id 8D98B1132419; Tue, 18 Oct 2011 07:34:01 -0400 (EDT) From: Dave Abrahams References: <87sjmvmi6y.fsf@lifelogs.com> <87ehybpm2v.fsf@lifelogs.com> <87y5wjfl18.fsf@lifelogs.com> Date: Tue, 18 Oct 2011 07:34:01 -0400 In-Reply-To: <87y5wjfl18.fsf@lifelogs.com> (Ted Zlatanov's message of "Mon, 17 Oct 2011 14:57:55 -0500") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) on Mon Oct 17 2011, Ted Zlatanov wrote: > On Mon, 17 Oct 2011 21:14:46 +0200 Lars Magne Ingebrigtsen wrote: > > LMI> Ted Zlatanov writes: >>> This is committed, thanks again and sorry for the delay. > > LMI> Has the FSF gotten Dave's copyright paperwork yet? I haven't been > LMI> notified of that... > > I thought they did. Dave? Do you mind if I rewrite your patch so we > don't require your papers, if they are not in yet? Rewrite anything you want, please. > LMI> And the patch broke the XEmacs build. Please fix. > > I will, pending Dave's response. Broke the build!? Wow. Ted, when you figure out why, please let me know. -- Dave Abrahams BoostPro Computing http://www.boostpro.com From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 20:10:44 2012 Received: (at control) by debbugs.gnu.org; 7 Jan 2012 01:10:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjKnz-000353-6R for submit@debbugs.gnu.org; Fri, 06 Jan 2012 20:10:43 -0500 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjKnx-00034w-30 for control@debbugs.gnu.org; Fri, 06 Jan 2012 20:10:41 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1RjKkL-0007u6-4L for control@debbugs.gnu.org; Sat, 07 Jan 2012 02:06:57 +0100 Date: Sat, 07 Jan 2012 02:06:56 +0100 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #9691 X-MailScanner-ID: 1RjKkL-0007u6-4L X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1326503217.30288@4z+sTRzT/f/La98GwdoRUQ X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 9691 fixed close 9691 24.1