From unknown Tue Jun 17 20:18:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9679 <9679@debbugs.gnu.org> To: bug#9679 <9679@debbugs.gnu.org> Subject: Status: 24.0.90; After rgrep, next-error goes to the wrong line Reply-To: bug#9679 <9679@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:18:27 +0000 retitle 9679 24.0.90; After rgrep, next-error goes to the wrong line reassign 9679 emacs submitter 9679 Ari Roponen severity 9679 important thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 02:14:30 2011 Received: (at submit) by debbugs.gnu.org; 6 Oct 2011 06:14:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBhDx-00007w-NT for submit@debbugs.gnu.org; Thu, 06 Oct 2011 02:14:30 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBhDv-00007k-NM for submit@debbugs.gnu.org; Thu, 06 Oct 2011 02:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBhDi-0007bP-6e for submit@debbugs.gnu.org; Thu, 06 Oct 2011 02:14:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:58797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBhDi-0007bJ-5C for submit@debbugs.gnu.org; Thu, 06 Oct 2011 02:14:14 -0400 Received: from eggs.gnu.org ([140.186.70.92]:35960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBhDh-00042c-3z for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2011 02:14:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBhDg-0007az-4T for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2011 02:14:13 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:49031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBhDf-0007at-SE for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2011 02:14:12 -0400 Received: by bkbzs2 with SMTP id zs2so3415107bkb.0 for ; Wed, 05 Oct 2011 23:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; bh=WOuXcm7KF2M2RLjVXm5fZ5XYQGQJwFF0dhsH2Gq+45M=; b=oQtdK/4dsIbM4fAiXKY1ieCKMOl10lC4Dm1iP6lopKSQn0ntG/LXiJ5HnMwjXZgE4P +LZ07qk3n+SdCyAo2Dmyq8bR0A1zVon2wa5t/z2SdAykcV1VcYEVIdnnufIb4Yb0ZfHH gCUrWtKqOWLHbv+CLmX8G31sJUU1fq+lEWrnA= Received: by 10.223.17.84 with SMTP id r20mr1464354faa.33.1317881650376; Wed, 05 Oct 2011 23:14:10 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fe17fb00-113.dhcp.inet.fi. [84.251.23.113]) by mx.google.com with ESMTPS id k26sm5647099fab.12.2011.10.05.23.14.08 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Oct 2011 23:14:09 -0700 (PDT) From: Ari Roponen To: bug-gnu-emacs@gnu.org Subject: 24.0.90; After rgrep, next-error goes to the wrong line Date: Thu, 06 Oct 2011 09:14:02 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Sometimes next-error goes to the wrong line when stepping through rgrep matches. Using git bisect and the code below, I found the commit that causes the problem (rev 105677). Reverting that (and before that a commit that depended on it) makes the problem disappear. rev 105685: (grep-regexp-alist): Move dangling comment to the previous rule. rev 105677: progmodes/grep.el (grep-regexp-alist): Calculate column positions I used the following test case to find the problematic commit. It creates a file with two lines matching "mapcar" and then rgreps for it. After that it calls next-error two times. The second call goes into the line starting with " (list 'face ...". ^- here --- code begins ---- (let ((dir (expand-file-name (format "tmp%d" (emacs-pid)) temporary-file-directory))) (ignore-errors (make-directory dir)) (with-temp-file (expand-file-name "test.el" dir) (insert "(defun my-diary-lib--date-to-string (date) (destructuring-bind (month day year) (mapcar 'number-to-string date) (concat day \".\" month \".\" year))) \(defun my-diary-lib--string-to-date (datestr) (destructuring-bind (day month year) (mapcar #'string-to-number (split-string datestr \"\\\\.\")) (list month day year))) \(defun my-diary-lib-add-dayname (datestr) (list 'face 'font-lock-comment-face 'display (concat datestr \" \" (calendar-day-name (my-diary-lib--string-to-date datestr))))) ")) (grep-compute-defaults) (rgrep "mapcar" "test.el" dir) (run-with-idle-timer 0.5 nil #'next-error 1) (run-with-idle-timer 1.0 nil #'next-error 1)) --- code ends --- In GNU Emacs 24.0.90.7 (x86_64-unknown-linux-gnu, GTK+ Version 3.2.0) of 2011-10-06 on arirop Windowing system distributor `Fedora Project', version 11.0.11000000 configured using `configure '--with-x-toolkit=gtk3'' -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 11:29:19 2011 Received: (at 9679) by debbugs.gnu.org; 6 Oct 2011 15:29:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBpss-00044A-RE for submit@debbugs.gnu.org; Thu, 06 Oct 2011 11:29:19 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBpsq-000442-G1 for 9679@debbugs.gnu.org; Thu, 06 Oct 2011 11:29:17 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 05A226E8064; Thu, 6 Oct 2011 08:29:06 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 1F095451C527; Thu, 6 Oct 2011 08:29:04 -0700 (PDT) From: Juri Linkov To: Ari Roponen Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line Organization: JURTA References: Date: Thu, 06 Oct 2011 18:27:56 +0300 In-Reply-To: (Ari Roponen's message of "Thu, 06 Oct 2011 09:14:02 +0300") Message-ID: <8739f6w35v.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Sometimes next-error goes to the wrong line when stepping through rgrep > matches. > > Using git bisect and the code below, I found the commit that causes the > problem (rev 105677). Reverting that (and before that a commit that > depended on it) makes the problem disappear. > > rev 105685: (grep-regexp-alist): Move dangling comment to the previous rule. > rev 105677: progmodes/grep.el (grep-regexp-alist): Calculate column positions > > I used the following test case to find the problematic commit. It > creates a file with two lines matching "mapcar" and then rgreps for it. > After that it calls next-error two times. The second call goes into the > line starting with " (list 'face ...". > ^- here Thanks for the comprehensive test case. I tried it but the second call goes into the line starting with "(mapcar #'string-to-number ...". From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 01:16:18 2011 Received: (at 9679) by debbugs.gnu.org; 7 Oct 2011 05:16:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC2nB-00084n-Kl for submit@debbugs.gnu.org; Fri, 07 Oct 2011 01:16:18 -0400 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC2n8-00084U-Vi for 9679@debbugs.gnu.org; Fri, 07 Oct 2011 01:16:15 -0400 Received: by bkaq10 with SMTP id q10so3996111bka.3 for <9679@debbugs.gnu.org>; Thu, 06 Oct 2011 22:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=u0Pgf2uY8/ObGXGzE/L+MFDAgkESBvzCsqASbEYNkXk=; b=loZH9GnNMnZZyLPYZXrn95REvMixqqeUc6ijUbTfEV08JC58yOdGzXa5xbT0mjxEk3 yME01zNvD9AF5IyIQphS65CXWrPe1+71+JrjIwh4ow5axzQwpKvt3gp1c/c6g3tU5lbz bJmlcCP3jtdTdEYBOUY5MCeT0bg9yMBwu2wOs= Received: by 10.223.65.3 with SMTP id g3mr8625220fai.25.1317964556595; Thu, 06 Oct 2011 22:15:56 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fe17fb00-113.dhcp.inet.fi. [84.251.23.113]) by mx.google.com with ESMTPS id v17sm10712334fai.18.2011.10.06.22.15.53 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Oct 2011 22:15:55 -0700 (PDT) From: Ari Roponen To: Juri Linkov Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line References: <8739f6w35v.fsf@mail.jurta.org> Date: Fri, 07 Oct 2011 08:15:49 +0300 In-Reply-To: <8739f6w35v.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 06 Oct 2011 18:27:56 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) Juri Linkov writes: > Thanks for the comprehensive test case. I tried it but the second call > goes into the line starting with "(mapcar #'string-to-number ...". Hi, I compared the behavior between the version with commits reverted and not reverted. In the reverted commits case, typing M-g M-p and M-g M-n goes to the correct line and column, but highlights the whole line. In the non-reverted commits case, typing those commands goes to the wrong line but right column. The highlight seems to start at the end of correct match and end at the cursor position. I found something that may be relevant to the problem. These are the values of *grep*-buffer's variable compilation-locs in both cases: * Reverted commits case: Value: #s(hash-table size 65 test equal weakness value rehash-size 1.5 rehash-threshold 0.8 data ( ("./test.el") (("./test.el" nil) nil (8 (nil 8 #1 # nil . t)) (3 (nil 3 #1 # nil . t))))) * Non-reverted commits case: Value: #s(hash-table size 65 test equal weakness value rehash-size 1.5 rehash-threshold 0.8 data (("Grep started at Fri Oct 7 07") (("Grep started at Fri Oct 7 07" nil) nil (31 (nil 31 #1 nil nil))) ("./test.el") (("./test.el" nil) nil (8 (13 8 #1 # nil) (7 8 #1 # nil . t)) (3 (13 3 #1 # nil) (7 3 #1 # nil . t))) ("Grep finished (matches found) at Fri Oct 7 07") (("Grep finished (matches found) at Fri Oct 7 07" nil) nil (31 (nil 31 #1 nil nil))))) In the non-reverted commits case, The marker pairs seem to delimit the matched text. The first pair (from 258 to 387) starts at the end of correct match and goes too far. The second pair (from 90 to 96) highlight correctly the first match. I noticed that killing the buffer the markers use seems to fix the problem: 1. Run the test case from the original bug report. 2. Kill the "test.el"-buffer 3. Type M-g M-p M-g M-n Now the cursor is at the beginning of the match and the match is highlighted correctly. The value of compilation-locs in *grep*-buffer is also correct: Value: #s(hash-table size 65 test equal weakness value rehash-size 1.5 rehash-threshold 0.8 data (("Grep started at Fri Oct 7 07") (("Grep started at Fri Oct 7 07" nil) nil (56 (nil 56 #1 nil nil))) ("./test.el") (("./test.el" nil) nil (8 (13 8 #1 # nil) (7 8 #1 # nil . t)) (3 (13 3 #1 # nil) (7 3 #1 # nil . t))) ("Grep finished (matches found) at Fri Oct 7 07") (("Grep finished (matches found) at Fri Oct 7 07" nil) nil (56 (nil 56 #1 nil nil))))) I guess the problem has something to do with those markers. -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 04:42:08 2011 Received: (at 9679) by debbugs.gnu.org; 7 Oct 2011 08:42:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC60N-0006iw-ST for submit@debbugs.gnu.org; Fri, 07 Oct 2011 04:42:08 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC60J-0006iR-Rh for 9679@debbugs.gnu.org; Fri, 07 Oct 2011 04:42:05 -0400 Received: by eye22 with SMTP id 22so2036321eye.3 for <9679@debbugs.gnu.org>; Fri, 07 Oct 2011 01:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=rRsySs4UGyrqoV6EOg28aKyOwRyestPORs5LuorR3cE=; b=Wlj2+JKAyMaRcjlH2PUP99rk+RkM02DalCAGj84aZw/xRU3WRLl+2ldpMZmHi1xZ39 Hv/bwX9f7FghESCXW6dao96PT4OWsVUh4Q7XcxrtMs0NOluPAKxZAr3N7uWVUyRwpV5r geJWHMm3j+05v3qn+hFaTgYVJ+udKQg3d7j2U= Received: by 10.223.15.25 with SMTP id i25mr9335188faa.31.1317976904737; Fri, 07 Oct 2011 01:41:44 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fe17fb00-113.dhcp.inet.fi. [84.251.23.113]) by mx.google.com with ESMTPS id h16sm11547324fab.19.2011.10.07.01.41.42 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Oct 2011 01:41:43 -0700 (PDT) From: Ari Roponen To: Juri Linkov Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line References: <8739f6w35v.fsf@mail.jurta.org> Date: Fri, 07 Oct 2011 11:41:38 +0300 In-Reply-To: (Ari Roponen's message of "Fri, 07 Oct 2011 08:15:49 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) Ari Roponen writes: > I guess the problem has something to do with those markers. I found a way to fix the problem locally without reverting any commits. The function `compilation-next-error-function' contains this: ;; If loc contains no marker, no error in that file has been visited. ;; If the marker is invalid the buffer has been killed. ;; So, recalculate all markers for that file. (unless (and (compilation--loc->marker loc) (marker-buffer (compilation--loc->marker loc)) ;; FIXME-omake: For "omake -P", which automatically recompiles ;; when the file is modified, the line numbers of new output ;; may not be related to line numbers from earlier output When I add "nil" after "and", the problem goes away. -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 11:22:51 2011 Received: (at 9679) by debbugs.gnu.org; 7 Oct 2011 15:22:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCCGA-0001zs-Lv for submit@debbugs.gnu.org; Fri, 07 Oct 2011 11:22:50 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCCG7-0001zi-JJ for 9679@debbugs.gnu.org; Fri, 07 Oct 2011 11:22:48 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 877946E8061; Fri, 7 Oct 2011 08:22:31 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A34EC451C49C; Fri, 7 Oct 2011 08:22:30 -0700 (PDT) From: Juri Linkov To: Ari Roponen Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line Organization: JURTA References: <8739f6w35v.fsf@mail.jurta.org> Date: Fri, 07 Oct 2011 18:20:52 +0300 In-Reply-To: (Ari Roponen's message of "Fri, 07 Oct 2011 08:15:49 +0300") Message-ID: <87r52o7rqj.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > ("./test.el") > (("./test.el" nil) > nil > (8 > (13 8 #1 # nil) > (7 8 #1 # nil . t)) > (3 > (13 3 #1 # nil) > (7 3 #1 # nil . t))) This is odd, I have in the non-reverted commits case after visiting the second match: #s(hash-table size 65 test equal weakness value rehash-size 1.5 rehash-threshold 0.8 data (("./test.el") (("./test.el" nil) nil (8 (13 8 #1 # nil) (7 8 #1 # nil . t)) (3 (13 3 #1 # nil) (7 3 #1 # nil . t))))) So unfortunately I can't reproduce this bug. I suspect it may be related to screen columns because somehow `compilation-move-to-column' in `compilation-next-error-function' goes to the wrong line and column, i.e. to the position 387. What values of `compilation-error-screen-columns' and `grep-error-screen-columns' do you have in the *grep* buffer? I have both of them equal to `nil'. Could you please get the values of arguments that `compilation-move-to-column' receives here by debugging or adding (message "...") and seeing what values it prints in the *Message* buffer? From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 11:51:57 2011 Received: (at 9679) by debbugs.gnu.org; 7 Oct 2011 15:51:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCCiL-0002ev-4N for submit@debbugs.gnu.org; Fri, 07 Oct 2011 11:51:57 -0400 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCCiI-0002eg-6I for 9679@debbugs.gnu.org; Fri, 07 Oct 2011 11:51:55 -0400 Received: by bkaq10 with SMTP id q10so4503971bka.3 for <9679@debbugs.gnu.org>; Fri, 07 Oct 2011 08:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=do4pRBzH1eXUq06juwrqFwqRjhvT7HEvH6LL8WLegA0=; b=NGMkIplGhb/IV8DqtelICnxYXVenhZA+4+sihhNXV8tA9bVmgMfppdMQvoTv6yPnc0 h5fclnXAnsMm8HiNqXN12Ia4vYneu0UyuLnAMTDdVhNPfc6G/W45xxzWRovepEdP5ZXn p3V4AI83HOmWM5Djk+D0UpE1IsIYoOAvOtUjo= Received: by 10.204.152.24 with SMTP id e24mr1614872bkw.136.1318002693232; Fri, 07 Oct 2011 08:51:33 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fe17fb00-113.dhcp.inet.fi. [84.251.23.113]) by mx.google.com with ESMTPS id t13sm1686929fae.0.2011.10.07.08.51.31 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Oct 2011 08:51:32 -0700 (PDT) From: Ari Roponen To: Juri Linkov Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line References: <8739f6w35v.fsf@mail.jurta.org> <87r52o7rqj.fsf@mail.jurta.org> Date: Fri, 07 Oct 2011 18:51:26 +0300 In-Reply-To: <87r52o7rqj.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 07 Oct 2011 18:20:52 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) Juri Linkov writes: > I suspect it may be related to screen columns because somehow > `compilation-move-to-column' in `compilation-next-error-function' > goes to the wrong line and column, i.e. to the position 387. > What values of `compilation-error-screen-columns' and > `grep-error-screen-columns' do you have in the *grep* buffer? > I have both of them equal to `nil'. I run the test case with "emacs -Q -l bug.el", so the variables use their default values: compilation-error-screen-columns is a variable defined in `compile.el'. Its value is nil Original value was t Local in buffer *grep*; global value is t grep-error-screen-columns is a variable defined in `grep.el'. Its value is nil > > Could you please get the values of arguments that > `compilation-move-to-column' receives here by debugging > or adding (message "...") and seeing what values it prints > in the *Message* buffer? (defun compilation-move-to-column (col screen) "Go to column COL on the current line. If SCREEN is non-nil, columns are screen columns, otherwise, they are just char-counts." (message "col: %S, screen %S" col screen) ; Display parameters. (if screen (move-to-column (max col 0)) (goto-char (min (+ (line-beginning-position) col) (line-end-position))))) => Grep finished (matches found) col: 13, screen nil col: 7, screen nil col: 13, screen t col: 7, screen t I get the same values also with the simpler "fix" that I mentioned in the other post. -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 13:10:10 2011 Received: (at 9679) by debbugs.gnu.org; 7 Oct 2011 17:10:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCDw2-0005xm-Ox for submit@debbugs.gnu.org; Fri, 07 Oct 2011 13:10:10 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCDvz-0005xc-LJ for 9679@debbugs.gnu.org; Fri, 07 Oct 2011 13:10:08 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 638896E8077; Fri, 7 Oct 2011 10:09:51 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 87CEF451C49C; Fri, 7 Oct 2011 10:09:50 -0700 (PDT) From: Juri Linkov To: Ari Roponen Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line Organization: JURTA References: <8739f6w35v.fsf@mail.jurta.org> <87r52o7rqj.fsf@mail.jurta.org> Date: Fri, 07 Oct 2011 19:36:00 +0300 In-Reply-To: (Ari Roponen's message of "Fri, 07 Oct 2011 18:51:26 +0300") Message-ID: <874nzk68av.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > col: 13, screen nil > col: 7, screen nil > col: 13, screen t > col: 7, screen t Something is completely broken in your test case, because I get: col: 13, screen nil col: 7, screen nil col: 13, screen nil col: 7, screen nil i.e. `nil' is what's expected for the second match. I don't understand how `t' is possible. It looks like `compilation-next-error-function' is not in `grep-mode' at that time. Could you please add the following `message' to `compilation-next-error-function': (defun compilation-next-error-function (n &optional reset) "Advance to the next error message and visit the file where the error was. This is the value of `next-error-function' in Compilation buffers." (interactive "p") (when reset (setq compilation-current-error nil)) (message "mode: %S, buffer: %S" major-mode (current-buffer)) ... I get the following output: mode: grep-mode, buffer: # col: 13, screen nil col: 7, screen nil col: 13, screen nil col: 7, screen nil mode: grep-mode, buffer: # From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 07 13:49:08 2011 Received: (at 9679) by debbugs.gnu.org; 7 Oct 2011 17:49:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCEXj-0006rW-JW for submit@debbugs.gnu.org; Fri, 07 Oct 2011 13:49:08 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCEXh-0006r2-Qd for 9679@debbugs.gnu.org; Fri, 07 Oct 2011 13:49:06 -0400 Received: by eye22 with SMTP id 22so2573138eye.3 for <9679@debbugs.gnu.org>; Fri, 07 Oct 2011 10:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=HugpPP4cC0msgrSG+1Jbo6Ofey494jEqwhEf7xaeqOY=; b=IRf/Kgbh86hqQ8U97Xbz5SYJ2j8Tdjf/auBQrPoo7oANBH9foodUGA6NVm2iTM19tF Jr6r0MBbDNCVh5d/cylYQUAPLOXWoSaDAgqiu9nObGKMtC+7ym24BA/k1h33zKgMOHeP ChOt32bvnmO5M9nvMMeOoAo68tivGXUbw9Zco= Received: by 10.223.16.82 with SMTP id n18mr12129978faa.2.1318009724457; Fri, 07 Oct 2011 10:48:44 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fe17fb00-113.dhcp.inet.fi. [84.251.23.113]) by mx.google.com with ESMTPS id v17sm13772491fai.18.2011.10.07.10.48.40 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Oct 2011 10:48:42 -0700 (PDT) From: Ari Roponen To: Juri Linkov Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line References: <8739f6w35v.fsf@mail.jurta.org> <87r52o7rqj.fsf@mail.jurta.org> <874nzk68av.fsf@mail.jurta.org> Date: Fri, 07 Oct 2011 20:48:41 +0300 In-Reply-To: <874nzk68av.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 07 Oct 2011 19:36:00 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) Juri Linkov writes: > I don't understand how `t' is possible. It looks like > `compilation-next-error-function' is not in `grep-mode' at that time. > > Could you please add the following `message' to `compilation-next-error-function': > > (defun compilation-next-error-function (n &optional reset) > "Advance to the next error message and visit the file where the error was. > This is the value of `next-error-function' in Compilation buffers." > (interactive "p") > (when reset > (setq compilation-current-error nil)) > (message "mode: %S, buffer: %S" major-mode (current-buffer)) > ... > > I get the following output: > > mode: grep-mode, buffer: # > col: 13, screen nil > col: 7, screen nil > col: 13, screen nil > col: 7, screen nil > mode: grep-mode, buffer: # Grep finished (matches found) mode: grep-mode, buffer: # col: 13, screen nil col: 7, screen nil col: 13, screen t col: 7, screen t mode: grep-mode, buffer: # -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 12:39:23 2011 Received: (at 9679) by debbugs.gnu.org; 8 Oct 2011 16:39:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCZvm-0003cm-Qg for submit@debbugs.gnu.org; Sat, 08 Oct 2011 12:39:23 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCZvj-0003cd-PT for 9679@debbugs.gnu.org; Sat, 08 Oct 2011 12:39:21 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 181FA6E809E; Sat, 8 Oct 2011 09:39:18 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A2FC8451C4A1; Sat, 8 Oct 2011 09:39:13 -0700 (PDT) From: Juri Linkov To: Ari Roponen Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line Organization: JURTA References: <8739f6w35v.fsf@mail.jurta.org> <87r52o7rqj.fsf@mail.jurta.org> <874nzk68av.fsf@mail.jurta.org> Date: Sat, 08 Oct 2011 19:30:12 +0300 In-Reply-To: (Ari Roponen's message of "Fri, 07 Oct 2011 20:48:41 +0300") Message-ID: <87wrcf78dq.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> mode: grep-mode, buffer: # >> col: 13, screen nil >> col: 7, screen nil >> col: 13, screen nil >> col: 7, screen nil >> mode: grep-mode, buffer: # > > Grep finished (matches found) > mode: grep-mode, buffer: # > col: 13, screen nil > col: 7, screen nil > col: 13, screen t > col: 7, screen t > mode: grep-mode, buffer: # Thanks, I can now reproduce this bug. Its occurrence depends on the frame's size. When frame's dimensions are 80x43 with 43 lines or more, so the first grep hit is visible in the *grep* buffer, then font-lock kicks in, calculates absolute column positions, after that `compilation-next-error-function' calculates relative column positions with markers for BOTH grep hits, where the final position of the second grep hit is correct. But when frame's dimensions are 80x42 with 42 lines or less, so the first grep hit is not visible in the *grep* buffer, then fontification doesn't start, and when you call `next-error', `compilation-next-error-function' calculates column positions with markers only for the FIRST grep hit, because the second grep hit is not fontified yet in the *grep* buffer. The second grep hit gets processes later with `jit-lock-fontify-now' that calls `compilation-internal-error-properties' and uses `compilation-move-to-column' to calculate columns. The problem is that `compilation-internal-error-properties' calculates column marker positions differently than `compilation-next-error-function'. Its markers have wrong positions as a result. `compilation-next-error-function' is always called in the *grep* buffer where it gets the buffer-local value of `compilation-error-screen-columns' and keeps its value locally. After that it visits the source buffer and correctly calculates column positions using `compilation-move-to-column'. `compilation-internal-error-properties' tries to do the same, but uses a different algorithm. It gets the global value of `compilation-error-screen-columns' instead of buffer-local from the *grep* buffer. Another difference that contributes to the wrong position is using: (beginning-of-line (if end-line (- line end-line -1) (- loc marker-line -1))) Contrary to this, `compilation-next-error-function' doesn't call `beginning-of-line' after `compilation-move-to-column' moves to the correct column. Unfortunately, I can't fix this, because I don't understand why there are two implementations of column position calculations. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 01:39:09 2011 Received: (at 9679) by debbugs.gnu.org; 9 Oct 2011 05:39:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCm6P-00056x-1V for submit@debbugs.gnu.org; Sun, 09 Oct 2011 01:39:09 -0400 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCm6M-00056U-JZ for 9679@debbugs.gnu.org; Sun, 09 Oct 2011 01:39:07 -0400 Received: by bkaq10 with SMTP id q10so6073499bka.3 for <9679@debbugs.gnu.org>; Sat, 08 Oct 2011 22:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=OewGVRJgSa3RUaimI6OwnWzJwOE64N1KdfFAK6j19Sg=; b=H9RRq/aaWtu2wl36S7brX4Psl+f8yVuottzaY+SDCnZ17lTZOipi2Nei6GuyA1wmdB oHzt/14EtP+1sJMOz4UQp5AbG2fSFBbf6NfxHV2Tw9+UCTFTSQNGjdsAUfDtUYP0ziCG ZaV3BQTk61083FXCIpMY1+GcizPA9tVdXZuTg= Received: by 10.204.7.156 with SMTP id d28mr2514069bkd.40.1318138736953; Sat, 08 Oct 2011 22:38:56 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fe17fb00-113.dhcp.inet.fi. [84.251.23.113]) by mx.google.com with ESMTPS id x4sm6332850fad.1.2011.10.08.22.38.53 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 08 Oct 2011 22:38:55 -0700 (PDT) From: Ari Roponen To: Juri Linkov Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line References: <8739f6w35v.fsf@mail.jurta.org> <87r52o7rqj.fsf@mail.jurta.org> <874nzk68av.fsf@mail.jurta.org> <87wrcf78dq.fsf@mail.jurta.org> Date: Sun, 09 Oct 2011 08:38:54 +0300 In-Reply-To: <87wrcf78dq.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 08 Oct 2011 19:30:12 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) Juri Linkov writes: > Thanks, I can now reproduce this bug. Thank you for looking at this problem. > > Unfortunately, I can't fix this, because I don't understand > why there are two implementations of column position calculations. No worries. As they say, a known bug is better than an unknown regression. :-) -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 25 23:32:09 2012 Received: (at control) by debbugs.gnu.org; 26 Mar 2012 03:32:09 +0000 Received: from localhost ([127.0.0.1]:38862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SC0f7-0005kS-Gh for submit@debbugs.gnu.org; Sun, 25 Mar 2012 23:32:07 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:41392) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SC0em-0005jl-UG for control@debbugs.gnu.org; Sun, 25 Mar 2012 23:32:03 -0400 Received: from bb121-7-229-226.singnet.com.sg ([121.7.229.226]:35189 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SC0Ae-0005Oz-Me for control@debbugs.gnu.org; Sun, 25 Mar 2012 23:00:37 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: severity 9679 important Date: Mon, 26 Mar 2012 11:00:30 +0800 Message-ID: <87limohxrl.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) severity 9679 important thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 06 02:25:20 2012 Received: (at 9679) by debbugs.gnu.org; 6 May 2012 06:25:20 +0000 Received: from localhost ([127.0.0.1]:37686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SQuuF-0005DC-G6 for submit@debbugs.gnu.org; Sun, 06 May 2012 02:25:20 -0400 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:64955) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SQuuC-0005Cy-Bf for 9679@debbugs.gnu.org; Sun, 06 May 2012 02:25:18 -0400 Received: by lagj5 with SMTP id j5so2665928lag.3 for <9679@debbugs.gnu.org>; Sat, 05 May 2012 23:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=KBDrNwGyhxcfhkA9l3+HugqEbk8RIpXZ/ZQaAXOFjvM=; b=t3qL9vuVNu3sG0GMq72zDwJ48oJ+P6GLh/Bnmj4me/BPAP5C1YIXz7S0I0TskJKwfd hIWZhBd7QtIk6/dhImhdTCyNTX5mZK+PF53fCOJonsttjK2eyp3Lm3ReV44CnmGMVtz2 iN1sNnX4dT7+VfKFvhQp5TLL/UDcD8GiHhVVO8hsmBw+xpO32WBkxO4zaTE+POhQQpD+ t2ZK45gMJrAgYy3PkHVJ7G6qvSGMFA0QhUF8aLIgFUbxNfW8X70EomGhynO0ptvAHDMY dkytGgEPxK/uKjnLtv4eXjBvO0MWC3J9dnfCDPRwtlylb1Aijjxo0lky8Jx7XQZMlaZI s6PQ== Received: by 10.112.37.164 with SMTP id z4mr3422090lbj.100.1336285396606; Sat, 05 May 2012 23:23:16 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fe82df00-79.dhcp.inet.fi. [80.223.130.79]) by mx.google.com with ESMTPS id pi5sm10557881lab.7.2012.05.05.23.23.15 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 05 May 2012 23:23:16 -0700 (PDT) From: Ari Roponen To: Juri Linkov Subject: Re: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line References: <8739f6w35v.fsf@mail.jurta.org> <87r52o7rqj.fsf@mail.jurta.org> <874nzk68av.fsf@mail.jurta.org> <87wrcf78dq.fsf@mail.jurta.org> Date: Sun, 06 May 2012 09:23:10 +0300 In-Reply-To: (Ari Roponen's message of "Sun, 09 Oct 2011 08:38:54 +0300") Message-ID: <87sjfdeskx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Ari Roponen writes: > Juri Linkov writes: > >> Thanks, I can now reproduce this bug. > > Thank you for looking at this problem. > >> >> Unfortunately, I can't fix this, because I don't understand >> why there are two implementations of column position calculations. > > No worries. As they say, a known bug is better than an unknown > regression. :-) Hi, I can't reproduce this bug any more with todays checkout. It seems that this commit fixed the bug: revno: 108138 fixes bug(s): http://debbugs.gnu.org/11382 author: Troels Nielsen committer: Chong Yidong branch nick: trunk timestamp: Sun 2012-05-06 12:52:58 +0800 message: Fix match highlighting in compilation buffers. * progmodes/compile.el (compilation-internal-error-properties): Calculate start position correctly when end-col is set but end-line is not. -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Sun May 06 22:28:28 2012 Received: (at control) by debbugs.gnu.org; 7 May 2012 02:28:28 +0000 Received: from localhost ([127.0.0.1]:38998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SRDgZ-0001a7-Ic for submit@debbugs.gnu.org; Sun, 06 May 2012 22:28:28 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:40594 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SRDgU-0001Zx-Dx for control@debbugs.gnu.org; Sun, 06 May 2012 22:28:23 -0400 Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:49657 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SRDeY-00064B-QA for control@debbugs.gnu.org; Sun, 06 May 2012 22:26:23 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 9679 Date: Mon, 07 May 2012 10:26:14 +0800 Message-ID: <87r4uwybeh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 9679 thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 13 02:40:50 2012 Received: (at 9679) by debbugs.gnu.org; 13 May 2012 06:40:51 +0000 Received: from localhost ([127.0.0.1]:50986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STSU5-0000RP-K6 for submit@debbugs.gnu.org; Sun, 13 May 2012 02:40:50 -0400 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:56821) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STSTj-0000Qc-DH for 9679@debbugs.gnu.org; Sun, 13 May 2012 02:40:46 -0400 Received: by lagv3 with SMTP id v3so1356324lag.3 for <9679@debbugs.gnu.org>; Sat, 12 May 2012 23:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=ZDJuvH39kFGLlu/ZyDruMGLJwIsix8cyJkQabZxmo0M=; b=oasKmsr5kWgEM8wrzIp+Ir5rTooAvFjFj6umszHofVGs1FDdSBqN1U6pIYl9PuCh7Q vJETA57zFeIke8sLO532cI6CRGBewlYUGgEWq3MuXJUE9QvvMYZd7xO3Kgi0k5GPmp9V POLWc7B6r/3fhtkuE1+QDuSk04x41W8vBlYcq2jLzbAO6Gr+DFL+zyT/Rz7+XQlbFmhD X4TjXUapnyd4HULG2dcp1doC4z0plW0dAtKwnf8OYCcaZmLCRknzoJ/ZADUastVdBPrr MpLc7NbsNPJiKUH9+d/S4c4FY/htOf7SO5iyCUlEeRau3e46W5QhCobXjG15V6EF4oyJ kCdw== Received: by 10.152.122.9 with SMTP id lo9mr3800837lab.48.1336891206478; Sat, 12 May 2012 23:40:06 -0700 (PDT) Received: from arirop (dsl-jklbrasgw1-fe82df00-79.dhcp.inet.fi. [80.223.130.79]) by mx.google.com with ESMTPS id ox7sm18824409lbb.17.2012.05.12.23.40.05 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 12 May 2012 23:40:05 -0700 (PDT) From: Ari Roponen To: 9679@debbugs.gnu.org Subject: Re: bug#9679 acknowledged by developer (close 9679) References: <87r4uwybeh.fsf@gnu.org> Date: Sun, 13 May 2012 09:39:57 +0300 In-Reply-To: (GNU bug Tracking System's message of "Sun, 06 May 2012 22:29:03 -0400") Message-ID: <87vck0lh36.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 9679 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This bug ("24.0.90; After rgrep, next-error goes to the wrong line") was fixed in trunk, but it still happens in emacs-24 branch. Maybe the patch from the following revision could be backported/applied into the emacs-24 branch. I just tested it locally, and it indeed fixed the problem there, too. revno: 108138 fixes bug(s): http://debbugs.gnu.org/11382 author: Troels Nielsen committer: Chong Yidong branch nick: trunk timestamp: Sun 2012-05-06 12:52:58 +0800 message: Fix match highlighting in compilation buffers. * progmodes/compile.el (compilation-internal-error-properties): Calculate start position correctly when end-col is set but end-line is not. -- Ari Roponen From debbugs-submit-bounces@debbugs.gnu.org Sun May 13 05:18:59 2012 Received: (at 9679) by debbugs.gnu.org; 13 May 2012 09:18:59 +0000 Received: from localhost ([127.0.0.1]:51104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STUx8-0004q5-Nq for submit@debbugs.gnu.org; Sun, 13 May 2012 05:18:59 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:32958 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STUwn-0004pf-Jf for 9679@debbugs.gnu.org; Sun, 13 May 2012 05:18:56 -0400 Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:57996 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1STUwW-0007XM-D2; Sun, 13 May 2012 05:18:21 -0400 From: Chong Yidong To: Ari Roponen Subject: Re: bug#9679: acknowledged by developer (close 9679) References: <87r4uwybeh.fsf@gnu.org> <87vck0lh36.fsf@gmail.com> Date: Sun, 13 May 2012 17:18:14 +0800 In-Reply-To: <87vck0lh36.fsf@gmail.com> (Ari Roponen's message of "Sun, 13 May 2012 09:39:57 +0300") Message-ID: <87y5owwiax.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.96 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 9679 Cc: 9679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Ari Roponen writes: > This bug ("24.0.90; After rgrep, next-error goes to the wrong line") was > fixed in trunk, but it still happens in emacs-24 branch. > > Maybe the patch from the following revision could be backported/applied > into the emacs-24 branch. I just tested it locally, and it indeed fixed > the problem there, too. Ah, I didn't realize this was a regression against Emacs 23. I've backported the fix the emacs-24 branch; thanks for the heads-up. From unknown Tue Jun 17 20:18:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Jun 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator