From unknown Thu Aug 14 21:23:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9639 <9639@debbugs.gnu.org> To: bug#9639 <9639@debbugs.gnu.org> Subject: Status: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Reply-To: bug#9639 <9639@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:23:30 +0000 retitle 9639 24.0.90; Problem with bury-buffer in minibuffer-hide-completio= ns reassign 9639 emacs submitter 9639 Stephen Berman severity 9639 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 18:11:17 2011 Received: (at submit) by debbugs.gnu.org; 30 Sep 2011 22:11:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R9lIb-0001fD-5t for submit@debbugs.gnu.org; Fri, 30 Sep 2011 18:11:17 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R9lIX-0001f5-OT for submit@debbugs.gnu.org; Fri, 30 Sep 2011 18:11:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9lHQ-0000BO-1J for submit@debbugs.gnu.org; Fri, 30 Sep 2011 18:10:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:41728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9lHP-0000BK-W1 for submit@debbugs.gnu.org; Fri, 30 Sep 2011 18:10:03 -0400 Received: from eggs.gnu.org ([140.186.70.92]:39474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9lHO-0004nl-T3 for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2011 18:10:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9lHN-0000As-9d for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2011 18:10:02 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:41773) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1R9lHM-0000Ai-OZ for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2011 18:10:01 -0400 Received: (qmail invoked by alias); 30 Sep 2011 22:09:58 -0000 Received: from i59F555C7.versanet.de (EHLO escher.home) [89.245.85.199] by mail.gmx.net (mp049) with SMTP; 01 Oct 2011 00:09:58 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1/7ERIeDcz7IaSZYqUM3j/gCgCQnqdLQrY1EMjOoj Z6VgDH29sZ9Aur Received: by escher.home (Postfix, from userid 1000) id 95CE1228F6; Sat, 1 Oct 2011 00:09:56 +0200 (CEST) From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Date: Sat, 01 Oct 2011 00:09:56 +0200 Message-ID: <87hb3thebv.fsf@escher.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) 1. emacs -Q 2. Type `M-x glo TAB' and at the completion "M-x global-" type TAB again, making a *Completions* buffer pop up. 3. Type `v TAB', yielding the completion "M-x global-visual-line-mode". => The window that had been displaying the *Completions* buffer now displays the *Messages* buffer. AFAICT this is due to the following cond clause in bury-buffer (which is called by minibuffer-hide-completions): ((not (window-dedicated-p)) (switch-to-prev-buffer nil 'bury)) Only after typing RET in the minibuffer to accept the completion is the window that had been displaying the *Completions* buffer and now displays the *Messages* buffer deleted; in Emacs 23.2 it is deleted as soon as the sole completion is displayed in the minibuffer. Commenting out the above clause restores the 23.2 behavior. But this presumably has bad effects elsewhere. (Interestingly, the C code of bury-buffer prior to the move to Lisp in revision 104559 (and long before that) has the equivalent of the above clause.) In GNU Emacs 24.0.90.1 (i686-suse-linux-gnu, GTK+ Version 2.22.1) of 2011-09-30 on escher Windowing system distributor `The X.Org Foundation', version 11.0.10903000 configured using `configure '--without-toolkit-scroll-bars' 'CFLAGS=-g'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=local locale-coding-system: utf-8-unix default enable-multibyte-characters: t From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 05:09:26 2011 Received: (at 9639) by debbugs.gnu.org; 1 Oct 2011 09:09:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R9vZW-00087B-FF for submit@debbugs.gnu.org; Sat, 01 Oct 2011 05:09:26 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R9vZT-000871-Bu for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 05:09:24 -0400 Received: (qmail invoked by alias); 01 Oct 2011 09:08:10 -0000 Received: from 62-47-56-209.adsl.highway.telekom.at (EHLO [62.47.56.209]) [62.47.56.209] by mail.gmx.net (mp047) with SMTP; 01 Oct 2011 11:08:10 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/mYrJbIc7m5jpLzD2k0cJMwvG2JApD36d7+xCUIX NBoZq5gB6FZpNA Message-ID: <4E86D879.7060105@gmx.at> Date: Sat, 01 Oct 2011 11:08:09 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Stephen Berman Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> In-Reply-To: <87hb3thebv.fsf@escher.home> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > 1. emacs -Q > 2. Type `M-x glo TAB' and at the completion "M-x global-" type TAB again, > making a *Completions* buffer pop up. > 3. Type `v TAB', yielding the completion "M-x global-visual-line-mode". > => The window that had been displaying the *Completions* buffer now > displays the *Messages* buffer. > > AFAICT this is due to the following cond clause in bury-buffer (which is > called by minibuffer-hide-completions): > > ((not (window-dedicated-p)) > (switch-to-prev-buffer nil 'bury)) ... plus the fact that switching buffers should not delete windows ... > Only after typing RET in the minibuffer to accept the completion is the > window that had been displaying the *Completions* buffer and now > displays the *Messages* buffer deleted; in Emacs 23.2 it is deleted as > soon as the sole completion is displayed in the minibuffer. Commenting > out the above clause restores the 23.2 behavior. But this presumably > has bad effects elsewhere. Presumably `minibuffer-hide-completions' should iconify a standalone completions frame while deleting a split-off completions window. So maybe the following DTRT: (defun minibuffer-hide-completions () "Get rid of an out-of-date *Completions* buffer." ;; FIXME: We could/should use minibuffer-scroll-window here, but it ;; can also point to the minibuffer-parent-window, so it's a bit tricky. (let* ((window (get-buffer-window "*Completions*" 0)) (buffer (window-buffer window))) (when window (let ((deletable (window-deletable-p window))) (cond ((eq deletable 'frame) ;; Iconify frame. (iconify-frame (window-frame window)) (bury-buffer-internal buffer)) (deletable ;; Delete window (delete-window window) (bury-buffer-internal buffer)) (t ;; Switch to another buffer. (switch-to-prev-buffer window 'bury))))))) > (Interestingly, the C code of bury-buffer prior to the move to Lisp in > revision 104559 (and long before that) has the equivalent of the above > clause.) ISTR that completion windows were dedicated then and typing "v TAB" would trigger the following code in `minibuffer-completion-help' ;; If there are no completions, or if the current input is already the ;; only possible completion, then hide (previous&stale) completions. (let ((window (and (get-buffer "*Completions*") (get-buffer-window "*Completions*" 0)))) (when (and (window-live-p window) (window-dedicated-p window)) (condition-case () (delete-window window) (error (iconify-frame (window-frame window)))))) which I can't find anymore. But I might be wrong. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 06:04:15 2011 Received: (at 9639) by debbugs.gnu.org; 1 Oct 2011 10:04:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R9wQZ-0000tj-2P for submit@debbugs.gnu.org; Sat, 01 Oct 2011 06:04:15 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R9wQW-0000tZ-BO for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 06:04:13 -0400 Received: (qmail invoked by alias); 01 Oct 2011 10:02:59 -0000 Received: from i59F56B46.versanet.de (EHLO escher.home) [89.245.107.70] by mail.gmx.net (mp055) with SMTP; 01 Oct 2011 12:02:59 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX19Uqh4ojj9UtghIMrFvdMeD+FQc2zi/3ApV04S8TE S/y5lbo8QO0TMx Received: by escher.home (Postfix, from userid 1000) id 41A1021B58; Sat, 1 Oct 2011 12:03:07 +0200 (CEST) From: Stephen Berman To: martin rudalics Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> Date: Sat, 01 Oct 2011 12:03:06 +0200 In-Reply-To: <4E86D879.7060105@gmx.at> (martin rudalics's message of "Sat, 01 Oct 2011 11:08:09 +0200") Message-ID: <87r52xkp0l.fsf@escher.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Sat, 01 Oct 2011 11:08:09 +0200 martin rudalics wrote: >> 1. emacs -Q >> 2. Type `M-x glo TAB' and at the completion "M-x global-" type TAB again, >> making a *Completions* buffer pop up. >> 3. Type `v TAB', yielding the completion "M-x global-visual-line-mode". >> => The window that had been displaying the *Completions* buffer now >> displays the *Messages* buffer. >> >> AFAICT this is due to the following cond clause in bury-buffer (which is >> called by minibuffer-hide-completions): >> >> ((not (window-dedicated-p)) >> (switch-to-prev-buffer nil 'bury)) > > ... plus the fact that switching buffers should not delete windows ... > >> Only after typing RET in the minibuffer to accept the completion is the >> window that had been displaying the *Completions* buffer and now >> displays the *Messages* buffer deleted; in Emacs 23.2 it is deleted as >> soon as the sole completion is displayed in the minibuffer. Commenting >> out the above clause restores the 23.2 behavior. But this presumably >> has bad effects elsewhere. > > Presumably `minibuffer-hide-completions' should iconify a standalone > completions frame while deleting a split-off completions window. So > maybe the following DTRT: > > (defun minibuffer-hide-completions () > "Get rid of an out-of-date *Completions* buffer." > ;; FIXME: We could/should use minibuffer-scroll-window here, but it > ;; can also point to the minibuffer-parent-window, so it's a bit tricky. > (let* ((window (get-buffer-window "*Completions*" 0)) > (buffer (window-buffer window))) > (when window > (let ((deletable (window-deletable-p window))) > (cond > ((eq deletable 'frame) > ;; Iconify frame. > (iconify-frame (window-frame window)) > (bury-buffer-internal buffer)) > (deletable > ;; Delete window > (delete-window window) > (bury-buffer-internal buffer)) > (t > ;; Switch to another buffer. > (switch-to-prev-buffer window 'bury))))))) I confirm this DTRT for my case. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 06:59:05 2011 Received: (at 9639) by debbugs.gnu.org; 1 Oct 2011 10:59:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R9xHc-0002Ao-PW for submit@debbugs.gnu.org; Sat, 01 Oct 2011 06:59:04 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R9xHZ-0002AN-Mo for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 06:59:02 -0400 Received: (qmail invoked by alias); 01 Oct 2011 10:57:48 -0000 Received: from 62-47-56-209.adsl.highway.telekom.at (EHLO [62.47.56.209]) [62.47.56.209] by mail.gmx.net (mp011) with SMTP; 01 Oct 2011 12:57:48 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/B7Wp0+7DBhVT34WDSHDNKk8XXfqwtUkUGagcYXt fJFWb0Pxmq5ykd Message-ID: <4E86F22B.5060007@gmx.at> Date: Sat, 01 Oct 2011 12:57:47 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Stephen Berman Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> In-Reply-To: <87r52xkp0l.fsf@escher.home> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > I confirm this DTRT for my case. I believe the original idea was to mark the window as dedicated but `display-buffer-mark-dedicated' is currently not handled by the new buffer display routines. None of them calls `window--display-buffer-2' with the DEDICATED argument set. OTOH in the discussion of bug#7368 it was said that dedicating the completions window might harm its reuse by other `display-buffer' calls so I leave this to Stefan to decide what shall be done. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 10:39:47 2011 Received: (at 9639) by debbugs.gnu.org; 1 Oct 2011 14:39:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA0jD-000805-7X for submit@debbugs.gnu.org; Sat, 01 Oct 2011 10:39:47 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA0j9-0007zv-BT for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 10:39:44 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p91EcR5x017464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 1 Oct 2011 14:38:29 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p91EcRGs019681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 1 Oct 2011 14:38:27 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p91EcLJt011590; Sat, 1 Oct 2011 09:38:22 -0500 Received: from dradamslap1 (/10.159.37.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 01 Oct 2011 07:38:21 -0700 From: "Drew Adams" To: "'martin rudalics'" , "'Stephen Berman'" References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> Subject: RE: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Date: Sat, 1 Oct 2011 07:38:33 -0700 Message-ID: <944D5D429FE44884ABAFF93521DEBB73@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4E86D879.7060105@gmx.at> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 Thread-Index: AcyAGcjmkhXVNDRPQN2UmUCzqAC+vQAKg7Dw X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4E8725E6.007A:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > Presumably `minibuffer-hide-completions' should iconify a standalone > completions frame I have not been following this thread, but NO, it should *delete* a standalone completions frame, not iconify it. Better yet, the behavior should be customizable (delete, make invisible, iconify, put on a different tab,...), but the _default_ behavior should simply be to *delete* the frame. 1. The analogy to `delete-window' is `delete-frame', and that is just what the behavior here (at least the default behavior) should be: delete the frame. 2. There is no _need_ to iconify a frame that we no longer need (!). 3. Iconifying, at least on Windows, takes longer and distracts the user, sweeping an animation across the screen. 4. If someone binds the window-manager `iconify-frame' event to do something slightly different then things can be even worse: (define-key special-event-map [iconify-frame] 'foobar) 5. Iconifying puts icons (of one form or another) on the desktop. There is no general need for a *Completions* buffer icon. Occam's razor. Anyone really needing to access buffer *Completions* to see the candidate completions from the _last_ command can just use C-x C-b. 6. If *Completions* is always created as a standalone frame, then there is no need to save an icon for it. The buffer is one thing, the frame/icon is another. If you want the frame always created in the same position with the same size or something (the only argument Stefan has ever given for iconifying, AFAIK), then just _create_ it that way each time. 7. Just because Stefan's own use case prefers iconifying is _no reason_ to hard-code iconifying as the behavior. That's several reasons why iconifying is a bad idea. What's the argument _for_ iconifying? Only this: Stefan likes it. He likes it because it saves the frame position and size. That's the only reason that's ever been given, AFAIK. Position, shape, and size of a standalone frame can be handled at its creation, as is usual in Emacs. There is no need to create an icon just to save that info here. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 10:42:27 2011 Received: (at 9639) by debbugs.gnu.org; 1 Oct 2011 14:42:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA0lm-00083x-RT for submit@debbugs.gnu.org; Sat, 01 Oct 2011 10:42:27 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA0lk-00083p-Ln for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 10:42:25 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EADYlh05FpZLc/2dsb2JhbABBqDKBBoFTAQEEAVYjBQsLNBIUGA0kiA63HYckBKB5hEM X-IronPort-AV: E=Sophos;i="4.68,473,1312171200"; d="scan'208";a="139527069" Received: from 69-165-146-220.dsl.teksavvy.com (HELO pastel.home) ([69.165.146.220]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 01 Oct 2011 10:41:11 -0400 Received: by pastel.home (Postfix, from userid 20848) id 7F66F59119; Sat, 1 Oct 2011 10:41:11 -0400 (EDT) From: Stefan Monnier To: martin rudalics Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Message-ID: References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> Date: Sat, 01 Oct 2011 10:41:11 -0400 In-Reply-To: <4E86F22B.5060007@gmx.at> (martin rudalics's message of "Sat, 01 Oct 2011 12:57:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) >> I confirm this DTRT for my case. BTW, can't we just use `quit-window'? > I believe the original idea was to mark the window as dedicated but That's how it worked in Emacs-23, indeed. > `display-buffer-mark-dedicated' is currently not handled by the new > buffer display routines. Yes, that's a bug. > with the DEDICATED argument set. OTOH in the discussion of bug#7368 it > was said that dedicating the completions window might harm its reuse by > other `display-buffer' calls so I leave this to Stefan to decide what > shall be done. In Emacs-23, marking the window as dedicated via display-buffer-mark-dedicated was handy but indeed had the disadvantage of preventing the window's reuse by display-buffer. I think in Emacs-24 this disadvantage is less serious because the completion code is a lot more careful to not leave the *Completion* displayed too long. So making display-buffer-mark-dedicated work (which we need to do in any case) should be all that's needed to fix the bug. But of course, if we can get the *Completions* window/frame deleted without marking it as dedicated, that'd be fine as well. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 13:06:07 2011 Received: (at 9639) by debbugs.gnu.org; 1 Oct 2011 17:06:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA30p-0002qm-1s for submit@debbugs.gnu.org; Sat, 01 Oct 2011 13:06:07 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RA30m-0002qe-TV for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 13:06:06 -0400 Received: (qmail invoked by alias); 01 Oct 2011 17:04:50 -0000 Received: from 62-47-32-74.adsl.highway.telekom.at (EHLO [62.47.32.74]) [62.47.32.74] by mail.gmx.net (mp016) with SMTP; 01 Oct 2011 19:04:50 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18YqlkEOesYxrAOGSuLb2WWT05PtWpDwwY1oW99fK oImIP7G4gOTDaX Message-ID: <4E874831.3060709@gmx.at> Date: Sat, 01 Oct 2011 19:04:49 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > BTW, can't we just use `quit-window'? This would delete a stand-alone frame and not iconify it. > But of course, if we can get the *Completions* window/frame deleted > without marking it as dedicated, that'd be fine as well. We could give `quit-window' a third argument telling it to iconify the frame instead of deleting it or add an option to deal with this case. Since I still intend to eventually replace window excursions by `display-buffer' + `quit-window' (which will probably take years) some general pattern would be useful anyway. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 20:06:09 2011 Received: (at 9639) by debbugs.gnu.org; 2 Oct 2011 00:06:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA9ZI-0005h6-3D for submit@debbugs.gnu.org; Sat, 01 Oct 2011 20:06:09 -0400 Received: from mail-gx0-f172.google.com ([209.85.161.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RA9ZF-0005gy-VD for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 20:06:07 -0400 Received: by ggnk3 with SMTP id k3so244958ggn.3 for <9639@debbugs.gnu.org>; Sat, 01 Oct 2011 17:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:face:reply-to:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=jteZLypSP0G4t17qnutNJN9YXwujpvIezQ1Q3vl+5tk=; b=sEV5Fhsz8J/AAv2+j5C8KJVDKcEmmcVDFMfyuf3NxNTC/6BRZc2sqISvG75ag88gPK NvEoDYX8mUIY+aCylv+ZPLGplD7N/m/5maD+DlJNSwLjIwqzqvqmE0o0pinKD5ywAiPy 2nTtKQTdOm8DoVCtA8vjDhbG8Hw35u6ahZWvI= Received: by 10.68.12.162 with SMTP id z2mr68793774pbb.122.1317513890633; Sat, 01 Oct 2011 17:04:50 -0700 (PDT) Received: from Victoria.local ([222.77.98.74]) by mx.google.com with ESMTPS id e3sm35449694pbi.7.2011.10.01.17.04.45 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 01 Oct 2011 17:04:49 -0700 (PDT) From: Leo To: "Drew Adams" Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <944D5D429FE44884ABAFF93521DEBB73@us.oracle.com> Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Sun, 02 Oct 2011 07:38:18 +0800 In-Reply-To: <944D5D429FE44884ABAFF93521DEBB73@us.oracle.com> (Drew Adams's message of "Sat, 1 Oct 2011 07:38:33 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 9639 Cc: 'martin rudalics' , 9639@debbugs.gnu.org, 'Stephen Berman' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: 9639@debbugs.gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On 2011-10-01 22:38 +0800, Drew Adams wrote: > Better yet, the behavior should be customizable (delete, make invisible, > iconify, put on a different tab,...), but the _default_ behavior should simply > be to *delete* the frame. I have never been in a situation where iconification makes sense. Leo From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 20:39:53 2011 Received: (at 9639) by debbugs.gnu.org; 2 Oct 2011 00:39:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAA5w-0006Td-FL for submit@debbugs.gnu.org; Sat, 01 Oct 2011 20:39:53 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAA5t-0006TU-4V for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 20:39:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAMmxh05FpZLc/2dsb2JhbABBqDWBBoFTAQEEAVYjBQsLNBIUGA0kiA63FYckBKB5hEM X-IronPort-AV: E=Sophos;i="4.68,475,1312171200"; d="scan'208";a="139567162" Received: from 69-165-146-220.dsl.teksavvy.com (HELO pastel.home) ([69.165.146.220]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 01 Oct 2011 20:38:34 -0400 Received: by pastel.home (Postfix, from userid 20848) id B736E59291; Sat, 1 Oct 2011 20:38:33 -0400 (EDT) From: Stefan Monnier To: martin rudalics Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Message-ID: References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at> Date: Sat, 01 Oct 2011 20:38:33 -0400 In-Reply-To: <4E874831.3060709@gmx.at> (martin rudalics's message of "Sat, 01 Oct 2011 19:04:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) >> BTW, can't we just use `quit-window'? > This would delete a stand-alone frame and not iconify it. That's a problem of quit-window. I know that some users like this behavior, but making the distinction based on whether the code happened to use quit-window instead of bury-buffer is wrong, IMO. Both bury-buffer and quit-window should hide dedicated frames in the same way, either both by iconifying, or both by deleting the frame (and they should share the same code to do it). This shared code can provide a hook to let the user choose how the frame gets hidden, but the default should be to iconify since that's how it's worked until now (and also because I think it's a safer default, in the sense that iconifying throws away less information than deleting the frame). >> But of course, if we can get the *Completions* window/frame deleted >> without marking it as dedicated, that'd be fine as well. > We could give `quit-window' a third argument telling it to iconify the > frame instead of deleting it or add an option to deal with this case. An argument doesn't seem right, since the choice doesn't depend on the caller, AFAIK, but on the user. > Since I still intend to eventually replace window excursions by > `display-buffer' + `quit-window' (which will probably take years) some > general pattern would be useful anyway. Yes, we agree on this overarching goal, tho I think the issue is not so much save-window-excursion (which generally needs to be solved by changing the code so it doesn't call display-buffer at all) but rather "stash current-window-configuration + set-window-configuration". Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 06:11:09 2011 Received: (at 9639) by debbugs.gnu.org; 2 Oct 2011 10:11:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAJ0m-0002Mu-Ss for submit@debbugs.gnu.org; Sun, 02 Oct 2011 06:11:09 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RAJ0k-0002Ml-4c for 9639@debbugs.gnu.org; Sun, 02 Oct 2011 06:11:07 -0400 Received: (qmail invoked by alias); 02 Oct 2011 10:09:47 -0000 Received: from 62-47-43-155.adsl.highway.telekom.at (EHLO [62.47.43.155]) [62.47.43.155] by mail.gmx.net (mp061) with SMTP; 02 Oct 2011 12:09:47 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18BhyVvhp8BQ50VWTTOcXWun/zNfgPLPd8N8ze91k bOQiF85qyCAizc Message-ID: <4E883869.7070309@gmx.at> Date: Sun, 02 Oct 2011 12:09:45 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) >> This would delete a stand-alone frame and not iconify it. > > That's a problem of quit-window. I know that some users like this > behavior, but making the distinction based on whether the code happened > to use quit-window instead of bury-buffer is wrong, IMO. > > Both bury-buffer and quit-window should hide dedicated frames in the > same way, either both by iconifying, or both by deleting the frame (and > they should share the same code to do it). > > This shared code can provide a hook to let the user choose how the frame > gets hidden, but the default should be to iconify since that's how it's > worked until now (and also because I think it's a safer default, in the > sense that iconifying throws away less information than deleting the > frame). With emacs 23 help frames are deleted by default. So if I interpret you strictly, `quit-window' should iconify a dedicated frame and delete a non-dedicated one. Is that correct? Basically, it would be nice to get rid of either `bury-buffer' or `quit-window'. Having two functions do approximately the same thing is neither reasonable for developers nor for users. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 09:40:39 2011 Received: (at 9639) by debbugs.gnu.org; 2 Oct 2011 13:40:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAMHX-0007s6-AF for submit@debbugs.gnu.org; Sun, 02 Oct 2011 09:40:39 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAMHT-0007rx-Ss for 9639@debbugs.gnu.org; Sun, 02 Oct 2011 09:40:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EALloiE5FpZLc/2dsb2JhbABBqCyBBoFTAQEEAVYjBQsLNBIUGA0kiA62UochBKB3hEM X-IronPort-AV: E=Sophos;i="4.68,476,1312171200"; d="scan'208";a="139630035" Received: from 69-165-146-220.dsl.teksavvy.com (HELO pastel.home) ([69.165.146.220]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 02 Oct 2011 09:39:17 -0400 Received: by pastel.home (Postfix, from userid 20848) id 065C05914B; Sun, 2 Oct 2011 09:39:17 -0400 (EDT) From: Stefan Monnier To: martin rudalics Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Message-ID: References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at> <4E883869.7070309@gmx.at> Date: Sun, 02 Oct 2011 09:39:16 -0400 In-Reply-To: <4E883869.7070309@gmx.at> (martin rudalics's message of "Sun, 02 Oct 2011 12:09:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > With Emacs 23 help frames are deleted by default. Could be. Various packages do things differently. But the non-package-specific code is the one that interests me. > So if I interpret you strictly, `quit-window' should iconify > a dedicated frame and delete a non-dedicated one. Is that correct? No. Either both are deleted or both are iconified, since (again) it is mostly a choice that depends on the general window-manager usage and user preference. > Basically, it would be nice to get rid of either `bury-buffer' or > `quit-window'. Having two functions do approximately the same thing is > neither reasonable for developers nor for users. I think both are in fairly wide use, so getting rid of one of them is not really an option. But I hope we can define one in terms of the other (or both in terms of a third internal one). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 11:36:24 2011 Received: (at 9639) by debbugs.gnu.org; 2 Oct 2011 15:36:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAO5X-00025b-Ok for submit@debbugs.gnu.org; Sun, 02 Oct 2011 11:36:24 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAO5T-00025S-JC for 9639@debbugs.gnu.org; Sun, 02 Oct 2011 11:36:21 -0400 Received: from rtcsinet22.oracle.com (rtcsinet22.oracle.com [66.248.204.30]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p92FYwkf001702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 2 Oct 2011 15:35:00 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by rtcsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p92FYuA7003596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 2 Oct 2011 15:34:57 GMT Received: from abhmt111.oracle.com (abhmt111.oracle.com [141.146.116.63]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p92FYo4p001909; Sun, 2 Oct 2011 10:34:51 -0500 Received: from dradamslap1 (/10.159.59.250) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 02 Oct 2011 08:34:50 -0700 From: "Drew Adams" To: "'Stefan Monnier'" , "'martin rudalics'" References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at><87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at> Subject: RE: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Date: Sun, 2 Oct 2011 08:35:00 -0700 Message-ID: <72F08D70CD7048C491DBB6CBE4C2A5DA@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 Thread-Index: AcyAm7FQR18zDG0PRE24YPjO11RMsAAeRemw X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090206.4E8884A4.0132,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, 'Stephen Berman' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > This shared code can provide a hook to let the user choose > how the frame gets hidden, Why make users jump through hoops and hooks? Provide a user option. (And removing is not "hiding". And even hiding does not leave behind little icons.) > but the default should be to iconify since that's how it's > worked until now Oh, that's rich. If you resist bug reports long enough, sure, you can then claim that "that's how it's worked until now", and that's the reason it should continue to be the default ("since"). But no, that's not how it worked, even as recently as Emacs 22, IIRC. At least in Emacs 18,...21,22 quitting the debugger, say, does _not_ iconify a dedicated *Backtrace* frame - it simply _deletes_ it - behavior that makes sense. Seems to me this iconification is something that you introduced. Iconifying is hardly "how it worked" before that. emacs -Q ; Emacs 22 (setq special-display-regexps '("[ ]?[*][^*]+[*]")) M-: (/ 0) q ; in buffer *Backtrace*. Poof - the frame is _deleted_. So by your logic, "since" that's _not_ how it worked throughout Emacs's history until you introduced the iconification bug/feature, the traditional default behavior should be restored: delete the frame. > (and also because I think it's a safer default, in the > sense that iconifying throws away less information than deleting the > frame). You did add "in the sense that", but it's not about _safety_. Deleting a frame does not destroy any important information (buffer/file content etc.). And nothing prevents you from saving the frame position, shape, and size for your own use - e.g. in a register. Do that in a hook if you like. But the default behavior should simply do what a user expects: _remove_ the frame. That could be done by making it invisible or deleting it. Making it invisible would save all of your precious frame info, BTW. Invisibility, like deletion (and unlike iconification), is instantaneous and unclutters the display, and it would presumably be a reasonable compromise. In principle, it should address both your concerns and mine. Supposedly, there are some bugs associated with invisible frames, but it's not clear just what they are (?). Maybe it's time to find out (and fix them). In sum, invisibility would probably be an acceptable compromise default. Iconifying as default should be a non-starter - a bad idea. > the choice doesn't depend on the caller, AFAIK, but on the user. Which means it should be easily customizable by the user - a user option, not just hooks. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 20:42:37 2011 Received: (at 9639) by debbugs.gnu.org; 3 Oct 2011 00:42:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAWc8-00073y-JQ for submit@debbugs.gnu.org; Sun, 02 Oct 2011 20:42:37 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAWc4-00073n-8X for 9639@debbugs.gnu.org; Sun, 02 Oct 2011 20:42:33 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAF4DiU5FpZLc/2dsb2JhbABBqA+BBoFTAQEEAVYjBQsLNBIUGA0kiA63YYchBKB3hEM X-IronPort-AV: E=Sophos;i="4.68,478,1312171200"; d="scan'208";a="139695941" Received: from 69-165-146-220.dsl.teksavvy.com (HELO pastel.home) ([69.165.146.220]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 02 Oct 2011 20:41:10 -0400 Received: by pastel.home (Postfix, from userid 20848) id 8EBE559275; Sun, 2 Oct 2011 20:41:10 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Message-ID: References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at> <72F08D70CD7048C491DBB6CBE4C2A5DA@us.oracle.com> Date: Sun, 02 Oct 2011 20:41:10 -0400 In-Reply-To: <72F08D70CD7048C491DBB6CBE4C2A5DA@us.oracle.com> (Drew Adams's message of "Sun, 2 Oct 2011 08:35:00 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9639 Cc: 'martin rudalics' , 9639@debbugs.gnu.org, 'Stephen Berman' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > Why make users jump through hoops and hooks? Provide a user option. That's a false dichotomy. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 20:50:04 2011 Received: (at 9639) by debbugs.gnu.org; 3 Oct 2011 00:50:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAWjJ-0007EL-Pw for submit@debbugs.gnu.org; Sun, 02 Oct 2011 20:50:03 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAWjI-0007E5-1K for 9639@debbugs.gnu.org; Sun, 02 Oct 2011 20:50:00 -0400 Received: from ucsinet23.oracle.com (ucsinet23.oracle.com [156.151.31.71]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p930makS027293 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 3 Oct 2011 00:48:38 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet23.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p930mZAu010326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 3 Oct 2011 00:48:36 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p930mUfs001435; Sun, 2 Oct 2011 19:48:30 -0500 Received: from dradamslap1 (/10.159.61.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 02 Oct 2011 17:48:30 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at><87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at><72F08D70CD7048C491DBB6CBE4C2A5DA@us.oracle.com> Subject: RE: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Date: Sun, 2 Oct 2011 17:48:42 -0700 Message-ID: <2F0F108274AB4D1EBDFEEC0D623D55E7@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 Thread-Index: AcyBZSpnxjql6L6TT1ii/7Umt3a+oAAAHPYA X-Source-IP: ucsinet23.oracle.com [156.151.31.71] X-CT-RefId: str=0001.0A090204.4E890666.0056,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 9639 Cc: 'martin rudalics' , 9639@debbugs.gnu.org, 'Stephen Berman' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > > Why make users jump through hoops and hooks? Provide a user option. > > That's a false dichotomy. That's sophistry. No one presented any dichotomy. Provide hoops and hooks if you like. But provide a user option, for users. No one said it's either/or. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 11:51:47 2011 Received: (at 9639-done) by debbugs.gnu.org; 4 Oct 2011 15:51:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RB7HV-0001sp-Ib for submit@debbugs.gnu.org; Tue, 04 Oct 2011 11:51:46 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RB7HS-0001sg-Ng for 9639-done@debbugs.gnu.org; Tue, 04 Oct 2011 11:51:43 -0400 Received: (qmail invoked by alias); 04 Oct 2011 15:50:11 -0000 Received: from 62-47-57-203.adsl.highway.telekom.at (EHLO [62.47.57.203]) [62.47.57.203] by mail.gmx.net (mp043) with SMTP; 04 Oct 2011 17:50:11 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18Kz9xN7iYK+1BxiyOYc/Z6/rhNks3rmanhUOBL70 8NQIdEIJXPfSYo Message-ID: <4E8B2B32.5040302@gmx.at> Date: Tue, 04 Oct 2011 17:50:10 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: 9639-done@debbugs.gnu.org Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> In-Reply-To: <87hb3thebv.fsf@escher.home> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639-done Cc: Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > 1. emacs -Q > 2. Type `M-x glo TAB' and at the completion "M-x global-" type TAB again, > making a *Completions* buffer pop up. > 3. Type `v TAB', yielding the completion "M-x global-visual-line-mode". > => The window that had been displaying the *Completions* buffer now > displays the *Messages* buffer. Should be fixed in revision 105995. Please try again. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 11:52:09 2011 Received: (at 9639) by debbugs.gnu.org; 4 Oct 2011 15:52:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RB7Hs-0001u1-GU for submit@debbugs.gnu.org; Tue, 04 Oct 2011 11:52:09 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RB7Hq-0001ts-H3 for 9639@debbugs.gnu.org; Tue, 04 Oct 2011 11:52:07 -0400 Received: (qmail invoked by alias); 04 Oct 2011 15:50:35 -0000 Received: from 62-47-57-203.adsl.highway.telekom.at (EHLO [62.47.57.203]) [62.47.57.203] by mail.gmx.net (mp051) with SMTP; 04 Oct 2011 17:50:35 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/Txkl35tfTBosCVh7mht5JyqALIe5lia1gfemAri q3u0v/c6zbp6jt Message-ID: <4E8B2B4A.2080809@gmx.at> Date: Tue, 04 Oct 2011 17:50:34 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at> <4E883869.7070309@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > No. Either both are deleted or both are iconified, since (again) it is > mostly a choice that depends on the general window-manager usage and > user preference. > >> Basically, it would be nice to get rid of either `bury-buffer' or >> `quit-window'. Having two functions do approximately the same thing is >> neither reasonable for developers nor for users. > > I think both are in fairly wide use, so getting rid of one of them is > not really an option. But I hope we can define one in terms of > the other (or both in terms of a third internal one). I now try to handle burying buffers via `quit-window' and `bury-buffer' in a uniform manner. All this in a new function called `window--delete' (which is also called by `replace-buffer-in-windows' although the latter always deletes the frame if possible). martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 11:52:45 2011 Received: (at 9639) by debbugs.gnu.org; 4 Oct 2011 15:52:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RB7IS-0001uv-Fv for submit@debbugs.gnu.org; Tue, 04 Oct 2011 11:52:44 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RB7IO-0001uk-RD for 9639@debbugs.gnu.org; Tue, 04 Oct 2011 11:52:41 -0400 Received: (qmail invoked by alias); 04 Oct 2011 15:51:09 -0000 Received: from 62-47-57-203.adsl.highway.telekom.at (EHLO [62.47.57.203]) [62.47.57.203] by mail.gmx.net (mp057) with SMTP; 04 Oct 2011 17:51:09 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+GK6A88OeGF6xZ0AzA4gMNOM29ozmWldSJoUeDrr qP6mT5PWwaBk29 Message-ID: <4E8B2B6C.5050900@gmx.at> Date: Tue, 04 Oct 2011 17:51:08 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at><87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at><72F08D70CD7048C491DBB6CBE4C2A5DA@us.oracle.com> <2F0F108274AB4D1EBDFEEC0D623D55E7@us.oracle.com> In-Reply-To: <2F0F108274AB4D1EBDFEEC0D623D55E7@us.oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, 'Stefan Monnier' , 'Stephen Berman' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > But provide a user option, for users. I now revived an option for this. It's called `frame-auto-delete', is by default nil and, when non-nil, causes frames to be deleted in two cases: - `quit-window' when its first argument is nil and the frame has been specially created for the window's buffer. - `bury-buffer' when its argument is nil and the selected window is dedicated to its buffer. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 11:52:57 2011 Received: (at 9639) by debbugs.gnu.org; 4 Oct 2011 15:52:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RB7If-0001vI-De for submit@debbugs.gnu.org; Tue, 04 Oct 2011 11:52:57 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RB7Ib-0001vA-Mt for 9639@debbugs.gnu.org; Tue, 04 Oct 2011 11:52:55 -0400 Received: (qmail invoked by alias); 04 Oct 2011 15:51:22 -0000 Received: from 62-47-57-203.adsl.highway.telekom.at (EHLO [62.47.57.203]) [62.47.57.203] by mail.gmx.net (mp008) with SMTP; 04 Oct 2011 17:51:22 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/pMcktIX3pnaRnN+lgHkAiIv1Xr5GHYzbjaQIi44 EmG57GYdqccZG+ Message-ID: <4E8B2B7A.8010504@gmx.at> Date: Tue, 04 Oct 2011 17:51:22 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > In Emacs-23, marking the window as dedicated via > display-buffer-mark-dedicated was handy but indeed had the disadvantage > of preventing the window's reuse by display-buffer. I think in Emacs-24 > this disadvantage is less serious because the completion code is a lot > more careful to not leave the *Completion* displayed too long. > So making display-buffer-mark-dedicated work (which we need to do in any > case) should be all that's needed to fix the bug. > > But of course, if we can get the *Completions* window/frame deleted > without marking it as dedicated, that'd be fine as well. I think both `quit-window' and `bury-buffer' should handle this the same way now. So if bug#7368 has not been resolved yet we should be able to display completions in a non-dedicated window and quit that afterwards. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 12:05:07 2011 Received: (at 9639) by debbugs.gnu.org; 4 Oct 2011 16:05:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RB7UR-0002DZ-4Z for submit@debbugs.gnu.org; Tue, 04 Oct 2011 12:05:07 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RB7UP-0002DR-7l for 9639@debbugs.gnu.org; Tue, 04 Oct 2011 12:05:05 -0400 Received: from rtcsinet21.oracle.com (rtcsinet21.oracle.com [66.248.204.29]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p94G3W6H004140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 Oct 2011 16:03:34 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by rtcsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p94G3U9O020046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 4 Oct 2011 16:03:31 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p94G3Ov2003960; Tue, 4 Oct 2011 11:03:24 -0500 Received: from dradamslap1 (/10.159.58.205) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 04 Oct 2011 09:03:24 -0700 From: "Drew Adams" To: "'martin rudalics'" References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at><87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at><72F08D70CD7048C491DBB6CBE4C2A5DA@us.oracle.com> <2F0F108274AB4D1EBDFEEC0D623D55E7@us.oracle.com> <4E8B2B6C.5050900@gmx.at> Subject: RE: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Date: Tue, 4 Oct 2011 09:03:25 -0700 Message-ID: <482F77B4515A43AEA800AAA4E20DFDEC@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-reply-to: <4E8B2B6C.5050900@gmx.at> Thread-Index: AcyCrXWMQr//DB2XRuqI9nRhg9zVlQAAR2DA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: rtcsinet21.oracle.com [66.248.204.29] X-CT-RefId: str=0001.0A090205.4E8B2E56.00FF,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, 'Stefan Monnier' , 'Stephen Berman' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > > But provide a user option, for users. > > I now revived an option for this. It's called > `frame-auto-delete', is by default nil and, when non-nil, > causes frames to be deleted in two cases: > > - `quit-window' when its first argument is nil and the frame has been > specially created for the window's buffer. > > - `bury-buffer' when its argument is nil and the selected window is > dedicated to its buffer. Progress; thanks (haven't tried it, but sounds like progress). But: * You don't say what the non-deletion behavior is. * The default behavior should be deletion. `delete-frame' should be treated analogously to `delete-window'. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 13:47:10 2011 Received: (at 9639) by debbugs.gnu.org; 4 Oct 2011 17:47:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RB95B-0004iq-TM for submit@debbugs.gnu.org; Tue, 04 Oct 2011 13:47:10 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RB958-0004if-Dn for 9639@debbugs.gnu.org; Tue, 04 Oct 2011 13:47:08 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p94HjZVH020699; Tue, 4 Oct 2011 13:45:35 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 60E3FB4346; Tue, 4 Oct 2011 13:45:35 -0400 (EDT) From: Stefan Monnier To: martin rudalics Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Message-ID: References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at> <4E883869.7070309@gmx.at> <4E8B2B4A.2080809@gmx.at> Date: Tue, 04 Oct 2011 13:45:35 -0400 In-Reply-To: <4E8B2B4A.2080809@gmx.at> (martin rudalics's message of "Tue, 04 Oct 2011 17:50:34 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4000=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4000> : streams <688144> : uri <975642> X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) > I now try to handle burying buffers via `quit-window' and `bury-buffer' > in a uniform manner. All this in a new function called `window--delete' > (which is also called by `replace-buffer-in-windows' although the latter > always deletes the frame if possible). Thanks, this looks good, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 16:20:54 2011 Received: (at 9639-done) by debbugs.gnu.org; 4 Oct 2011 20:20:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBBTx-00036Y-R4 for submit@debbugs.gnu.org; Tue, 04 Oct 2011 16:20:54 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RBBTt-00036O-Gm for 9639-done@debbugs.gnu.org; Tue, 04 Oct 2011 16:20:52 -0400 Received: (qmail invoked by alias); 04 Oct 2011 20:19:17 -0000 Received: from i59F56513.versanet.de (EHLO escher.home) [89.245.101.19] by mail.gmx.net (mp009) with SMTP; 04 Oct 2011 22:19:17 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX19RibohqPZR9VVAw/v3MAcfeS5PQ3/P7VCcVgwmZ/ /bsnYyXXxU/fSQ Received: by escher.home (Postfix, from userid 1000) id 61AB322E2B; Tue, 4 Oct 2011 22:19:16 +0200 (CEST) From: Stephen Berman To: martin rudalics Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E8B2B32.5040302@gmx.at> Date: Tue, 04 Oct 2011 22:19:16 +0200 In-Reply-To: <4E8B2B32.5040302@gmx.at> (martin rudalics's message of "Tue, 04 Oct 2011 17:50:10 +0200") Message-ID: <87wrckse63.fsf@escher.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 9639-done Cc: 9639-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, 04 Oct 2011 17:50:10 +0200 martin rudalics wrote: >> 1. emacs -Q >> 2. Type `M-x glo TAB' and at the completion "M-x global-" type TAB again, >> making a *Completions* buffer pop up. >> 3. Type `v TAB', yielding the completion "M-x global-visual-line-mode". >> => The window that had been displaying the *Completions* buffer now >> displays the *Messages* buffer. > > Should be fixed in revision 105995. Please try again. I updated and confirm the problem I reported is now fixed; thanks. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 21:37:04 2011 Received: (at 9639) by debbugs.gnu.org; 12 Oct 2011 01:37:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDnkl-00079v-LF for submit@debbugs.gnu.org; Tue, 11 Oct 2011 21:37:04 -0400 Received: from mail-gx0-f172.google.com ([209.85.161.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDnkj-00079Q-8b for 9639@debbugs.gnu.org; Tue, 11 Oct 2011 21:37:02 -0400 Received: by ggnk3 with SMTP id k3so193381ggn.3 for <9639@debbugs.gnu.org>; Tue, 11 Oct 2011 18:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Dy0d6RMT1WH03smpO1iAYC3HGgdRfyYCf/saI/jwvCA=; b=oy20V4dLVWvqeFNOCUVOZqp4uX9A34PSbJIRcEYmN8M6p+DaCJ9oLab2KCtdwnb79E 7suu+eLroyIl41LlPHDed1l4spAmsO9TZhULGJJJONqD+R+7JWAMW+Dc+kTotPT3TrnY x0f63ymRi9fAc9H265Sngrur4kvksCNEoOM6U= Received: by 10.101.97.15 with SMTP id z15mr35813anl.60.1318383395824; Tue, 11 Oct 2011 18:36:35 -0700 (PDT) Received: from [192.168.1.3] (71-212-150-156.hlrn.qwest.net. [71.212.150.156]) by mx.google.com with ESMTPS id r5sm1431487anl.13.2011.10.11.18.36.31 (version=SSLv3 cipher=OTHER); Tue, 11 Oct 2011 18:36:34 -0700 (PDT) Message-ID: <4E94EF1B.30900@gmail.com> Date: Tue, 11 Oct 2011 19:36:27 -0600 From: Christoph Scholtes User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: martin rudalics Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at><87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at><72F08D70CD7048C491DBB6CBE4C2A5DA@us.oracle.com> <2F0F108274AB4D1EBDFEEC0D623D55E7@us.oracle.com> <4E8B2B6C.5050900@gmx.at> In-Reply-To: <4E8B2B6C.5050900@gmx.at> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) On 10/4/2011 9:51 AM, martin rudalics wrote: > > But provide a user option, for users. > > I now revived an option for this. It's called `frame-auto-delete', is by > default nil and, when non-nil, causes frames to be deleted in two cases: > > - `quit-window' when its first argument is nil and the frame has been > specially created for the window's buffer. > > - `bury-buffer' when its argument is nil and the selected window is > dedicated to its buffer. I can't see this variable in the Emacs trunk. Was this committed? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 00:10:28 2011 Received: (at control) by debbugs.gnu.org; 12 Oct 2011 04:10:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDq9C-00031V-9t for submit@debbugs.gnu.org; Wed, 12 Oct 2011 00:10:27 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDq99-00031O-JL for control@debbugs.gnu.org; Wed, 12 Oct 2011 00:10:24 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RDq8n-0008OR-Uv for control@debbugs.gnu.org; Wed, 12 Oct 2011 00:10:02 -0400 Date: Wed, 12 Oct 2011 00:10:01 -0400 Message-Id: Subject: control message for bug 9724 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) forcemerge 9639 9724 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 02:53:28 2011 Received: (at 9639) by debbugs.gnu.org; 12 Oct 2011 06:53:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDsgw-0007cg-CO for submit@debbugs.gnu.org; Wed, 12 Oct 2011 02:53:27 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RDsgt-0007cP-5K for 9639@debbugs.gnu.org; Wed, 12 Oct 2011 02:53:24 -0400 Received: (qmail invoked by alias); 12 Oct 2011 06:52:56 -0000 Received: from 62-47-62-98.adsl.highway.telekom.at (EHLO [62.47.62.98]) [62.47.62.98] by mail.gmx.net (mp050) with SMTP; 12 Oct 2011 08:52:56 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1++VNwqx4e+xA/jgW41JF+nvsdXN52B3Vuyrq4+Oy 0IMxvv75qq/OjD Message-ID: <4E953946.2010706@gmx.at> Date: Wed, 12 Oct 2011 08:52:54 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Christoph Scholtes Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at><87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at><72F08D70CD7048C491DBB6CBE4C2A5DA@us.oracle.com> <2F0F108274AB4D1EBDFEEC0D623D55E7@us.oracle.com> <4E8B2B6C.5050900@gmx.at> <4E94EF1B.30900@gmail.com> In-Reply-To: <4E94EF1B.30900@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639 Cc: 9639@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) >> I now revived an option for this. It's called `frame-auto-delete', is by >> default nil and, when non-nil, causes frames to be deleted in two cases: [...] > I can't see this variable in the Emacs trunk. Was this committed? Upon Stefan's request this variable was renamed to `frame-auto-hide-function' and is now supposed to specify a function that takes a frame as argument. The default value is `iconify-frame' and `delete-frame' is a preinstalled choice. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 03:02:43 2011 Received: (at 9639-done) by debbugs.gnu.org; 12 Oct 2011 07:02:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDspu-0007sb-Uw for submit@debbugs.gnu.org; Wed, 12 Oct 2011 03:02:43 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RDsps-0007sL-HO for 9639-done@debbugs.gnu.org; Wed, 12 Oct 2011 03:02:41 -0400 Received: (qmail invoked by alias); 12 Oct 2011 07:02:13 -0000 Received: from 62-47-62-98.adsl.highway.telekom.at (EHLO [62.47.62.98]) [62.47.62.98] by mail.gmx.net (mp057) with SMTP; 12 Oct 2011 09:02:13 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19SfmtymB1SVsL9WLYiN8q/4Kq9Y2Y6fxYKKrPc3x 3+VcBeesXe5MLc Message-ID: <4E953B74.40400@gmx.at> Date: Wed, 12 Oct 2011 09:02:12 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: 9639-done@debbugs.gnu.org Subject: Re: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions References: <87hb3thebv.fsf@escher.home> <4E8B2B32.5040302@gmx.at> <87wrckse63.fsf@escher.home> In-Reply-To: <87wrckse63.fsf@escher.home> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 9639-done Cc: Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > I updated and confirm the problem I reported is now fixed; thanks. Thanks, martin From unknown Thu Aug 14 21:23:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Nov 2011 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator