GNU bug report logs -
#9622
23.3; flet indentation
Previous Next
Reported by: diogofsr <at> gmail.com (Diogo F. S. Ramos)
Date: Wed, 28 Sep 2011 01:59:02 UTC
Severity: minor
Tags: confirmed
Found in versions 23.3, 26.2
Done: Stefan Kangas <stefankangas <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
30 sep. 2021 kl. 08.37 skrev Lars Ingebrigtsen <larsi <at> gnus.org>:
>> - I attached flet-tests.sexp which only contains cl-flet forms written
>> the way they are meant to be indented. I think writing them in
>> strings in deftest forms would be quite ugly and unreliable.
What would be unreliable?
> Indeed. I have a new machinery for doing tests like this waiting for
> Emacs 29 development to commence to fix this awkwardness.
We should insist on tests accompanying any bug fix from the start. Awkward is better than nothing. If the author finds it too difficult to write the test then we should help.
Akater, we have plenty of indentation tests for other programming modes already and they employ a variety of methods; there are many examples to look at. For instance, look at ruby-mode-tests.el; it contains a converted legacy test (ruby--indent/converted-from-manual-test) that reindents a separate source file, much like your example.
If you need further directions, we will assist.
This bug report was last modified 92 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.