GNU bug report logs - #9597
23.3; [diff-mode] Can't quite cope with git patches

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Dave Abrahams <dave <at> boostpro.com>, 9597 <at> debbugs.gnu.org
Subject: bug#9597: 23.3; [diff-mode] Can't quite cope with git patches
Date: Tue, 27 Sep 2011 03:03:50 +0300

>> I suppose that modifying the buffer with inserting a newline
>> is a temporary workaround for some earlier bug, so I added
>> a check for the diff separator in another condition branch.
>
> No, it's not outdated.
> The issue is in diff-end-of-hunk where we can sometimes use the numbers
> but not always.
> Also, adding a newline makes the thing less ambiguous in cases such as
> when the user edits the hunks (in which case we need to update the hunk
> header based on the hunk text).

Maybe we should add an option that doesn't insert a newline
for users who don't want that viewing diff files modifies them.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.