GNU bug report logs - #9597
23.3; [diff-mode] Can't quite cope with git patches

Previous Next

Package: emacs;

Reported by: Dave Abrahams <dave <at> boostpro.com>

Date: Sun, 25 Sep 2011 02:01:01 UTC

Severity: normal

Found in version 23.3

Done: Dima Kogan <dima <at> secretsauce.net>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 9597 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> jurta.org>
Cc: Dave Abrahams <dave <at> boostpro.com>, 9597 <at> debbugs.gnu.org
Subject: Re: bug#9597: 23.3; [diff-mode] Can't quite cope with git patches
Date: Sun, 25 Sep 2011 22:08:34 -0400

> I suppose that modifying the buffer with inserting a newline
> is a temporary workaround for some earlier bug, so I added
> a check for the diff separator in another condition branch.

No, it's not outdated.
The issue is in diff-end-of-hunk where we can sometimes use the numbers
but not always.
Also, adding a newline makes the thing less ambiguous in cases such as
when the user edits the hunks (in which case we need to update the hunk
header based on the hunk text).


        Stefan
This bug report was last modified 8 years and 114 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.