GNU bug report logs - #9582
Annoying point movement

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9582 in the body.
You can then email your comments to 9582 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Annoying point movement
Date: Fri, 23 Sep 2011 09:41:02 +0800

1. In the group buffer, key 'a'
2. In the popup message buffer, key C-c C-k

Point moved to the first group line.

Gnus v5.13 as in Emacs-trunk
GNU Emacs 23.3.50.1 (x86_64-apple-darwin10.8.0, Carbon Version 1.6.0 AppKit 1038.36)
 of 2011-09-15 on Victoria.local
200 news.gmane.org InterNetNews NNRP server INN 2.5.1 ready (posting ok)
101 Capability list:
VERSION 2
IMPLEMENTATION INN 2.5.1
AUTHINFO USER
HDR
LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT
OVER
POST
READER
STARTTLS
.

Message #8 received at 9582 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 9582 <at> debbugs.gnu.org
Subject: Re: bug#9582: Annoying point movement
Date: Fri, 23 Sep 2011 10:30:12 +0200

Leo <sdl.web <at> gmail.com> writes:

> 1. In the group buffer, key 'a'
> 2. In the popup message buffer, key C-c C-k

I don't get anything popped up.

> Point moved to the first group line.

And I'm unable to reproduce this.  Do you have any local customisations
that's moving point around?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #11 received at 9582 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 9582 <at> debbugs.gnu.org
Subject: Re: bug#9582: Annoying point movement
Date: Fri, 23 Sep 2011 18:27:00 +0800

On 2011-09-23 16:30 +0800, Lars Magne Ingebrigtsen wrote:
> Leo <sdl.web <at> gmail.com> writes:
>
>> 1. In the group buffer, key 'a'
>> 2. In the popup message buffer, key C-c C-k
>
> I don't get anything popped up.

`a' in gnus-group-buffer is bound to gnus-group-post-news. Does it not
pop up anything? That's odd.

>> Point moved to the first group line.
>
> And I'm unable to reproduce this.  Do you have any local customisations
> that's moving point around?

No.

Leo

Message #14 received at 9582 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 9582 <at> debbugs.gnu.org
Subject: Re: bug#9582: Annoying point movement
Date: Fri, 23 Sep 2011 12:43:49 +0200

Leo <sdl.web <at> gmail.com> writes:

>> I don't get anything popped up.
>
> `a' in gnus-group-buffer is bound to gnus-group-post-news. Does it not
> pop up anything? That's odd.

Oh, you mean that it opens a new window?  I thought you referred to
popping up a frame.

Yes, it does pop to a new window.

>>> Point moved to the first group line.
>>
>> And I'm unable to reproduce this.  Do you have any local customisations
>> that's moving point around?
>
> No.

I still can't reproduce it.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #17 received at 9582 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 9582 <at> debbugs.gnu.org
Subject: Re: bug#9582: Annoying point movement
Date: Fri, 23 Sep 2011 19:26:33 +0800

On 2011-09-23 18:43 +0800, Lars Magne Ingebrigtsen wrote:
>>> And I'm unable to reproduce this.  Do you have any local customisations
>>> that's moving point around?
>>
>> No.
>
> I still can't reproduce it.

My bad. I have topic-mode turned on and forgot that it isn't the
default. Could you try again with gnus-topic-mode on the group buffer?

I can't reproduce either if topic-mode is off.

Leo

Message #20 received at 9582 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 9582 <at> debbugs.gnu.org
Subject: Re: bug#9582: Annoying point movement
Date: Mon, 26 Sep 2011 23:09:04 +0200

Leo <sdl.web <at> gmail.com> writes:

> My bad. I have topic-mode turned on and forgot that it isn't the
> default. Could you try again with gnus-topic-mode on the group buffer?

I do use topic mode.  I can't reproduce the bug.

Can you explain, step by step, what you're doing, and what happens?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #23 received at 9582 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 9582 <at> debbugs.gnu.org
Subject: Re: bug#9582: Annoying point movement
Date: Sat, 08 Oct 2011 21:08:03 +0800

On 2011-09-27 05:09 +0800, Lars Magne Ingebrigtsen wrote:
[snipped 5 lines]
> I do use topic mode.  I can't reproduce the bug.
>
> Can you explain, step by step, what you're doing, and what happens?

My group buffer has topic mode enabled.

In the group buffer, I hit `C-u a' (which runs gnus-group-post-news) to
post a news, after which the message buffer pops up.

I inspect the value message-kill-actions in the message buffer and see:

((progn
   (setq gnus-current-window-configuration 'reply-yank)
   (when
       (gnus-buffer-exists-p "*Group*")
     (set-window-configuration #<window-configuration>)))
 (nndraft-update-unread-articles))

but then I decide I have no news to post and so hit C-c C-k
(message-kill-buffer).

The current buffer returns to the group buffer as dictated by
message-kill-actions but then the point is moved to the first group in
the group buffer.

BTW, message-kill-actions is added by gnus-setup-message.

Hope this helps.
Leo

Message #26 received at 9582 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 9582 <at> debbugs.gnu.org
Subject: Re: bug#9582: Annoying point movement
Date: Wed, 04 Jan 2012 11:44:41 +0800

On 2011-09-23 16:30 +0800, Lars Magne Ingebrigtsen wrote:
> Leo <sdl.web <at> gmail.com> writes:
>
>> 1. In the group buffer, key 'a'
>> 2. In the popup message buffer, key C-c C-k
>
> I don't get anything popped up.
>
>> Point moved to the first group line.
>
> And I'm unable to reproduce this.  Do you have any local customisations
> that's moving point around?

I have just looked at the cause of this bug and it is due to
nndraft-update-unread-articles in message-kill-actions (it is also in
'postpone 'exit actions) which is added by
nndraft-request-associate-buffer.

,----[ C-h v message-kill-actions RET ]
| message-kill-actions is a variable defined in `message.el'.
| Its value is ((progn
|    (setq gnus-current-window-configuration 'article)
|    (when
|        (gnus-buffer-exists-p "*Summary nndoc+/tmp/leo-tmp-347GXu/gnus-temp-group-42680G9l-ephemeral:gnus-read-ephemeral-bug*")
|      (set-window-configuration #<window-configuration>)))
|  (nndraft-update-unread-articles))
| 
| Local in buffer *unsent wide reply to Lars Magne Ingebrigtsen*; global value is nil
| 
| Documentation:
| A list of actions to be performed before killing a message buffer.
| 
| [back]
`----

The following patch fixes this bug.

=== modified file 'lisp/gnus/nndraft.el'
--- lisp/gnus/nndraft.el	2011-08-17 00:10:46 +0000
+++ lisp/gnus/nndraft.el	2012-01-04 03:43:01 +0000
@@ -181,13 +181,14 @@
 	   (gnus-get-new-news-hook nil)
 	   (inhibit-read-only t))
       (gnus-group-get-new-news-this-group nil t)
-      (dolist (group groups)
-	(unless (and gnus-permanently-visible-groups
-		     (string-match gnus-permanently-visible-groups
-				   group))
-	  (gnus-group-goto-group group)
-	  (when (zerop (gnus-group-group-unread))
-	    (gnus-delete-line)))))))
+      (save-excursion
+	(dolist (group groups)
+	  (unless (and gnus-permanently-visible-groups
+		       (string-match gnus-permanently-visible-groups
+				     group))
+	    (gnus-group-goto-group group)
+	    (when (zerop (gnus-group-group-unread))
+	      (gnus-delete-line))))))))
 
 (deffoo nndraft-request-associate-buffer (group)
   "Associate the current buffer with some article in the draft group."


Leo

Message #29 received at 9582 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 9582 <at> debbugs.gnu.org
Subject: Re: bug#9582: Annoying point movement
Date: Wed, 04 Jan 2012 20:42:19 +0100

Leo <sdl.web <at> gmail.com> writes:

> The following patch fixes this bug.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.