From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2011 23:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 9581@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.131673251530302 (code B ref -1); Thu, 22 Sep 2011 23:02:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Sep 2011 23:01:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6sHC-0007sg-W0 for submit@debbugs.gnu.org; Thu, 22 Sep 2011 19:01:55 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6sH6-0007sU-I9 for submit@debbugs.gnu.org; Thu, 22 Sep 2011 19:01:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6sGi-0005Wy-Au for submit@debbugs.gnu.org; Thu, 22 Sep 2011 19:01:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:44350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6sGi-0005Wu-9I for submit@debbugs.gnu.org; Thu, 22 Sep 2011 19:01:24 -0400 Received: from eggs.gnu.org ([140.186.70.92]:37829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6sGh-0003FO-Ge for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2011 19:01:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6sGg-0005Wg-G4 for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2011 19:01:23 -0400 Received: from prometheus.naquadah.org ([212.85.154.174]:47232 helo=mx1.naquadah.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6sGg-0005WS-BV for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2011 19:01:22 -0400 Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 57C0C5C1C0 for ; Fri, 23 Sep 2011 01:01:18 +0200 (CEST) From: Julien Danjou Date: Fri, 23 Sep 2011 01:01:17 +0200 Message-ID: <87pqisi3lu.fsf@keller.adm.naquadah.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) If you use `dbus-register-signal' with a nil SERVICE value, like: (dbus-register-signal :session nil "/org/gtk/Private/RemoteVolumeMonitor" "org.gtk.Private.RemoteVolumeMonitor" "VolumeAd= ded" 'identity) This is valid and works fine. However, on unregister it fails: Debugger entered--Lisp error: (dbus-error "Call to ReleaseName has wrong ar= gs (b, expected s)") dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus" = "org.freedesktop.DBus" "ReleaseName" nil) dbus-unregister-object(((:session "org.gtk.Private.RemoteVolumeMonitor" "= VolumeAdded") (nil "/org/gtk/Private/RemoteVolumeMonitor" identity))) Why does it fail? Because of the following code in `dbus-unregister-object': #+begin_src emacs-lisp (unless found (dbus-call-method bus dbus-service-dbus dbus-path-dbus dbus-interface-dbus "ReleaseName" service)))) +end_src And here service is=E2=80=A6 nil. Which is translated to a boolean (b) but should be a string (s). But honestly, I'm not sure what the good fix is. To me, this code is totally wrong in such a case. When using `dbus-register-signal', this happens: 1. the dbus_bus_add_match() function is called to add a match on the bus 2. the (match callback) pair is recorded into `dbus-registered-objets-table'=20 This makes things work. When a signal happens, something is looking into `dbus-registered-objets-table' and call the callback function. But to stop listening for a signal, the function to use is `dbus-unregister-object', and it is doing this: 1. remove the (match callback) pair from `dbus-registered-objets-table' 2. call ReleaseName on the service we were listening While I agree on point 1., the point 2. is totally irrelevant in such a case. There's no need to do such a thing, the name has never been requested with RequestName before. I think that: - step 2 should be removed or another function should be created which does not send a ReleaseName - dbus_bus_remove_match() should be used to remove the watch from the bus, which would be a lot cleaner. --=20 Julien Danjou From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2011 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Julien Danjou Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.131679228731111 (code B ref 9581); Fri, 23 Sep 2011 15:39:02 +0000 Received: (at 9581) by debbugs.gnu.org; 23 Sep 2011 15:38:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R77pG-00085j-8x for submit@debbugs.gnu.org; Fri, 23 Sep 2011 11:38:07 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R77pC-00085Q-IZ for 9581@debbugs.gnu.org; Fri, 23 Sep 2011 11:38:03 -0400 Received: (qmail invoked by alias); 23 Sep 2011 15:37:34 -0000 Received: from p57BB97B6.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.151.182] by mail.gmx.net (mp053) with SMTP; 23 Sep 2011 17:37:34 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18chDASNUkcmMXzbu4AYRHUuR0wOQDTMZU7S4UNHU mvMwVWVvtRfQH8 From: Michael Albinus References: <87pqisi3lu.fsf@keller.adm.naquadah.org> Date: Fri, 23 Sep 2011 17:37:31 +0200 In-Reply-To: <87pqisi3lu.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Fri, 23 Sep 2011 01:01:17 +0200") Message-ID: <87ehz7e0ck.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Julien Danjou writes: > When using `dbus-register-signal', this happens: > 1. the dbus_bus_add_match() function is called to add a match on the bus > 2. the (match callback) pair is recorded into > `dbus-registered-objets-table' > > This makes things work. When a signal happens, something is looking into > `dbus-registered-objets-table' and call the callback function. > > But to stop listening for a signal, the function to use is > `dbus-unregister-object', and it is doing this: > 1. remove the (match callback) pair from `dbus-registered-objets-table' > 2. call ReleaseName on the service we were listening > > While I agree on point 1., the point 2. is totally irrelevant in such a > case. There's no need to do such a thing, the name has never been > requested with RequestName before. It's simply an error. We are speaking abut the generalized `dbus-unregister-object', which is used for both signals and methods. ReleaseName shall be called only in case a *method* has been registered; I'll fix this. > I think that: > - step 2 should be removed or another function should be created which > does not send a ReleaseName Nope. See above. > - dbus_bus_remove_match() should be used to remove the watch from the > bus, which would be a lot cleaner. Good point. Registering a signal shall also keep the match string in dbus-registered-objects-table (it doesn't yet). Then we could use this string to send RemoveMatch. I'll prepare a patch for this (hopefully in time before starting the pretest). Best regards, Michael. From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2011 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.13167943561609 (code B ref 9581); Fri, 23 Sep 2011 16:13:02 +0000 Received: (at 9581) by debbugs.gnu.org; 23 Sep 2011 16:12:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R78Me-0000Pu-80 for submit@debbugs.gnu.org; Fri, 23 Sep 2011 12:12:36 -0400 Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R78Mb-0000Pm-Oe for 9581@debbugs.gnu.org; Fri, 23 Sep 2011 12:12:35 -0400 Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 12E7E5C1AE; Fri, 23 Sep 2011 18:12:05 +0200 (CEST) From: Julien Danjou References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> Date: Fri, 23 Sep 2011 18:12:04 +0200 In-Reply-To: <87ehz7e0ck.fsf@gmx.de> (Michael Albinus's message of "Fri, 23 Sep 2011 17:37:31 +0200") Message-ID: <871uv7i6gb.fsf@keller.adm.naquadah.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Sep 23 2011, Michael Albinus wrote: >> While I agree on point 1., the point 2. is totally irrelevant in such a >> case. There's no need to do such a thing, the name has never been >> requested with RequestName before. > > It's simply an error. We are speaking abut the generalized > `dbus-unregister-object', which is used for both signals and > methods. ReleaseName shall be called only in case a *method* has been > registered; I'll fix this. > >> I think that: >> - step 2 should be removed or another function should be created which >> does not send a ReleaseName > > Nope. See above. Ok, if you do this in one function, I agree with you then. >> - dbus_bus_remove_match() should be used to remove the watch from the >> bus, which would be a lot cleaner. > > Good point. Registering a signal shall also keep the match string in > dbus-registered-objects-table (it doesn't yet). Then we could use this > string to send RemoveMatch. > > I'll prepare a patch for this (hopefully in time before starting the > pretest). It sounds like a solution. What I don't like is that it's not really opaque, so somebody could mess with this, but well=E2=80=A6 I might be para= noid. :) =2D-=20 Julien Danjou --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOfK/UAAoJEGEbqVCLeKXCltwP/2Ah7UdQdCg/xwxt4aX7Qoo4 qCOu2OLFJ+T446MvUoHCuBbfl4C+lyGwPKbmwBAeBOoPjYJmz/M28LvUfnaJqrDd 5vMrDGw8K+n5xBLjqTTQ1Ol159PcPtTSZSGBi4PE5iDJAr/CQ2g/dWqB5B+T6g0F xN9cUwUuSUdKzZkt26xjQIF4xNeUsjnzZLRBy506oGPCD0Nhyc+4YZLWtCvoBQFS 8Q9Cby/3U2b+ruuZFNSmYWmz4mDIX1vW9zwK1c+lETPZCDN+3Qa4rlSEq2scR4KN cGsc0y8ad3NtMGoC7tdjX6hxHQbuN0/extHfJp+SeM8y3M0nre1jdinJkb72CowH iQ3JAVInuotaIanLQdcd1Vqf7wU8xpmvkU6f5C/hT19phb+nV0DOEd9dkAqF1dyP 29jYwElsA2xGpOPHYoEKFmO7JUZq5M5kvd/oWFM3sF8O5jhGaWI9OzA+6/o8d53T bycAidAWbP3PZao0KzvUCGiG1xdZIy2wBQzFAVDNJw0qTbyjl38Es4MhhUEmYRlt gXKRkLzpbPNeXtmHBZKD6lmKF8rHACQIN9sxfCR0L/dsfKRPNamVPqBGXd8Np2u3 uWoQJGmDJtwN0q9p9z4ULLAjLBo3al8T528/D0/NleNzCxxijW+Y0E42TO7JmAQA LXORSMqDxK1rc0sY1gfw =rfQK -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2011 11:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Julien Danjou Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.131686507019245 (code B ref 9581); Sat, 24 Sep 2011 11:52:01 +0000 Received: (at 9581) by debbugs.gnu.org; 24 Sep 2011 11:51:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7QlA-00050L-VP for submit@debbugs.gnu.org; Sat, 24 Sep 2011 07:51:10 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R7Ql8-00050C-4c for 9581@debbugs.gnu.org; Sat, 24 Sep 2011 07:51:07 -0400 Received: (qmail invoked by alias); 24 Sep 2011 11:50:32 -0000 Received: from p57BB9134.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.145.52] by mail.gmx.net (mp061) with SMTP; 24 Sep 2011 13:50:32 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/NuXk3h6HNOYP4ZnMfq3Rq/AosRjPKh3/e3Yewbt Xcxe2Auo957hWN From: Michael Albinus References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> Date: Sat, 24 Sep 2011 13:50:29 +0200 In-Reply-To: <871uv7i6gb.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Fri, 23 Sep 2011 18:12:04 +0200") Message-ID: <87bouab1mi.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Julien Danjou writes: I've committed a fix for both problems, could you, please, check? > It sounds like a solution. What I don't like is that it's not really > opaque, so somebody could mess with this, but well=E2=80=A6 I might be pa= ranoid. :) Reading the code, `dbus-registered-objects-table' has become an unreadable format. Maybe we shall redesign the format, and move most of the functionality from dbusbind.c to dbus.el. But that's something for after-the-release. Best regards, Michael. From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2011 14:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.1316874018437 (code B ref 9581); Sat, 24 Sep 2011 14:21:01 +0000 Received: (at 9581) by debbugs.gnu.org; 24 Sep 2011 14:20:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7T5W-000070-8T for submit@debbugs.gnu.org; Sat, 24 Sep 2011 10:20:18 -0400 Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7T5T-00006q-QK for 9581@debbugs.gnu.org; Sat, 24 Sep 2011 10:20:17 -0400 Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 47A405C174; Sat, 24 Sep 2011 16:19:42 +0200 (CEST) From: Julien Danjou References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> Date: Sat, 24 Sep 2011 16:19:41 +0200 In-Reply-To: <87bouab1mi.fsf@gmx.de> (Michael Albinus's message of "Sat, 24 Sep 2011 13:50:29 +0200") Message-ID: <87wrcydnuq.fsf@keller.adm.naquadah.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Sep 24 2011, Michael Albinus wrote: > I've committed a fix for both problems, could you, please, check? The patch is not enough. It fixes the precise case I reported, but this fails now: (setq db (dbus-register-signal :session "some.service" "/org/gtk/Private/RemoteVolumeMonitor" "org.gtk.Private.RemoteVolumeMonitor" "VolumeAd= ded" 'identity)) (dbus-unregister-object db) Debugger entered--Lisp error: (dbus-error "Match rule has a key with no sub= sequent '=3D' character") dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus" = "org.freedesktop.DBus" "RemoveMatch" "Z") dbus-unregister-object(((:session "org.gtk.Private.RemoteVolumeMonitor" "= VolumeAdded") ("some.service" "/org/gtk/Private/RemoteVolumeMonitor" identi= ty))) eval((dbus-unregister-object db) nil) And, I've not tested, but AFAICS you added a check "(when service =E2=80=A6" before running ReleaseName. Just not that you must not do a ReleaseName if you are unregistering a match, and I've the feeling that this code will do. > Reading the code, `dbus-registered-objects-table' has become an > unreadable format. Maybe we shall redesign the format, and move most of > the functionality from dbusbind.c to dbus.el. But that's something for > after-the-release. I totally agree with that. It needs to be reworked. :) =2D-=20 Julien Danjou --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOfeb9AAoJEGEbqVCLeKXCr9YP/17XOZU9R2xeibw/bhK+LnQf cCoMmE3XAmGK3y6pcELUlU8ijTw79jhyyZj3aIWJxw4ZSc4Qlg02WCtoPmNgxZp6 NFu9hTe8xMa1bVJxco7HI32sqHGEktbsAKw7A16h3NV9AG1xXAP96neLdP1AqAWy vu3VGkWIlR4uMVPkz6cr9xayWwM9LxziZwl4oL0SY1yaH/+4RKGxWtD2FqMpTMog 6+1rmB5pigzbJHdYLXwsi0mxAEJiCSIZgPNWf2YGHEEhLdA5zdr5KJ22GN91yciK srLorVPOVBP91Kr3XdFLCLbYbzDitK5xM1sw88cJuIvht1s08tDlclseQ/8nlZ5M Rz0UT95yqLwPMhv1lCz7BRX71PgxjN/RgUyaE4oGFd/Xab1Cz2kHtsP9WjUCnmEy 539+9Z2+C+fC5VZibLfdX/I4Tt+FtQOTDoJWu7pmU2Ovx/M5RKpb08ONtPXFhJUR 93EQb4ITDjOqmXO32rJWBNHGRaFhrq2v96CypoWRyaTkvKWgxp1cXDZ/ScjVQAl3 /5DqDl+piBWxeVlU3/R3X3pNSeoMbUTElwhcZvf6NS88WnC+dMefyNeMpI/i6ri/ phacB9Il9HHVZ9zyShP+tevtfIyM8r+Y54eNODh5jwZeCQ4onGhZML7GDAwh2ey7 unoqwRn/J3d0yI6uHhx6 =RGpa -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2011 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Julien Danjou Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.13168750914926 (code B ref 9581); Sat, 24 Sep 2011 14:39:02 +0000 Received: (at 9581) by debbugs.gnu.org; 24 Sep 2011 14:38:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7TMo-0001HP-J2 for submit@debbugs.gnu.org; Sat, 24 Sep 2011 10:38:11 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R7TMj-0001HD-7R for 9581@debbugs.gnu.org; Sat, 24 Sep 2011 10:38:07 -0400 Received: (qmail invoked by alias); 24 Sep 2011 14:37:31 -0000 Received: from p57BB9134.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.145.52] by mail.gmx.net (mp038) with SMTP; 24 Sep 2011 16:37:31 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1++vmB4RgG+8sNt6KOJTFjPHF5JYUJQK6iUEiyp02 uNBk+y3EmiCqYw From: Michael Albinus References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> <87wrcydnuq.fsf@keller.adm.naquadah.org> Date: Sat, 24 Sep 2011 16:37:29 +0200 In-Reply-To: <87wrcydnuq.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Sat, 24 Sep 2011 16:19:41 +0200") Message-ID: <877h4yc8gm.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Julien Danjou writes: > The patch is not enough. It fixes the precise case I reported, but this > fails now: > > (setq db > (dbus-register-signal :session "some.service" > "/org/gtk/Private/RemoteVolumeMonitor" > "org.gtk.Private.RemoteVolumeMonitor" "VolumeAdded" > 'identity)) > (dbus-unregister-object db) I've played exactly this example (replacing "some.service" by "org.gtk.Private.GduVolumeMonitor" in order to have an existing service). No problem. > Debugger entered--Lisp error: (dbus-error "Match rule has a key with no subsequent '=' character") > dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus" "org.freedesktop.DBus" "RemoveMatch" "Z") Where does the "Z" comes from? There will never be such a rule, added by AddMatch. Did you compile also dbusbind.c before testing? Could you apply (dbus-list-hash-table) before calling `dbus-unregister-object', and show the result? >> Reading the code, `dbus-registered-objects-table' has become an >> unreadable format. Maybe we shall redesign the format, and move most of >> the functionality from dbusbind.c to dbus.el. But that's something for >> after-the-release. > > I totally agree with that. It needs to be reworked. :) I'll prepare a patch. Locally, there are already some of them waiting for after-the-release. Best regards, Michael. From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2011 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.131695074525795 (code B ref 9581); Sun, 25 Sep 2011 11:40:02 +0000 Received: (at 9581) by debbugs.gnu.org; 25 Sep 2011 11:39:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7n32-0006i0-Rn for submit@debbugs.gnu.org; Sun, 25 Sep 2011 07:39:05 -0400 Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7n2z-0006hZ-24 for 9581@debbugs.gnu.org; Sun, 25 Sep 2011 07:39:02 -0400 Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 610985C0F6; Sun, 25 Sep 2011 13:38:22 +0200 (CEST) From: Julien Danjou References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> <87wrcydnuq.fsf@keller.adm.naquadah.org> <877h4yc8gm.fsf@gmx.de> Date: Sun, 25 Sep 2011 13:38:21 +0200 In-Reply-To: <877h4yc8gm.fsf@gmx.de> (Michael Albinus's message of "Sat, 24 Sep 2011 16:37:29 +0200") Message-ID: <87aa9setsi.fsf@keller.adm.naquadah.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Spam-Score: -3.2 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Sep 24 2011, Michael Albinus wrote: >> The patch is not enough. It fixes the precise case I reported, but this >> fails now: >> >> (setq db >> (dbus-register-signal :session "some.service" >> "/org/gtk/Private/RemoteVolumeMonitor" >> "org.gtk.Private.RemoteVolumeMonitor" "Volum= eAdded" >> 'identity)) >> (dbus-unregister-object db) > > I've played exactly this example (replacing "some.service" by > "org.gtk.Private.GduVolumeMonitor" in order to have an existing > service). No problem. Indeed. It works fine with org.gtk.Private.GduVolumeMonitor as service, but with "some.service" it fails. Why? >> Debugger entered--Lisp error: (dbus-error "Match rule has a key with no = subsequent '=3D' character") >> dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBu= s" "org.freedesktop.DBus" "RemoveMatch" "Z") > > Where does the "Z" comes from? There will never be such a rule, added by > AddMatch. It's not a Z. One of our MUA altered this. On the first try it's " ^H\330" On the second try it's "Z^B" On the third try it's "\300#\264" =E2=80=A6 (I register then unregister to make a try) > Did you compile also dbusbind.c before testing? Oh yes I'm sure of that. :) > Could you apply (dbus-list-hash-table) before calling > `dbus-unregister-object', and show the result? Yeah. I start emacs-snapshot, then register then call `dbus-list-hash-table', it messages: (((:session "org.freedesktop.Notifications" "ActionInvoked") (":1.129" "org.freedesktop.Notifications" "/org/freedesktop/Notifications" notifications-on-action-signal "type=3D'signal',interface=3D'org.freedesktop.Notifications',member=3D'A= ctionInvoked',sender=3D':1.129',path=3D'/org/freedesktop/Notifications'")) ((:session "org.freedesktop.Notifications" "NotificationClosed") (":1.129" "org.freedesktop.Notifications" "/org/freedesktop/Notifications" notifications-on-closed-signal "type=3D'signal',interface=3D'org.freedesktop.Notifications',member=3D'N= otificationClosed',sender=3D':1.129',path=3D'/org/freedesktop/Notifications= '")) ((:session "org.gtk.Private.RemoteVolumeMonitor" "VolumeAdded") ("" "some.service" "/org/gtk/Private/RemoteVolumeMonitor" identity "=C2=82=02=01"))) In case one of our MUA will change the last string on the last line it shows: "^A\202^F^B^D^A" Then I call unregister it yells: Debugger entered--Lisp error: (dbus-error "Unable to append argument" "\202= =02=01") dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus" = "org.freedesktop.DBus" "RemoveMatch" "\202=02=01") Where the last string is obviously the same as I talked about above. :) =2D-=20 Julien Danjou --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOfxKtAAoJEGEbqVCLeKXCsbIP/R80+qoxVSCAi+6eoLaIIBpn 4vEcTjdOQ8/Ddqc8RY1P9IxUdA2lPReqKb4ijQBgKbaeZnVf7vZw1YXkXB2KYEjO aigBmB6K1olzFB3ksLX798s24q9JErB1MyFc9JWVhDk212T9hZSYNhdoNs2alo3Y G6pyzocx+/VUGGoFBFE42xdfE60vYn7JSfD3diuuvww2l+tFYuejcof4rGOZimQE ZumV1bm1M4xrQx5E1uQ/5wTELSMtn8XWBWzMoNHHvej8IvjAzRqHUJ6esZHVtJ9k pIU/2lC8e8j65gUq35EjBhINfB3qJYt+678bjO8Sa4kuBNXhdegzGiOsqBADHfdh bciZ8A5zCJK+SpvvSem00PwHX8qUdpc85FryY1uN5GXYtcVnENZUIZsKWQAapoZ/ YV41WX5UJosMMZ4WtLhiCC7Nc/ouMetgBW/fEtSaaEUor/BOWV36qMkf5dWbo5fw jGWcKWGZh7SCP55gK4zAswcFwLpKmdhPWrxdPLjGAD9cNj0baL2CqFt/5nDZMSCa eB/33JWiIAP48CVMCh+RLdeujPPFVx1gHFq9JMvnvHU31DBlUUC5GZ64PQgcSEFR b0B+21r5VPJNzFAnj9k9ceEBS6wF0CfjZ48hXlRfnBMGNqCRaimggcQNtIH0Szyr 3iBV9lj/Z5XrykAXHLV3 =4o61 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2011 12:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Julien Danjou Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.131695202927636 (code B ref 9581); Sun, 25 Sep 2011 12:01:01 +0000 Received: (at 9581) by debbugs.gnu.org; 25 Sep 2011 12:00:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7nNk-0007Bg-N5 for submit@debbugs.gnu.org; Sun, 25 Sep 2011 08:00:28 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R7nNi-0007BZ-QD for 9581@debbugs.gnu.org; Sun, 25 Sep 2011 08:00:27 -0400 Received: (qmail invoked by alias); 25 Sep 2011 11:59:47 -0000 Received: from p57BB8C92.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.140.146] by mail.gmx.net (mp069) with SMTP; 25 Sep 2011 13:59:47 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+uEn5Mbl2ujmtug7KEmVCu6AkeF6KkppjRVmQX9G xBtF9/s2V6wcl6 From: Michael Albinus References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> <87wrcydnuq.fsf@keller.adm.naquadah.org> <877h4yc8gm.fsf@gmx.de> <87aa9setsi.fsf@keller.adm.naquadah.org> Date: Sun, 25 Sep 2011 13:59:45 +0200 In-Reply-To: <87aa9setsi.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Sun, 25 Sep 2011 13:38:21 +0200") Message-ID: <87mxdsvnm6.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Julien Danjou writes: >> I've played exactly this example (replacing "some.service" by >> "org.gtk.Private.GduVolumeMonitor" in order to have an existing >> service). No problem. > > Indeed. It works fine with org.gtk.Private.GduVolumeMonitor as service, > but with "some.service" it fails. Why? `dbus-register-signal' checks for the a valid service name, if it isn't nil. Usually, "some.service" is not known; in my test `dbus-register-signal' raises an error then. How did you manage to register your signal with that service? >> Could you apply (dbus-list-hash-table) before calling >> `dbus-unregister-object', and show the result? > > Yeah. I start emacs-snapshot, then register then call > `dbus-list-hash-table', it messages: > > (((:session "org.freedesktop.Notifications" "ActionInvoked") > (":1.129" > "org.freedesktop.Notifications" "/org/freedesktop/Notifications" > notifications-on-action-signal > "type=3D'signal',interface=3D'org.freedesktop.Notifications',member=3D= 'ActionInvoked',sender=3D':1.129',path=3D'/org/freedesktop/Notifications'")) > ((:session "org.freedesktop.Notifications" "NotificationClosed") > (":1.129" "org.freedesktop.Notifications" > "/org/freedesktop/Notifications" notifications-on-closed-signal > "type=3D'signal',interface=3D'org.freedesktop.Notifications',member=3D= 'NotificationClosed',sender=3D':1.129',path=3D'/org/freedesktop/Notificatio= ns'")) These two entries show the correct match rule (the respective last element). > ((:session "org.gtk.Private.RemoteVolumeMonitor" "VolumeAdded") > ("" > "some.service" "/org/gtk/Private/RemoteVolumeMonitor" identity > "=C2=82=01"))) This entry has a corrupted match rule. Again, which trick brings `dbus-register-signal' to accept it? I must implement a counter-check for this! > Then I call unregister it yells: > Debugger entered--Lisp error: (dbus-error "Unable to append argument" "\2= 02=01") > dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus= " "org.freedesktop.DBus" "RemoveMatch" "\202=01") > > Where the last string is obviously the same as I talked about above. :) Which is the correct answer, because there isn't a valid match rule. I could add a check for a valid match rule before sending the "RemoveMatch" message, but I believe this is superfluous, because there is exactly one place that match rule is appended. At this place, we must prevent wrong values. Best regards, Michael. From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2011 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.131695319129312 (code B ref 9581); Sun, 25 Sep 2011 12:20:02 +0000 Received: (at 9581) by debbugs.gnu.org; 25 Sep 2011 12:19:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7ngV-0007ci-5J for submit@debbugs.gnu.org; Sun, 25 Sep 2011 08:19:51 -0400 Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7ngR-0007cX-NR for 9581@debbugs.gnu.org; Sun, 25 Sep 2011 08:19:49 -0400 Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id BAE0B5C0F4; Sun, 25 Sep 2011 14:19:08 +0200 (CEST) From: Julien Danjou References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> <87wrcydnuq.fsf@keller.adm.naquadah.org> <877h4yc8gm.fsf@gmx.de> <87aa9setsi.fsf@keller.adm.naquadah.org> <87mxdsvnm6.fsf@gmx.de> Date: Sun, 25 Sep 2011 14:19:07 +0200 In-Reply-To: <87mxdsvnm6.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Sep 2011 13:59:45 +0200") Message-ID: <874o00erwk.fsf@keller.adm.naquadah.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, Sep 25 2011, Michael Albinus wrote: > `dbus-register-signal' checks for the a valid service name, if it isn't > nil. Usually, "some.service" is not known; in my test > `dbus-register-signal' raises an error then. > > How did you manage to register your signal with that service? No idea. But the check seems to be not functionnal here obviously. >> ((:session "org.gtk.Private.RemoteVolumeMonitor" "VolumeAdded") >> ("" >> "some.service" "/org/gtk/Private/RemoteVolumeMonitor" identity >> "=C2=82"))) > > This entry has a corrupted match rule. Again, which trick brings > `dbus-register-signal' to accept it? I must implement a counter-check > for this! Yes. If you want me to test a patch before committing it, or to run a debug patch with some printf or whatever, do not hesitate. >> Then I call unregister it yells: >> Debugger entered--Lisp error: (dbus-error "Unable to append argument" "\= 202") >> dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBu= s" "org.freedesktop.DBus" "RemoveMatch" "\202") >> >> Where the last string is obviously the same as I talked about above. :) > > Which is the correct answer, because there isn't a valid match rule. I > could add a check for a valid match rule before sending the > "RemoveMatch" message, but I believe this is superfluous, because there > is exactly one place that match rule is appended. At this place, we must > prevent wrong values. Again, be careful on one last thing. I did a couple of tests in an Emacs session, and sometimes I saw: method call sender=3D:1.254 -> dest=3Dorg.freedesktop.DBus serial=3D27 path= =3D/org/freedesktop/DBus; interface=3Dorg.freedesktop.DBus; member=3DReleas= eName string "some.service" And I was *only* testing dbus-register-signal, so there seems to be still some case or the "(when service =E2=80=A6" stuff is doing ReleaseName= even on a signal match. =2D-=20 Julien Danjou --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOfxw7AAoJEGEbqVCLeKXCfkIP/jNqlAOnOacZcqWVqNaVCkdq EjQXuY8aYE59+HC6TGSknRZvPHEtGVonDqPW1RX2piyPPMWiGowd/nfLJJiAzIFL 7snz8aezD1SsJuzWlv9Hqe852vcEDHC0bllapYSxY8wF8GDBSezizg6kbwoMXqYn djjtyykT+pJn/kxCK9Pcb2NmRr4Zy3tolQAh69VR3UMyXavuje2ozeBZ2Xrrb1bA 9p8uXejaZ7kiW0lzwDdzCGI7XL7YrMnFPccgOgKiuBaCiXHKH2pZJh3GrANmdTqR nfWgZNfkK6b7UXpSWxitxnzCkV9/VhfsF15FDMrwTeKi/ZhmUMWkVll0lSCBE3pe AJIbsiRI1+pKd4nwqLzjtzCieiBnW7M5blQWW0gKy/gW1OtBiTbK7ZuAiZSG5Svz uqyMGoaM6wEUKa7VcGskG522Cgl69CYk2rDrUSR3d23qSLNqYYpGIIXVqyX6RRo5 wvbW6O+L0D/2mifAi1x5ZPF27aN0ACwmhus+Lt+6gNL9NWrXpsQfmZUepkChSTo6 6ZwZ75jrAPeUtSWQJj3PtyWKRc0ZXry7Vuh6fu5BxFLBYzh2uEElJZjsLNY7r08x vWzeMHIAbWYlkjrReezrweao6yBNj94DtKkAMqYYUXxWnA4KE5xyWWow1LuryHvQ ioF1+6831hP1lXn6ToxP =WUjn -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2011 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Julien Danjou Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.131696667525681 (code B ref 9581); Sun, 25 Sep 2011 16:05:02 +0000 Received: (at 9581) by debbugs.gnu.org; 25 Sep 2011 16:04:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7rBz-0006g9-Gm for submit@debbugs.gnu.org; Sun, 25 Sep 2011 12:04:35 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R7rBw-0006g1-Rl for 9581@debbugs.gnu.org; Sun, 25 Sep 2011 12:04:34 -0400 Received: (qmail invoked by alias); 25 Sep 2011 16:03:52 -0000 Received: from p57BB8C92.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.140.146] by mail.gmx.net (mp043) with SMTP; 25 Sep 2011 18:03:52 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+6P84k57u6JywhfO+lJGWVj7oxjRo7VNdFrgvkXC MF7iaS90Vglind From: Michael Albinus References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> <87wrcydnuq.fsf@keller.adm.naquadah.org> <877h4yc8gm.fsf@gmx.de> <87aa9setsi.fsf@keller.adm.naquadah.org> <87mxdsvnm6.fsf@gmx.de> <874o00erwk.fsf@keller.adm.naquadah.org> Date: Sun, 25 Sep 2011 18:03:50 +0200 In-Reply-To: <874o00erwk.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Sun, 25 Sep 2011 14:19:07 +0200") Message-ID: <87ehz4vcbd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Julien Danjou writes: >> `dbus-register-signal' checks for the a valid service name, if it isn't >> nil. Usually, "some.service" is not known; in my test >> `dbus-register-signal' raises an error then. >> >> How did you manage to register your signal with that service? > > No idea. But the check seems to be not functionnal here obviously. The point was that I have `dbus-debug' set to t "since ever". In this case, `dbus-get-name-owner' raises an error, which I've seen ... >>> ((:session "org.gtk.Private.RemoteVolumeMonitor" "VolumeAdded") >>> ("" >>> "some.service" "/org/gtk/Private/RemoteVolumeMonitor" identity >>> "=C2=82"))) >> >> This entry has a corrupted match rule. Again, which trick brings >> `dbus-register-signal' to accept it? I must implement a counter-check >> for this! > > Yes. If you want me to test a patch before committing it, or to run a > debug patch with some printf or whatever, do not hesitate. Should be fixed now. > Again, be careful on one last thing. I did a couple of tests in an Emacs > session, and sometimes I saw: > > method call sender=3D:1.254 -> dest=3Dorg.freedesktop.DBus serial=3D27 > path=3D/org/freedesktop/DBus; interface=3Dorg.freedesktop.DBus; > member=3DReleaseName > string "some.service" > > And I was *only* testing dbus-register-signal, so there seems to be > still some case or the "(when service =E2=80=A6" stuff is doing ReleaseNa= me even > on a signal match. Also fixed. Thanks for testing, and best regards, Michael. From unknown Sat Sep 06 08:36:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2011 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 9581@debbugs.gnu.org Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.131703942032615 (code B ref 9581); Mon, 26 Sep 2011 12:17:02 +0000 Received: (at 9581) by debbugs.gnu.org; 26 Sep 2011 12:17:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R8A7H-0008Tx-Cx for submit@debbugs.gnu.org; Mon, 26 Sep 2011 08:17:00 -0400 Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R8A7E-0008Tn-5m for 9581@debbugs.gnu.org; Mon, 26 Sep 2011 08:16:57 -0400 Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id A2DDC5C12A; Mon, 26 Sep 2011 14:16:11 +0200 (CEST) From: Julien Danjou References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> <87wrcydnuq.fsf@keller.adm.naquadah.org> <877h4yc8gm.fsf@gmx.de> <87aa9setsi.fsf@keller.adm.naquadah.org> <87mxdsvnm6.fsf@gmx.de> <874o00erwk.fsf@keller.adm.naquadah.org> <87ehz4vcbd.fsf@gmx.de> Date: Mon, 26 Sep 2011 14:16:09 +0200 In-Reply-To: <87ehz4vcbd.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Sep 2011 18:03:50 +0200") Message-ID: <87d3enmrcm.fsf@keller.adm.naquadah.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, Sep 25 2011, Michael Albinus wrote: > The point was that I have `dbus-debug' set to t "since ever". In this > case, `dbus-get-name-owner' raises an error, which I've seen ... Ok, that explains everything! :) >>> This entry has a corrupted match rule. Again, which trick brings >>> `dbus-register-signal' to accept it? I must implement a counter-check >>> for this! >> >> Yes. If you want me to test a patch before committing it, or to run a >> debug patch with some printf or whatever, do not hesitate. > > Should be fixed now. It is fixed now. >> And I was *only* testing dbus-register-signal, so there seems to be >> still some case or the "(when service =E2=80=A6" stuff is doing ReleaseN= ame even >> on a signal match. > > Also fixed. This if fixed now. I think you can close this bug, and maybe reopen one if you want to track the other changes you want to do after the pretest. You call. :) =2D-=20 Julien Danjou --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOgG0JAAoJEGEbqVCLeKXC8LYP/jiXYIQGdJktssPlSrJ4+b4D mHA2HeKWVNFQ7ab26hfQuXRdCAWcw1RHFWRABsRShEQCgHtdJWoA/fJrF4zTYZbm NjYBg/DEcimg4CjvbrdJIcQ1RyAL8xtfSGDs7wirInWsLTMoqqrYADXa95gJcY0K udSEHEZ/4utUbb9VBnzEUl2DepjAaUVc6dW3fTNCgpyO37pjILaClFio1g73B0H/ Rr2TYkYg5bKnsEwg8G+D8Si8FYGPYqceA/ogvQ/Noq2J7QvJJ1hOV9/C3YChzF9x yfW9YJiBjRTa9rE3Lx4OFqSEO2qfyx0T8uHVDpYI8g5klT59eroKkm9AjZT2Knzm p0GSwyAiBfPaRmoL7xUuH3euR909hgEPH08a0WhLSDdgIuix1RYSlwEnn11QoStg L8yrGrPA74/dOy+vLkWGk9d76eM2HQcm3LfgSR/NNNXII7a2T0kgyo+rVpXgt+3h UK75L5yEUIZh+VjFGo/q5JNo9DSG3uUy1Yw9mJmGpEfw1Hnas5VWeg4gpkKE5Ca3 0ycvTqoh0484g3U9UHmbnewTymSh5sIW9yTtrS8DDl9inT+oktyPb84CC095f/aH CTX1jQ7ez4lvvrJ2s0tLWllZ1pFWZFYBdRiTSJl7e9aQmr0U02j7EYBnymCwEGsS ZUtU8CAKI9pp7HbaRId3 =8VR7 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 08:36:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Julien Danjou Subject: bug#9581: closed (Re: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil) Message-ID: References: <87ipofbe3e.fsf@gmx.de> <87pqisi3lu.fsf@keller.adm.naquadah.org> X-Gnu-PR-Message: they-closed 9581 X-Gnu-PR-Package: emacs Reply-To: 9581@debbugs.gnu.org Date: Mon, 26 Sep 2011 13:59:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1317045542-9533-1" This is a multi-part message in MIME format... ------------=_1317045542-9533-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #9581: 24.0.50; dbus-unregister-object fails if service is nil which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 9581@debbugs.gnu.org. --=20 9581: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9581 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1317045542-9533-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 9581-done) by debbugs.gnu.org; 26 Sep 2011 13:58:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R8Bhq-0002TM-4c for submit@debbugs.gnu.org; Mon, 26 Sep 2011 09:58:50 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1R8Bhm-0002T8-5T for 9581-done@debbugs.gnu.org; Mon, 26 Sep 2011 09:58:47 -0400 Received: (qmail invoked by alias); 26 Sep 2011 13:58:00 -0000 Received: from p57BB9768.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.151.104] by mail.gmx.net (mp021) with SMTP; 26 Sep 2011 15:58:00 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/EWnUK53/EbrS0/VXRLa0x7YDxcZycrr5CmcfdbB VsuV12wHHvOJra From: Michael Albinus To: Julien Danjou Subject: Re: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> <87wrcydnuq.fsf@keller.adm.naquadah.org> <877h4yc8gm.fsf@gmx.de> <87aa9setsi.fsf@keller.adm.naquadah.org> <87mxdsvnm6.fsf@gmx.de> <874o00erwk.fsf@keller.adm.naquadah.org> <87ehz4vcbd.fsf@gmx.de> <87d3enmrcm.fsf@keller.adm.naquadah.org> Date: Mon, 26 Sep 2011 15:57:57 +0200 In-Reply-To: <87d3enmrcm.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Mon, 26 Sep 2011 14:16:09 +0200") Message-ID: <87ipofbe3e.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 9581-done Cc: 9581-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Julien Danjou writes: > I think you can close this bug, and maybe reopen one if you want to > track the other changes you want to do after the pretest. You call. :) OK, closed. I don't believe we need another bug report just to remind myself ... I tend to forget everything (ask my wife!), but this patch is already prepared in my local repo. I should find it after the release. Thanks for your patient testing, and best regards, Michael. ------------=_1317045542-9533-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Sep 2011 23:01:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6sHC-0007sg-W0 for submit@debbugs.gnu.org; Thu, 22 Sep 2011 19:01:55 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6sH6-0007sU-I9 for submit@debbugs.gnu.org; Thu, 22 Sep 2011 19:01:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6sGi-0005Wy-Au for submit@debbugs.gnu.org; Thu, 22 Sep 2011 19:01:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:44350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6sGi-0005Wu-9I for submit@debbugs.gnu.org; Thu, 22 Sep 2011 19:01:24 -0400 Received: from eggs.gnu.org ([140.186.70.92]:37829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6sGh-0003FO-Ge for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2011 19:01:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6sGg-0005Wg-G4 for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2011 19:01:23 -0400 Received: from prometheus.naquadah.org ([212.85.154.174]:47232 helo=mx1.naquadah.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6sGg-0005WS-BV for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2011 19:01:22 -0400 Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 57C0C5C1C0 for ; Fri, 23 Sep 2011 01:01:18 +0200 (CEST) From: Julien Danjou To: bug-gnu-emacs@gnu.org Subject: 24.0.50; dbus-unregister-object fails if service is nil Date: Fri, 23 Sep 2011 01:01:17 +0200 Message-ID: <87pqisi3lu.fsf@keller.adm.naquadah.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) If you use `dbus-register-signal' with a nil SERVICE value, like: (dbus-register-signal :session nil "/org/gtk/Private/RemoteVolumeMonitor" "org.gtk.Private.RemoteVolumeMonitor" "VolumeAd= ded" 'identity) This is valid and works fine. However, on unregister it fails: Debugger entered--Lisp error: (dbus-error "Call to ReleaseName has wrong ar= gs (b, expected s)") dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus" = "org.freedesktop.DBus" "ReleaseName" nil) dbus-unregister-object(((:session "org.gtk.Private.RemoteVolumeMonitor" "= VolumeAdded") (nil "/org/gtk/Private/RemoteVolumeMonitor" identity))) Why does it fail? Because of the following code in `dbus-unregister-object': #+begin_src emacs-lisp (unless found (dbus-call-method bus dbus-service-dbus dbus-path-dbus dbus-interface-dbus "ReleaseName" service)))) +end_src And here service is=E2=80=A6 nil. Which is translated to a boolean (b) but should be a string (s). But honestly, I'm not sure what the good fix is. To me, this code is totally wrong in such a case. When using `dbus-register-signal', this happens: 1. the dbus_bus_add_match() function is called to add a match on the bus 2. the (match callback) pair is recorded into `dbus-registered-objets-table'=20 This makes things work. When a signal happens, something is looking into `dbus-registered-objets-table' and call the callback function. But to stop listening for a signal, the function to use is `dbus-unregister-object', and it is doing this: 1. remove the (match callback) pair from `dbus-registered-objets-table' 2. call ReleaseName on the service we were listening While I agree on point 1., the point 2. is totally irrelevant in such a case. There's no need to do such a thing, the name has never been requested with RequestName before. I think that: - step 2 should be removed or another function should be created which does not send a ReleaseName - dbus_bus_remove_match() should be used to remove the watch from the bus, which would be a lot cleaner. --=20 Julien Danjou ------------=_1317045542-9533-1--