GNU bug report logs - #9579
distcheck does not detect incomplete uninstall as advertised

Previous Next

Full log

Message #42 received at 9579-done <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Nick Bowler <nbowler <at> elliptictech.com>,
 9579-done <at> debbugs.gnu.org
Cc: automake-patches <at> gnu.org
Subject: Re: bug#9579: distcheck does not detect incomplete uninstall as
	advertised
Date: Sat, 1 Oct 2011 19:23:58 +0200

On Tuesday 27 September 2011, Stefano Lattarini wrote:
> On Monday 26 September 2011, Nick Bowler wrote:
> > Hi Stefano,
> > 
> > On 2011-09-23 21:46 +0200, Stefano Lattarini wrote:
> > > Apparently, it was a simple bug.  Attached is the patch I'll push to maint
> > > in a couple of days to fix it.  As usual, reviews welcome.
> > > 
> > > Thanks,
> > >   Stefano
> > 
> > > From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
> > > Date: Fri, 23 Sep 2011 16:06:59 +0200
> > > Subject: [PATCH] distuninstallcheck: fail also when only one file is left installed
> > 
> > I've tested this on my project, and now distcheck fails when I revert my
> > uninstall-local rule.  It's perhaps a bit unfortunate that
> > 
> >   make infodir='${prefix}/somewhere_else' distcheck
> > 
> > no longer works, but I agree that it seems non-trivial to make that
> > work properly.
> >
> Well, I don't agree anymore on this ;-) -- by complicating my patch just
> a little bit, we can apparently cater for this situation as well.  See the
> attached squash-in (I've also attached the updated patch, for reference).
> 
> So I'll give a couple of days for further comments, than I'll push this
> improved patch instead of the previous one.
> 
> Thanks,
>   Stefano
> 
Pushed now, so I'm closing the bug report.

Regards,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.