From unknown Fri Aug 15 21:28:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#9566 <9566@debbugs.gnu.org> To: bug#9566 <9566@debbugs.gnu.org> Subject: Status: sql-mode: sql-comint-postgres can't decide if sql-port is an integer or port Reply-To: bug#9566 <9566@debbugs.gnu.org> Date: Sat, 16 Aug 2025 04:28:23 +0000 retitle 9566 sql-mode: sql-comint-postgres can't decide if sql-port is an i= nteger or port reassign 9566 emacs submitter 9566 Andrew Schein severity 9566 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 21:09:12 2011 Received: (at submit) by debbugs.gnu.org; 21 Sep 2011 01:09:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6BJH-000872-AU for submit@debbugs.gnu.org; Tue, 20 Sep 2011 21:09:12 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6BJE-00086u-CQ for submit@debbugs.gnu.org; Tue, 20 Sep 2011 21:09:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6BJ1-0001oc-CA for submit@debbugs.gnu.org; Tue, 20 Sep 2011 21:08:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:51333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6BJ1-0001oY-A3 for submit@debbugs.gnu.org; Tue, 20 Sep 2011 21:08:55 -0400 Received: from eggs.gnu.org ([140.186.70.92]:40278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6BJ0-0005Ok-AT for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2011 21:08:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6BIy-0001lM-RS for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2011 21:08:54 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:47962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6BIy-0001l7-KZ for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2011 21:08:52 -0400 Received: by gwb19 with SMTP id 19so1606907gwb.32 for ; Tue, 20 Sep 2011 18:08:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.236.8 with SMTP id j8mr323287ybh.24.1316567331407; Tue, 20 Sep 2011 18:08:51 -0700 (PDT) Received: by 10.150.212.18 with HTTP; Tue, 20 Sep 2011 18:08:51 -0700 (PDT) Date: Tue, 20 Sep 2011 18:08:51 -0700 Message-ID: Subject: sql-mode: sql-comint-postgres can't decide if sql-port is an integer or port From: Andrew Schein To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) sql-port is initialized as an integer in sql.el, but later treated as a string when building up the params variable within the function sql-comint-postgres. Below is my small patch that fixes this. Cheers, Andy =3D=3D=3D modified file 'lisp/progmodes/sql.el' *** lisp/progmodes/sql.el=A0=A0=A0=A0=A0=A0 2011-07-06 03:51:48 +0000 --- lisp/progmodes/sql.el=A0=A0=A0=A0=A0=A0 2011-09-21 00:56:35 +0000 *************** Try to set `comint-output-filter-functio *** 4719,4731 **** =A0=A0=A0 ;; sql-postgres-options. =A0=A0=A0 (let ((params options)) =A0=A0=A0=A0=A0 (if (not (string=3D "" sql-database)) !=A0=A0=A0=A0=A0=A0 (setq params (append params (list sql-database)))) =A0=A0=A0=A0=A0 (if (not (string=3D "" sql-server)) !=A0=A0=A0=A0=A0=A0 (setq params (append (list "-h" sql-server) params))) =A0=A0=A0=A0=A0 (if (not (string=3D "" sql-user)) !=A0=A0=A0=A0=A0=A0 (setq params (append (list "-U" sql-user) params))) =A0=A0=A0=A0=A0 (if (not (=3D 0 sql-port)) !=A0=A0=A0=A0=A0=A0 (setq params (append (list "-p" sql-port) params))) =A0=A0=A0=A0=A0 (sql-comint product params))) =A0 (defun sql-postgres-completion-object (sqlbuf schema) --- 4719,4731 ---- =A0=A0=A0 ;; sql-postgres-options. =A0=A0=A0 (let ((params options)) =A0=A0=A0=A0=A0 (if (not (string=3D "" sql-database)) !=A0=A0=A0=A0 (setq params (append params (list sql-database)))) =A0=A0=A0=A0=A0 (if (not (string=3D "" sql-server)) !=A0=A0=A0=A0 (setq params (append (list "-h" sql-server) params))) =A0=A0=A0=A0=A0 (if (not (string=3D "" sql-user)) !=A0=A0=A0=A0 (setq params (append (list "-U" sql-user) params))) =A0=A0=A0=A0=A0 (if (not (=3D 0 sql-port)) !=A0=A0=A0=A0 (setq params (append (list "-p" (number-to-string sql-port)) = params))) =A0=A0=A0=A0=A0 (sql-comint product params))) =A0 (defun sql-postgres-completion-object (sqlbuf schema) -- Andrew I. Schein www.andrewschein.com From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 22 03:07:07 2011 Received: (at 9566-done) by debbugs.gnu.org; 22 Sep 2011 07:07:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6dND-0007lI-Fs for submit@debbugs.gnu.org; Thu, 22 Sep 2011 03:07:07 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6dNA-0007lA-Ld for 9566-done@debbugs.gnu.org; Thu, 22 Sep 2011 03:07:05 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1R6dMp-0003S6-SI; Thu, 22 Sep 2011 03:06:43 -0400 From: Glenn Morris To: 9566-done@debbugs.gnu.org Subject: Re: bug#9566: sql-mode: sql-comint-postgres can't decide if sql-port is an integer or port References: X-Spook: SRI Elvis industrial espionage Audiotel Etacs csim Uzi X-Ran: q$`YrMZ+uNr^YI+|MUOEk(y1br~<:K#CJ\(>t:X_+q&breWD"{${_h`T{tUBf=1@b;V_LO X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 22 Sep 2011 03:06:43 -0400 In-Reply-To: (Andrew Schein's message of "Tue, 20 Sep 2011 18:08:51 -0700") Message-ID: <63sjnp9hto.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 9566-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Version: 24.1 Thank you; applied. (FYI, your patch had extraneous whitespace changes.) From unknown Fri Aug 15 21:28:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Oct 2011 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator